Blame SOURCES/0025-Coverity-still-doesn-t-believe-in-error-codes.patch

da1a85
From c2223eb4638c6d8562626917651a11b8aa1e8f9e Mon Sep 17 00:00:00 2001
da1a85
From: Peter Jones <pjones@redhat.com>
da1a85
Date: Thu, 21 Jun 2018 16:18:32 -0400
da1a85
Subject: [PATCH] Coverity still doesn't believe in error codes...
da1a85
da1a85
So also test fbuf here.
da1a85
da1a85
Signed-off-by: Peter Jones <pjones@redhat.com>
da1a85
---
da1a85
 src/linux-acpi.c | 2 +-
da1a85
 1 file changed, 1 insertion(+), 1 deletion(-)
da1a85
da1a85
diff --git a/src/linux-acpi.c b/src/linux-acpi.c
da1a85
index 88f0084a37e..346eba09041 100644
da1a85
--- a/src/linux-acpi.c
da1a85
+++ b/src/linux-acpi.c
da1a85
@@ -49,7 +49,7 @@ parse_acpi_hid_uid(struct device *dev, const char *fmt, ...)
da1a85
                 return -1;
da1a85
 
da1a85
         rc = read_sysfs_file(&fbuf, "%s/firmware_node/path", path);
da1a85
-        if (rc > 0) {
da1a85
+        if (rc > 0 && fbuf) {
da1a85
                 size_t l = strlen(fbuf);
da1a85
                 if (l > 1) {
da1a85
                         fbuf[l-1] = 0;
da1a85
-- 
da1a85
2.17.1
da1a85