Blame SOURCES/0025-Coverity-still-doesn-t-believe-in-error-codes.patch

529d1b
From c2223eb4638c6d8562626917651a11b8aa1e8f9e Mon Sep 17 00:00:00 2001
529d1b
From: Peter Jones <pjones@redhat.com>
529d1b
Date: Thu, 21 Jun 2018 16:18:32 -0400
529d1b
Subject: [PATCH] Coverity still doesn't believe in error codes...
529d1b
529d1b
So also test fbuf here.
529d1b
529d1b
Signed-off-by: Peter Jones <pjones@redhat.com>
529d1b
---
529d1b
 src/linux-acpi.c | 2 +-
529d1b
 1 file changed, 1 insertion(+), 1 deletion(-)
529d1b
529d1b
diff --git a/src/linux-acpi.c b/src/linux-acpi.c
529d1b
index 88f0084a37e..346eba09041 100644
529d1b
--- a/src/linux-acpi.c
529d1b
+++ b/src/linux-acpi.c
529d1b
@@ -49,7 +49,7 @@ parse_acpi_hid_uid(struct device *dev, const char *fmt, ...)
529d1b
                 return -1;
529d1b
 
529d1b
         rc = read_sysfs_file(&fbuf, "%s/firmware_node/path", path);
529d1b
-        if (rc > 0) {
529d1b
+        if (rc > 0 && fbuf) {
529d1b
                 size_t l = strlen(fbuf);
529d1b
                 if (l > 1) {
529d1b
                         fbuf[l-1] = 0;
529d1b
-- 
529d1b
2.17.1
529d1b