|
 |
b15ea1 |
From 0dad6d78a7fb5f6c5fb4a1d646040539db6cf865 Mon Sep 17 00:00:00 2001
|
|
|
b15ea1 |
From: Chih-Wei Huang <cwhuang@linux.org.tw>
|
|
|
b15ea1 |
Date: Tue, 26 Feb 2019 18:42:20 +0800
|
|
|
b15ea1 |
Subject: [PATCH 09/86] Fix another error of -Werror=address-of-packed-member
|
|
|
b15ea1 |
|
|
|
b15ea1 |
Android 9 clang complains:
|
|
|
b15ea1 |
|
|
|
b15ea1 |
external/efivar/src/dp-message.c:367:24: error: taking address of packed member '' of class or structure 'efidp_infiniband' may result in an unaligned pointer value [-Werror,-Waddress-of-packed-member]
|
|
|
b15ea1 |
(efi_guid_t *)&dp->infiniband.ioc_guid);
|
|
|
b15ea1 |
^~~~~~~~~~~~~~~~~~~~~~~
|
|
|
b15ea1 |
external/efivar/src/dp.h:76:19: note: expanded from macro 'format_guid'
|
|
|
b15ea1 |
memmove(&_guid, guid, sizeof(_guid)); \
|
|
|
b15ea1 |
^~~~
|
|
|
b15ea1 |
1 error generated.
|
|
|
b15ea1 |
|
|
|
b15ea1 |
Since commit c3c553d the fifth parameter of format_guid() is treated as
|
|
|
b15ea1 |
a const void *. The casting is unnecessary.
|
|
|
b15ea1 |
|
|
|
b15ea1 |
Signed-off-by: Chih-Wei Huang <cwhuang@linux.org.tw>
|
|
|
b15ea1 |
---
|
|
|
b15ea1 |
src/dp-media.c | 3 +--
|
|
|
b15ea1 |
src/dp-message.c | 2 +-
|
|
|
b15ea1 |
2 files changed, 2 insertions(+), 3 deletions(-)
|
|
|
b15ea1 |
|
|
|
b15ea1 |
diff --git a/src/dp-media.c b/src/dp-media.c
|
|
|
b15ea1 |
index 96a576fdc2a..be691c44326 100644
|
|
|
b15ea1 |
--- a/src/dp-media.c
|
|
|
b15ea1 |
+++ b/src/dp-media.c
|
|
|
b15ea1 |
@@ -46,8 +46,7 @@ _format_media_dn(char *buf, size_t size, const_efidp dp)
|
|
|
b15ea1 |
break;
|
|
|
b15ea1 |
case EFIDP_HD_SIGNATURE_GUID:
|
|
|
b15ea1 |
format(buf, size, off, "HD", "GPT,");
|
|
|
b15ea1 |
- format_guid(buf, size, off, "HD",
|
|
|
b15ea1 |
- (efi_guid_t *)dp->hd.signature);
|
|
|
b15ea1 |
+ format_guid(buf, size, off, "HD", dp->hd.signature);
|
|
|
b15ea1 |
format(buf, size, off, "HD",
|
|
|
b15ea1 |
",0x%"PRIx64",0x%"PRIx64")",
|
|
|
b15ea1 |
dp->hd.start, dp->hd.size);
|
|
|
b15ea1 |
diff --git a/src/dp-message.c b/src/dp-message.c
|
|
|
b15ea1 |
index 9f964663de8..6b8e9072594 100644
|
|
|
b15ea1 |
--- a/src/dp-message.c
|
|
|
b15ea1 |
+++ b/src/dp-message.c
|
|
|
b15ea1 |
@@ -364,7 +364,7 @@ _format_message_dn(char *buf, size_t size, const_efidp dp)
|
|
|
b15ea1 |
dp->infiniband.port_gid[1],
|
|
|
b15ea1 |
dp->infiniband.port_gid[0]);
|
|
|
b15ea1 |
format_guid(buf, size, off, "Infiniband",
|
|
|
b15ea1 |
- (efi_guid_t *)&dp->infiniband.ioc_guid);
|
|
|
b15ea1 |
+ &dp->infiniband.ioc_guid);
|
|
|
b15ea1 |
format(buf, size, off, "Infiniband",
|
|
|
b15ea1 |
",%"PRIu64",%"PRIu64")",
|
|
|
b15ea1 |
dp->infiniband.target_port_id,
|
|
|
b15ea1 |
--
|
|
|
b15ea1 |
2.24.1
|
|
|
b15ea1 |
|