Blame 0020-MdeModulePkg-Bds-Remove-assertion-in-BmCharToUint.patch

Paolo Bonzini 2e34e0
From: Ruiyu Ni <ruiyu.ni@intel.com>
Paolo Bonzini 2e34e0
Subject: [PATCH] MdeModulePkg/Bds: Remove assertion in BmCharToUint
Paolo Bonzini 2e34e0
Date: Thu, 16 Nov 2017 18:04:42 +0100
Paolo Bonzini 2e34e0
Paolo Bonzini 2e34e0
BmCharToUint() could be called using external data and it
Paolo Bonzini 2e34e0
already contains logic to return -1 when data is invalid,
Paolo Bonzini 2e34e0
so removing unnecessary assertion to avoid system hang.
Paolo Bonzini 2e34e0
Paolo Bonzini 2e34e0
Contributed-under: TianoCore Contribution Agreement 1.1
Paolo Bonzini 2e34e0
Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com>
Paolo Bonzini 2e34e0
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
Paolo Bonzini 2e34e0
Reviewed-by: Star Zeng <star.zeng@intel.com>
Paolo Bonzini 2e34e0
Acked-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Paolo Bonzini 2e34e0
(cherry picked from commit 618ef6f9bae14e1543d61993ab7ab8992063e4cc)
Paolo Bonzini 2e34e0
---
Paolo Bonzini 2e34e0
 MdeModulePkg/Library/UefiBootManagerLib/BmMisc.c | 1 -
Paolo Bonzini 2e34e0
 1 file changed, 1 deletion(-)
Paolo Bonzini 2e34e0
Paolo Bonzini 2e34e0
diff --git a/MdeModulePkg/Library/UefiBootManagerLib/BmMisc.c b/MdeModulePkg/Library/UefiBootManagerLib/BmMisc.c
Paolo Bonzini 2e34e0
index 11ab86792a52..a3fa25424592 100644
Paolo Bonzini 2e34e0
--- a/MdeModulePkg/Library/UefiBootManagerLib/BmMisc.c
Paolo Bonzini 2e34e0
+++ b/MdeModulePkg/Library/UefiBootManagerLib/BmMisc.c
Paolo Bonzini 2e34e0
@@ -420,7 +420,6 @@ BmCharToUint (
Paolo Bonzini 2e34e0
     return (Char - L'A' + 0xA);
Paolo Bonzini 2e34e0
   }
Paolo Bonzini 2e34e0
 
Paolo Bonzini 2e34e0
-  ASSERT (FALSE);
Paolo Bonzini 2e34e0
   return (UINTN) -1;
Paolo Bonzini 2e34e0
 }
Paolo Bonzini 2e34e0
 
Paolo Bonzini 2e34e0
-- 
Paolo Bonzini 2e34e0
2.14.1.3.gb7cf6e02401b
Paolo Bonzini 2e34e0
Paolo Bonzini 2e34e0