Blame 0018-BaseTools-header.makefile-remove-c-from-BUILD_CFLAGS.patch

285b94
From 0af592dfa9a6d1a3379db1331344f411f7774bea Mon Sep 17 00:00:00 2001
285b94
From: Laszlo Ersek <lersek@redhat.com>
285b94
Date: Wed, 25 Jul 2018 22:40:09 +0200
285b94
Subject: [PATCH] BaseTools/header.makefile: remove "-c" from BUILD_CFLAGS
285b94
285b94
Option "-c" is a mode selection flag (choosing between compiling and
285b94
linking); it should not be in BUILD_CFLAGS, which applies only to
285b94
compiling anyway. The compilation rule for C source files, in
285b94
"footer.makefile", already includes "-c" -- currently we have double "-c"
285b94
options.
285b94
285b94
This patch doesn't change behavior.
285b94
285b94
Cc: Liming Gao <liming.gao@intel.com>
285b94
Cc: Yonghong Zhu <yonghong.zhu@intel.com>
285b94
Ref: https://bugzilla.redhat.com/show_bug.cgi?id=1540244
285b94
Contributed-under: TianoCore Contribution Agreement 1.1
285b94
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
285b94
Reviewed-by: Liming Gao <liming.gao@intel.com>
285b94
(cherry picked from commit 03252ae287c4a61983b3793ff71baeabe2ff3df7)
285b94
---
285b94
 BaseTools/Source/C/Makefiles/header.makefile | 4 ++--
285b94
 1 file changed, 2 insertions(+), 2 deletions(-)
285b94
285b94
diff --git a/BaseTools/Source/C/Makefiles/header.makefile b/BaseTools/Source/C/Makefiles/header.makefile
285b94
index db436773cf..08421ba24c 100644
285b94
--- a/BaseTools/Source/C/Makefiles/header.makefile
285b94
+++ b/BaseTools/Source/C/Makefiles/header.makefile
285b94
@@ -71,9 +71,9 @@ INCLUDE = $(TOOL_INCLUDE) -I $(MAKEROOT) -I $(MAKEROOT)/Include/Common -I $(MAKE
285b94
 BUILD_CPPFLAGS = $(INCLUDE) -O2
285b94
 ifeq ($(DARWIN),Darwin)
285b94
 # assume clang or clang compatible flags on OS X
285b94
-BUILD_CFLAGS = -MD -fshort-wchar -fno-strict-aliasing -Wall -Werror -Wno-deprecated-declarations -Wno-self-assign -Wno-unused-result -nostdlib -c -g
285b94
+BUILD_CFLAGS = -MD -fshort-wchar -fno-strict-aliasing -Wall -Werror -Wno-deprecated-declarations -Wno-self-assign -Wno-unused-result -nostdlib -g
285b94
 else
285b94
-BUILD_CFLAGS = -MD -fshort-wchar -fno-strict-aliasing -Wall -Werror -Wno-deprecated-declarations -Wno-stringop-truncation -Wno-restrict -Wno-unused-result -nostdlib -c -g
285b94
+BUILD_CFLAGS = -MD -fshort-wchar -fno-strict-aliasing -Wall -Werror -Wno-deprecated-declarations -Wno-stringop-truncation -Wno-restrict -Wno-unused-result -nostdlib -g
285b94
 endif
285b94
 BUILD_LFLAGS =
285b94
 BUILD_CXXFLAGS = -Wno-unused-result