From 01046984f4e68e7f0ef8649c0bf30803f4059b66 Mon Sep 17 00:00:00 2001

From: Laszlo Ersek <lersek@redhat.com>

Date: Wed, 14 Oct 2015 13:49:43 +0200

Subject: [PATCH] ArmPlatformPkg: introduce fixed PCD for early hello message

 (RH only)

Drew has proposed that ARM|AARCH64 platform firmware (especially virtual

machine firmware) print a reasonably early, simple hello message to the

serial port, regardless of debug mask settings. This should inform

interactive users, and provide some rough help in localizing boot

problems, even with restrictive debug masks.

If a platform doesn't want this feature, it should stick with the default

empty string.

RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=1270279

Downstream only:

<http://thread.gmane.org/gmane.comp.bios.edk2.devel/2996/focus=3433>.

Notes about the 20160608b-988715a -> 20170228-c325e41585e3 rebase:

- no changes

Notes about the 20170228-c325e41585e3 -> 20171011-92d07e48907f rebase:

- no changes

Suggested-by: Drew Jones <drjones@redhat.com>

Contributed-under: TianoCore Contribution Agreement 1.0

Signed-off-by: Laszlo Ersek <lersek@redhat.com>

(cherry picked from commit 7ce97b06421434c82095f01a1753a8c9c546cc30)

(cherry picked from commit 20b1f1cbd0590aa71c6d99d35e23cf08e0707750)

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

---

 ArmPlatformPkg/ArmPlatformPkg.dec | 7 +++++++

 1 file changed, 7 insertions(+)

diff --git a/ArmPlatformPkg/ArmPlatformPkg.dec b/ArmPlatformPkg/ArmPlatformPkg.dec

index c8ea183313..bab4804a17 100644

--- a/ArmPlatformPkg/ArmPlatformPkg.dec

+++ b/ArmPlatformPkg/ArmPlatformPkg.dec

@@ -108,6 +108,13 @@

   ## If set, this will swap settings for HDLCD RED_SELECT and BLUE_SELECT registers

   gArmPlatformTokenSpaceGuid.PcdArmHdLcdSwapBlueRedSelect|FALSE|BOOLEAN|0x00000045

+  #

+  # Early hello message (ASCII string), printed to the serial port.

+  # If set to the empty string, nothing is printed.

+  # Otherwise, a trailing CRLF should be specified explicitly.

+  #

+  gArmPlatformTokenSpaceGuid.PcdEarlyHelloMessage|""|VOID*|0x00000100

+

 [PcdsFixedAtBuild.common,PcdsDynamic.common]

   ## PL031 RealTimeClock

   gArmPlatformTokenSpaceGuid.PcdPL031RtcBase|0x0|UINT32|0x00000024