From a6f7be73206a27f6b5eb95ed66095d38110560cc Mon Sep 17 00:00:00 2001

From: wuguanghao <wuguanghao3@huawei.com>

Date: Wed, 30 Jun 2021 16:27:14 +0800

Subject: [PATCH 27/46] tdb_transaction_recover: fix memory leak

Content-Type: text/plain

In tdb_transaction_recover(), need free data before return,

otherwise it will cause memory leak.

Signed-off-by: Wu Guanghao <wuguanghao3@huawei.com>

Signed-off-by: Zhiqiang Liu <liuzhiqiang26@huawei.com>

Reviewed-by: Wu Bo <wubo40@huawei.com>

Signed-off-by: Theodore Ts'o <tytso@mit.edu>

Signed-off-by: Lukas Czerner <lczerner@redhat.com>

---

 lib/ext2fs/tdb.c | 1 +

 1 file changed, 1 insertion(+)

diff --git a/lib/ext2fs/tdb.c b/lib/ext2fs/tdb.c

index 5091b128..0fb94815 100644

--- a/lib/ext2fs/tdb.c

+++ b/lib/ext2fs/tdb.c

@@ -2186,6 +2186,7 @@ int tdb_transaction_recover(struct tdb_context *tdb)

 				   rec.data_len, 0) == -1) {

 		TDB_LOG((tdb, TDB_DEBUG_FATAL, "tdb_transaction_recover: failed to read recovery data\n"));

 		tdb->ecode = TDB_ERR_IO;

+		free(data);

 		return -1;

 	}

-- 

2.35.1