|
 |
0ef434 |
From 6efb6613deeca55b8e5673c77644890e7f5e4738 Mon Sep 17 00:00:00 2001
|
|
|
0ef434 |
From: Theodore Ts'o <tytso@mit.edu>
|
|
|
0ef434 |
Date: Wed, 8 Oct 2014 11:18:41 -0400
|
|
|
0ef434 |
Subject: [PATCH 13/16] e2fsck: fix free pointer dereferences
|
|
|
0ef434 |
|
|
|
0ef434 |
commit ebdf895b43a1ce499e4d2556a201e2a753fc422f
|
|
|
0ef434 |
|
|
|
0ef434 |
Commit 47fee2ef6a23a introduces some free pointer dereference bugs by
|
|
|
0ef434 |
not clearing ctx->fs after calling ext2fs_close_free().
|
|
|
0ef434 |
|
|
|
0ef434 |
Reported-by: Matthias Andree <mandree@FreeBSD.org>
|
|
|
0ef434 |
Cc: Lukas Czerner <lczerner@redhat.com>
|
|
|
0ef434 |
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
|
|
|
0ef434 |
---
|
|
|
0ef434 |
e2fsck/unix.c | 6 +++---
|
|
|
0ef434 |
1 file changed, 3 insertions(+), 3 deletions(-)
|
|
|
0ef434 |
|
|
|
0ef434 |
diff --git a/e2fsck/unix.c b/e2fsck/unix.c
|
|
|
0ef434 |
index 84b9a454..bbf65d90 100644
|
|
|
0ef434 |
--- a/e2fsck/unix.c
|
|
|
0ef434 |
+++ b/e2fsck/unix.c
|
|
|
0ef434 |
@@ -458,7 +458,7 @@ static void check_if_skip(e2fsck_t ctx)
|
|
|
0ef434 |
}
|
|
|
0ef434 |
log_out(ctx, "\n");
|
|
|
0ef434 |
skip:
|
|
|
0ef434 |
- ext2fs_close_free(&fs);
|
|
|
0ef434 |
+ ext2fs_close_free(&ctx->fs);
|
|
|
0ef434 |
e2fsck_free_context(ctx);
|
|
|
0ef434 |
exit(FSCK_OK);
|
|
|
0ef434 |
}
|
|
|
0ef434 |
@@ -1461,7 +1461,7 @@ failure:
|
|
|
0ef434 |
/*
|
|
|
0ef434 |
* Restart in order to reopen fs but this time start mmp.
|
|
|
0ef434 |
*/
|
|
|
0ef434 |
- ext2fs_close_free(&fs);
|
|
|
0ef434 |
+ ext2fs_close_free(&ctx->fs);
|
|
|
0ef434 |
flags &= ~EXT2_FLAG_SKIP_MMP;
|
|
|
0ef434 |
goto restart;
|
|
|
0ef434 |
}
|
|
|
0ef434 |
@@ -1690,7 +1690,7 @@ no_journal:
|
|
|
0ef434 |
_("while resetting context"));
|
|
|
0ef434 |
fatal_error(ctx, 0);
|
|
|
0ef434 |
}
|
|
|
0ef434 |
- ext2fs_close_free(&fs);
|
|
|
0ef434 |
+ ext2fs_close_free(&ctx->fs);
|
|
|
0ef434 |
goto restart;
|
|
|
0ef434 |
}
|
|
|
0ef434 |
if (run_result & E2F_FLAG_CANCEL) {
|
|
|
0ef434 |
--
|
|
|
0ef434 |
2.20.1
|
|
|
0ef434 |
|