|
 |
fab351 |
From d6d50a239eebf9da13a0d7892df00a0e725ef9d6 Mon Sep 17 00:00:00 2001
|
|
|
fab351 |
From: Jonathan Lebon <jonathan@jlebon.com>
|
|
|
fab351 |
Date: Wed, 19 Feb 2020 10:44:24 -0500
|
|
|
fab351 |
Subject: [PATCH] network-legacy/ifup: fix ip=dhcp,dhcp6 setup_net logic
|
|
|
fab351 |
|
|
|
fab351 |
Previously, we were doing `setup_net` from `ifup` for any setup that
|
|
|
fab351 |
wasn't DHCP, since those are already taken care of by `dhclient-script`.
|
|
|
fab351 |
|
|
|
fab351 |
The issue is that the case-statement we use to detect this doesn't catch
|
|
|
fab351 |
options like `ip=dhcp,dhcp6`.
|
|
|
fab351 |
|
|
|
fab351 |
Fix this by reworking the logic here to just check if a
|
|
|
fab351 |
`setup_net_$netif.sh` hook exists. If so, then we know that `setup_net`
|
|
|
fab351 |
will be called for this interface later.
|
|
|
fab351 |
|
|
|
fab351 |
This was causing issues in RHCOS which now ships with `ip=dhcp,dhcp6` to
|
|
|
fab351 |
support IPv6 environments[1]. The code here would make us do `setup_net`
|
|
|
fab351 |
pre-emptively which IIUC would then cause the initqueue to finish
|
|
|
fab351 |
earlier even if we had more udev netif events to process.
|
|
|
fab351 |
|
|
|
fab351 |
[1] https://github.com/coreos/coreos-assembler/pull/1067
|
|
|
fab351 |
|
|
|
fab351 |
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1803926
|
|
|
fab351 |
(cherry picked from commit 4985aa8c6e89451996e659a39fec7646e9e25f76)
|
|
|
fab351 |
|
|
|
fab351 |
Cherry-picked from: 4985aa8c6e89451996e659a39fec7646e9e25f76
|
|
|
fab351 |
Resolves: #1807395
|
|
|
fab351 |
---
|
|
|
fab351 |
modules.d/35network-legacy/ifup.sh | 11 +++++------
|
|
|
fab351 |
1 file changed, 5 insertions(+), 6 deletions(-)
|
|
|
fab351 |
|
|
|
fab351 |
diff --git a/modules.d/35network-legacy/ifup.sh b/modules.d/35network-legacy/ifup.sh
|
|
|
fab351 |
index eb7d2eb4..61838741 100755
|
|
|
fab351 |
--- a/modules.d/35network-legacy/ifup.sh
|
|
|
fab351 |
+++ b/modules.d/35network-legacy/ifup.sh
|
|
|
fab351 |
@@ -453,17 +453,16 @@ for p in $(getargs ip=); do
|
|
|
fab351 |
> /tmp/net.$(cat /sys/class/net/${netif}/address).up
|
|
|
fab351 |
fi
|
|
|
fab351 |
|
|
|
fab351 |
- case $autoconf in
|
|
|
fab351 |
- dhcp|on|any|dhcp6)
|
|
|
fab351 |
- ;;
|
|
|
fab351 |
- *)
|
|
|
fab351 |
+ # and finally, finish interface set up if there isn't already a script
|
|
|
fab351 |
+ # to do so (which is the case in the dhcp path)
|
|
|
fab351 |
+ if [ ! -e $hookdir/initqueue/setup_net_$netif.sh ]; then
|
|
|
fab351 |
setup_net $netif
|
|
|
fab351 |
source_hook initqueue/online $netif
|
|
|
fab351 |
if [ -z "$manualup" ]; then
|
|
|
fab351 |
/sbin/netroot $netif
|
|
|
fab351 |
fi
|
|
|
fab351 |
- ;;
|
|
|
fab351 |
- esac
|
|
|
fab351 |
+ fi
|
|
|
fab351 |
+
|
|
|
fab351 |
exit $ret
|
|
|
fab351 |
fi
|
|
|
fab351 |
done
|
|
|
6edea0 |
|