|
Harald Hoyer |
bb31e7 |
From 74c9fb947b265f30f4190ce77269ec0cd0e73925 Mon Sep 17 00:00:00 2001
|
|
Harald Hoyer |
bb31e7 |
From: "dyoung@redhat.com" <dyoung@redhat.com>
|
|
Harald Hoyer |
bb31e7 |
Date: Mon, 31 Aug 2015 10:43:15 +0800
|
|
Harald Hoyer |
bb31e7 |
Subject: [PATCH] Revert "Change the implementation of action_on_fail"
|
|
Harald Hoyer |
bb31e7 |
|
|
Harald Hoyer |
bb31e7 |
This reverts commit d2765b5175663d094737d6819cc3f3df53e7a4cb.
|
|
Harald Hoyer |
bb31e7 |
|
|
Harald Hoyer |
bb31e7 |
action_on_fail is useless thus remove the commits for it one by one.
|
|
Harald Hoyer |
bb31e7 |
|
|
Harald Hoyer |
bb31e7 |
Signed-off-by: Dave Young <dyoung@redhat.com>
|
|
Harald Hoyer |
bb31e7 |
---
|
|
Harald Hoyer |
bb31e7 |
dracut.cmdline.7.asc | 4 ++++
|
|
Harald Hoyer |
bb31e7 |
.../98dracut-systemd/dracut-emergency.service | 2 +-
|
|
Harald Hoyer |
bb31e7 |
modules.d/98dracut-systemd/emergency.service | 2 +-
|
|
Harald Hoyer |
bb31e7 |
modules.d/99base/dracut-lib.sh | 28 ++++++++++++++--------
|
|
Harald Hoyer |
bb31e7 |
4 files changed, 24 insertions(+), 12 deletions(-)
|
|
Harald Hoyer |
bb31e7 |
|
|
Harald Hoyer |
bb31e7 |
diff --git a/dracut.cmdline.7.asc b/dracut.cmdline.7.asc
|
|
Harald Hoyer |
bb31e7 |
index d790afd..ad99799 100644
|
|
Harald Hoyer |
bb31e7 |
--- a/dracut.cmdline.7.asc
|
|
Harald Hoyer |
bb31e7 |
+++ b/dracut.cmdline.7.asc
|
|
Harald Hoyer |
bb31e7 |
@@ -159,6 +159,10 @@ Misc
|
|
Harald Hoyer |
bb31e7 |
specify the controlling terminal for the console.
|
|
Harald Hoyer |
bb31e7 |
This is useful, if you have multiple "console=" arguments.
|
|
Harald Hoyer |
bb31e7 |
|
|
Harald Hoyer |
bb31e7 |
+**rd.action_on_fail=**_{shell|continue}_::
|
|
Harald Hoyer |
bb31e7 |
+ Specify the action after failure. By default it's emergency_shell.
|
|
Harald Hoyer |
bb31e7 |
+ 'continue' means: ignore the current failure and go ahead.
|
|
Harald Hoyer |
bb31e7 |
+
|
|
Harald Hoyer |
bb31e7 |
[[dracutkerneldebug]]
|
|
Harald Hoyer |
bb31e7 |
Debug
|
|
Harald Hoyer |
bb31e7 |
~~~~~
|
|
Harald Hoyer |
bb31e7 |
diff --git a/modules.d/98dracut-systemd/dracut-emergency.service b/modules.d/98dracut-systemd/dracut-emergency.service
|
|
Harald Hoyer |
bb31e7 |
index 5a6d525..a4b81bc 100644
|
|
Harald Hoyer |
bb31e7 |
--- a/modules.d/98dracut-systemd/dracut-emergency.service
|
|
Harald Hoyer |
bb31e7 |
+++ b/modules.d/98dracut-systemd/dracut-emergency.service
|
|
Harald Hoyer |
bb31e7 |
@@ -13,7 +13,7 @@ DefaultDependencies=no
|
|
Harald Hoyer |
bb31e7 |
After=systemd-vconsole-setup.service
|
|
Harald Hoyer |
bb31e7 |
Wants=systemd-vconsole-setup.service
|
|
Harald Hoyer |
bb31e7 |
Conflicts=emergency.service emergency.target
|
|
Harald Hoyer |
bb31e7 |
-ConditionPathExists=!/lib/dracut/no-emergency-shell
|
|
Harald Hoyer |
bb31e7 |
+ConditionKernelCommandLine=!action_on_fail=continue
|
|
Harald Hoyer |
bb31e7 |
|
|
Harald Hoyer |
bb31e7 |
[Service]
|
|
Harald Hoyer |
bb31e7 |
Environment=HOME=/
|
|
Harald Hoyer |
bb31e7 |
diff --git a/modules.d/98dracut-systemd/emergency.service b/modules.d/98dracut-systemd/emergency.service
|
|
Harald Hoyer |
bb31e7 |
index 5f1eaa2..c19fe37 100644
|
|
Harald Hoyer |
bb31e7 |
--- a/modules.d/98dracut-systemd/emergency.service
|
|
Harald Hoyer |
bb31e7 |
+++ b/modules.d/98dracut-systemd/emergency.service
|
|
Harald Hoyer |
bb31e7 |
@@ -12,7 +12,7 @@ Description=Emergency Shell
|
|
Harald Hoyer |
bb31e7 |
DefaultDependencies=no
|
|
Harald Hoyer |
bb31e7 |
After=systemd-vconsole-setup.service
|
|
Harald Hoyer |
bb31e7 |
Wants=systemd-vconsole-setup.service
|
|
Harald Hoyer |
bb31e7 |
-ConditionPathExists=!/lib/dracut/no-emergency-shell
|
|
Harald Hoyer |
bb31e7 |
+ConditionKernelCommandLine=!action_on_fail=continue
|
|
Harald Hoyer |
bb31e7 |
|
|
Harald Hoyer |
bb31e7 |
[Service]
|
|
Harald Hoyer |
bb31e7 |
Environment=HOME=/
|
|
Harald Hoyer |
bb31e7 |
diff --git a/modules.d/99base/dracut-lib.sh b/modules.d/99base/dracut-lib.sh
|
|
Harald Hoyer |
bb31e7 |
index 03a283c..cc5bb42 100755
|
|
Harald Hoyer |
bb31e7 |
--- a/modules.d/99base/dracut-lib.sh
|
|
Harald Hoyer |
bb31e7 |
+++ b/modules.d/99base/dracut-lib.sh
|
|
Harald Hoyer |
bb31e7 |
@@ -1143,16 +1143,24 @@ emergency_shell()
|
|
Harald Hoyer |
bb31e7 |
|
|
Harald Hoyer |
bb31e7 |
action_on_fail()
|
|
Harald Hoyer |
bb31e7 |
{
|
|
Harald Hoyer |
bb31e7 |
- if [ -f "$initdir/lib/dracut/no-emergency-shell" ]; then
|
|
Harald Hoyer |
bb31e7 |
- [ "$1" = "-n" ] && shift 2
|
|
Harald Hoyer |
bb31e7 |
- [ "$1" = "--shutdown" ] && shift 2
|
|
Harald Hoyer |
bb31e7 |
- warn "$*"
|
|
Harald Hoyer |
bb31e7 |
- warn "Not dropping to emergency shell, because $initdir/lib/dracut/no-emergency-shell exists."
|
|
Harald Hoyer |
bb31e7 |
- return 0
|
|
Harald Hoyer |
bb31e7 |
- fi
|
|
Harald Hoyer |
bb31e7 |
-
|
|
Harald Hoyer |
bb31e7 |
- emergency_shell $@
|
|
Harald Hoyer |
bb31e7 |
- return 1
|
|
Harald Hoyer |
bb31e7 |
+ local _action=$(getarg rd.action_on_fail= -d action_on_fail=)
|
|
Harald Hoyer |
bb31e7 |
+ case "$_action" in
|
|
Harald Hoyer |
bb31e7 |
+ continue)
|
|
Harald Hoyer |
bb31e7 |
+ [ "$1" = "-n" ] && shift 2
|
|
Harald Hoyer |
bb31e7 |
+ [ "$1" = "--shutdown" ] && shift 2
|
|
Harald Hoyer |
bb31e7 |
+ warn "$*"
|
|
Harald Hoyer |
bb31e7 |
+ warn "Not dropping to emergency shell, because 'action_on_fail=continue' was set on the kernel command line."
|
|
Harald Hoyer |
bb31e7 |
+ return 0
|
|
Harald Hoyer |
bb31e7 |
+ ;;
|
|
Harald Hoyer |
bb31e7 |
+ shell)
|
|
Harald Hoyer |
bb31e7 |
+ emergency_shell $@
|
|
Harald Hoyer |
bb31e7 |
+ return 1
|
|
Harald Hoyer |
bb31e7 |
+ ;;
|
|
Harald Hoyer |
bb31e7 |
+ *)
|
|
Harald Hoyer |
bb31e7 |
+ emergency_shell $@
|
|
Harald Hoyer |
bb31e7 |
+ return 1
|
|
Harald Hoyer |
bb31e7 |
+ ;;
|
|
Harald Hoyer |
bb31e7 |
+ esac
|
|
Harald Hoyer |
bb31e7 |
}
|
|
Harald Hoyer |
bb31e7 |
|
|
Harald Hoyer |
bb31e7 |
# Retain the values of these variables but ensure that they are unexported
|