Harald Hoyer 02dec6
From 01ffcf342ae65984c655f10a2fd35019a492ee5c Mon Sep 17 00:00:00 2001
Harald Hoyer 02dec6
From: =?UTF-8?q?Renaud=20M=C3=A9trich?= <rmetrich@redhat.com>
Harald Hoyer 02dec6
Date: Wed, 14 Nov 2018 13:19:27 +0100
Harald Hoyer 02dec6
Subject: [PATCH] fips: removed false-positive 'FATAL: Module xxx not found'
Harald Hoyer 02dec6
 error message when kernel provides a generic algo for module
Harald Hoyer 02dec6
MIME-Version: 1.0
Harald Hoyer 02dec6
Content-Type: text/plain; charset=UTF-8
Harald Hoyer 02dec6
Content-Transfer-Encoding: 8bit
Harald Hoyer 02dec6
Harald Hoyer 02dec6
Signed-off-by: Renaud Métrich <rmetrich@redhat.com>
Harald Hoyer 02dec6
---
Harald Hoyer 02dec6
 modules.d/01fips/fips.sh | 4 ++--
Harald Hoyer 02dec6
 1 file changed, 2 insertions(+), 2 deletions(-)
Harald Hoyer 02dec6
Harald Hoyer 02dec6
diff --git a/modules.d/01fips/fips.sh b/modules.d/01fips/fips.sh
Harald Hoyer 02dec6
index 9bc089f2..c6c986cf 100755
Harald Hoyer 02dec6
--- a/modules.d/01fips/fips.sh
Harald Hoyer 02dec6
+++ b/modules.d/01fips/fips.sh
Harald Hoyer 02dec6
@@ -84,7 +84,7 @@ do_fips()
Harald Hoyer 02dec6
     mv /etc/modprobe.d/fips.conf /etc/modprobe.d/fips.conf.bak
Harald Hoyer 02dec6
     for _module in $FIPSMODULES; do
Harald Hoyer 02dec6
         if [ "$_module" != "tcrypt" ]; then
Harald Hoyer 02dec6
-            if ! modprobe "${_module}"; then
Harald Hoyer 02dec6
+            if ! modprobe "${_module}" 2>/tmp/fips.modprobe_err; then
Harald Hoyer 02dec6
                 # check if kernel provides generic algo
Harald Hoyer 02dec6
                 _found=0
Harald Hoyer 02dec6
                 while read _k _s _v || [ -n "$_k" ]; do
Harald Hoyer 02dec6
@@ -93,7 +93,7 @@ do_fips()
Harald Hoyer 02dec6
                     _found=1
Harald Hoyer 02dec6
                     break
Harald Hoyer 02dec6
                 done 
Harald Hoyer 02dec6
-                [ "$_found" = "0" ] && return 1
Harald Hoyer 02dec6
+                [ "$_found" = "0" ] && cat /tmp/fips.modprobe_err >&2 && return 1
Harald Hoyer 02dec6
             fi
Harald Hoyer 02dec6
         fi
Harald Hoyer 02dec6
     done
Harald Hoyer 02dec6