|
 |
6cae2f |
From e12d415556994d0901c317f6338ed2961185465f Mon Sep 17 00:00:00 2001
|
|
|
6cae2f |
Message-Id: <e12d415556994d0901c317f6338ed2961185465f.1666780268.git.tredaelli@redhat.com>
|
|
|
6cae2f |
In-Reply-To: <f167022606b5ccca27a627ae599538ce2348ef67.1666780268.git.tredaelli@redhat.com>
|
|
|
6cae2f |
References: <f167022606b5ccca27a627ae599538ce2348ef67.1666780268.git.tredaelli@redhat.com>
|
|
|
6cae2f |
From: Maxime Coquelin <maxime.coquelin@redhat.com>
|
|
|
6cae2f |
Date: Thu, 16 Jun 2022 14:25:07 +0200
|
|
|
6cae2f |
Subject: [PATCH 2/2] vhost: fix header spanned across more than two
|
|
|
6cae2f |
descriptors
|
|
|
6cae2f |
|
|
|
6cae2f |
[ upstream commit dc1516e260a0df272b218392faf6db3cbf45e717 ]
|
|
|
6cae2f |
|
|
|
6cae2f |
This patch aims at supporting the unlikely case where a
|
|
|
6cae2f |
Virtio-net header is spanned across more than two
|
|
|
6cae2f |
descriptors.
|
|
|
6cae2f |
|
|
|
6cae2f |
CVE-2022-2132
|
|
|
6cae2f |
Fixes: fd68b4739d2c ("vhost: use buffer vectors in dequeue path")
|
|
|
6cae2f |
|
|
|
6cae2f |
Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
|
|
|
6cae2f |
Acked-by: Chenbo Xia <chenbo.xia@intel.com>
|
|
|
6cae2f |
Reviewed-by: David Marchand <david.marchand@redhat.com>
|
|
|
6cae2f |
---
|
|
|
6cae2f |
lib/vhost/virtio_net.c | 41 +++++++++++++----------------------------
|
|
|
6cae2f |
1 file changed, 13 insertions(+), 28 deletions(-)
|
|
|
6cae2f |
|
|
|
6cae2f |
diff --git a/lib/vhost/virtio_net.c b/lib/vhost/virtio_net.c
|
|
|
6cae2f |
index 991a7a2bd4..bf4d75b4bd 100644
|
|
|
6cae2f |
--- a/lib/vhost/virtio_net.c
|
|
|
6cae2f |
+++ b/lib/vhost/virtio_net.c
|
|
|
6cae2f |
@@ -2322,25 +2322,22 @@ copy_desc_to_mbuf(struct virtio_net *dev, struct vhost_virtqueue *vq,
|
|
|
6cae2f |
uint32_t buf_avail, buf_offset;
|
|
|
6cae2f |
uint64_t buf_addr, buf_len;
|
|
|
6cae2f |
uint32_t mbuf_avail, mbuf_offset;
|
|
|
6cae2f |
+ uint32_t hdr_remain = dev->vhost_hlen;
|
|
|
6cae2f |
uint32_t cpy_len;
|
|
|
6cae2f |
struct rte_mbuf *cur = m, *prev = m;
|
|
|
6cae2f |
struct virtio_net_hdr tmp_hdr;
|
|
|
6cae2f |
struct virtio_net_hdr *hdr = NULL;
|
|
|
6cae2f |
- /* A counter to avoid desc dead loop chain */
|
|
|
6cae2f |
- uint16_t vec_idx = 0;
|
|
|
6cae2f |
+ uint16_t vec_idx;
|
|
|
6cae2f |
struct batch_copy_elem *batch_copy = vq->batch_copy_elems;
|
|
|
6cae2f |
int error = 0;
|
|
|
6cae2f |
|
|
|
6cae2f |
- buf_addr = buf_vec[vec_idx].buf_addr;
|
|
|
6cae2f |
- buf_len = buf_vec[vec_idx].buf_len;
|
|
|
6cae2f |
-
|
|
|
6cae2f |
/*
|
|
|
6cae2f |
* The caller has checked the descriptors chain is larger than the
|
|
|
6cae2f |
* header size.
|
|
|
6cae2f |
*/
|
|
|
6cae2f |
|
|
|
6cae2f |
if (virtio_net_with_host_offload(dev)) {
|
|
|
6cae2f |
- if (unlikely(buf_len < sizeof(struct virtio_net_hdr))) {
|
|
|
6cae2f |
+ if (unlikely(buf_vec[0].buf_len < sizeof(struct virtio_net_hdr))) {
|
|
|
6cae2f |
/*
|
|
|
6cae2f |
* No luck, the virtio-net header doesn't fit
|
|
|
6cae2f |
* in a contiguous virtual area.
|
|
|
6cae2f |
@@ -2348,34 +2345,22 @@ copy_desc_to_mbuf(struct virtio_net *dev, struct vhost_virtqueue *vq,
|
|
|
6cae2f |
copy_vnet_hdr_from_desc(&tmp_hdr, buf_vec);
|
|
|
6cae2f |
hdr = &tmp_hdr;
|
|
|
6cae2f |
} else {
|
|
|
6cae2f |
- hdr = (struct virtio_net_hdr *)((uintptr_t)buf_addr);
|
|
|
6cae2f |
+ hdr = (struct virtio_net_hdr *)((uintptr_t)buf_vec[0].buf_addr);
|
|
|
6cae2f |
}
|
|
|
6cae2f |
}
|
|
|
6cae2f |
|
|
|
6cae2f |
- /*
|
|
|
6cae2f |
- * A virtio driver normally uses at least 2 desc buffers
|
|
|
6cae2f |
- * for Tx: the first for storing the header, and others
|
|
|
6cae2f |
- * for storing the data.
|
|
|
6cae2f |
- */
|
|
|
6cae2f |
- if (unlikely(buf_len < dev->vhost_hlen)) {
|
|
|
6cae2f |
- buf_offset = dev->vhost_hlen - buf_len;
|
|
|
6cae2f |
- vec_idx++;
|
|
|
6cae2f |
- buf_addr = buf_vec[vec_idx].buf_addr;
|
|
|
6cae2f |
- buf_len = buf_vec[vec_idx].buf_len;
|
|
|
6cae2f |
- buf_avail = buf_len - buf_offset;
|
|
|
6cae2f |
- } else if (buf_len == dev->vhost_hlen) {
|
|
|
6cae2f |
- if (unlikely(++vec_idx >= nr_vec))
|
|
|
6cae2f |
- goto out;
|
|
|
6cae2f |
- buf_addr = buf_vec[vec_idx].buf_addr;
|
|
|
6cae2f |
- buf_len = buf_vec[vec_idx].buf_len;
|
|
|
6cae2f |
+ for (vec_idx = 0; vec_idx < nr_vec; vec_idx++) {
|
|
|
6cae2f |
+ if (buf_vec[vec_idx].buf_len > hdr_remain)
|
|
|
6cae2f |
+ break;
|
|
|
6cae2f |
|
|
|
6cae2f |
- buf_offset = 0;
|
|
|
6cae2f |
- buf_avail = buf_len;
|
|
|
6cae2f |
- } else {
|
|
|
6cae2f |
- buf_offset = dev->vhost_hlen;
|
|
|
6cae2f |
- buf_avail = buf_vec[vec_idx].buf_len - dev->vhost_hlen;
|
|
|
6cae2f |
+ hdr_remain -= buf_vec[vec_idx].buf_len;
|
|
|
6cae2f |
}
|
|
|
6cae2f |
|
|
|
6cae2f |
+ buf_addr = buf_vec[vec_idx].buf_addr;
|
|
|
6cae2f |
+ buf_len = buf_vec[vec_idx].buf_len;
|
|
|
6cae2f |
+ buf_offset = hdr_remain;
|
|
|
6cae2f |
+ buf_avail = buf_vec[vec_idx].buf_len - hdr_remain;
|
|
|
6cae2f |
+
|
|
|
6cae2f |
PRINT_PACKET(dev,
|
|
|
6cae2f |
(uintptr_t)(buf_addr + buf_offset),
|
|
|
6cae2f |
(uint32_t)buf_avail, 0);
|
|
|
6cae2f |
--
|
|
|
6cae2f |
2.37.3
|
|
|
6cae2f |
|