|
 |
2c1bf6 |
From 652a2e3a1ba0db81ae1814e8c3cb989e9e89c4e0 Mon Sep 17 00:00:00 2001
|
|
|
2c1bf6 |
From: Jens Freimann <jfreimann@redhat.com>
|
|
|
2c1bf6 |
Date: Mon, 17 Dec 2018 22:31:31 +0100
|
|
|
2c1bf6 |
Subject: [PATCH 02/18] net/virtio: add packed virtqueue helpers
|
|
|
2c1bf6 |
|
|
|
2c1bf6 |
[ upstream commit e9f4feb7e6225f671b59375aff44b9d576121577 ]
|
|
|
2c1bf6 |
|
|
|
2c1bf6 |
Add helper functions to set/clear and check descriptor flags.
|
|
|
2c1bf6 |
|
|
|
2c1bf6 |
Signed-off-by: Jens Freimann <jfreimann@redhat.com>
|
|
|
2c1bf6 |
Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
|
|
|
2c1bf6 |
(cherry picked from commit e9f4feb7e6225f671b59375aff44b9d576121577)
|
|
|
2c1bf6 |
Signed-off-by: Jens Freimann <jfreimann@redhat.com>
|
|
|
2c1bf6 |
---
|
|
|
2c1bf6 |
drivers/net/virtio/virtio_pci.h | 6 +++
|
|
|
2c1bf6 |
drivers/net/virtio/virtqueue.h | 72 ++++++++++++++++++++++++++++++++-
|
|
|
2c1bf6 |
2 files changed, 76 insertions(+), 2 deletions(-)
|
|
|
2c1bf6 |
|
|
|
2c1bf6 |
diff --git a/drivers/net/virtio/virtio_pci.h b/drivers/net/virtio/virtio_pci.h
|
|
|
2c1bf6 |
index 4c975a531..b22b62dad 100644
|
|
|
2c1bf6 |
--- a/drivers/net/virtio/virtio_pci.h
|
|
|
2c1bf6 |
+++ b/drivers/net/virtio/virtio_pci.h
|
|
|
2c1bf6 |
@@ -315,6 +315,12 @@ vtpci_with_feature(struct virtio_hw *hw, uint64_t bit)
|
|
|
2c1bf6 |
return (hw->guest_features & (1ULL << bit)) != 0;
|
|
|
2c1bf6 |
}
|
|
|
2c1bf6 |
|
|
|
2c1bf6 |
+static inline int
|
|
|
2c1bf6 |
+vtpci_packed_queue(struct virtio_hw *hw)
|
|
|
2c1bf6 |
+{
|
|
|
2c1bf6 |
+ return vtpci_with_feature(hw, VIRTIO_F_RING_PACKED);
|
|
|
2c1bf6 |
+}
|
|
|
2c1bf6 |
+
|
|
|
2c1bf6 |
/*
|
|
|
2c1bf6 |
* Function declaration from virtio_pci.c
|
|
|
2c1bf6 |
*/
|
|
|
2c1bf6 |
diff --git a/drivers/net/virtio/virtqueue.h b/drivers/net/virtio/virtqueue.h
|
|
|
2c1bf6 |
index 1525c7d10..c32812427 100644
|
|
|
2c1bf6 |
--- a/drivers/net/virtio/virtqueue.h
|
|
|
2c1bf6 |
+++ b/drivers/net/virtio/virtqueue.h
|
|
|
2c1bf6 |
@@ -251,6 +251,31 @@ struct virtio_tx_region {
|
|
|
2c1bf6 |
__attribute__((__aligned__(16)));
|
|
|
2c1bf6 |
};
|
|
|
2c1bf6 |
|
|
|
2c1bf6 |
+static inline int
|
|
|
2c1bf6 |
+desc_is_used(struct vring_packed_desc *desc, struct virtqueue *vq)
|
|
|
2c1bf6 |
+{
|
|
|
2c1bf6 |
+ uint16_t used, avail, flags;
|
|
|
2c1bf6 |
+
|
|
|
2c1bf6 |
+ flags = desc->flags;
|
|
|
2c1bf6 |
+ used = !!(flags & VRING_DESC_F_USED(1));
|
|
|
2c1bf6 |
+ avail = !!(flags & VRING_DESC_F_AVAIL(1));
|
|
|
2c1bf6 |
+
|
|
|
2c1bf6 |
+ return avail == used && used == vq->used_wrap_counter;
|
|
|
2c1bf6 |
+}
|
|
|
2c1bf6 |
+
|
|
|
2c1bf6 |
+
|
|
|
2c1bf6 |
+static inline void
|
|
|
2c1bf6 |
+vring_desc_init_packed(struct virtqueue *vq, int n)
|
|
|
2c1bf6 |
+{
|
|
|
2c1bf6 |
+ int i;
|
|
|
2c1bf6 |
+ for (i = 0; i < n - 1; i++) {
|
|
|
2c1bf6 |
+ vq->ring_packed.desc_packed[i].id = i;
|
|
|
2c1bf6 |
+ vq->vq_descx[i].next = i + 1;
|
|
|
2c1bf6 |
+ }
|
|
|
2c1bf6 |
+ vq->ring_packed.desc_packed[i].id = i;
|
|
|
2c1bf6 |
+ vq->vq_descx[i].next = VQ_RING_DESC_CHAIN_END;
|
|
|
2c1bf6 |
+}
|
|
|
2c1bf6 |
+
|
|
|
2c1bf6 |
/* Chain all the descriptors in the ring with an END */
|
|
|
2c1bf6 |
static inline void
|
|
|
2c1bf6 |
vring_desc_init(struct vring_desc *dp, uint16_t n)
|
|
|
2c1bf6 |
@@ -262,13 +287,53 @@ vring_desc_init(struct vring_desc *dp, uint16_t n)
|
|
|
2c1bf6 |
dp[i].next = VQ_RING_DESC_CHAIN_END;
|
|
|
2c1bf6 |
}
|
|
|
2c1bf6 |
|
|
|
2c1bf6 |
+/**
|
|
|
2c1bf6 |
+ * Tell the backend not to interrupt us.
|
|
|
2c1bf6 |
+ */
|
|
|
2c1bf6 |
+static inline void
|
|
|
2c1bf6 |
+virtqueue_disable_intr_packed(struct virtqueue *vq)
|
|
|
2c1bf6 |
+{
|
|
|
2c1bf6 |
+ uint16_t *event_flags = &vq->ring_packed.driver_event->desc_event_flags;
|
|
|
2c1bf6 |
+
|
|
|
2c1bf6 |
+ *event_flags = RING_EVENT_FLAGS_DISABLE;
|
|
|
2c1bf6 |
+}
|
|
|
2c1bf6 |
+
|
|
|
2c1bf6 |
+
|
|
|
2c1bf6 |
/**
|
|
|
2c1bf6 |
* Tell the backend not to interrupt us.
|
|
|
2c1bf6 |
*/
|
|
|
2c1bf6 |
static inline void
|
|
|
2c1bf6 |
virtqueue_disable_intr(struct virtqueue *vq)
|
|
|
2c1bf6 |
{
|
|
|
2c1bf6 |
- vq->vq_ring.avail->flags |= VRING_AVAIL_F_NO_INTERRUPT;
|
|
|
2c1bf6 |
+ if (vtpci_packed_queue(vq->hw))
|
|
|
2c1bf6 |
+ virtqueue_disable_intr_packed(vq);
|
|
|
2c1bf6 |
+ else
|
|
|
2c1bf6 |
+ vq->vq_ring.avail->flags |= VRING_AVAIL_F_NO_INTERRUPT;
|
|
|
2c1bf6 |
+}
|
|
|
2c1bf6 |
+
|
|
|
2c1bf6 |
+/**
|
|
|
2c1bf6 |
+ * Tell the backend to interrupt. Implementation for packed virtqueues.
|
|
|
2c1bf6 |
+ */
|
|
|
2c1bf6 |
+static inline void
|
|
|
2c1bf6 |
+virtqueue_enable_intr_packed(struct virtqueue *vq)
|
|
|
2c1bf6 |
+{
|
|
|
2c1bf6 |
+ uint16_t *event_flags = &vq->ring_packed.driver_event->desc_event_flags;
|
|
|
2c1bf6 |
+
|
|
|
2c1bf6 |
+
|
|
|
2c1bf6 |
+ if (vq->event_flags_shadow == RING_EVENT_FLAGS_DISABLE) {
|
|
|
2c1bf6 |
+ virtio_wmb();
|
|
|
2c1bf6 |
+ vq->event_flags_shadow = RING_EVENT_FLAGS_ENABLE;
|
|
|
2c1bf6 |
+ *event_flags = vq->event_flags_shadow;
|
|
|
2c1bf6 |
+ }
|
|
|
2c1bf6 |
+}
|
|
|
2c1bf6 |
+
|
|
|
2c1bf6 |
+/**
|
|
|
2c1bf6 |
+ * Tell the backend to interrupt. Implementation for split virtqueues.
|
|
|
2c1bf6 |
+ */
|
|
|
2c1bf6 |
+static inline void
|
|
|
2c1bf6 |
+virtqueue_enable_intr_split(struct virtqueue *vq)
|
|
|
2c1bf6 |
+{
|
|
|
2c1bf6 |
+ vq->vq_ring.avail->flags &= (~VRING_AVAIL_F_NO_INTERRUPT);
|
|
|
2c1bf6 |
}
|
|
|
2c1bf6 |
|
|
|
2c1bf6 |
/**
|
|
|
2c1bf6 |
@@ -277,7 +342,10 @@ virtqueue_disable_intr(struct virtqueue *vq)
|
|
|
2c1bf6 |
static inline void
|
|
|
2c1bf6 |
virtqueue_enable_intr(struct virtqueue *vq)
|
|
|
2c1bf6 |
{
|
|
|
2c1bf6 |
- vq->vq_ring.avail->flags &= (~VRING_AVAIL_F_NO_INTERRUPT);
|
|
|
2c1bf6 |
+ if (vtpci_packed_queue(vq->hw))
|
|
|
2c1bf6 |
+ virtqueue_enable_intr_packed(vq);
|
|
|
2c1bf6 |
+ else
|
|
|
2c1bf6 |
+ virtqueue_enable_intr_split(vq);
|
|
|
2c1bf6 |
}
|
|
|
2c1bf6 |
|
|
|
2c1bf6 |
/**
|
|
|
2c1bf6 |
--
|
|
|
2c1bf6 |
2.21.0
|
|
|
2c1bf6 |
|