|
 |
eabdae |
From dcb4fa04548ab2364f662b735be86e275bd50745 Mon Sep 17 00:00:00 2001
|
|
|
eabdae |
From: =?UTF-8?q?Petr=20Men=C5=A1=C3=ADk?= <pemensik@redhat.com>
|
|
|
eabdae |
Date: Fri, 19 Jul 2019 14:00:08 +0200
|
|
|
eabdae |
Subject: [PATCH] Remove warnings in coverity
|
|
|
eabdae |
|
|
|
eabdae |
Change in dnsmasq should never occur, because ent_pw would not change.
|
|
|
eabdae |
But keep Coverity happy and prevent logic error. Second change avoids
|
|
|
eabdae |
warning from compiler.
|
|
|
eabdae |
---
|
|
|
eabdae |
src/dnsmasq.c | 9 ++++++++-
|
|
|
eabdae |
src/option.c | 2 +-
|
|
|
eabdae |
2 files changed, 9 insertions(+), 2 deletions(-)
|
|
|
eabdae |
|
|
|
eabdae |
diff --git a/src/dnsmasq.c b/src/dnsmasq.c
|
|
|
eabdae |
index ce44809..2984f55 100644
|
|
|
eabdae |
--- a/src/dnsmasq.c
|
|
|
eabdae |
+++ b/src/dnsmasq.c
|
|
|
eabdae |
@@ -608,7 +608,14 @@ int main (int argc, char **argv)
|
|
|
eabdae |
|
|
|
eabdae |
if (ent_pw && ent_pw->pw_uid != 0)
|
|
|
eabdae |
{
|
|
|
eabdae |
-#if defined(HAVE_LINUX_NETWORK)
|
|
|
eabdae |
+#if defined(HAVE_LINUX_NETWORK)
|
|
|
eabdae |
+ if (!hdr || !data)
|
|
|
eabdae |
+ {
|
|
|
eabdae |
+ /* Just failsafe for logic errors */
|
|
|
eabdae |
+ send_event(err_pipe[1], EVENT_CAP_ERR, ENOMEM, NULL);
|
|
|
eabdae |
+ _exit(0);
|
|
|
eabdae |
+ }
|
|
|
eabdae |
+
|
|
|
eabdae |
/* On linux, we keep CAP_NETADMIN (for ARP-injection) and
|
|
|
eabdae |
CAP_NET_RAW (for icmp) if we're doing dhcp. If we have yet to bind
|
|
|
eabdae |
ports because of DAD, or we're doing it dynamically,
|
|
|
eabdae |
diff --git a/src/option.c b/src/option.c
|
|
|
eabdae |
index 9768efb..b12183b 100644
|
|
|
eabdae |
--- a/src/option.c
|
|
|
eabdae |
+++ b/src/option.c
|
|
|
eabdae |
@@ -4255,7 +4255,7 @@ err:
|
|
|
eabdae |
struct name_list *nl;
|
|
|
eabdae |
if (!canon)
|
|
|
eabdae |
{
|
|
|
eabdae |
- struct name_list *tmp = new->names, *next;
|
|
|
eabdae |
+ struct name_list *tmp, *next;
|
|
|
eabdae |
for (tmp = new->names; tmp; tmp = next)
|
|
|
eabdae |
{
|
|
|
eabdae |
next = tmp->next;
|
|
|
eabdae |
--
|
|
|
eabdae |
2.20.1
|
|
|
eabdae |
|