|
 |
9f623f |
From 4348c43be45d20aba87ee5564ecdde10aff7e5e7 Mon Sep 17 00:00:00 2001
|
|
|
9f623f |
From: Simon Kelley <simon@thekelleys.org.uk>
|
|
|
9f623f |
Date: Fri, 22 Jan 2021 16:49:12 +0000
|
|
|
9f623f |
Subject: [PATCH] Move fd into frec_src, fixes
|
|
|
9f623f |
15b60ddf935a531269bb8c68198de012a4967156
|
|
|
9f623f |
|
|
|
9f623f |
If identical queries from IPv4 and IPv6 sources are combined by the
|
|
|
9f623f |
new code added in 15b60ddf935a531269bb8c68198de012a4967156 then replies
|
|
|
9f623f |
can end up being sent via the wrong family of socket. The ->fd
|
|
|
9f623f |
should be per query, not per-question.
|
|
|
9f623f |
|
|
|
9f623f |
In bind-interfaces mode, this could also result in replies being sent
|
|
|
9f623f |
via the wrong socket even when IPv4/IPV6 issues are not in play.
|
|
|
9f623f |
|
|
|
9f623f |
(cherry picked from commit 04490bf622ac84891aad6f2dd2edf83725decdee)
|
|
|
9f623f |
|
|
|
9f623f |
Fix for 12af2b171de0d678d98583e2190789e544440e02
|
|
|
9f623f |
|
|
|
9f623f |
(cherry picked from commit 3f535da79e7a42104543ef5c7b5fa2bed819a78b)
|
|
|
9f623f |
---
|
|
|
9f623f |
src/dnsmasq.h | 3 ++-
|
|
|
9f623f |
src/forward.c | 5 +++--
|
|
|
9f623f |
2 files changed, 5 insertions(+), 3 deletions(-)
|
|
|
9f623f |
|
|
|
9f623f |
diff --git a/src/dnsmasq.h b/src/dnsmasq.h
|
|
|
9f623f |
index f3bbb4e..e7e1693 100644
|
|
|
9f623f |
--- a/src/dnsmasq.h
|
|
|
9f623f |
+++ b/src/dnsmasq.h
|
|
|
9f623f |
@@ -632,6 +632,7 @@ struct frec {
|
|
|
9f623f |
union mysockaddr source;
|
|
|
9f623f |
struct all_addr dest;
|
|
|
9f623f |
unsigned int iface, log_id;
|
|
|
9f623f |
+ int fd;
|
|
|
9f623f |
unsigned short orig_id;
|
|
|
9f623f |
struct frec_src *next;
|
|
|
9f623f |
} frec_src;
|
|
|
9f623f |
@@ -641,7 +642,7 @@ struct frec {
|
|
|
9f623f |
struct randfd *rfd6;
|
|
|
9f623f |
#endif
|
|
|
9f623f |
unsigned short new_id;
|
|
|
9f623f |
- int fd, forwardall, flags;
|
|
|
9f623f |
+ int forwardall, flags;
|
|
|
9f623f |
time_t time;
|
|
|
9f623f |
unsigned char *hash[HASH_SIZE];
|
|
|
9f623f |
#ifdef HAVE_DNSSEC
|
|
|
9f623f |
diff --git a/src/forward.c b/src/forward.c
|
|
|
9f623f |
index 9d249c0..82dd850 100644
|
|
|
9f623f |
--- a/src/forward.c
|
|
|
9f623f |
+++ b/src/forward.c
|
|
|
9f623f |
@@ -368,6 +368,7 @@ static int forward_query(int udpfd, union mysockaddr *udpaddr,
|
|
|
9f623f |
new->dest = *dst_addr;
|
|
|
9f623f |
new->log_id = daemon->log_id;
|
|
|
9f623f |
new->iface = dst_iface;
|
|
|
9f623f |
+ new->fd = udpfd;
|
|
|
9f623f |
}
|
|
|
9f623f |
|
|
|
9f623f |
return 1;
|
|
|
9f623f |
@@ -392,8 +393,8 @@ static int forward_query(int udpfd, union mysockaddr *udpaddr,
|
|
|
9f623f |
forward->frec_src.dest = *dst_addr;
|
|
|
9f623f |
forward->frec_src.iface = dst_iface;
|
|
|
9f623f |
forward->frec_src.next = NULL;
|
|
|
9f623f |
+ forward->frec_src.fd = udpfd;
|
|
|
9f623f |
forward->new_id = get_id();
|
|
|
9f623f |
- forward->fd = udpfd;
|
|
|
9f623f |
memcpy(forward->hash, hash, HASH_SIZE);
|
|
|
9f623f |
forward->forwardall = 0;
|
|
|
9f623f |
forward->flags = fwd_flags;
|
|
|
9f623f |
@@ -1175,7 +1176,7 @@ void reply_query(int fd, int family, time_t now)
|
|
|
9f623f |
{
|
|
|
9f623f |
header->id = htons(src->orig_id);
|
|
|
9f623f |
|
|
|
9f623f |
- send_from(forward->fd, option_bool(OPT_NOWILD) || option_bool (OPT_CLEVERBIND), daemon->packet, nn,
|
|
|
9f623f |
+ send_from(src->fd, option_bool(OPT_NOWILD) || option_bool (OPT_CLEVERBIND), daemon->packet, nn,
|
|
|
9f623f |
&src->source, &src->dest, src->iface);
|
|
|
9f623f |
|
|
|
9f623f |
if (option_bool(OPT_EXTRALOG) && src != &forward->frec_src)
|
|
|
9f623f |
--
|
|
|
9f623f |
2.26.2
|
|
|
9f623f |
|