|
 |
784d94 |
From c82a594d95431e8615126621397ea595eb037a6b Mon Sep 17 00:00:00 2001
|
|
|
784d94 |
From: Doran Moppert <dmoppert@redhat.com>
|
|
|
784d94 |
Date: Tue, 26 Sep 2017 14:48:20 +0930
|
|
|
784d94 |
Subject: [PATCH] google patch hand-applied
|
|
|
784d94 |
|
|
|
784d94 |
---
|
|
|
784d94 |
src/edns0.c | 10 +++++-----
|
|
|
784d94 |
src/forward.c | 4 ++++
|
|
|
784d94 |
src/rfc1035.c | 2 ++
|
|
|
784d94 |
3 files changed, 11 insertions(+), 5 deletions(-)
|
|
|
784d94 |
|
|
|
784d94 |
diff --git a/src/edns0.c b/src/edns0.c
|
|
|
784d94 |
index af33877..ba6ff0c 100644
|
|
|
784d94 |
--- a/src/edns0.c
|
|
|
784d94 |
+++ b/src/edns0.c
|
|
|
784d94 |
@@ -212,11 +212,11 @@ size_t add_pseudoheader(struct dns_header *header, size_t plen, unsigned char *l
|
|
|
784d94 |
/* Copy back any options */
|
|
|
784d94 |
if (buff)
|
|
|
784d94 |
{
|
|
|
784d94 |
- if (p + rdlen > limit)
|
|
|
784d94 |
- {
|
|
|
784d94 |
- free(buff);
|
|
|
784d94 |
- return plen; /* Too big */
|
|
|
784d94 |
- }
|
|
|
784d94 |
+ if (p + rdlen > limit)
|
|
|
784d94 |
+ {
|
|
|
784d94 |
+ free(buff);
|
|
|
784d94 |
+ return plen; /* Too big */
|
|
|
784d94 |
+ }
|
|
|
784d94 |
memcpy(p, buff, rdlen);
|
|
|
784d94 |
free(buff);
|
|
|
784d94 |
p += rdlen;
|
|
|
784d94 |
diff --git a/src/forward.c b/src/forward.c
|
|
|
784d94 |
index cdd11d3..3078f64 100644
|
|
|
784d94 |
--- a/src/forward.c
|
|
|
784d94 |
+++ b/src/forward.c
|
|
|
784d94 |
@@ -1438,6 +1438,10 @@ void receive_query(struct listener *listen, time_t now)
|
|
|
784d94 |
udp_size = PACKETSZ; /* Sanity check - can't reduce below default. RFC 6891 6.2.3 */
|
|
|
784d94 |
}
|
|
|
784d94 |
|
|
|
784d94 |
+ // Make sure the udp size is not smaller than the incoming message so that we
|
|
|
784d94 |
+ // do not underflow
|
|
|
784d94 |
+ if (udp_size < n) udp_size = n;
|
|
|
784d94 |
+
|
|
|
784d94 |
#ifdef HAVE_AUTH
|
|
|
784d94 |
if (auth_dns)
|
|
|
784d94 |
{
|
|
|
784d94 |
diff --git a/src/rfc1035.c b/src/rfc1035.c
|
|
|
784d94 |
index b078b59..777911b 100644
|
|
|
784d94 |
--- a/src/rfc1035.c
|
|
|
784d94 |
+++ b/src/rfc1035.c
|
|
|
784d94 |
@@ -1281,6 +1281,8 @@ size_t answer_request(struct dns_header *header, char *limit, size_t qlen,
|
|
|
784d94 |
int nxdomain = 0, auth = 1, trunc = 0, sec_data = 1;
|
|
|
784d94 |
struct mx_srv_record *rec;
|
|
|
784d94 |
size_t len;
|
|
|
784d94 |
+ // Make sure we do not underflow here too.
|
|
|
784d94 |
+ if (qlen > (limit - ((char *)header))) return 0;
|
|
|
784d94 |
|
|
|
784d94 |
if (ntohs(header->ancount) != 0 ||
|
|
|
784d94 |
ntohs(header->nscount) != 0 ||
|
|
|
784d94 |
--
|
|
|
784d94 |
2.14.3
|
|
|
784d94 |
|