Blame SOURCES/ltrace-0.7.91-ppc64le-support.patch

263585
From eea4ad2cce289753aaa35b4e0258a76d8f8f367c Mon Sep 17 00:00:00 2001
263585
From: Thierry Fauck <thierry@linux.vnet.ibm.com>
263585
Date: Tue, 13 May 2014 07:48:24 -0400
263585
Subject: [PATCH] Support for powerpc64 arch ppc64el
263585
263585
Signed-off-by: Thierry Fauck <thierry@linux.vnet.ibm.com>
263585
263585
	Add support for ppc64le proc and ELF ABIv2.
263585
	Provides support for irelative and wchar
263585
---
263585
 ltrace-elf.c                           |    2 +-
263585
 ltrace-elf.h                           |    1 +
263585
 sysdeps/linux-gnu/ppc/arch.h           |   35 ++++-
263585
 sysdeps/linux-gnu/ppc/fetch.c          |  244 +++++++++++++++++++++++++++++---
263585
 sysdeps/linux-gnu/ppc/plt.c            |   98 ++++++++++++--
263585
 sysdeps/linux-gnu/ppc/trace.c          |   10 ++
263585
 testsuite/ltrace.main/system_calls.exp |    2 +-
263585
 7 files changed, 356 insertions(+), 36 deletions(-)
263585
263585
diff --git a/ltrace-elf.c b/ltrace-elf.c
263585
index 8997518..f638342 100644
263585
--- a/ltrace-elf.c
263585
+++ b/ltrace-elf.c
263585
@@ -859,7 +859,7 @@ populate_plt(struct process *proc, const char *filename,
263585
 	return 0;
263585
 }
263585
 
263585
-static void
263585
+void
263585
 delete_symbol_chain(struct library_symbol *libsym)
263585
 {
263585
 	while (libsym != NULL) {
263585
diff --git a/ltrace-elf.h b/ltrace-elf.h
263585
index db4ffe9..4a824c4 100644
263585
--- a/ltrace-elf.h
263585
+++ b/ltrace-elf.h
263585
@@ -166,6 +166,7 @@ int elf_read_next_uleb128(Elf_Data *data, GElf_Xword *offset, uint64_t *retp);
263585
 /* Return whether there's AMOUNT more bytes after OFFSET in DATA.  */
263585
 int elf_can_read_next(Elf_Data *data, GElf_Xword offset, GElf_Xword amount);
263585
 
263585
+void delete_symbol_chain(struct library_symbol *);
263585
 #if __WORDSIZE == 32
263585
 #define PRI_ELF_ADDR		PRIx32
263585
 #define GELF_ADDR_CAST(x)	(void *)(uint32_t)(x)
263585
diff --git a/sysdeps/linux-gnu/ppc/arch.h b/sysdeps/linux-gnu/ppc/arch.h
263585
index bf9b5dc..7918a13 100644
263585
--- a/sysdeps/linux-gnu/ppc/arch.h
263585
+++ b/sysdeps/linux-gnu/ppc/arch.h
263585
@@ -23,8 +23,8 @@
263585
 #define LTRACE_PPC_ARCH_H
263585
 
263585
 #include <gelf.h>
263585
+#include <stdbool.h>
263585
 
263585
-#define BREAKPOINT_VALUE { 0x7f, 0xe0, 0x00, 0x08 }
263585
 #define BREAKPOINT_LENGTH 4
263585
 #define DECR_PC_AFTER_BREAK 0
263585
 
263585
@@ -34,8 +34,33 @@
263585
 #ifdef __powerpc64__ // Says 'ltrace' is 64 bits, says nothing about target.
263585
 #define LT_ELFCLASS2	ELFCLASS64
263585
 #define LT_ELF_MACHINE2	EM_PPC64
263585
-#define ARCH_SUPPORTS_OPD
263585
-#endif
263585
+
263585
+# ifdef __LITTLE_ENDIAN__
263585
+# define BREAKPOINT_VALUE { 0x08, 0x00, 0xe0, 0x7f }
263585
+# define ARCH_ENDIAN_LITTLE
263585
+# else
263585
+# define BREAKPOINT_VALUE { 0x7f, 0xe0, 0x00, 0x08 }
263585
+# define ARCH_SUPPORTS_OPD
263585
+# define ARCH_ENDIAN_BIG
263585
+# endif
263585
+
263585
+# if _CALL_ELF != 2
263585
+# define ARCH_SUPPORTS_OPD
263585
+# define STACK_FRAME_OVERHEAD 112
263585
+#  ifndef EF_PPC64_ABI
263585
+#  define EF_PPC64_ABI 3
263585
+#  endif
263585
+# else /* _CALL_ELF == 2 ABIv2 */
263585
+# define STACK_FRAME_OVERHEAD 32
263585
+# endif /* CALL_ELF */
263585
+
263585
+#else
263585
+#define BREAKPOINT_VALUE { 0x7f, 0xe0, 0x00, 0x08 }
263585
+#define ARCH_ENDIAN_BIG
263585
+# ifndef EF_PPC64_ABI
263585
+# define EF_PPC64_ABI 3
263585
+# endif
263585
+#endif 	/* __powerpc64__ */
263585
 
263585
 #define ARCH_HAVE_SW_SINGLESTEP
263585
 #define ARCH_HAVE_ADD_PLT_ENTRY
263585
@@ -43,7 +68,6 @@
263585
 #define ARCH_HAVE_TRANSLATE_ADDRESS
263585
 #define ARCH_HAVE_DYNLINK_DONE
263585
 #define ARCH_HAVE_FETCH_ARG
263585
-#define ARCH_ENDIAN_BIG
263585
 #define ARCH_HAVE_SIZEOF
263585
 #define ARCH_HAVE_ALIGNOF
263585
 
263585
@@ -56,7 +80,8 @@ struct arch_ltelf_data {
263585
 	Elf_Data *opd_data;
263585
 	GElf_Addr opd_base;
263585
 	GElf_Xword opd_size;
263585
-	int secure_plt;
263585
+	bool secure_plt : 1;
263585
+	bool elfv2_abi  : 1;
263585
 
263585
 	Elf_Data *reladyn;
263585
 	size_t reladyn_count;
263585
diff --git a/sysdeps/linux-gnu/ppc/fetch.c b/sysdeps/linux-gnu/ppc/fetch.c
263585
index ed38336..c9381c3 100644
263585
--- a/sysdeps/linux-gnu/ppc/fetch.c
263585
+++ b/sysdeps/linux-gnu/ppc/fetch.c
263585
@@ -30,9 +30,11 @@
263585
 #include "ptrace.h"
263585
 #include "proc.h"
263585
 #include "value.h"
263585
+#include "ltrace-elf.h"
263585
 
263585
 static int allocate_gpr(struct fetch_context *ctx, struct process *proc,
263585
-			struct arg_type_info *info, struct value *valuep);
263585
+			struct arg_type_info *info, struct value *valuep,
263585
+			size_t off, bool is_hfa_type);
263585
 
263585
 /* Floating point registers have the same width on 32-bit as well as
263585
  * 64-bit PPC, but <ucontext.h> presents a different API depending on
263585
@@ -62,7 +64,10 @@ struct fetch_context {
263585
 		gregs64_t r64;
263585
 	} regs;
263585
 	struct fpregs_t fpregs;
263585
-
263585
+	int vgreg;
263585
+	int struct_size;
263585
+	int struct_hfa_size;
263585
+	int struct_hfa_count;
263585
 };
263585
 
263585
 static int
263585
@@ -74,7 +79,8 @@ fetch_context_init(struct process *proc, struct fetch_context *context)
263585
 	if (proc->e_machine == EM_PPC)
263585
 		context->stack_pointer = proc->stack_pointer + 8;
263585
 	else
263585
-		context->stack_pointer = proc->stack_pointer + 112;
263585
+		context->stack_pointer = proc->stack_pointer
263585
+			+ STACK_FRAME_OVERHEAD;
263585
 
263585
 	/* When ltrace is 64-bit, we might use PTRACE_GETREGS to
263585
 	 * obtain 64-bit as well as 32-bit registers.  But if we do it
263585
@@ -118,6 +124,11 @@ arch_fetch_arg_init(enum tof type, struct process *proc,
263585
 		return NULL;
263585
 	}
263585
 
263585
+	context->vgreg = context->greg;
263585
+	context->struct_size = 0;
263585
+	context->struct_hfa_size = 0;
263585
+	context->struct_hfa_count = 0;
263585
+
263585
 	/* Aggregates or unions of any length, and character strings
263585
 	 * of length longer than 8 bytes, will be returned in a
263585
 	 * storage buffer allocated by the caller. The caller will
263585
@@ -125,8 +136,20 @@ arch_fetch_arg_init(enum tof type, struct process *proc,
263585
 	 * in r3, causing the first explicit argument to be passed in
263585
 	 * r4.  */
263585
 	context->ret_struct = ret_info->type == ARGTYPE_STRUCT;
263585
-	if (context->ret_struct)
263585
+	if (context->ret_struct) {
263585
+#if _CALL_ELF == 2
263585
+		/* if R3 points to stack, parameters will be in R4.  */
263585
+		uint64_t pstack_end = ptrace(PTRACE_PEEKTEXT, proc->pid,
263585
+					proc->stack_pointer, 0);
263585
+		if (((arch_addr_t)context->regs.r64[3] > proc->stack_pointer)
263585
+		    && (context->regs.r64[3] < pstack_end)) {
263585
+			context->greg++;
263585
+			context->stack_pointer += 8;
263585
+		}
263585
+#else
263585
 		context->greg++;
263585
+#endif
263585
+	}
263585
 
263585
 	return context;
263585
 }
263585
@@ -144,7 +167,8 @@ arch_fetch_arg_clone(struct process *proc,
263585
 
263585
 static int
263585
 allocate_stack_slot(struct fetch_context *ctx, struct process *proc,
263585
-		    struct arg_type_info *info, struct value *valuep)
263585
+		    struct arg_type_info *info, struct value *valuep,
263585
+		    bool is_hfa_type)
263585
 {
263585
 	size_t sz = type_sizeof(proc, info);
263585
 	if (sz == (size_t)-1)
263585
@@ -154,7 +178,14 @@ allocate_stack_slot(struct fetch_context *ctx, struct process *proc,
263585
 	size_t off = 0;
263585
 	if (proc->e_machine == EM_PPC && a < 4)
263585
 		a = 4;
263585
+#if _CALL_ELF == 2
263585
+	else if (proc->e_machine == EM_PPC64 && sz == 4 && is_hfa_type)
263585
+		a = 4;
263585
+	else
263585
+		a = 8;
263585
+#else
263585
 	else if (proc->e_machine == EM_PPC64 && a < 8)
263585
+#endif
263585
 		a = 8;
263585
 
263585
 	/* XXX Remove the two double casts when arch_addr_t
263585
@@ -164,7 +195,7 @@ allocate_stack_slot(struct fetch_context *ctx, struct process *proc,
263585
 
263585
 	if (valuep != NULL)
263585
 		value_in_inferior(valuep, ctx->stack_pointer + off);
263585
-	ctx->stack_pointer += sz;
263585
+	ctx->stack_pointer += a;
263585
 
263585
 	return 0;
263585
 }
263585
@@ -216,19 +247,34 @@ align_small_int(unsigned char *buf, size_t w, size_t sz)
263585
 
263585
 static int
263585
 allocate_gpr(struct fetch_context *ctx, struct process *proc,
263585
-	     struct arg_type_info *info, struct value *valuep)
263585
+	     struct arg_type_info *info, struct value *valuep,
263585
+	     size_t off, bool is_hfa_type)
263585
 {
263585
 	if (ctx->greg > 10)
263585
-		return allocate_stack_slot(ctx, proc, info, valuep);
263585
+		return allocate_stack_slot(ctx, proc, info, valuep, is_hfa_type);
263585
 
263585
-	int reg_num = ctx->greg++;
263585
-	if (valuep == NULL)
263585
-		return 0;
263585
+	int reg_num = ctx->greg;
263585
 
263585
 	size_t sz = type_sizeof(proc, info);
263585
 	if (sz == (size_t)-1)
263585
 		return -1;
263585
 	assert(sz == 1 || sz == 2 || sz == 4 || sz == 8);
263585
+#if _CALL_ELF == 2
263585
+	/* Consume the stack slot corresponding to this arg.  */
263585
+	if ((sz + off) >= 8)
263585
+		ctx->greg++;
263585
+
263585
+	if (is_hfa_type)
263585
+		ctx->stack_pointer += sz;
263585
+	else
263585
+		ctx->stack_pointer += 8;
263585
+#else
263585
+	ctx->greg++;
263585
+#endif
263585
+
263585
+	if (valuep == NULL)
263585
+		return 0;
263585
+
263585
 	if (value_reserve(valuep, sz) == NULL)
263585
 		return -1;
263585
 
263585
@@ -240,13 +286,14 @@ allocate_gpr(struct fetch_context *ctx, struct process *proc,
263585
 	u.i64 = read_gpr(ctx, proc, reg_num);
263585
 	if (proc->e_machine == EM_PPC)
263585
 		align_small_int(u.buf, 8, sz);
263585
-	memcpy(value_get_raw_data(valuep), u.buf, sz);
263585
+	memcpy(value_get_raw_data(valuep), u.buf + off, sz);
263585
 	return 0;
263585
 }
263585
 
263585
 static int
263585
 allocate_float(struct fetch_context *ctx, struct process *proc,
263585
-	       struct arg_type_info *info, struct value *valuep)
263585
+	       struct arg_type_info *info, struct value *valuep,
263585
+	       size_t off, bool is_hfa_type)
263585
 {
263585
 	int pool = proc->e_machine == EM_PPC64 ? 13 : 8;
263585
 	if (ctx->freg <= pool) {
263585
@@ -257,8 +304,12 @@ allocate_float(struct fetch_context *ctx, struct process *proc,
263585
 		} u = { .d = ctx->fpregs.fpregs[ctx->freg] };
263585
 
263585
 		ctx->freg++;
263585
+
263585
+		if (!is_hfa_type)
263585
+			ctx->vgreg++;
263585
+
263585
 		if (proc->e_machine == EM_PPC64)
263585
-			allocate_gpr(ctx, proc, info, NULL);
263585
+			allocate_gpr(ctx, proc, info, NULL, off, is_hfa_type);
263585
 
263585
 		size_t sz = sizeof(double);
263585
 		if (info->type == ARGTYPE_FLOAT) {
263585
@@ -272,8 +323,128 @@ allocate_float(struct fetch_context *ctx, struct process *proc,
263585
 		memcpy(value_get_raw_data(valuep), u.buf, sz);
263585
 		return 0;
263585
 	}
263585
-	return allocate_stack_slot(ctx, proc, info, valuep);
263585
+	return allocate_stack_slot(ctx, proc, info, valuep, is_hfa_type);
263585
+}
263585
+
263585
+#if _CALL_ELF == 2
263585
+static int
263585
+allocate_hfa(struct fetch_context *ctx, struct process *proc,
263585
+	     struct arg_type_info *info, struct value *valuep,
263585
+	     enum arg_type hfa_type, size_t hfa_count)
263585
+{
263585
+	size_t sz = type_sizeof(proc, info);
263585
+	if (sz == (size_t)-1)
263585
+		return -1;
263585
+
263585
+	ctx->struct_hfa_size += sz;
263585
+
263585
+	/* There are two changes regarding structure return types:
263585
+	 * * heterogeneous float/vector structs are returned
263585
+	 *   in (multiple) FP/vector registers,
263585
+	 *   instead of via implicit reference.
263585
+	 * * small structs (up to 16 bytes) are return
263585
+	 *   in one or two GPRs, instead of via implicit reference.
263585
+	 *
263585
+	 * Other structures (larger than 16 bytes, not heterogeneous)
263585
+	 * are still returned via implicit reference (i.e. a pointer
263585
+	 * to memory where to return the struct being passed in r3).
263585
+	 * Of course, whether or not an implicit reference pointer
263585
+	 * is present will shift the remaining arguments,
263585
+	 * so you need to get this right for ELFv2 in order
263585
+	 * to get the arguments correct.
263585
+	 * If an actual parameter is known to correspond to an HFA
263585
+	 * formal parameter, each element is passed in the next
263585
+	 * available floating-point argument register starting at fp1
263585
+	 * until the fp13. The remaining elements of the aggregate are
263585
+	 * passed on the stack.  */
263585
+	size_t slot_off = 0;
263585
+
263585
+	unsigned char *buf = value_reserve(valuep, sz);
263585
+	if (buf == NULL)
263585
+		return -1;
263585
+
263585
+	struct arg_type_info *hfa_info = type_get_simple(hfa_type);
263585
+	size_t hfa_sz = type_sizeof(proc, hfa_info);
263585
+
263585
+	if (hfa_count > 8)
263585
+		ctx->struct_hfa_count += hfa_count;
263585
+
263585
+	while (hfa_count > 0 && ctx->freg <= 13) {
263585
+		int rc;
263585
+		struct value tmp;
263585
+
263585
+		value_init(&tmp, proc, NULL, hfa_info, 0);
263585
+
263585
+		/* Hetereogeneous struct - get value on GPR or stack.  */
263585
+		if (((hfa_type == ARGTYPE_FLOAT
263585
+		    || hfa_type == ARGTYPE_DOUBLE)
263585
+		      && hfa_count <= 8))
263585
+			rc = allocate_float(ctx, proc, hfa_info, &tmp,
263585
+						slot_off, true);
263585
+		else
263585
+			rc = allocate_gpr(ctx, proc, hfa_info, &tmp,
263585
+						slot_off, true);
263585
+
263585
+		memcpy(buf, value_get_data(&tmp, NULL), hfa_sz);
263585
+
263585
+		slot_off += hfa_sz;
263585
+		buf += hfa_sz;
263585
+		hfa_count--;
263585
+		if (slot_off == 8) {
263585
+			slot_off = 0;
263585
+			ctx->vgreg++;
263585
+		}
263585
+
263585
+		value_destroy(&tmp);
263585
+		if (rc < 0)
263585
+			return -1;
263585
+	}
263585
+	if (hfa_count == 0)
263585
+		return 0;
263585
+
263585
+	/* if no remaining FP, GPR corresponding to slot is used
263585
+	* Mostly it is in part of r10.  */
263585
+	if (ctx->struct_hfa_size <= 64 && ctx->vgreg == 10) {
263585
+		while (ctx->vgreg <= 10) {
263585
+			struct value tmp;
263585
+			value_init(&tmp, proc, NULL, hfa_info, 0);
263585
+			union {
263585
+				uint64_t i64;
263585
+				unsigned char buf[0];
263585
+			} u;
263585
+
263585
+			u.i64 = read_gpr(ctx, proc, ctx->vgreg);
263585
+
263585
+			memcpy(buf, u.buf + slot_off, hfa_sz);
263585
+			slot_off += hfa_sz;
263585
+			buf += hfa_sz;
263585
+			hfa_count--;
263585
+			ctx->stack_pointer += hfa_sz;
263585
+			if (slot_off >= 8 ) {
263585
+				slot_off = 0;
263585
+				ctx->vgreg++;
263585
+			}
263585
+			value_destroy(&tmp);
263585
+		}
263585
+	}
263585
+
263585
+	if (hfa_count == 0)
263585
+		return 0;
263585
+
263585
+	/* Remaining values are on stack */
263585
+	while (hfa_count) {
263585
+		struct value tmp;
263585
+		value_init(&tmp, proc, NULL, hfa_info, 0);
263585
+
263585
+		value_in_inferior(&tmp, ctx->stack_pointer);
263585
+		memcpy(buf, value_get_data(&tmp, NULL), hfa_sz);
263585
+		ctx->stack_pointer += hfa_sz;
263585
+		buf += hfa_sz;
263585
+		hfa_count--;
263585
+	}
263585
+	return 0;
263585
 }
263585
+#endif
263585
 
263585
 static int
263585
 allocate_argument(struct fetch_context *ctx, struct process *proc,
263585
@@ -287,13 +458,25 @@ allocate_argument(struct fetch_context *ctx, struct process *proc,
263585
 
263585
 	case ARGTYPE_FLOAT:
263585
 	case ARGTYPE_DOUBLE:
263585
-		return allocate_float(ctx, proc, info, valuep);
263585
+		return allocate_float(ctx, proc, info, valuep,
263585
+					8 - type_sizeof(proc,info), false);
263585
 
263585
 	case ARGTYPE_STRUCT:
263585
 		if (proc->e_machine == EM_PPC) {
263585
 			if (value_pass_by_reference(valuep) < 0)
263585
 				return -1;
263585
 		} else {
263585
+#if _CALL_ELF == 2
263585
+			struct arg_type_info *hfa_info;
263585
+			size_t hfa_size;
263585
+			hfa_info = type_get_hfa_type(info, &hfa_size);
263585
+			if (hfa_info != NULL ) {
263585
+				size_t sz = type_sizeof(proc, info);
263585
+				ctx->struct_size += sz;
263585
+				return allocate_hfa(ctx, proc, info, valuep,
263585
+						hfa_info->type, hfa_size);
263585
+			}
263585
+#endif
263585
 			/* PPC64: Fixed size aggregates and unions passed by
263585
 			 * value are mapped to as many doublewords of the
263585
 			 * parameter save area as the value uses in memory.
263585
@@ -326,6 +509,10 @@ allocate_argument(struct fetch_context *ctx, struct process *proc,
263585
 	size_t sz = type_sizeof(proc, valuep->type);
263585
 	if (sz == (size_t)-1)
263585
 		return -1;
263585
+
263585
+	if (ctx->ret_struct)
263585
+		ctx->struct_size += sz;
263585
+
263585
 	size_t slots = (sz + width - 1) / width;  /* Round up.  */
263585
 	unsigned char *buf = value_reserve(valuep, slots * width);
263585
 	if (buf == NULL)
263585
@@ -346,9 +533,11 @@ allocate_argument(struct fetch_context *ctx, struct process *proc,
263585
 		struct arg_type_info *fp_info
263585
 			= type_get_fp_equivalent(valuep->type);
263585
 		if (fp_info != NULL)
263585
-			rc = allocate_float(ctx, proc, fp_info, &val;;
263585
+			rc = allocate_float(ctx, proc, fp_info, &val,
263585
+					8-type_sizeof(proc,info), false);
263585
 		else
263585
-			rc = allocate_gpr(ctx, proc, long_info, &val;;
263585
+			rc = allocate_gpr(ctx, proc, long_info, &val,
263585
+					0, false);
263585
 
263585
 		if (rc >= 0) {
263585
 			memcpy(ptr, value_get_data(&val, NULL), width);
263585
@@ -363,6 +552,7 @@ allocate_argument(struct fetch_context *ctx, struct process *proc,
263585
 			return rc;
263585
 	}
263585
 
263585
+#ifndef __LITTLE_ENDIAN__
263585
 	/* Small values need post-processing.  */
263585
 	if (sz < width) {
263585
 		switch (info->type) {
263585
@@ -394,6 +584,7 @@ allocate_argument(struct fetch_context *ctx, struct process *proc,
263585
 			break;
263585
 		}
263585
 	}
263585
+#endif
263585
 
263585
 	return 0;
263585
 }
263585
@@ -411,7 +602,22 @@ arch_fetch_retval(struct fetch_context *ctx, enum tof type,
263585
 		  struct process *proc, struct arg_type_info *info,
263585
 		  struct value *valuep)
263585
 {
263585
+	if (fetch_context_init(proc, ctx) < 0)
263585
+		return -1;
263585
+
263585
+#if _CALL_ELF == 2
263585
+	void *ptr = (void *)(ctx->regs.r64[1]+32);
263585
+	uint64_t val = ptrace(PTRACE_PEEKTEXT, proc->pid, ptr, 0);
263585
+
263585
+	if (ctx->ret_struct
263585
+	   && ((ctx->struct_size > 64
263585
+	      || ctx->struct_hfa_count > 8
263585
+	      || (ctx->struct_hfa_size == 0 && ctx->struct_size > 56)
263585
+	      || (ctx->regs.r64[3] == ctx->regs.r64[1]+32)
263585
+	      || (ctx->regs.r64[3] == val )))) {
263585
+#else
263585
 	if (ctx->ret_struct) {
263585
+#endif
263585
 		assert(info->type == ARGTYPE_STRUCT);
263585
 
263585
 		uint64_t addr = read_gpr(ctx, proc, 3);
263585
@@ -424,8 +630,6 @@ arch_fetch_retval(struct fetch_context *ctx, enum tof type,
263585
 		return 0;
263585
 	}
263585
 
263585
-	if (fetch_context_init(proc, ctx) < 0)
263585
-		return -1;
263585
 	return allocate_argument(ctx, proc, info, valuep);
263585
 }
263585
 
263585
diff --git a/sysdeps/linux-gnu/ppc/plt.c b/sysdeps/linux-gnu/ppc/plt.c
263585
index 332daa8..45ed7fb 100644
263585
--- a/sysdeps/linux-gnu/ppc/plt.c
263585
+++ b/sysdeps/linux-gnu/ppc/plt.c
263585
@@ -136,7 +136,11 @@
263585
  */
263585
 
263585
 #define PPC_PLT_STUB_SIZE 16
263585
-#define PPC64_PLT_STUB_SIZE 8 //xxx
263585
+#if _CALL_ELF != 2
263585
+#define PPC64_PLT_STUB_SIZE 8
263585
+#else
263585
+#define PPC64_PLT_STUB_SIZE 4
263585
+#endif
263585
 
263585
 static inline int
263585
 host_powerpc64()
263585
@@ -186,8 +190,13 @@ ppc32_delayed_symbol(struct library_symbol *libsym)
263585
 	if ((insn1 & BRANCH_MASK) == B_INSN
263585
 	    || ((insn2 & BRANCH_MASK) == B_INSN
263585
 		/* XXX double cast  */
263585
+#ifdef __LITTLE_ENDIAN__
263585
+		&& (ppc_branch_dest(libsym->enter_addr + 4, insn1)
263585
+		    == (arch_addr_t) (long) libsym->lib->arch.pltgot_addr)))
263585
+#else
263585
 		&& (ppc_branch_dest(libsym->enter_addr + 4, insn2)
263585
 		    == (arch_addr_t) (long) libsym->lib->arch.pltgot_addr)))
263585
+#endif
263585
 	{
263585
 		mark_as_resolved(libsym, libsym->arch.resolved_value);
263585
 	}
263585
@@ -206,7 +215,7 @@ arch_dynlink_done(struct process *proc)
263585
 				"couldn't read PLT value for %s(%p): %s\n",
263585
 				libsym->name, libsym->enter_addr,
263585
 				strerror(errno));
263585
-			return;
263585
+				return;
263585
 		}
263585
 
263585
 		if (proc->e_machine == EM_PPC)
263585
@@ -227,8 +236,14 @@ reloc_is_irelative(int machine, GElf_Rela *rela)
263585
 {
263585
 	bool irelative = false;
263585
 	if (machine == EM_PPC64) {
263585
-#ifdef R_PPC64_JMP_IREL
263585
+#ifdef __LITTLE_ENDIAN__
263585
+# ifdef R_PPC64_IRELATIVE
263585
+		irelative = GELF_R_TYPE(rela->r_info) == R_PPC64_IRELATIVE;
263585
+# endif
263585
+#else
263585
+# ifdef R_PPC64_JMP_IREL
263585
 		irelative = GELF_R_TYPE(rela->r_info) == R_PPC64_JMP_IREL;
263585
+# endif
263585
 #endif
263585
 	} else {
263585
 		assert(machine == EM_PPC);
263585
@@ -285,6 +300,7 @@ arch_translate_address_dyn(struct process *proc,
263585
 			   arch_addr_t addr, arch_addr_t *ret)
263585
 {
263585
 	if (proc->e_machine == EM_PPC64) {
263585
+#if _CALL_ELF != 2
263585
 		uint64_t value;
263585
 		if (proc_read_64(proc, addr, &value) < 0) {
263585
 			fprintf(stderr,
263585
@@ -296,6 +312,7 @@ arch_translate_address_dyn(struct process *proc,
263585
 		 * arch_addr_t becomes integral type.  */
263585
 		*ret = (arch_addr_t)(uintptr_t)value;
263585
 		return 0;
263585
+#endif
263585
 	}
263585
 
263585
 	*ret = addr;
263585
@@ -306,7 +323,8 @@ int
263585
 arch_translate_address(struct ltelf *lte,
263585
 		       arch_addr_t addr, arch_addr_t *ret)
263585
 {
263585
-	if (lte->ehdr.e_machine == EM_PPC64) {
263585
+	if (lte->ehdr.e_machine == EM_PPC64
263585
+	    && !lte->arch.elfv2_abi) {
263585
 		/* XXX The double cast should be removed when
263585
 		 * arch_addr_t becomes integral type.  */
263585
 		GElf_Xword offset
263585
@@ -430,7 +448,16 @@ reloc_copy_if_irelative(GElf_Rela *rela, void *data)
263585
 int
263585
 arch_elf_init(struct ltelf *lte, struct library *lib)
263585
 {
263585
+
263585
+	/* Check for ABIv2 in ELF header processor specific flag.  */
263585
+#ifndef EF_PPC64_ABI
263585
+	assert (! (lte->ehdr.e_flags & 3 ) == 2)
263585
+#else
263585
+	lte->arch.elfv2_abi=((lte->ehdr.e_flags & EF_PPC64_ABI) == 2) ;
263585
+#endif
263585
+
263585
 	if (lte->ehdr.e_machine == EM_PPC64
263585
+	    && !lte->arch.elfv2_abi
263585
 	    && load_opd_data(lte, lib) < 0)
263585
 		return -1;
263585
 
263585
@@ -599,7 +626,7 @@ read_plt_slot_value(struct process *proc, GElf_Addr addr, GElf_Addr *valp)
263585
 	uint64_t l;
263585
 	/* XXX double cast.  */
263585
 	if (proc_read_64(proc, (arch_addr_t)(uintptr_t)addr, &l) < 0) {
263585
-		fprintf(stderr, "ptrace .plt slot value @%#" PRIx64": %s\n",
263585
+		debug(DEBUG_EVENT, "ptrace .plt slot value @%#" PRIx64": %s",
263585
 			addr, strerror(errno));
263585
 		return -1;
263585
 	}
263585
@@ -616,7 +643,7 @@ unresolve_plt_slot(struct process *proc, GElf_Addr addr, GElf_Addr value)
263585
 	 * pointers intact.  Hence the only adjustment that we need to
263585
 	 * do is to IP.  */
263585
 	if (ptrace(PTRACE_POKETEXT, proc->pid, addr, value) < 0) {
263585
-		fprintf(stderr, "failed to unresolve .plt slot: %s\n",
263585
+		debug(DEBUG_EVENT, "failed to unresolve .plt slot: %s",
263585
 			strerror(errno));
263585
 		return -1;
263585
 	}
263585
@@ -629,9 +656,48 @@ arch_elf_add_func_entry(struct process *proc, struct ltelf *lte,
263585
 			arch_addr_t addr, const char *name,
263585
 			struct library_symbol **ret)
263585
 {
263585
-	if (lte->ehdr.e_machine != EM_PPC || lte->ehdr.e_type == ET_DYN)
263585
+#ifndef PPC64_LOCAL_ENTRY_OFFSET
263585
+	assert(! lte->arch.elfv2_abi);
263585
+#else
263585
+	/* With ABIv2 st_other field contains an offset.  */
263585
+	 if (lte->arch.elfv2_abi)
263585
+		addr += PPC64_LOCAL_ENTRY_OFFSET(sym->st_other);
263585
+#endif
263585
+
263585
+	int st_info = GELF_ST_TYPE(sym->st_info);
263585
+
263585
+	if ((lte->ehdr.e_machine != EM_PPC && sym->st_other == 0)
263585
+	    || lte->ehdr.e_type == ET_DYN
263585
+	    || (st_info == STT_FUNC && ! sym->st_other))
263585
 		return PLT_DEFAULT;
263585
 
263585
+	if (st_info == STT_FUNC) {
263585
+		/* Put the default symbol to the chain.
263585
+		 * The addr has already been updated with
263585
+		 * symbol offset  */
263585
+		char *full_name = strdup(name);
263585
+		if (full_name == NULL) {
263585
+			fprintf(stderr, "couldn't copy name of %s: %s\n",
263585
+			name, strerror(errno));
263585
+			free(full_name);
263585
+			return PLT_FAIL;
263585
+		}
263585
+		struct library_symbol *libsym = malloc(sizeof *libsym);
263585
+		if (libsym == NULL
263585
+		    || library_symbol_init(libsym, addr, full_name, 1,
263585
+					   LS_TOPLT_NONE) < 0) {
263585
+			free(libsym);
263585
+			delete_symbol_chain(libsym);
263585
+			libsym = NULL;
263585
+			fprintf(stderr, "Couldn't add symbol %s"
263585
+				"for tracing.\n", name);
263585
+		}
263585
+		full_name = NULL;
263585
+		libsym->next = *ret;
263585
+		*ret = libsym;
263585
+		return PLT_OK;
263585
+	}
263585
+
263585
 	bool ifunc = false;
263585
 #ifdef STT_GNU_IFUNC
263585
 	ifunc = GELF_ST_TYPE(sym->st_info) == STT_GNU_IFUNC;
263585
@@ -761,9 +827,15 @@ arch_elf_add_plt_entry(struct process *proc, struct ltelf *lte,
263585
 	assert(plt_slot_addr >= lte->plt_addr
263585
 	       || plt_slot_addr < lte->plt_addr + lte->plt_size);
263585
 
263585
+	/* Should avoid to do read if dynamic linker hasn't run yet
263585
+	 * or allow -1 a valid return code.  */
263585
 	GElf_Addr plt_slot_value;
263585
-	if (read_plt_slot_value(proc, plt_slot_addr, &plt_slot_value) < 0)
263585
-		goto fail;
263585
+	if (read_plt_slot_value(proc, plt_slot_addr, &plt_slot_value) < 0) {
263585
+		if (!lte->arch.elfv2_abi)
263585
+			goto fail;
263585
+		else
263585
+			return PPC_PLT_UNRESOLVED;
263585
+	}
263585
 
263585
 	struct library_symbol *libsym = malloc(sizeof(*libsym));
263585
 	if (libsym == NULL) {
263585
@@ -997,8 +1069,12 @@ ppc_plt_bp_continue(struct breakpoint *bp, struct process *proc)
263585
 			return;
263585
 		}
263585
 
263585
+#if _CALL_ELF == 2
263585
+		continue_after_breakpoint(proc, bp);
263585
+#else
263585
 		jump_to_entry_point(proc, bp);
263585
 		continue_process(proc->pid);
263585
+#endif
263585
 		return;
263585
 
263585
 	case PPC64_PLT_STUB:
263585
@@ -1123,7 +1199,11 @@ arch_library_symbol_init(struct library_symbol *libsym)
263585
 	/* We set type explicitly in the code above, where we have the
263585
 	 * necessary context.  This is for calls from ltrace-elf.c and
263585
 	 * such.  */
263585
+#if _CALL_ELF == 2
263585
+	libsym->arch.type = PPC_PLT_UNRESOLVED;
263585
+#else
263585
 	libsym->arch.type = PPC_DEFAULT;
263585
+#endif
263585
 	return 0;
263585
 }
263585
 
263585
diff --git a/sysdeps/linux-gnu/ppc/trace.c b/sysdeps/linux-gnu/ppc/trace.c
263585
index ee9a6b5..5aab538 100644
263585
--- a/sysdeps/linux-gnu/ppc/trace.c
263585
+++ b/sysdeps/linux-gnu/ppc/trace.c
263585
@@ -65,9 +65,15 @@ syscall_p(struct process *proc, int status, int *sysnum)
263585
 	if (WIFSTOPPED(status)
263585
 	    && WSTOPSIG(status) == (SIGTRAP | proc->tracesysgood)) {
263585
 		long pc = (long)get_instruction_pointer(proc);
263585
+#ifndef __LITTLE_ENDIAN__
263585
 		int insn =
263585
 		    (int)ptrace(PTRACE_PEEKTEXT, proc->pid, pc - sizeof(long),
263585
 				0);
263585
+#else
263585
+		int insn =
263585
+		    (int)ptrace(PTRACE_PEEKTEXT, proc->pid, pc - sizeof(int),
263585
+				0);
263585
+#endif
263585
 
263585
 		if (insn == SYSCALL_INSN) {
263585
 			*sysnum =
263585
diff -up ltrace-0.7.91/sysdeps/linux-gnu/ppc/trace.c\~ ltrace-0.7.91/sysdeps/linux-gnu/ppc/trace.c
263585
--- ltrace-0.7.91/sysdeps/linux-gnu/ppc/trace.c~	2014-08-08 14:05:58.000000000 +0200
263585
+++ ltrace-0.7.91/sysdeps/linux-gnu/ppc/trace.c	2014-08-08 14:07:55.000000000 +0200
263585
@@ -133,7 +133,11 @@ arch_sw_singlestep(struct process *proc,
263585
 			return SWS_FAIL;
263585
 		uint32_t insn;
263585
 #ifdef __powerpc64__
263585
+# ifdef __LITTLE_ENDIAN__
263585
+		insn = (uint32_t) l;
263585
+# else
263585
 		insn = l >> 32;
263585
+# endif
263585
 #else
263585
 		insn = l;
263585
 #endif
263585
diff -up ltrace-0.7.91/configure\~ ltrace-0.7.91/configure
263585
--- ltrace-0.7.91/configure~	2014-08-08 14:09:12.000000000 +0200
263585
+++ ltrace-0.7.91/configure	2014-08-08 14:18:30.000000000 +0200
263585
@@ -2555,7 +2555,7 @@ case "${host_cpu}" in
263585
     arm*|sa110)		HOST_CPU="arm" ;;
263585
     cris*)		HOST_CPU="cris" ;;
263585
     mips*)		HOST_CPU="mips" ;;
263585
-    powerpc|powerpc64)	HOST_CPU="ppc" ;;
263585
+    powerpc|powerpc64|powerpc64le)	HOST_CPU="ppc" ;;
263585
     sun4u|sparc64)	HOST_CPU="sparc" ;;
263585
     s390x)		HOST_CPU="s390" ;;
263585
     i?86|x86_64)	HOST_CPU="x86" ;;
263585
@@ -12094,7 +12094,7 @@ if test x"$enable_libunwind" = xyes; the
263585
       arm*|sa110)         UNWIND_ARCH="arm" ;;
263585
       i?86)               UNWIND_ARCH="x86" ;;
263585
       powerpc)            UNWIND_ARCH="ppc32" ;;
263585
-      powerpc64)          UNWIND_ARCH="ppc64" ;;
263585
+      powerpc64|powerpc64le)          UNWIND_ARCH="ppc64" ;;
263585
       mips*)              UNWIND_ARCH="mips" ;;
263585
       *)                  UNWIND_ARCH="${host_cpu}" ;;
263585
   esac