|
 |
4604e0 |
From 93c0d8e98f3859c91fbfa2a6998235ee899e878e Mon Sep 17 00:00:00 2001
|
|
|
4604e0 |
From: Kamil Dudka <kdudka@redhat.com>
|
|
|
4604e0 |
Date: Thu, 20 Jul 2017 08:05:59 +0200
|
|
|
4604e0 |
Subject: [PATCH 1/2] nss: unify the coding style of nss_send() and nss_recv()
|
|
|
4604e0 |
|
|
|
4604e0 |
No changes in behavior intended by this commit.
|
|
|
4604e0 |
|
|
|
4604e0 |
Upstream-commit: c89eb6d0f87a3620074bc04a6af255e5dc3a523e
|
|
|
4604e0 |
Signed-off-by: Kamil Dudka <kdudka@redhat.com>
|
|
|
4604e0 |
---
|
|
|
4604e0 |
lib/nss.c | 12 +++++++-----
|
|
|
4604e0 |
1 file changed, 7 insertions(+), 5 deletions(-)
|
|
|
4604e0 |
|
|
|
4604e0 |
diff --git a/lib/nss.c b/lib/nss.c
|
|
|
4604e0 |
index 9e0e373..ce1e25a 100644
|
|
|
4604e0 |
--- a/lib/nss.c
|
|
|
4604e0 |
+++ b/lib/nss.c
|
|
|
4604e0 |
@@ -1689,9 +1689,10 @@ static ssize_t nss_send(struct connectdata *conn, /* connection data */
|
|
|
4604e0 |
size_t len, /* amount to write */
|
|
|
4604e0 |
CURLcode *curlcode)
|
|
|
4604e0 |
{
|
|
|
4604e0 |
- int rc;
|
|
|
4604e0 |
+ struct ssl_connect_data *connssl = &conn->ssl[sockindex];
|
|
|
4604e0 |
+ ssize_t rc;
|
|
|
4604e0 |
|
|
|
4604e0 |
- rc = PR_Send(conn->ssl[sockindex].handle, mem, (int)len, 0, -1);
|
|
|
4604e0 |
+ rc = PR_Send(connssl->handle, mem, (int)len, 0, -1);
|
|
|
4604e0 |
|
|
|
4604e0 |
if(rc < 0) {
|
|
|
4604e0 |
PRInt32 err = PR_GetError();
|
|
|
4604e0 |
@@ -1714,15 +1715,16 @@ static ssize_t nss_send(struct connectdata *conn, /* connection data */
|
|
|
4604e0 |
return rc; /* number of bytes */
|
|
|
4604e0 |
}
|
|
|
4604e0 |
|
|
|
4604e0 |
-static ssize_t nss_recv(struct connectdata * conn, /* connection data */
|
|
|
4604e0 |
- int num, /* socketindex */
|
|
|
4604e0 |
+static ssize_t nss_recv(struct connectdata *conn, /* connection data */
|
|
|
4604e0 |
+ int sockindex, /* socketindex */
|
|
|
4604e0 |
char *buf, /* store read data here */
|
|
|
4604e0 |
size_t buffersize, /* max amount to read */
|
|
|
4604e0 |
CURLcode *curlcode)
|
|
|
4604e0 |
{
|
|
|
4604e0 |
+ struct ssl_connect_data *connssl = &conn->ssl[sockindex];
|
|
|
4604e0 |
ssize_t nread;
|
|
|
4604e0 |
|
|
|
4604e0 |
- nread = PR_Recv(conn->ssl[num].handle, buf, (int)buffersize, 0, -1);
|
|
|
4604e0 |
+ nread = PR_Recv(connssl->handle, buf, (int)buffersize, 0, -1);
|
|
|
4604e0 |
if(nread < 0) {
|
|
|
4604e0 |
/* failed SSL read */
|
|
|
4604e0 |
PRInt32 err = PR_GetError();
|
|
|
4604e0 |
--
|
|
|
4604e0 |
2.13.5
|
|
|
4604e0 |
|
|
|
4604e0 |
|
|
|
4604e0 |
From 032731492497a1cde17752f8c178719bd32a7722 Mon Sep 17 00:00:00 2001
|
|
|
4604e0 |
From: Kamil Dudka <kdudka@redhat.com>
|
|
|
4604e0 |
Date: Wed, 19 Jul 2017 18:02:26 +0200
|
|
|
4604e0 |
Subject: [PATCH 2/2] nss: fix a possible use-after-free in SelectClientCert()
|
|
|
4604e0 |
|
|
|
4604e0 |
... causing a SIGSEGV in showit() in case the handle used to initiate
|
|
|
4604e0 |
the connection has already been freed.
|
|
|
4604e0 |
|
|
|
4604e0 |
This commit fixes a bug introduced in curl-7_19_5-204-g5f0cae803.
|
|
|
4604e0 |
|
|
|
4604e0 |
Reported-by: Rob Sanders
|
|
|
4604e0 |
Bug: https://bugzilla.redhat.com/1436158
|
|
|
4604e0 |
|
|
|
4604e0 |
Upstream-commit: 42a4cd4c78b3feb5ca07286479129116e125a730
|
|
|
4604e0 |
Signed-off-by: Kamil Dudka <kdudka@redhat.com>
|
|
|
4604e0 |
---
|
|
|
4604e0 |
lib/nss.c | 8 ++++++++
|
|
|
4604e0 |
1 file changed, 8 insertions(+)
|
|
|
4604e0 |
|
|
|
4604e0 |
diff --git a/lib/nss.c b/lib/nss.c
|
|
|
4604e0 |
index ce1e25a..b73a1e8 100644
|
|
|
4604e0 |
--- a/lib/nss.c
|
|
|
4604e0 |
+++ b/lib/nss.c
|
|
|
4604e0 |
@@ -1692,6 +1692,10 @@ static ssize_t nss_send(struct connectdata *conn, /* connection data */
|
|
|
4604e0 |
struct ssl_connect_data *connssl = &conn->ssl[sockindex];
|
|
|
4604e0 |
ssize_t rc;
|
|
|
4604e0 |
|
|
|
4604e0 |
+ /* The SelectClientCert() hook uses this for infof() and failf() but the
|
|
|
4604e0 |
+ handle stored in nss_setup_connect() could have already been freed. */
|
|
|
4604e0 |
+ connssl->data = conn->data;
|
|
|
4604e0 |
+
|
|
|
4604e0 |
rc = PR_Send(connssl->handle, mem, (int)len, 0, -1);
|
|
|
4604e0 |
|
|
|
4604e0 |
if(rc < 0) {
|
|
|
4604e0 |
@@ -1724,6 +1728,10 @@ static ssize_t nss_recv(struct connectdata *conn, /* connection data */
|
|
|
4604e0 |
struct ssl_connect_data *connssl = &conn->ssl[sockindex];
|
|
|
4604e0 |
ssize_t nread;
|
|
|
4604e0 |
|
|
|
4604e0 |
+ /* The SelectClientCert() hook uses this for infof() and failf() but the
|
|
|
4604e0 |
+ handle stored in nss_setup_connect() could have already been freed. */
|
|
|
4604e0 |
+ connssl->data = conn->data;
|
|
|
4604e0 |
+
|
|
|
4604e0 |
nread = PR_Recv(connssl->handle, buf, (int)buffersize, 0, -1);
|
|
|
4604e0 |
if(nread < 0) {
|
|
|
4604e0 |
/* failed SSL read */
|
|
|
4604e0 |
--
|
|
|
4604e0 |
2.13.5
|
|
|
4604e0 |
|