|
 |
9d7d3f |
From 7959c5713bbec03c9284a14b1fdd7379520199bc Mon Sep 17 00:00:00 2001
|
|
|
9d7d3f |
From: Daniel Stenberg <daniel@haxx.se>
|
|
|
9d7d3f |
Date: Thu, 8 Sep 2016 22:59:54 +0200
|
|
|
9d7d3f |
Subject: [PATCH 1/2] curl_easy_escape: deny negative string lengths as input
|
|
|
9d7d3f |
|
|
|
9d7d3f |
CVE-2016-7167
|
|
|
9d7d3f |
|
|
|
9d7d3f |
Bug: https://curl.haxx.se/docs/adv_20160914.html
|
|
|
9d7d3f |
|
|
|
9d7d3f |
Upstream-commit: 826a9ced2bed217155e34065ef4048931f327b1e
|
|
|
9d7d3f |
Signed-off-by: Kamil Dudka <kdudka@redhat.com>
|
|
|
9d7d3f |
---
|
|
|
9d7d3f |
lib/escape.c | 10 ++++++++--
|
|
|
9d7d3f |
1 file changed, 8 insertions(+), 2 deletions(-)
|
|
|
9d7d3f |
|
|
|
9d7d3f |
diff --git a/lib/escape.c b/lib/escape.c
|
|
|
9d7d3f |
index 40338a9..c6aa3b9 100644
|
|
|
9d7d3f |
--- a/lib/escape.c
|
|
|
9d7d3f |
+++ b/lib/escape.c
|
|
|
9d7d3f |
@@ -80,15 +80,21 @@ char *curl_unescape(const char *string, int length)
|
|
|
9d7d3f |
|
|
|
9d7d3f |
char *curl_easy_escape(CURL *handle, const char *string, int inlength)
|
|
|
9d7d3f |
{
|
|
|
9d7d3f |
- size_t alloc = (inlength?(size_t)inlength:strlen(string))+1;
|
|
|
9d7d3f |
+ size_t alloc;
|
|
|
9d7d3f |
char *ns;
|
|
|
9d7d3f |
char *testing_ptr = NULL;
|
|
|
9d7d3f |
unsigned char in; /* we need to treat the characters unsigned */
|
|
|
9d7d3f |
- size_t newlen = alloc;
|
|
|
9d7d3f |
+ size_t newlen;
|
|
|
9d7d3f |
size_t strindex=0;
|
|
|
9d7d3f |
size_t length;
|
|
|
9d7d3f |
CURLcode res;
|
|
|
9d7d3f |
|
|
|
9d7d3f |
+ if(inlength < 0)
|
|
|
9d7d3f |
+ return NULL;
|
|
|
9d7d3f |
+
|
|
|
9d7d3f |
+ alloc = (inlength?(size_t)inlength:strlen(string))+1;
|
|
|
9d7d3f |
+ newlen = alloc;
|
|
|
9d7d3f |
+
|
|
|
9d7d3f |
ns = malloc(alloc);
|
|
|
9d7d3f |
if(!ns)
|
|
|
9d7d3f |
return NULL;
|
|
|
9d7d3f |
--
|
|
|
9d7d3f |
2.7.4
|
|
|
9d7d3f |
|
|
|
9d7d3f |
|
|
|
9d7d3f |
From 6a280152e3893938e5d26f5d535613eefab80b5a Mon Sep 17 00:00:00 2001
|
|
|
9d7d3f |
From: Daniel Stenberg <daniel@haxx.se>
|
|
|
9d7d3f |
Date: Tue, 13 Sep 2016 23:00:50 +0200
|
|
|
9d7d3f |
Subject: [PATCH 2/2] curl_easy_unescape: deny negative string lengths as input
|
|
|
9d7d3f |
|
|
|
9d7d3f |
CVE-2016-7167
|
|
|
9d7d3f |
|
|
|
9d7d3f |
Bug: https://curl.haxx.se/docs/adv_20160914.html
|
|
|
9d7d3f |
|
|
|
9d7d3f |
Upstream-commit: 01cf1308ee2e792c77bb1d2c9218c56a30fd40ae
|
|
|
9d7d3f |
Signed-off-by: Kamil Dudka <kdudka@redhat.com>
|
|
|
9d7d3f |
---
|
|
|
9d7d3f |
lib/escape.c | 18 ++++++++++--------
|
|
|
9d7d3f |
1 file changed, 10 insertions(+), 8 deletions(-)
|
|
|
9d7d3f |
|
|
|
9d7d3f |
diff --git a/lib/escape.c b/lib/escape.c
|
|
|
9d7d3f |
index c6aa3b9..808ac6c 100644
|
|
|
9d7d3f |
--- a/lib/escape.c
|
|
|
9d7d3f |
+++ b/lib/escape.c
|
|
|
9d7d3f |
@@ -219,14 +219,16 @@ char *curl_easy_unescape(CURL *handle, const char *string, int length,
|
|
|
9d7d3f |
int *olen)
|
|
|
9d7d3f |
{
|
|
|
9d7d3f |
char *str = NULL;
|
|
|
9d7d3f |
- size_t inputlen = length;
|
|
|
9d7d3f |
- size_t outputlen;
|
|
|
9d7d3f |
- CURLcode res = Curl_urldecode(handle, string, inputlen, &str, &outputlen,
|
|
|
9d7d3f |
- FALSE);
|
|
|
9d7d3f |
- if(res)
|
|
|
9d7d3f |
- return NULL;
|
|
|
9d7d3f |
- if(olen)
|
|
|
9d7d3f |
- *olen = curlx_uztosi(outputlen);
|
|
|
9d7d3f |
+ if(length >= 0) {
|
|
|
9d7d3f |
+ size_t inputlen = length;
|
|
|
9d7d3f |
+ size_t outputlen;
|
|
|
9d7d3f |
+ CURLcode res = Curl_urldecode(handle, string, inputlen, &str, &outputlen,
|
|
|
9d7d3f |
+ FALSE);
|
|
|
9d7d3f |
+ if(res)
|
|
|
9d7d3f |
+ return NULL;
|
|
|
9d7d3f |
+ if(olen)
|
|
|
9d7d3f |
+ *olen = curlx_uztosi(outputlen);
|
|
|
9d7d3f |
+ }
|
|
|
9d7d3f |
return str;
|
|
|
9d7d3f |
}
|
|
|
9d7d3f |
|
|
|
9d7d3f |
--
|
|
|
9d7d3f |
2.7.4
|
|
|
9d7d3f |
|