Blame SOURCES/0041-curl-7.29.0-b2dcf034.patch

c260e0
From ac2121bf962ecc054dd103ccd42a93912051672e Mon Sep 17 00:00:00 2001
c260e0
From: Kamil Dudka <kdudka@redhat.com>
c260e0
Date: Tue, 21 Jun 2016 12:40:26 +0200
c260e0
Subject: [PATCH] curl-compilers.m4: improve detection of GCC's -fvisibility=
c260e0
 flag
c260e0
c260e0
Some builds of GCC produce output on both stdout and stderr when --help
c260e0
--verbose is used.  The 2>&1 redirection caused them to be arbitrarily
c260e0
interleaved with each other because of stream buffering.  Consequently,
c260e0
grep failed to match the fvisibility= string in the mixed output, even
c260e0
though the string was present in GCC's standard output.
c260e0
c260e0
This led to silently disabling symbol hiding in some builds of curl.
c260e0
c260e0
Upstream-commit: b2dcf0347f1ee5041cccd64632bb8dd7ccbbae91
c260e0
Signed-off-by: Kamil Dudka <kdudka@redhat.com>
c260e0
---
c260e0
 configure            | 2 +-
c260e0
 m4/curl-compilers.m4 | 4 ++--
c260e0
 2 files changed, 3 insertions(+), 3 deletions(-)
c260e0
c260e0
diff --git a/configure b/configure
c260e0
index 4797e02..fc260ee 100755
c260e0
--- a/configure
c260e0
+++ b/configure
c260e0
@@ -17636,7 +17636,7 @@ $as_echo_n "checking if compiler supports hiding library internal symbols... " >
c260e0
       ;;
c260e0
     GNU_C)
c260e0
             if test "$compiler_num" -ge "304"; then
c260e0
-        if $CC --help --verbose 2>&1 | grep fvisibility= > /dev/null ; then
c260e0
+        if $CC --help --verbose 2>/dev/null | grep fvisibility= >/dev/null ; then
c260e0
           tmp_EXTERN="__attribute__ ((__visibility__ (\"default\")))"
c260e0
           tmp_CFLAGS="-fvisibility=hidden"
c260e0
           supports_symbol_hiding="yes"
c260e0
diff --git a/m4/curl-compilers.m4 b/m4/curl-compilers.m4
c260e0
index ca064dd..77371de 100644
c260e0
--- a/m4/curl-compilers.m4
c260e0
+++ b/m4/curl-compilers.m4
c260e0
@@ -21,7 +21,7 @@
c260e0
 #***************************************************************************
c260e0
 
c260e0
 # File version for 'aclocal' use. Keep it a single number.
c260e0
-# serial 65
c260e0
+# serial 66
c260e0
 
c260e0
 
c260e0
 dnl CURL_CHECK_COMPILER
c260e0
@@ -1391,7 +1391,7 @@ AC_DEFUN([CURL_CHECK_COMPILER_SYMBOL_HIDING], [
c260e0
     GNU_C)
c260e0
       dnl Only gcc 3.4 or later
c260e0
       if test "$compiler_num" -ge "304"; then
c260e0
-        if $CC --help --verbose 2>&1 | grep fvisibility= > /dev/null ; then
c260e0
+        if $CC --help --verbose 2>/dev/null | grep fvisibility= >/dev/null ; then
c260e0
           tmp_EXTERN="__attribute__ ((__visibility__ (\"default\")))"
c260e0
           tmp_CFLAGS="-fvisibility=hidden"
c260e0
           supports_symbol_hiding="yes"
c260e0
-- 
c260e0
2.5.5
c260e0