Blame SOURCES/cups-systemd-socket.patch

87cf9a
diff -up cups-1.6.2/config.h.in.systemd-socket cups-1.6.2/config.h.in
87cf9a
--- cups-1.6.2/config.h.in.systemd-socket	2012-12-17 23:17:08.000000000 +0100
87cf9a
+++ cups-1.6.2/config.h.in	2013-03-18 18:53:53.768961644 +0100
87cf9a
@@ -487,6 +487,13 @@
87cf9a
 
87cf9a
 
87cf9a
 /*
87cf9a
+ * Do we have systemd support?
87cf9a
+ */
87cf9a
+
87cf9a
+#undef HAVE_SYSTEMD
87cf9a
+
87cf9a
+
87cf9a
+/*
87cf9a
  * Various scripting languages...
87cf9a
  */
87cf9a
 
87cf9a
diff -up cups-1.6.2/config-scripts/cups-systemd.m4.systemd-socket cups-1.6.2/config-scripts/cups-systemd.m4
87cf9a
--- cups-1.6.2/config-scripts/cups-systemd.m4.systemd-socket	2013-03-18 18:53:53.769961630 +0100
87cf9a
+++ cups-1.6.2/config-scripts/cups-systemd.m4	2013-03-18 18:53:53.769961630 +0100
87cf9a
@@ -0,0 +1,36 @@
87cf9a
+dnl
87cf9a
+dnl "$Id$"
87cf9a
+dnl
87cf9a
+dnl   systemd stuff for CUPS.
87cf9a
+
87cf9a
+dnl Find whether systemd is available
87cf9a
+
87cf9a
+SDLIBS=""
87cf9a
+AC_ARG_WITH([systemdsystemunitdir],
87cf9a
+        AS_HELP_STRING([--with-systemdsystemunitdir=DIR], [Directory for systemd service files]),
87cf9a
+        [], [with_systemdsystemunitdir=$($PKGCONFIG --variable=systemdsystemunitdir systemd)])
87cf9a
+if test "x$with_systemdsystemunitdir" != xno; then
87cf9a
+        AC_MSG_CHECKING(for libsystemd-daemon)
87cf9a
+        if $PKGCONFIG --exists libsystemd-daemon; then
87cf9a
+		AC_MSG_RESULT(yes)
87cf9a
+        	SDCFLAGS=`$PKGCONFIG --cflags libsystemd-daemon`
87cf9a
+        	SDLIBS=`$PKGCONFIG --libs libsystemd-daemon`
87cf9a
+		AC_SUBST([systemdsystemunitdir], [$with_systemdsystemunitdir])
87cf9a
+		AC_DEFINE(HAVE_SYSTEMD)
87cf9a
+	else
87cf9a
+		AC_MSG_RESULT(no)
87cf9a
+	fi
87cf9a
+fi
87cf9a
+
87cf9a
+if test -n "$with_systemdsystemunitdir" -a "x$with_systemdsystemunitdir" != xno ; then
87cf9a
+        SYSTEMD_UNITS="cups.service cups.socket cups.path"
87cf9a
+else
87cf9a
+        SYSTEMD_UNITS=""
87cf9a
+fi
87cf9a
+
87cf9a
+AC_SUBST(SYSTEMD_UNITS)
87cf9a
+AC_SUBST(SDLIBS)
87cf9a
+
87cf9a
+dnl
87cf9a
+dnl "$Id$"
87cf9a
+dnl
87cf9a
diff -up cups-1.6.2/configure.in.systemd-socket cups-1.6.2/configure.in
87cf9a
--- cups-1.6.2/configure.in.systemd-socket	2013-03-18 18:00:03.000000000 +0100
87cf9a
+++ cups-1.6.2/configure.in	2013-03-18 18:55:30.773612461 +0100
87cf9a
@@ -33,6 +33,7 @@ sinclude(config-scripts/cups-pam.m4)
87cf9a
 sinclude(config-scripts/cups-largefile.m4)
87cf9a
 sinclude(config-scripts/cups-dnssd.m4)
87cf9a
 sinclude(config-scripts/cups-launchd.m4)
87cf9a
+sinclude(config-scripts/cups-systemd.m4)
87cf9a
 sinclude(config-scripts/cups-defaults.m4)
87cf9a
 sinclude(config-scripts/cups-scripting.m4)
87cf9a
 
87cf9a
@@ -67,6 +68,9 @@ AC_OUTPUT(Makedefs
87cf9a
 	  conf/snmp.conf
87cf9a
 	  cups-config
87cf9a
 	  data/testprint
87cf9a
+	  data/cups.service
87cf9a
+	  data/cups.socket
87cf9a
+	  data/cups.path
87cf9a
 	  desktop/cups.desktop
87cf9a
 	  doc/help/ref-cups-files-conf.html
87cf9a
 	  doc/help/ref-cupsd-conf.html
87cf9a
diff -up cups-1.6.2/cups/usersys.c.systemd-socket cups-1.6.2/cups/usersys.c
87cf9a
--- cups-1.6.2/cups/usersys.c.systemd-socket	2013-03-12 15:26:28.000000000 +0100
87cf9a
+++ cups-1.6.2/cups/usersys.c	2013-03-18 18:53:53.769961630 +0100
87cf9a
@@ -964,7 +964,7 @@ cups_read_client_conf(
87cf9a
     struct stat	sockinfo;		/* Domain socket information */
87cf9a
 
87cf9a
     if (!stat(CUPS_DEFAULT_DOMAINSOCKET, &sockinfo) &&
87cf9a
-	(sockinfo.st_mode & S_IRWXO) == S_IRWXO)
87cf9a
+	(sockinfo.st_mode & (S_IROTH | S_IWOTH)) == (S_IROTH | S_IWOTH))
87cf9a
       cups_server = CUPS_DEFAULT_DOMAINSOCKET;
87cf9a
     else
87cf9a
 #endif /* CUPS_DEFAULT_DOMAINSOCKET */
87cf9a
diff -up cups-1.6.2/data/cups.path.in.systemd-socket cups-1.6.2/data/cups.path.in
87cf9a
--- cups-1.6.2/data/cups.path.in.systemd-socket	2013-03-18 18:53:53.770961616 +0100
87cf9a
+++ cups-1.6.2/data/cups.path.in	2013-03-18 18:53:53.770961616 +0100
87cf9a
@@ -0,0 +1,8 @@
87cf9a
+[Unit]
87cf9a
+Description=CUPS Printer Service Spool
87cf9a
+
87cf9a
+[Path]
87cf9a
+PathExistsGlob=@CUPS_REQUESTS@/d*
87cf9a
+
87cf9a
+[Install]
87cf9a
+WantedBy=multi-user.target
87cf9a
diff -up cups-1.6.2/data/cups.service.in.systemd-socket cups-1.6.2/data/cups.service.in
87cf9a
--- cups-1.6.2/data/cups.service.in.systemd-socket	2013-03-18 18:53:53.770961616 +0100
87cf9a
+++ cups-1.6.2/data/cups.service.in	2013-03-18 18:53:53.770961616 +0100
87cf9a
@@ -0,0 +1,11 @@
87cf9a
+[Unit]
87cf9a
+Description=CUPS Printing Service
87cf9a
+After=network.target
87cf9a
+
87cf9a
+[Service]
87cf9a
+ExecStart=@sbindir@/cupsd -f
87cf9a
+PrivateTmp=true
87cf9a
+
87cf9a
+[Install]
87cf9a
+Also=cups.socket cups.path
87cf9a
+WantedBy=printer.target
87cf9a
diff -up cups-1.6.2/data/cups.socket.in.systemd-socket cups-1.6.2/data/cups.socket.in
87cf9a
--- cups-1.6.2/data/cups.socket.in.systemd-socket	2013-03-18 18:53:53.770961616 +0100
87cf9a
+++ cups-1.6.2/data/cups.socket.in	2013-03-18 18:53:53.770961616 +0100
87cf9a
@@ -0,0 +1,8 @@
87cf9a
+[Unit]
87cf9a
+Description=CUPS Printing Service Sockets
87cf9a
+
87cf9a
+[Socket]
87cf9a
+ListenStream=@CUPS_DEFAULT_DOMAINSOCKET@
87cf9a
+
87cf9a
+[Install]
87cf9a
+WantedBy=sockets.target
87cf9a
diff -up cups-1.6.2/data/Makefile.systemd-socket cups-1.6.2/data/Makefile
87cf9a
--- cups-1.6.2/data/Makefile.systemd-socket	2011-08-27 11:23:01.000000000 +0200
87cf9a
+++ cups-1.6.2/data/Makefile	2013-03-18 18:53:53.770961616 +0100
87cf9a
@@ -100,6 +100,12 @@ install-data:
87cf9a
 		$(INSTALL_DATA) $$file $(DATADIR)/ppdc; \
87cf9a
 	done
87cf9a
 	$(INSTALL_DIR) -m 755 $(DATADIR)/profiles
87cf9a
+	if test "x$(SYSTEMD_UNITS)" != "x" ; then \
87cf9a
+		$(INSTALL_DIR) -m 755 $(SYSTEMDUNITDIR); \
87cf9a
+		for file in $(SYSTEMD_UNITS); do \
87cf9a
+			$(INSTALL_DATA) $$file $(SYSTEMDUNITDIR); \
87cf9a
+		done; \
87cf9a
+	fi
87cf9a
 
87cf9a
 
87cf9a
 #
87cf9a
@@ -143,6 +149,9 @@ uninstall:
87cf9a
 	-$(RMDIR) $(DATADIR)/data
87cf9a
 	-$(RMDIR) $(DATADIR)/banners
87cf9a
 	-$(RMDIR) $(DATADIR)
87cf9a
+	for file in $(SYSTEMD_UNITS); do \
87cf9a
+		$(RM) $(SYSTEMDUNITDIR)/$$file; \
87cf9a
+	done
87cf9a
 
87cf9a
 
87cf9a
 #
87cf9a
diff -up cups-1.6.2/Makedefs.in.systemd-socket cups-1.6.2/Makedefs.in
87cf9a
--- cups-1.6.2/Makedefs.in.systemd-socket	2013-03-18 18:53:53.758961783 +0100
87cf9a
+++ cups-1.6.2/Makedefs.in	2013-03-18 18:53:53.771961602 +0100
87cf9a
@@ -134,11 +134,13 @@ CXXFLAGS	=	@CPPFLAGS@ @CXXFLAGS@
87cf9a
 CXXLIBS		=	@CXXLIBS@
87cf9a
 DBUS_NOTIFIER	=	@DBUS_NOTIFIER@
87cf9a
 DBUS_NOTIFIERLIBS =	@DBUS_NOTIFIERLIBS@
87cf9a
+SYSTEMD_UNITS   =       @SYSTEMD_UNITS@
87cf9a
 DNSSD_BACKEND	=	@DNSSD_BACKEND@
87cf9a
 DSOFLAGS	=	-L../cups @DSOFLAGS@
87cf9a
 DSOLIBS		=	@DSOLIBS@ $(COMMONLIBS)
87cf9a
 DNSSDLIBS	=	@DNSSDLIBS@
87cf9a
 LAUNCHDLIBS	=	@LAUNCHDLIBS@
87cf9a
+SDLIBS		=	@SDLIBS@
87cf9a
 LDFLAGS		=	-L../cgi-bin -L../cups -L../filter -L../ppdc \
87cf9a
 			-L../scheduler @LDARCHFLAGS@ \
87cf9a
 			@LDFLAGS@ @RELROFLAGS@ @PIEFLAGS@ $(OPTIM)
87cf9a
@@ -229,6 +231,7 @@ PAMFILE		=	@PAMFILE@
87cf9a
 
87cf9a
 DEFAULT_LAUNCHD_CONF =	@DEFAULT_LAUNCHD_CONF@
87cf9a
 DBUSDIR		=	@DBUSDIR@
87cf9a
+SYSTEMDUNITDIR  =       $(BUILDROOT)@systemdsystemunitdir@
87cf9a
 
87cf9a
 
87cf9a
 #
87cf9a
diff -up cups-1.6.2/scheduler/client.h.systemd-socket cups-1.6.2/scheduler/client.h
87cf9a
--- cups-1.6.2/scheduler/client.h.systemd-socket	2012-03-22 21:30:20.000000000 +0100
87cf9a
+++ cups-1.6.2/scheduler/client.h	2013-03-18 18:53:53.771961602 +0100
87cf9a
@@ -77,6 +77,9 @@ typedef struct
87cf9a
   int			fd;		/* File descriptor for this server */
87cf9a
   http_addr_t		address;	/* Bind address of socket */
87cf9a
   http_encryption_t	encryption;	/* To encrypt or not to encrypt... */
87cf9a
+#ifdef HAVE_SYSTEMD
87cf9a
+  int			is_systemd;	/* Is this a systemd socket? */
87cf9a
+#endif /* HAVE_SYSTEMD */
87cf9a
 } cupsd_listener_t;
87cf9a
 
87cf9a
 
87cf9a
diff -up cups-1.6.2/scheduler/listen.c.systemd-socket cups-1.6.2/scheduler/listen.c
87cf9a
--- cups-1.6.2/scheduler/listen.c.systemd-socket	2011-04-16 01:38:13.000000000 +0200
87cf9a
+++ cups-1.6.2/scheduler/listen.c	2013-03-18 18:53:53.771961602 +0100
87cf9a
@@ -401,7 +401,11 @@ cupsdStopListening(void)
87cf9a
        lis;
87cf9a
        lis = (cupsd_listener_t *)cupsArrayNext(Listeners))
87cf9a
   {
87cf9a
-    if (lis->fd != -1)
87cf9a
+    if (lis->fd != -1
87cf9a
+#ifdef HAVE_SYSTEMD
87cf9a
+        && !lis->is_systemd
87cf9a
+#endif /* HAVE_SYSTEMD */
87cf9a
+        )
87cf9a
     {
87cf9a
 #ifdef WIN32
87cf9a
       closesocket(lis->fd);
87cf9a
diff -up cups-1.6.2/scheduler/main.c.systemd-socket cups-1.6.2/scheduler/main.c
87cf9a
--- cups-1.6.2/scheduler/main.c.systemd-socket	2013-03-18 18:53:53.724962256 +0100
87cf9a
+++ cups-1.6.2/scheduler/main.c	2013-03-18 18:53:53.772961588 +0100
87cf9a
@@ -26,6 +26,8 @@
87cf9a
  *   launchd_checkin()     - Check-in with launchd and collect the listening
87cf9a
  *                           fds.
87cf9a
  *   launchd_checkout()    - Update the launchd KeepAlive file as needed.
87cf9a
+ *   systemd_checkin()     - Check-in with systemd and collect the
87cf9a
+ *                           listening fds.
87cf9a
  *   parent_handler()      - Catch USR1/CHLD signals...
87cf9a
  *   process_children()    - Process all dead children...
87cf9a
  *   select_timeout()      - Calculate the select timeout value.
87cf9a
@@ -62,6 +64,10 @@
87cf9a
 #  endif /* !LAUNCH_JOBKEY_SERVICEIPC */
87cf9a
 #endif /* HAVE_LAUNCH_H */
87cf9a
 
87cf9a
+#ifdef HAVE_SYSTEMD
87cf9a
+#include <systemd/sd-daemon.h>
87cf9a
+#endif /* HAVE_SYSTEMD */
87cf9a
+
87cf9a
 #if defined(HAVE_MALLOC_H) && defined(HAVE_MALLINFO)
87cf9a
 #  include <malloc.h>
87cf9a
 #endif /* HAVE_MALLOC_H && HAVE_MALLINFO */
87cf9a
@@ -83,6 +89,9 @@
87cf9a
 static void		launchd_checkin(void);
87cf9a
 static void		launchd_checkout(void);
87cf9a
 #endif /* HAVE_LAUNCHD */
87cf9a
+#ifdef HAVE_SYSTEMD
87cf9a
+static void		systemd_checkin(void);
87cf9a
+#endif /* HAVE_SYSTEMD */
87cf9a
 static void		parent_handler(int sig);
87cf9a
 static void		process_children(void);
87cf9a
 static void		sigchld_handler(int sig);
87cf9a
@@ -581,6 +590,13 @@ main(int  argc,				/* I - Number of comm
87cf9a
   }
87cf9a
 #endif /* HAVE_LAUNCHD */
87cf9a
 
87cf9a
+#ifdef HAVE_SYSTEMD
87cf9a
+ /*
87cf9a
+  * If we were started by systemd get the listen sockets file descriptors...
87cf9a
+  */
87cf9a
+  systemd_checkin();
87cf9a
+#endif /* HAVE_SYSTEMD */
87cf9a
+
87cf9a
  /*
87cf9a
   * Startup the server...
87cf9a
   */
87cf9a
@@ -791,6 +807,15 @@ main(int  argc,				/* I - Number of comm
87cf9a
 	}
87cf9a
 #endif /* HAVE_LAUNCHD */
87cf9a
 
87cf9a
+#ifdef HAVE_SYSTEMD
87cf9a
+       /*
87cf9a
+	* If we were started by systemd get the listen sockets file
87cf9a
+	* descriptors...
87cf9a
+        */
87cf9a
+
87cf9a
+        systemd_checkin();
87cf9a
+#endif /* HAVE_SYSTEMD */
87cf9a
+
87cf9a
        /*
87cf9a
         * Startup the server...
87cf9a
         */
87cf9a
@@ -1552,6 +1577,102 @@ launchd_checkout(void)
87cf9a
 }
87cf9a
 #endif /* HAVE_LAUNCHD */
87cf9a
 
87cf9a
+#ifdef HAVE_SYSTEMD
87cf9a
+static void
87cf9a
+systemd_checkin(void)
87cf9a
+{
87cf9a
+  int n, fd;
87cf9a
+
87cf9a
+  n = sd_listen_fds(0);
87cf9a
+  if (n < 0)
87cf9a
+  {
87cf9a
+    cupsdLogMessage(CUPSD_LOG_ERROR,
87cf9a
+           "systemd_checkin: Failed to acquire sockets from systemd - %s",
87cf9a
+           strerror(-n));
87cf9a
+    exit(EXIT_FAILURE);
87cf9a
+    return;
87cf9a
+  }
87cf9a
+
87cf9a
+  if (n == 0)
87cf9a
+    return;
87cf9a
+
87cf9a
+  for (fd = SD_LISTEN_FDS_START; fd < SD_LISTEN_FDS_START + n; fd ++)
87cf9a
+  {
87cf9a
+    http_addr_t addr;
87cf9a
+    socklen_t addrlen = sizeof (addr);
87cf9a
+    int r;
87cf9a
+    cupsd_listener_t *lis;
87cf9a
+    char s[256];
87cf9a
+
87cf9a
+    r = sd_is_socket(fd, AF_UNSPEC, SOCK_STREAM, 1);
87cf9a
+    if (r < 0)
87cf9a
+    {
87cf9a
+      cupsdLogMessage(CUPSD_LOG_ERROR,
87cf9a
+             "systemd_checkin: Unable to verify socket type - %s",
87cf9a
+             strerror(-r));
87cf9a
+      continue;
87cf9a
+    }
87cf9a
+
87cf9a
+    if (!r)
87cf9a
+    {
87cf9a
+      cupsdLogMessage(CUPSD_LOG_ERROR,
87cf9a
+             "systemd_checkin: Socket not of the right type");
87cf9a
+      continue;
87cf9a
+    }
87cf9a
+
87cf9a
+    if (getsockname(fd, (struct sockaddr*) &addr, &addrlen))
87cf9a
+    {
87cf9a
+      cupsdLogMessage(CUPSD_LOG_ERROR,
87cf9a
+             "systemd_checkin: Unable to get local address - %s",
87cf9a
+             strerror(errno));
87cf9a
+      continue;
87cf9a
+    }
87cf9a
+
87cf9a
+   /*
87cf9a
+    * Try to match the systemd socket address to one of the listeners...
87cf9a
+    */
87cf9a
+
87cf9a
+    for (lis = (cupsd_listener_t *)cupsArrayFirst(Listeners);
87cf9a
+       lis;
87cf9a
+       lis = (cupsd_listener_t *)cupsArrayNext(Listeners))
87cf9a
+      if (httpAddrEqual(&lis->address, &addr))
87cf9a
+	break;
87cf9a
+
87cf9a
+    if (lis)
87cf9a
+    {
87cf9a
+      cupsdLogMessage(CUPSD_LOG_DEBUG,
87cf9a
+                      "systemd_checkin: Matched existing listener %s with fd %d...",
87cf9a
+                      httpAddrString(&(lis->address), s, sizeof(s)), fd);
87cf9a
+    }
87cf9a
+    else
87cf9a
+    {
87cf9a
+      cupsdLogMessage(CUPSD_LOG_DEBUG,
87cf9a
+                      "systemd_checkin: Adding new listener %s with fd %d...",
87cf9a
+                      httpAddrString(&addr, s, sizeof(s)), fd);
87cf9a
+
87cf9a
+      if ((lis = calloc(1, sizeof(cupsd_listener_t))) == NULL)
87cf9a
+      {
87cf9a
+        cupsdLogMessage(CUPSD_LOG_ERROR,
87cf9a
+                        "systemd_checkin: Unable to allocate listener - "
87cf9a
+                        "%s.", strerror(errno));
87cf9a
+        exit(EXIT_FAILURE);
87cf9a
+      }
87cf9a
+
87cf9a
+      cupsArrayAdd(Listeners, lis);
87cf9a
+
87cf9a
+      memcpy(&lis->address, &addr, sizeof(lis->address));
87cf9a
+    }
87cf9a
+
87cf9a
+    lis->fd = fd;
87cf9a
+    lis->is_systemd = 1;
87cf9a
+
87cf9a
+#  ifdef HAVE_SSL
87cf9a
+    if (_httpAddrPort(&(lis->address)) == 443)
87cf9a
+      lis->encryption = HTTP_ENCRYPT_ALWAYS;
87cf9a
+#  endif /* HAVE_SSL */
87cf9a
+  }
87cf9a
+}
87cf9a
+#endif /* HAVE_SYSTEMD */
87cf9a
 
87cf9a
 /*
87cf9a
  * 'parent_handler()' - Catch USR1/CHLD signals...
87cf9a
diff -up cups-1.6.2/scheduler/Makefile.systemd-socket cups-1.6.2/scheduler/Makefile
87cf9a
--- cups-1.6.2/scheduler/Makefile.systemd-socket	2012-05-21 19:40:22.000000000 +0200
87cf9a
+++ cups-1.6.2/scheduler/Makefile	2013-03-18 18:53:53.772961588 +0100
87cf9a
@@ -371,7 +371,7 @@ cupsd:	$(CUPSDOBJS) $(LIBCUPSMIME) ../cu
87cf9a
 	$(CC) $(LDFLAGS) -o cupsd $(CUPSDOBJS) -L. -lcupsmime \
87cf9a
 		$(LIBZ) $(SSLLIBS) $(LIBSLP) $(LIBLDAP) $(PAMLIBS) \
87cf9a
 		$(LIBPAPER) $(LIBMALLOC) $(SERVERLIBS) $(DNSSDLIBS) $(LIBS) \
87cf9a
-		$(LIBGSSAPI) $(LIBWRAP)
87cf9a
+		$(LIBGSSAPI) $(LIBWRAP) $(SDLIBS)
87cf9a
 
87cf9a
 cupsd-static:	$(CUPSDOBJS) libcupsmime.a ../cups/$(LIBCUPSSTATIC)
87cf9a
 	echo Linking $@...
87cf9a
@@ -379,7 +379,7 @@ cupsd-static:	$(CUPSDOBJS) libcupsmime.a
87cf9a
 		$(LIBZ) $(SSLLIBS) $(LIBSLP) $(LIBLDAP) $(PAMLIBS) \
87cf9a
 		../cups/$(LIBCUPSSTATIC) $(COMMONLIBS) $(LIBZ) $(LIBPAPER) \
87cf9a
 		$(LIBMALLOC) $(SERVERLIBS) $(DNSSDLIBS) $(LIBGSSAPI) \
87cf9a
-		$(LIBWRAP)
87cf9a
+		$(LIBWRAP)  $(SDLIBS)
87cf9a
 
87cf9a
 tls.o:	tls-darwin.c tls-gnutls.c tls-openssl.c
87cf9a