Blame SOURCES/cups-CVE-2018-4180.patch

87cf9a
diff --git a/man/cups-files.conf.man.in b/man/cups-files.conf.man.in
87cf9a
index e34d7c4..1d0f51d 100644
87cf9a
--- a/man/cups-files.conf.man.in
87cf9a
+++ b/man/cups-files.conf.man.in
87cf9a
@@ -85,6 +85,11 @@ PageLog filename
87cf9a
 PageLog syslog
87cf9a
 .br
87cf9a
 Specifies the page log filename.
87cf9a
+.\"#PassEnv
87cf9a
+.TP 5
87cf9a
+\fBPassEnv \fIvariable \fR[ ... \fIvariable \fR]
87cf9a
+Passes the specified environment variable(s) to child processes.
87cf9a
+Note: the standard CUPS filter and backend environment variables cannot be overridden using this directive.
87cf9a
 .TP 5
87cf9a
 Printcap
87cf9a
 .TP 5
87cf9a
@@ -121,6 +126,11 @@ Specifies the encryption key to use.
87cf9a
 ServerRoot directory
87cf9a
 .br
87cf9a
 Specifies the directory where the server configuration files can be found.
87cf9a
+.\"#SetEnv
87cf9a
+.TP 5
87cf9a
+\fBSetEnv \fIvariable value\fR
87cf9a
+Set the specified environment variable to be passed to child processes.
87cf9a
+Note: the standard CUPS filter and backend environment variables cannot be overridden using this directive.
87cf9a
 .TP 5
87cf9a
 SyncOnClose Yes
87cf9a
 .TP 5
87cf9a
diff --git a/man/cupsd.conf.man.in b/man/cupsd.conf.man.in
87cf9a
index 1a4f40a..583070e 100644
87cf9a
--- a/man/cupsd.conf.man.in
87cf9a
+++ b/man/cupsd.conf.man.in
87cf9a
@@ -380,10 +380,6 @@ PageLogFormat format string
87cf9a
 .br
87cf9a
 Specifies the format of page log lines.
87cf9a
 .TP 5
87cf9a
-PassEnv variable [... variable]
87cf9a
-.br
87cf9a
-Passes the specified environment variable(s) to child processes.
87cf9a
-.TP 5
87cf9a
 <Policy name> ... </Policy>
87cf9a
 .br
87cf9a
 Specifies access control for the named policy.
87cf9a
@@ -470,10 +466,6 @@ ServerTokens ProductOnly
87cf9a
 Specifies what information is included in the Server header of HTTP
87cf9a
 responses.
87cf9a
 .TP 5
87cf9a
-SetEnv variable value
87cf9a
-.br
87cf9a
-Set the specified environment variable to be passed to child processes.
87cf9a
-.TP 5
87cf9a
 SSLListen
87cf9a
 .br
87cf9a
 Listens on the specified address and port for encrypted connections.
87cf9a
diff --git a/scheduler/conf.c b/scheduler/conf.c
87cf9a
index f8732d4..ac1d024 100644
87cf9a
--- a/scheduler/conf.c
87cf9a
+++ b/scheduler/conf.c
87cf9a
@@ -2935,13 +2935,10 @@ read_cupsd_conf(cups_file_t *fp)	/* I - File to read from */
87cf9a
 					/* Line from file */
87cf9a
 			temp[HTTP_MAX_BUFFER],
87cf9a
 					/* Temporary buffer for value */
87cf9a
-			*value,		/* Pointer to value */
87cf9a
-			*valueptr;	/* Pointer into value */
87cf9a
+			*value;		/* Pointer to value */
87cf9a
   int			valuelen;	/* Length of value */
87cf9a
   http_addrlist_t	*addrlist,	/* Address list */
87cf9a
 			*addr;		/* Current address */
87cf9a
-  cups_file_t		*incfile;	/* Include file */
87cf9a
-  char			incname[1024];	/* Include filename */
87cf9a
 
87cf9a
 
87cf9a
  /*
87cf9a
@@ -2956,28 +2953,7 @@ read_cupsd_conf(cups_file_t *fp)	/* I - File to read from */
87cf9a
     * Decode the directive...
87cf9a
     */
87cf9a
 
87cf9a
-    if (!_cups_strcasecmp(line, "Include") && value)
87cf9a
-    {
87cf9a
-     /*
87cf9a
-      * Include filename
87cf9a
-      */
87cf9a
-
87cf9a
-      if (value[0] == '/')
87cf9a
-        strlcpy(incname, value, sizeof(incname));
87cf9a
-      else
87cf9a
-        snprintf(incname, sizeof(incname), "%s/%s", ServerRoot, value);
87cf9a
-
87cf9a
-      if ((incfile = cupsFileOpen(incname, "rb")) == NULL)
87cf9a
-        cupsdLogMessage(CUPSD_LOG_ERROR,
87cf9a
-	                "Unable to include config file \"%s\" - %s",
87cf9a
-	                incname, strerror(errno));
87cf9a
-      else
87cf9a
-      {
87cf9a
-        read_cupsd_conf(incfile);
87cf9a
-	cupsFileClose(incfile);
87cf9a
-      }
87cf9a
-    }
87cf9a
-    else if (!_cups_strcasecmp(line, "
87cf9a
+    if (!_cups_strcasecmp(line, "
87cf9a
     {
87cf9a
      /*
87cf9a
       * <Location path>
87cf9a
@@ -3302,31 +3278,6 @@ read_cupsd_conf(cups_file_t *fp)	/* I - File to read from */
87cf9a
 	cupsdLogMessage(CUPSD_LOG_WARN, "Unknown ServerTokens %s on line %d.",
87cf9a
                         value, linenum);
87cf9a
     }
87cf9a
-    else if (!_cups_strcasecmp(line, "PassEnv") && value)
87cf9a
-    {
87cf9a
-     /*
87cf9a
-      * PassEnv variable [... variable]
87cf9a
-      */
87cf9a
-
87cf9a
-      for (; *value;)
87cf9a
-      {
87cf9a
-        for (valuelen = 0; value[valuelen]; valuelen ++)
87cf9a
-	  if (_cups_isspace(value[valuelen]) || value[valuelen] == ',')
87cf9a
-	    break;
87cf9a
-
87cf9a
-        if (value[valuelen])
87cf9a
-        {
87cf9a
-	  value[valuelen] = '\0';
87cf9a
-	  valuelen ++;
87cf9a
-	}
87cf9a
-
87cf9a
-        cupsdSetEnv(value, NULL);
87cf9a
-
87cf9a
-        for (value += valuelen; *value; value ++)
87cf9a
-	  if (!_cups_isspace(*value) || *value != ',')
87cf9a
-	    break;
87cf9a
-      }
87cf9a
-    }
87cf9a
     else if (!_cups_strcasecmp(line, "ServerAlias") && value)
87cf9a
     {
87cf9a
      /*
87cf9a
@@ -3355,30 +3306,6 @@ read_cupsd_conf(cups_file_t *fp)	/* I - File to read from */
87cf9a
 	    break;
87cf9a
       }
87cf9a
     }
87cf9a
-    else if (!_cups_strcasecmp(line, "SetEnv") && value)
87cf9a
-    {
87cf9a
-     /*
87cf9a
-      * SetEnv variable value
87cf9a
-      */
87cf9a
-
87cf9a
-      for (valueptr = value; *valueptr && !isspace(*valueptr & 255); valueptr ++);
87cf9a
-
87cf9a
-      if (*valueptr)
87cf9a
-      {
87cf9a
-       /*
87cf9a
-        * Found a value...
87cf9a
-	*/
87cf9a
-
87cf9a
-        while (isspace(*valueptr & 255))
87cf9a
-	  *valueptr++ = '\0';
87cf9a
-
87cf9a
-        cupsdSetEnv(value, valueptr);
87cf9a
-      }
87cf9a
-      else
87cf9a
-        cupsdLogMessage(CUPSD_LOG_ERROR,
87cf9a
-	                "Missing value for SetEnv directive on line %d.",
87cf9a
-	                linenum);
87cf9a
-    }
87cf9a
 #ifdef HAVE_SSL
87cf9a
     else if (!_cups_strcasecmp(line, "SSLOptions"))
87cf9a
     {
87cf9a
@@ -3448,6 +3375,7 @@ read_cupsd_conf(cups_file_t *fp)	/* I - File to read from */
87cf9a
              !_cups_strcasecmp(line, "LogFilePerm") ||
87cf9a
              !_cups_strcasecmp(line, "LPDConfigFile") ||
87cf9a
              !_cups_strcasecmp(line, "PageLog") ||
87cf9a
+             !_cups_strcasecmp(line, "PassEnv") ||
87cf9a
              !_cups_strcasecmp(line, "Printcap") ||
87cf9a
              !_cups_strcasecmp(line, "PrintcapFormat") ||
87cf9a
              !_cups_strcasecmp(line, "RemoteRoot") ||
87cf9a
@@ -3456,6 +3384,7 @@ read_cupsd_conf(cups_file_t *fp)	/* I - File to read from */
87cf9a
              !_cups_strcasecmp(line, "ServerCertificate") ||
87cf9a
              !_cups_strcasecmp(line, "ServerKey") ||
87cf9a
              !_cups_strcasecmp(line, "ServerRoot") ||
87cf9a
+             !_cups_strcasecmp(line, "SetEnv") ||
87cf9a
              !_cups_strcasecmp(line, "SMBConfigFile") ||
87cf9a
              !_cups_strcasecmp(line, "StateDir") ||
87cf9a
              !_cups_strcasecmp(line, "SystemGroup") ||
87cf9a
@@ -3485,11 +3414,51 @@ read_cupsd_conf(cups_file_t *fp)	/* I - File to read from */
87cf9a
 static int				/* O - 1 on success, 0 on failure */
87cf9a
 read_cups_files_conf(cups_file_t *fp)	/* I - File to read from */
87cf9a
 {
87cf9a
-  int		linenum;		/* Current line number */
87cf9a
+  int		i,			/* Looping var */
87cf9a
+		linenum;		/* Current line number */
87cf9a
   char		line[HTTP_MAX_BUFFER],	/* Line from file */
87cf9a
 		*value;			/* Value from line */
87cf9a
   struct group	*group;			/* Group */
87cf9a
 
87cf9a
+  static const char * const prohibited_env[] =
87cf9a
+  {					/* Prohibited environment variables */
87cf9a
+    "APPLE_LANGUAGE",
87cf9a
+    "AUTH_DOMAIN",
87cf9a
+    "AUTH_INFO_REQUIRED",
87cf9a
+    "AUTH_NEGOTIATE",
87cf9a
+    "AUTH_PASSWORD",
87cf9a
+    "AUTH_UID",
87cf9a
+    "AUTH_USERNAME",
87cf9a
+    "CHARSET",
87cf9a
+    "CLASS",
87cf9a
+    "CLASSIFICATION",
87cf9a
+    "CONTENT_TYPE",
87cf9a
+    "CUPS_CACHEDIR",
87cf9a
+    "CUPS_DATADIR",
87cf9a
+    "CUPS_DOCROOT",
87cf9a
+    "CUPS_FILETYPE",
87cf9a
+    "CUPS_FONTPATH",
87cf9a
+    "CUPS_MAX_MESSAGE",
87cf9a
+    "CUPS_REQUESTROOT",
87cf9a
+    "CUPS_SERVERBIN",
87cf9a
+    "CUPS_SERVERROOT",
87cf9a
+    "CUPS_STATEDIR",
87cf9a
+    "DEVICE_URI",
87cf9a
+    "FINAL_CONTENT_TYPE",
87cf9a
+    "HOME",
87cf9a
+    "LANG",
87cf9a
+    "PPD",
87cf9a
+    "PRINTER",
87cf9a
+    "PRINTER_INFO",
87cf9a
+    "PRINTER_LOCATION",
87cf9a
+    "PRINTER_STATE_REASONS",
87cf9a
+    "RIP_CACHE",
87cf9a
+    "SERVER_ADMIN",
87cf9a
+    "SOFTWARE",
87cf9a
+    "TMPDIR",
87cf9a
+    "USER"
87cf9a
+  };
87cf9a
+
87cf9a
 
87cf9a
  /*
87cf9a
   * Loop through each line in the file...
87cf9a
@@ -3526,6 +3495,87 @@ read_cups_files_conf(cups_file_t *fp)	/* I - File to read from */
87cf9a
 	}
87cf9a
       }
87cf9a
     }
87cf9a
+    else if (!_cups_strcasecmp(line, "PassEnv") && value)
87cf9a
+    {
87cf9a
+     /*
87cf9a
+      * PassEnv variable [... variable]
87cf9a
+      */
87cf9a
+
87cf9a
+      int valuelen;			/* Length of variable name */
87cf9a
+
87cf9a
+      for (; *value;)
87cf9a
+      {
87cf9a
+        for (valuelen = 0; value[valuelen]; valuelen ++)
87cf9a
+	        if (_cups_isspace(value[valuelen]) || value[valuelen] == ',')
87cf9a
+	          break;
87cf9a
+
87cf9a
+        if (value[valuelen])
87cf9a
+        {
87cf9a
+	        value[valuelen] = '\0';
87cf9a
+	        valuelen ++;
87cf9a
+	      }
87cf9a
+
87cf9a
+        for (i = 0; i < (int)(sizeof(prohibited_env) / sizeof(prohibited_env[0])); i ++)
87cf9a
+        {
87cf9a
+          if (!strcmp(value, prohibited_env[i]))
87cf9a
+          {
87cf9a
+	          cupsdLogMessage(CUPSD_LOG_ERROR, "Environment variable \"%s\" cannot be passed through on line %d of %s.", value, linenum, CupsFilesFile);
87cf9a
+
87cf9a
+            if (FatalErrors & CUPSD_FATAL_CONFIG)
87cf9a
+              return (0);
87cf9a
+            else
87cf9a
+              break;
87cf9a
+          }
87cf9a
+	      }
87cf9a
+
87cf9a
+        if (i >= (int)(sizeof(prohibited_env) / sizeof(prohibited_env[0])))
87cf9a
+          cupsdSetEnv(value, NULL);
87cf9a
+
87cf9a
+        for (value += valuelen; *value; value ++)
87cf9a
+	        if (!_cups_isspace(*value) || *value != ',')
87cf9a
+	          break;
87cf9a
+      }
87cf9a
+    }
87cf9a
+    else if (!_cups_strcasecmp(line, "SetEnv") && value)
87cf9a
+    {
87cf9a
+      /*
87cf9a
+      * SetEnv variable value
87cf9a
+      */
87cf9a
+
87cf9a
+      char *valueptr;			/* Pointer to environment variable value */
87cf9a
+
87cf9a
+      for (valueptr = value; *valueptr && !isspace(*valueptr & 255); valueptr ++);
87cf9a
+
87cf9a
+      if (*valueptr)
87cf9a
+      {
87cf9a
+       /*
87cf9a
+        * Found a value...
87cf9a
+	      */
87cf9a
+
87cf9a
+        while (isspace(*valueptr & 255))
87cf9a
+	        *valueptr++ = '\0';
87cf9a
+
87cf9a
+        for (i = 0; i < (int)(sizeof(prohibited_env) / sizeof(prohibited_env[0])); i ++)
87cf9a
+        {
87cf9a
+          if (!strcmp(value, prohibited_env[i]))
87cf9a
+          {
87cf9a
+	          cupsdLogMessage(CUPSD_LOG_ERROR, "Environment variable \"%s\" cannot be set  on line %d of %s.", value, linenum, CupsFilesFile);
87cf9a
+
87cf9a
+            if (FatalErrors & CUPSD_FATAL_CONFIG)
87cf9a
+              return (0);
87cf9a
+            else
87cf9a
+              break;
87cf9a
+          }
87cf9a
+	      }
87cf9a
+
87cf9a
+        if (i >= (int)(sizeof(prohibited_env) / sizeof(prohibited_env[0])))
87cf9a
+	        cupsdSetEnv(value, valueptr);
87cf9a
+      }
87cf9a
+      else
87cf9a
+        cupsdLogMessage(CUPSD_LOG_ERROR,
87cf9a
+	                "Missing value for SetEnv directive on line %d of %s.",
87cf9a
+	                linenum, ConfigurationFile);
87cf9a
+    }
87cf9a
     else if (!_cups_strcasecmp(line, "PrintcapFormat") && value)
87cf9a
     {
87cf9a
      /*
87cf9a
diff --git a/scheduler/job.c b/scheduler/job.c
87cf9a
index 48cc35d..0e1bca3 100644
87cf9a
--- a/scheduler/job.c
87cf9a
+++ b/scheduler/job.c
87cf9a
@@ -4761,6 +4761,18 @@ start_job(cupsd_job_t     *job,		/* I - Job ID */
87cf9a
   job->status  = 0;
87cf9a
   job->profile = cupsdCreateProfile(job->id);
87cf9a
 
87cf9a
+  #ifdef HAVE_SANDBOX_H
87cf9a
+    if (!job->profile)
87cf9a
+    {
87cf9a
+    /*
87cf9a
+      * Failure to create the sandbox profile means something really bad has
87cf9a
+      * happened and we need to shutdown immediately.
87cf9a
+      */
87cf9a
+
87cf9a
+      return;
87cf9a
+    }
87cf9a
+  #endif /* HAVE_SANDBOX_H */
87cf9a
+
87cf9a
  /*
87cf9a
   * Create the status pipes and buffer...
87cf9a
   */
87cf9a
diff --git a/scheduler/process.c b/scheduler/process.c
87cf9a
index 1782064..b460838 100644
87cf9a
--- a/scheduler/process.c
87cf9a
+++ b/scheduler/process.c
87cf9a
@@ -94,10 +94,14 @@ cupsdCreateProfile(int job_id)		/* I - Job ID or 0 for none */
87cf9a
 
87cf9a
   if ((fp = cupsTempFile2(profile, sizeof(profile))) == NULL)
87cf9a
   {
87cf9a
+    /*
87cf9a
+    * This should never happen, and is fatal when sandboxing is enabled.
87cf9a
+    */
87cf9a
+
87cf9a
     cupsdLogMessage(CUPSD_LOG_DEBUG2, "cupsdCreateProfile(job_id=%d) = NULL",
87cf9a
                     job_id);
87cf9a
-    cupsdLogMessage(CUPSD_LOG_ERROR, "Unable to create security profile: %s",
87cf9a
-                    strerror(errno));
87cf9a
+    cupsdLogMessage(CUPSD_LOG_EMERG, "Unable to create security profile: %s", strerror(errno));
87cf9a
+    kill(getpid(), SIGTERM);
87cf9a
     return (NULL);
87cf9a
   }
87cf9a
 
87cf9a
diff --git a/scheduler/server.c b/scheduler/server.c
87cf9a
index a5a31c5..7a34891 100644
87cf9a
--- a/scheduler/server.c
87cf9a
+++ b/scheduler/server.c
87cf9a
@@ -44,17 +44,29 @@ static int		started = 0;	/* Did we start the server already? */
87cf9a
 void
87cf9a
 cupsdStartServer(void)
87cf9a
 {
87cf9a
- /*
87cf9a
-  * Start color management (as needed)...
87cf9a
+  /*
87cf9a
+  * Create the default security profile...
87cf9a
   */
87cf9a
 
87cf9a
-  cupsdStartColor();
87cf9a
+  DefaultProfile = cupsdCreateProfile(0);
87cf9a
+
87cf9a
+  #ifdef HAVE_SANDBOX_H
87cf9a
+    if (!DefaultProfile)
87cf9a
+    {
87cf9a
+    /*
87cf9a
+      * Failure to create the sandbox profile means something really bad has
87cf9a
+      * happened and we need to shutdown immediately.
87cf9a
+      */
87cf9a
+
87cf9a
+      return;
87cf9a
+    }
87cf9a
+  #endif /* HAVE_SANDBOX_H */
87cf9a
 
87cf9a
  /*
87cf9a
-  * Create the default security profile...
87cf9a
+  * Start color management (as needed)...
87cf9a
   */
87cf9a
 
87cf9a
-  DefaultProfile = cupsdCreateProfile(0);
87cf9a
+  cupsdStartColor();
87cf9a
 
87cf9a
  /*
87cf9a
   * Startup all the networking stuff...