|
 |
96d6bf |
diff -ru cronie-1.5.2/src/cronnext.c cronie-1.5.2_patched/src/cronnext.c
|
|
|
96d6bf |
--- cronie-1.5.2/src/cronnext.c 2018-05-03 18:41:12.000000000 +0200
|
|
|
96d6bf |
+++ cronie-1.5.2_patched/src/cronnext.c 2018-09-07 15:17:54.555924440 +0200
|
|
|
96d6bf |
@@ -71,13 +71,13 @@
|
|
|
96d6bf |
/*
|
|
|
96d6bf |
* print entry flags
|
|
|
96d6bf |
*/
|
|
|
96d6bf |
-char *flagname[]= {
|
|
|
96d6bf |
- [MIN_STAR] = "MIN_STAR",
|
|
|
96d6bf |
- [HR_STAR] = "HR_STAR",
|
|
|
96d6bf |
- [DOM_STAR] = "DOM_STAR",
|
|
|
96d6bf |
- [DOW_STAR] = "DOW_STAR",
|
|
|
96d6bf |
- [WHEN_REBOOT] = "WHEN_REBOOT",
|
|
|
96d6bf |
- [DONT_LOG] = "DONT_LOG"
|
|
|
96d6bf |
+const char *flagname[]= {
|
|
|
96d6bf |
+ "MIN_STAR",
|
|
|
96d6bf |
+ "HR_STAR",
|
|
|
96d6bf |
+ "DOM_STAR",
|
|
|
96d6bf |
+ "DOW_STAR",
|
|
|
96d6bf |
+ "WHEN_REBOOT",
|
|
|
96d6bf |
+ "DONT_LOG"
|
|
|
96d6bf |
};
|
|
|
96d6bf |
|
|
|
96d6bf |
void printflags(char *indent, int flags) {
|
|
|
96d6bf |
@@ -85,8 +85,8 @@
|
|
|
96d6bf |
int first = 1;
|
|
|
96d6bf |
|
|
|
96d6bf |
printf("%s flagnames:", indent);
|
|
|
96d6bf |
- for (f = 1; f < sizeof(flagname); f = f << 1)
|
|
|
96d6bf |
- if (flags & f) {
|
|
|
96d6bf |
+ for (f = 0; f < sizeof(flagname)/sizeof(char *); f++)
|
|
|
96d6bf |
+ if (flags & (int)1 << f) {
|
|
|
96d6bf |
printf("%s%s", first ? " " : "|", flagname[f]);
|
|
|
96d6bf |
first = 0;
|
|
|
96d6bf |
}
|
|
|
96d6bf |
diff -ru cronie-1.5.2/src/do_command.c cronie-1.5.2_patched/src/do_command.c
|
|
|
96d6bf |
--- cronie-1.5.2/src/do_command.c 2017-09-14 13:53:21.000000000 +0200
|
|
|
96d6bf |
+++ cronie-1.5.2_patched/src/do_command.c 2018-09-07 15:17:54.555924440 +0200
|
|
|
96d6bf |
@@ -418,7 +418,7 @@
|
|
|
96d6bf |
if (mailto && safe_p(usernm, mailto)
|
|
|
96d6bf |
&& strncmp(MailCmd,"off",3) && !SyslogOutput) {
|
|
|
96d6bf |
char **env;
|
|
|
96d6bf |
- char mailcmd[MAX_COMMAND];
|
|
|
96d6bf |
+ char mailcmd[MAX_COMMAND+1]; /* +1 for terminator */
|
|
|
96d6bf |
char hostname[MAXHOSTNAMELEN];
|
|
|
96d6bf |
char *content_type = env_get("CONTENT_TYPE", jobenv),
|
|
|
96d6bf |
*content_transfer_encoding =
|
|
|
96d6bf |
@@ -434,7 +434,7 @@
|
|
|
96d6bf |
}
|
|
|
96d6bf |
}
|
|
|
96d6bf |
else {
|
|
|
96d6bf |
- strncpy(mailcmd, MailCmd, MAX_COMMAND);
|
|
|
96d6bf |
+ strncpy(mailcmd, MailCmd, MAX_COMMAND+1);
|
|
|
96d6bf |
}
|
|
|
96d6bf |
if (!(mail = cron_popen(mailcmd, "w", e->pwd, jobenv))) {
|
|
|
96d6bf |
perror(mailcmd);
|
|
|
96d6bf |
diff -ru cronie-1.5.2/src/env.c cronie-1.5.2_patched/src/env.c
|
|
|
96d6bf |
--- cronie-1.5.2/src/env.c 2017-09-14 13:53:21.000000000 +0200
|
|
|
96d6bf |
+++ cronie-1.5.2_patched/src/env.c 2018-09-07 15:17:54.554924435 +0200
|
|
|
96d6bf |
@@ -63,7 +63,7 @@
|
|
|
96d6bf |
for (i = 0; i < count; i++)
|
|
|
96d6bf |
if ((p[i] = strdup(envp[i])) == NULL) {
|
|
|
96d6bf |
save_errno = errno;
|
|
|
96d6bf |
- while (--i >= 0)
|
|
|
96d6bf |
+ while (i-- > 0)
|
|
|
96d6bf |
free(p[i]);
|
|
|
96d6bf |
free(p);
|
|
|
96d6bf |
errno = save_errno;
|
|
|
96d6bf |
@@ -263,7 +263,9 @@
|
|
|
96d6bf |
}
|
|
|
96d6bf |
if (state != FINI && state != EQ2 && !(state == VALUE && !quotechar)) {
|
|
|
96d6bf |
Debug(DPARS, ("load_env, not an env var, state = %d\n", state));
|
|
|
96d6bf |
- fseek(f, filepos, 0);
|
|
|
96d6bf |
+ if (fseek(f, filepos, 0)) {
|
|
|
96d6bf |
+ return ERR;
|
|
|
96d6bf |
+ }
|
|
|
96d6bf |
Set_LineNum(fileline);
|
|
|
96d6bf |
return (FALSE);
|
|
|
96d6bf |
}
|
|
|
96d6bf |
diff -ru cronie-1.5.2/src/globals.h cronie-1.5.2_patched/src/globals.h
|
|
|
96d6bf |
--- cronie-1.5.2/src/globals.h 2017-01-17 16:53:50.000000000 +0100
|
|
|
96d6bf |
+++ cronie-1.5.2_patched/src/globals.h 2018-09-07 15:17:54.555924440 +0200
|
|
|
96d6bf |
@@ -77,7 +77,7 @@
|
|
|
96d6bf |
XTRN time_t StartTime;
|
|
|
96d6bf |
XTRN int NoFork;
|
|
|
96d6bf |
XTRN int PermitAnyCrontab;
|
|
|
96d6bf |
-XTRN char MailCmd[MAX_COMMAND];
|
|
|
96d6bf |
+XTRN char MailCmd[MAX_COMMAND+1]; /* +1 for terminator */
|
|
|
96d6bf |
XTRN char cron_default_mail_charset[MAX_ENVSTR];
|
|
|
96d6bf |
XTRN int EnableClustering;
|
|
|
96d6bf |
XTRN int ChangePath;
|
|
|
96d6bf |
diff -ru cronie-1.5.2/src/security.c cronie-1.5.2_patched/src/security.c
|
|
|
96d6bf |
--- cronie-1.5.2/src/security.c 2017-09-14 13:29:47.000000000 +0200
|
|
|
96d6bf |
+++ cronie-1.5.2_patched/src/security.c 2018-09-07 15:17:54.554924435 +0200
|
|
|
96d6bf |
@@ -417,7 +417,7 @@
|
|
|
96d6bf |
}
|
|
|
96d6bf |
}
|
|
|
96d6bf |
|
|
|
96d6bf |
- if (strcmp(u->scontext, ucontext)) {
|
|
|
96d6bf |
+ if (!ucontext || strcmp(u->scontext, ucontext)) {
|
|
|
96d6bf |
if (!cron_authorize_range(u->scontext, ucontext)) {
|
|
|
96d6bf |
if (security_getenforce() > 0) {
|
|
|
96d6bf |
# ifdef WITH_AUDIT
|
|
|
96d6bf |
diff -ru cronie-1.5.2/src/user.c cronie-1.5.2_patched/src/user.c
|
|
|
96d6bf |
--- cronie-1.5.2/src/user.c 2017-01-17 16:53:50.000000000 +0100
|
|
|
96d6bf |
+++ cronie-1.5.2_patched/src/user.c 2018-09-07 15:17:54.555924440 +0200
|
|
|
96d6bf |
@@ -44,6 +44,10 @@
|
|
|
96d6bf |
free_user (user * u) {
|
|
|
96d6bf |
entry *e, *ne;
|
|
|
96d6bf |
|
|
|
96d6bf |
+ if (!u) {
|
|
|
96d6bf |
+ return;
|
|
|
96d6bf |
+ }
|
|
|
96d6bf |
+
|
|
|
96d6bf |
free(u->name);
|
|
|
96d6bf |
free(u->tabname);
|
|
|
96d6bf |
for (e = u->crontab; e != NULL; e = ne) {
|