|
 |
ed0152 |
From 4cb65a0d9168778d120920418b968d05da10989f Mon Sep 17 00:00:00 2001
|
|
|
ed0152 |
From: HATAYAMA Daisuke <d.hatayama@fujitsu.com>
|
|
|
ed0152 |
Date: Fri, 25 Feb 2022 04:59:48 -0500
|
|
|
ed0152 |
Subject: [PATCH 3/3] gcore: fix memory allocation failure during processing
|
|
|
ed0152 |
NT_AUXV note
|
|
|
ed0152 |
|
|
|
ed0152 |
For crash dumps generated using kernel-4.18.0-365.el8 or later on
|
|
|
ed0152 |
CentOS stream 8, crash gcore command fails as follows:
|
|
|
ed0152 |
|
|
|
ed0152 |
crash> gcore -v 7 -f 128 10604
|
|
|
ed0152 |
gcore: Opening file core.10604.test-dumpfilter ...
|
|
|
ed0152 |
gcore: done.
|
|
|
ed0152 |
gcore: Writing ELF header ...
|
|
|
ed0152 |
gcore: done.
|
|
|
ed0152 |
gcore: Retrieving and writing note information ...
|
|
|
ed0152 |
gcore: zero-size memory allocation! (called from 7fd558ce1e05)
|
|
|
ed0152 |
Failed.
|
|
|
ed0152 |
|
|
|
ed0152 |
This memory allocation failure occurs in fill_auxv_note() that creates
|
|
|
ed0152 |
NT_AUXV note due to saved_auxv entries of size and offset tables are
|
|
|
ed0152 |
somehow 0.
|
|
|
ed0152 |
|
|
|
ed0152 |
This is because during the merge of the upstream kernel commit
|
|
|
ed0152 |
1c33bb0507508af24fd754dd7123bd8e997fab2f (x86/elf: Support a new ELF
|
|
|
ed0152 |
aux vector AT_MINSIGSTKSZ), location of saved_auxv of struct mm_struct
|
|
|
ed0152 |
has been moved as workaround in order to avoid kABI breakage.
|
|
|
ed0152 |
|
|
|
ed0152 |
Fix this by using RHEL-specific location for saved_auxv if there is
|
|
|
ed0152 |
member rh_reserved_saved_auxv in struct mm_struct.
|
|
|
ed0152 |
|
|
|
ed0152 |
Signed-off-by: HATAYAMA Daisuke <d.hatayama@fujitsu.com>
|
|
|
ed0152 |
---
|
|
|
ed0152 |
src/libgcore/gcore_coredump.c | 54 +++++++++++++++++++++++++++++------
|
|
|
ed0152 |
1 file changed, 46 insertions(+), 8 deletions(-)
|
|
|
ed0152 |
|
|
|
ed0152 |
diff --git a/src/libgcore/gcore_coredump.c b/src/libgcore/gcore_coredump.c
|
|
|
ed0152 |
index 6f57b21b62b6..c14cc116e951 100644
|
|
|
ed0152 |
--- a/src/libgcore/gcore_coredump.c
|
|
|
ed0152 |
+++ b/src/libgcore/gcore_coredump.c
|
|
|
ed0152 |
@@ -18,6 +18,10 @@
|
|
|
ed0152 |
|
|
|
ed0152 |
static struct elf_note_info *elf_note_info_init(void);
|
|
|
ed0152 |
|
|
|
ed0152 |
+static void get_auxv_size_addr(struct task_context *tc,
|
|
|
ed0152 |
+ size_t *size,
|
|
|
ed0152 |
+ ulong *addr);
|
|
|
ed0152 |
+
|
|
|
ed0152 |
static void fill_prstatus_note(struct elf_note_info *info,
|
|
|
ed0152 |
struct task_context *tc,
|
|
|
ed0152 |
struct memelfnote *memnote);
|
|
|
ed0152 |
@@ -923,18 +927,49 @@ compat_fill_prstatus_note(struct elf_note_info *info,
|
|
|
ed0152 |
|
|
|
ed0152 |
#endif /* GCORE_ARCH_COMPAT */
|
|
|
ed0152 |
|
|
|
ed0152 |
+static void get_auxv_size_addr(struct task_context *tc,
|
|
|
ed0152 |
+ size_t *psize,
|
|
|
ed0152 |
+ ulong *paddr)
|
|
|
ed0152 |
+{
|
|
|
ed0152 |
+ size_t size;
|
|
|
ed0152 |
+ ulong addr;
|
|
|
ed0152 |
+
|
|
|
ed0152 |
+ if (MEMBER_EXISTS("mm_struct", "rh_reserved_saved_auxv")) {
|
|
|
ed0152 |
+ ulong mm_rh;
|
|
|
ed0152 |
+
|
|
|
ed0152 |
+ size = MEMBER_SIZE("mm_struct_rh", "saved_auxv");
|
|
|
ed0152 |
+ readmem(task_mm(tc->task, FALSE) + MEMBER_OFFSET("mm_struct", "mm_rh"),
|
|
|
ed0152 |
+ KVADDR,
|
|
|
ed0152 |
+ &mm_rh,
|
|
|
ed0152 |
+ sizeof(mm_rh),
|
|
|
ed0152 |
+ "mm_struct mm_rh",
|
|
|
ed0152 |
+ gcore_verbose_error_handle());
|
|
|
ed0152 |
+ addr = mm_rh + MEMBER_OFFSET("mm_struct_rh", "saved_auxv");
|
|
|
ed0152 |
+ } else {
|
|
|
ed0152 |
+ size = MEMBER_SIZE("mm_struct", "saved_auxv");
|
|
|
ed0152 |
+ addr = task_mm(tc->task, FALSE) +
|
|
|
ed0152 |
+ MEMBER_OFFSET("mm_struct", "saved_auxv");
|
|
|
ed0152 |
+ }
|
|
|
ed0152 |
+
|
|
|
ed0152 |
+ *psize = size;
|
|
|
ed0152 |
+ *paddr = addr;
|
|
|
ed0152 |
+}
|
|
|
ed0152 |
+
|
|
|
ed0152 |
static void
|
|
|
ed0152 |
fill_auxv_note(struct elf_note_info *info, struct task_context *tc,
|
|
|
ed0152 |
struct memelfnote *memnote)
|
|
|
ed0152 |
{
|
|
|
ed0152 |
ulong *auxv;
|
|
|
ed0152 |
+ ulong addr;
|
|
|
ed0152 |
+ size_t size;
|
|
|
ed0152 |
int i;
|
|
|
ed0152 |
|
|
|
ed0152 |
- auxv = (ulong *)GETBUF(MEMBER_SIZE("mm_struct", "saved_auxv"));
|
|
|
ed0152 |
+ get_auxv_size_addr(tc, &size, &addr);
|
|
|
ed0152 |
|
|
|
ed0152 |
- readmem(task_mm(tc->task, FALSE) +
|
|
|
ed0152 |
- MEMBER_OFFSET("mm_struct", "saved_auxv"), KVADDR, auxv,
|
|
|
ed0152 |
- MEMBER_SIZE("mm_struct", "saved_auxv"), "fill_auxv_note",
|
|
|
ed0152 |
+ auxv = (ulong *)GETBUF(size);
|
|
|
ed0152 |
+
|
|
|
ed0152 |
+ readmem(addr, KVADDR, auxv,
|
|
|
ed0152 |
+ size, "fill_auxv_note",
|
|
|
ed0152 |
gcore_verbose_error_handle());
|
|
|
ed0152 |
|
|
|
ed0152 |
i = 0;
|
|
|
ed0152 |
@@ -954,13 +989,16 @@ compat_fill_auxv_note(struct elf_note_info *info,
|
|
|
ed0152 |
struct memelfnote *memnote)
|
|
|
ed0152 |
{
|
|
|
ed0152 |
uint32_t *auxv;
|
|
|
ed0152 |
+ ulong addr;
|
|
|
ed0152 |
+ size_t size;
|
|
|
ed0152 |
int i;
|
|
|
ed0152 |
|
|
|
ed0152 |
- auxv = (uint32_t *)GETBUF(MEMBER_SIZE("mm_struct", "saved_auxv"));
|
|
|
ed0152 |
+ get_auxv_size_addr(tc, &size, &addr);
|
|
|
ed0152 |
+
|
|
|
ed0152 |
+ auxv = (uint32_t *)GETBUF(size);
|
|
|
ed0152 |
|
|
|
ed0152 |
- readmem(task_mm(tc->task, FALSE) +
|
|
|
ed0152 |
- MEMBER_OFFSET("mm_struct", "saved_auxv"), KVADDR, auxv,
|
|
|
ed0152 |
- MEMBER_SIZE("mm_struct", "saved_auxv"), "fill_auxv_note32",
|
|
|
ed0152 |
+ readmem(addr, KVADDR, auxv,
|
|
|
ed0152 |
+ size, "fill_auxv_note32",
|
|
|
ed0152 |
gcore_verbose_error_handle());
|
|
|
ed0152 |
|
|
|
ed0152 |
i = 0;
|
|
|
ed0152 |
--
|
|
|
ed0152 |
2.30.2
|
|
|
ed0152 |
|