Blame SOURCES/cracklib-2.9.0-python-gzdicts.patch

356b41
diff -up cracklib-2.9.0/python/_cracklib.c.gzdicts cracklib-2.9.0/python/_cracklib.c
356b41
--- cracklib-2.9.0/python/_cracklib.c.gzdicts	2013-06-01 16:47:13.000000000 +0200
356b41
+++ cracklib-2.9.0/python/_cracklib.c	2013-08-20 12:37:32.028611493 +0200
356b41
@@ -23,6 +23,7 @@
356b41
  * Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301  USA
356b41
  */
356b41
 
356b41
+#include "config.h"
356b41
 #ifdef PYTHON_H
356b41
 #include PYTHON_H
356b41
 #else
356b41
@@ -72,9 +73,8 @@ static char _cracklib_FascistCheck_doc [
356b41
 static PyObject *
356b41
 _cracklib_FascistCheck(PyObject *self, PyObject *args, PyObject *kwargs)
356b41
 {
356b41
-    char *candidate, *dict;
356b41
-    char *defaultdict = NULL;
356b41
-    const char *result;
356b41
+    char *candidate;
356b41
+    const char *result, *dict;
356b41
     struct stat st;
356b41
     char *keywords[] = {"pw", "dictpath", NULL};
356b41
     char *dictfile;
356b41
@@ -103,44 +103,35 @@ _cracklib_FascistCheck(PyObject *self, P
356b41
                             "second argument was not an absolute path!");
356b41
             return NULL;
356b41
         }
356b41
-        dictfile = malloc(strlen(dict) + sizeof(DICT_SUFFIX));
356b41
-        if (dictfile == NULL)
356b41
-        {
356b41
-            PyErr_SetFromErrnoWithFilename(PyExc_OSError, dict);
356b41
-            return NULL;
356b41
-        }
356b41
-        sprintf(dictfile, "%s" DICT_SUFFIX, dict);
356b41
-        if (lstat(dictfile, &st) == -1)
356b41
-        {
356b41
-            PyErr_SetFromErrnoWithFilename(PyExc_OSError, dictfile);
356b41
-            free(dictfile);
356b41
-            return NULL;
356b41
-        }
356b41
-        free(dictfile);
356b41
     } else
356b41
     {
356b41
-        defaultdict = strdup(GetDefaultCracklibDict());
356b41
-        if (errno == ENOMEM) {
356b41
-            PyErr_SetFromErrno(PyExc_OSError);
356b41
-            return NULL;
356b41
-        }
356b41
-        dictfile = malloc(strlen(defaultdict) + sizeof(DICT_SUFFIX));
356b41
-        if (dictfile == NULL)
356b41
-        {
356b41
-            PyErr_SetFromErrnoWithFilename(PyExc_OSError, defaultdict);
356b41
-            free(defaultdict);
356b41
-            return NULL;
356b41
-        }
356b41
-        sprintf(dictfile, "%s" DICT_SUFFIX, defaultdict);
356b41
+        /* No need to strdup() anything as this is a constant value */
356b41
+        dict = GetDefaultCracklibDict();
356b41
+    }
356b41
+
356b41
+    dictfile = malloc(strlen(dict) + sizeof(DICT_SUFFIX) + 3);
356b41
+    if (dictfile == NULL)
356b41
+    {
356b41
+        PyErr_SetFromErrnoWithFilename(PyExc_OSError, dict);
356b41
+        return NULL;
356b41
+    }
356b41
+    sprintf(dictfile, "%s" DICT_SUFFIX, dict);
356b41
+    if (lstat(dictfile, &st) == -1)
356b41
+    {
356b41
+#ifdef HAVE_ZLIB_H
356b41
+        sprintf(dictfile, "%s" DICT_SUFFIX ".gz", dict);
356b41
         if (lstat(dictfile, &st) == -1)
356b41
         {
356b41
+            sprintf(dictfile, "%s" DICT_SUFFIX, dict);
356b41
+#endif
356b41
             PyErr_SetFromErrnoWithFilename(PyExc_OSError, dictfile);
356b41
-            free(defaultdict);
356b41
             free(dictfile);
356b41
             return NULL;
356b41
+#ifdef HAVE_ZLIB_H
356b41
         }
356b41
-        free(dictfile);
356b41
+#endif
356b41
     }
356b41
+    free(dictfile);
356b41
 
356b41
 	setlocale(LC_ALL, "");
356b41
 #ifdef ENABLE_NLS
356b41
@@ -148,14 +139,9 @@ _cracklib_FascistCheck(PyObject *self, P
356b41
 #endif
356b41
 
356b41
     LOCK();
356b41
-    result = FascistCheck(candidate, dict ? dict : defaultdict);
356b41
+    result = FascistCheck(candidate, dict);
356b41
     UNLOCK();
356b41
 
356b41
-    if (defaultdict != NULL)
356b41
-    {
356b41
-        free(defaultdict);
356b41
-    }
356b41
-
356b41
     if (result != NULL)
356b41
     {
356b41
     	PyErr_SetString(PyExc_ValueError, result);