Blame SOURCES/cracklib-2.9.0-python-gzdicts.patch

2a06ea
diff -up cracklib-2.9.0/python/_cracklib.c.gzdicts cracklib-2.9.0/python/_cracklib.c
2a06ea
--- cracklib-2.9.0/python/_cracklib.c.gzdicts	2013-06-01 16:47:13.000000000 +0200
2a06ea
+++ cracklib-2.9.0/python/_cracklib.c	2013-08-20 12:37:32.028611493 +0200
2a06ea
@@ -23,6 +23,7 @@
2a06ea
  * Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301  USA
2a06ea
  */
2a06ea
 
2a06ea
+#include "config.h"
2a06ea
 #ifdef PYTHON_H
2a06ea
 #include PYTHON_H
2a06ea
 #else
2a06ea
@@ -72,9 +73,8 @@ static char _cracklib_FascistCheck_doc [
2a06ea
 static PyObject *
2a06ea
 _cracklib_FascistCheck(PyObject *self, PyObject *args, PyObject *kwargs)
2a06ea
 {
2a06ea
-    char *candidate, *dict;
2a06ea
-    char *defaultdict = NULL;
2a06ea
-    const char *result;
2a06ea
+    char *candidate;
2a06ea
+    const char *result, *dict;
2a06ea
     struct stat st;
2a06ea
     char *keywords[] = {"pw", "dictpath", NULL};
2a06ea
     char *dictfile;
2a06ea
@@ -103,44 +103,35 @@ _cracklib_FascistCheck(PyObject *self, P
2a06ea
                             "second argument was not an absolute path!");
2a06ea
             return NULL;
2a06ea
         }
2a06ea
-        dictfile = malloc(strlen(dict) + sizeof(DICT_SUFFIX));
2a06ea
-        if (dictfile == NULL)
2a06ea
-        {
2a06ea
-            PyErr_SetFromErrnoWithFilename(PyExc_OSError, dict);
2a06ea
-            return NULL;
2a06ea
-        }
2a06ea
-        sprintf(dictfile, "%s" DICT_SUFFIX, dict);
2a06ea
-        if (lstat(dictfile, &st) == -1)
2a06ea
-        {
2a06ea
-            PyErr_SetFromErrnoWithFilename(PyExc_OSError, dictfile);
2a06ea
-            free(dictfile);
2a06ea
-            return NULL;
2a06ea
-        }
2a06ea
-        free(dictfile);
2a06ea
     } else
2a06ea
     {
2a06ea
-        defaultdict = strdup(GetDefaultCracklibDict());
2a06ea
-        if (errno == ENOMEM) {
2a06ea
-            PyErr_SetFromErrno(PyExc_OSError);
2a06ea
-            return NULL;
2a06ea
-        }
2a06ea
-        dictfile = malloc(strlen(defaultdict) + sizeof(DICT_SUFFIX));
2a06ea
-        if (dictfile == NULL)
2a06ea
-        {
2a06ea
-            PyErr_SetFromErrnoWithFilename(PyExc_OSError, defaultdict);
2a06ea
-            free(defaultdict);
2a06ea
-            return NULL;
2a06ea
-        }
2a06ea
-        sprintf(dictfile, "%s" DICT_SUFFIX, defaultdict);
2a06ea
+        /* No need to strdup() anything as this is a constant value */
2a06ea
+        dict = GetDefaultCracklibDict();
2a06ea
+    }
2a06ea
+
2a06ea
+    dictfile = malloc(strlen(dict) + sizeof(DICT_SUFFIX) + 3);
2a06ea
+    if (dictfile == NULL)
2a06ea
+    {
2a06ea
+        PyErr_SetFromErrnoWithFilename(PyExc_OSError, dict);
2a06ea
+        return NULL;
2a06ea
+    }
2a06ea
+    sprintf(dictfile, "%s" DICT_SUFFIX, dict);
2a06ea
+    if (lstat(dictfile, &st) == -1)
2a06ea
+    {
2a06ea
+#ifdef HAVE_ZLIB_H
2a06ea
+        sprintf(dictfile, "%s" DICT_SUFFIX ".gz", dict);
2a06ea
         if (lstat(dictfile, &st) == -1)
2a06ea
         {
2a06ea
+            sprintf(dictfile, "%s" DICT_SUFFIX, dict);
2a06ea
+#endif
2a06ea
             PyErr_SetFromErrnoWithFilename(PyExc_OSError, dictfile);
2a06ea
-            free(defaultdict);
2a06ea
             free(dictfile);
2a06ea
             return NULL;
2a06ea
+#ifdef HAVE_ZLIB_H
2a06ea
         }
2a06ea
-        free(dictfile);
2a06ea
+#endif
2a06ea
     }
2a06ea
+    free(dictfile);
2a06ea
 
2a06ea
 	setlocale(LC_ALL, "");
2a06ea
 #ifdef ENABLE_NLS
2a06ea
@@ -148,14 +139,9 @@ _cracklib_FascistCheck(PyObject *self, P
2a06ea
 #endif
2a06ea
 
2a06ea
     LOCK();
2a06ea
-    result = FascistCheck(candidate, dict ? dict : defaultdict);
2a06ea
+    result = FascistCheck(candidate, dict);
2a06ea
     UNLOCK();
2a06ea
 
2a06ea
-    if (defaultdict != NULL)
2a06ea
-    {
2a06ea
-        free(defaultdict);
2a06ea
-    }
2a06ea
-
2a06ea
     if (result != NULL)
2a06ea
     {
2a06ea
     	PyErr_SetString(PyExc_ValueError, result);