|
 |
354091 |
From cddd62f972bca276c934e58f08da84071cec1ddb Mon Sep 17 00:00:00 2001
|
|
|
354091 |
From: Jan Friesse <jfriesse@redhat.com>
|
|
|
354091 |
Date: Mon, 25 Nov 2019 18:21:52 +0100
|
|
|
354091 |
Subject: [PATCH] votequorum: Ignore the icmap_get_* return value
|
|
|
354091 |
|
|
|
354091 |
Express intention to ignore icmap_get_* return
|
|
|
354091 |
value and rely on default behavior of not changing the output
|
|
|
354091 |
parameter on error.
|
|
|
354091 |
|
|
|
354091 |
Signed-off-by: Jan Friesse <jfriesse@redhat.com>
|
|
|
354091 |
---
|
|
|
354091 |
exec/votequorum.c | 22 +++++++++++-----------
|
|
|
354091 |
1 file changed, 11 insertions(+), 11 deletions(-)
|
|
|
354091 |
|
|
|
354091 |
diff --git a/exec/votequorum.c b/exec/votequorum.c
|
|
|
354091 |
index f78b3f9..e1d7e73 100644
|
|
|
354091 |
--- a/exec/votequorum.c
|
|
|
354091 |
+++ b/exec/votequorum.c
|
|
|
354091 |
@@ -1271,10 +1271,10 @@ static char *votequorum_readconfig(int runtime)
|
|
|
354091 |
/*
|
|
|
354091 |
* gather basic data here
|
|
|
354091 |
*/
|
|
|
354091 |
- icmap_get_uint32("quorum.expected_votes", &expected_votes);
|
|
|
354091 |
+ (void)icmap_get_uint32("quorum.expected_votes", &expected_votes);
|
|
|
354091 |
have_nodelist = votequorum_read_nodelist_configuration(&node_votes, &node_count, &node_expected_votes);
|
|
|
354091 |
have_qdevice = votequorum_qdevice_is_configured(&qdevice_votes);
|
|
|
354091 |
- icmap_get_uint8("quorum.two_node", &two_node);
|
|
|
354091 |
+ (void)icmap_get_uint8("quorum.two_node", &two_node);
|
|
|
354091 |
|
|
|
354091 |
/*
|
|
|
354091 |
* do config verification and enablement
|
|
|
354091 |
@@ -1319,13 +1319,13 @@ static char *votequorum_readconfig(int runtime)
|
|
|
354091 |
wait_for_all = 1;
|
|
|
354091 |
}
|
|
|
354091 |
|
|
|
354091 |
- icmap_get_uint8("quorum.allow_downscale", &allow_downscale);
|
|
|
354091 |
- icmap_get_uint8("quorum.wait_for_all", &wait_for_all);
|
|
|
354091 |
- icmap_get_uint8("quorum.last_man_standing", &last_man_standing);
|
|
|
354091 |
- icmap_get_uint32("quorum.last_man_standing_window", &last_man_standing_window);
|
|
|
354091 |
- icmap_get_uint8("quorum.expected_votes_tracking", &ev_tracking);
|
|
|
354091 |
- icmap_get_uint8("quorum.auto_tie_breaker", &atb;;
|
|
|
354091 |
- icmap_get_string("quorum.auto_tie_breaker_node", &atb_string);
|
|
|
354091 |
+ (void)icmap_get_uint8("quorum.allow_downscale", &allow_downscale);
|
|
|
354091 |
+ (void)icmap_get_uint8("quorum.wait_for_all", &wait_for_all);
|
|
|
354091 |
+ (void)icmap_get_uint8("quorum.last_man_standing", &last_man_standing);
|
|
|
354091 |
+ (void)icmap_get_uint32("quorum.last_man_standing_window", &last_man_standing_window);
|
|
|
354091 |
+ (void)icmap_get_uint8("quorum.expected_votes_tracking", &ev_tracking);
|
|
|
354091 |
+ (void)icmap_get_uint8("quorum.auto_tie_breaker", &atb;;
|
|
|
354091 |
+ (void)icmap_get_string("quorum.auto_tie_breaker_node", &atb_string);
|
|
|
354091 |
|
|
|
354091 |
/* auto_tie_breaker defaults to LOWEST */
|
|
|
354091 |
if (atb) {
|
|
|
354091 |
@@ -1517,7 +1517,7 @@ static char *votequorum_readconfig(int runtime)
|
|
|
354091 |
us->expected_votes = node_expected_votes;
|
|
|
354091 |
} else {
|
|
|
354091 |
us->votes = 1;
|
|
|
354091 |
- icmap_get_uint32("quorum.votes", &us->votes);
|
|
|
354091 |
+ (void)icmap_get_uint32("quorum.votes", &us->votes);
|
|
|
354091 |
}
|
|
|
354091 |
|
|
|
354091 |
if (expected_votes) {
|
|
|
354091 |
@@ -1568,7 +1568,7 @@ static void votequorum_refresh_config(
|
|
|
354091 |
return ;
|
|
|
354091 |
}
|
|
|
354091 |
|
|
|
354091 |
- icmap_get_uint8("quorum.cancel_wait_for_all", &cancel_wfa);
|
|
|
354091 |
+ (void)icmap_get_uint8("quorum.cancel_wait_for_all", &cancel_wfa);
|
|
|
354091 |
if (strcmp(key_name, "quorum.cancel_wait_for_all") == 0 &&
|
|
|
354091 |
cancel_wfa >= 1) {
|
|
|
354091 |
icmap_set_uint8("quorum.cancel_wait_for_all", 0);
|
|
|
354091 |
--
|
|
|
354091 |
1.8.3.1
|
|
|
354091 |
|