|
 |
098529 |
From 41b6695cf9205f9a0c756004694d1e96941edb51 Mon Sep 17 00:00:00 2001
|
|
|
098529 |
From: Phil Sutter <phil@nwl.cc>
|
|
|
098529 |
Date: Tue, 10 Sep 2019 14:02:30 +0200
|
|
|
098529 |
Subject: [PATCH] nfct: helper: Fix NFCTH_ATTR_PROTO_L4NUM size
|
|
|
098529 |
|
|
|
098529 |
Kernel defines NFCTH_TUPLE_L4PROTONUM as of type NLA_U8. When adding a
|
|
|
098529 |
helper, NFCTH_ATTR_PROTO_L4NUM attribute is correctly set using
|
|
|
098529 |
nfct_helper_attr_set_u8(), though when deleting
|
|
|
098529 |
nfct_helper_attr_set_u32() was incorrectly used. Due to alignment, this
|
|
|
098529 |
causes trouble only on Big Endian.
|
|
|
098529 |
|
|
|
098529 |
Fixes: 5e8f64f46cb1d ("conntrackd: add cthelper infrastructure (+ example FTP helper)")
|
|
|
098529 |
Signed-off-by: Phil Sutter <phil@nwl.cc>
|
|
|
098529 |
Acked-by: Pablo Neira Ayuso <pablo@netfilter.org>
|
|
|
098529 |
(cherry picked from commit 7c5f4b390f4b8dc02aceb0a18ed7c59ff14f392c)
|
|
|
098529 |
Signed-off-by: Phil Sutter <psutter@redhat.com>
|
|
|
098529 |
---
|
|
|
098529 |
src/nfct-extensions/helper.c | 2 +-
|
|
|
098529 |
1 file changed, 1 insertion(+), 1 deletion(-)
|
|
|
098529 |
|
|
|
098529 |
diff --git a/src/nfct-extensions/helper.c b/src/nfct-extensions/helper.c
|
|
|
098529 |
index 0569827612f06..e5d8d0a905df0 100644
|
|
|
098529 |
--- a/src/nfct-extensions/helper.c
|
|
|
098529 |
+++ b/src/nfct-extensions/helper.c
|
|
|
098529 |
@@ -284,7 +284,7 @@ nfct_cmd_helper_delete(struct mnl_socket *nl, int argc, char *argv[])
|
|
|
098529 |
nfct_perror("unsupported layer 4 protocol");
|
|
|
098529 |
return -1;
|
|
|
098529 |
}
|
|
|
098529 |
- nfct_helper_attr_set_u32(t, NFCTH_ATTR_PROTO_L4NUM, l4proto);
|
|
|
098529 |
+ nfct_helper_attr_set_u8(t, NFCTH_ATTR_PROTO_L4NUM, l4proto);
|
|
|
098529 |
}
|
|
|
098529 |
|
|
|
098529 |
seq = time(NULL);
|
|
|
098529 |
--
|
|
|
098529 |
2.24.0
|
|
|
098529 |
|