Blame SOURCES/0014-Conditionalize-tests-for-PR-libstdc-98466-on-__LIBST.patch

56505a
From fa770c25013df537c41d0929c4202b0a774a6a75 Mon Sep 17 00:00:00 2001
56505a
From: David Malcolm <dmalcolm@redhat.com>
56505a
Date: Thu, 2 Sep 2021 15:27:59 -0400
56505a
Subject: [PATCH 14/17] Conditionalize tests for PR libstdc++/98466 on
56505a
 __LIBSTDCXX_SO_VERSION >= 11
56505a
56505a
The tests:
56505a
  23_containers/deque/debug/98466.cc
56505a
  23_containers/unordered_map/debug/98466.cc
56505a
were added upstream 2021-01-01 as part of:
56505a
  libstdc++: Implement N3644 for _GLIBCXX_DEBUG iterators
56505a
    https://gcc.gnu.org/git/?p=gcc.git;a=commitdiff;h=05a30af3f237984b4dcf1dbbc17fdac583c46506
56505a
but fail when run in DTS against a system libstdc++.so
56505a
from an older GCC.
56505a
56505a
In particular, they use the older implementation of _M_can_compare from
56505a
the dynamic library:
56505a
56505a
$ eu-readelf -s 98466.exe | grep can_compare | c++filt
56505a
   11: 0000000000000000      0 FUNC    GLOBAL DEFAULT    UNDEF __gnu_debug::_Safe_iterator_base::_M_can_compare(__gnu_debug::_Safe_iterator_base const&) const@GLIBCXX_3.4 (4)
56505a
  157: 0000000000000000      0 FUNC    GLOBAL DEFAULT    UNDEF __gnu_debug::_Safe_iterator_base::_M_can_compare(__gnu_debug::_Safe_iterator_base const&) const@@GLIBCXX_3.4
56505a
---
56505a
 .../testsuite/23_containers/deque/debug/98466.cc     |  6 ++++++
56505a
 .../23_containers/unordered_map/debug/98466.cc       | 12 ++++++++++++
56505a
 2 files changed, 18 insertions(+)
56505a
56505a
diff --git a/libstdc++-v3/testsuite/23_containers/deque/debug/98466.cc b/libstdc++-v3/testsuite/23_containers/deque/debug/98466.cc
56505a
index c2d793374..e92d719bf 100644
56505a
--- a/libstdc++-v3/testsuite/23_containers/deque/debug/98466.cc
56505a
+++ b/libstdc++-v3/testsuite/23_containers/deque/debug/98466.cc
56505a
@@ -26,11 +26,17 @@ void test01()
56505a
 {
56505a
   typedef typename __gnu_debug::deque<int>::iterator It;
56505a
   It it = It();
56505a
+  // Fixed upstream in GCC 11
56505a
+#if __LIBSTDCXX_SO_VERSION >= 11
56505a
   VERIFY( it == it );
56505a
+#endif
56505a
 
56505a
   typedef typename __gnu_debug::deque<int>::const_iterator Cit;
56505a
   Cit cit = Cit();
56505a
+  // Fixed upstream in GCC 11
56505a
+#if __LIBSTDCXX_SO_VERSION >= 11
56505a
   VERIFY( cit == cit );
56505a
+#endif
56505a
 }
56505a
 
56505a
 int main()
56505a
diff --git a/libstdc++-v3/testsuite/23_containers/unordered_map/debug/98466.cc b/libstdc++-v3/testsuite/23_containers/unordered_map/debug/98466.cc
56505a
index cc22b9ff8..3a1b6cd32 100644
56505a
--- a/libstdc++-v3/testsuite/23_containers/unordered_map/debug/98466.cc
56505a
+++ b/libstdc++-v3/testsuite/23_containers/unordered_map/debug/98466.cc
56505a
@@ -25,16 +25,28 @@
56505a
 void test01()
56505a
 {
56505a
   __gnu_debug::unordered_map<int, int>::iterator it{};
56505a
+  // Fixed upstream in GCC 11
56505a
+#if __LIBSTDCXX_SO_VERSION >= 11
56505a
   VERIFY( it == it );
56505a
+#endif
56505a
 
56505a
   __gnu_debug::unordered_map<int, int>::const_iterator cit{};
56505a
+  // Fixed upstream in GCC 11
56505a
+#if __LIBSTDCXX_SO_VERSION >= 11
56505a
   VERIFY( cit == cit );
56505a
+#endif
56505a
 
56505a
   __gnu_debug::unordered_map<int, int>::local_iterator lit{};
56505a
+  // Fixed upstream in GCC 11
56505a
+#if __LIBSTDCXX_SO_VERSION >= 11
56505a
   VERIFY( lit == lit );
56505a
+#endif
56505a
 
56505a
   __gnu_debug::unordered_map<int, int>::const_local_iterator clit{};
56505a
+  // Fixed upstream in GCC 11
56505a
+#if __LIBSTDCXX_SO_VERSION >= 11
56505a
   VERIFY( clit == clit );
56505a
+#endif
56505a
 }
56505a
 
56505a
 int main()
56505a
-- 
56505a
2.31.1
56505a