|
 |
8ca2e9 |
Partial fix for issues filed upstream at
|
|
|
8ca2e9 |
http://bugzilla.maptools.org/show_bug.cgi?id=2140
|
|
|
8ca2e9 |
This stops the tiffcmp core dump noted in bug #460322, but isn't enough
|
|
|
8ca2e9 |
to make tiffcmp return the right answer (it emits a bunch of error
|
|
|
8ca2e9 |
messages instead).
|
|
|
8ca2e9 |
|
|
|
8ca2e9 |
|
|
|
8ca2e9 |
diff -Naur tiff-3.9.2.orig/libtiff/tif_jpeg.c tiff-3.9.2/libtiff/tif_jpeg.c
|
|
|
8ca2e9 |
--- tiff-3.9.2.orig/libtiff/tif_jpeg.c 2009-08-30 12:21:46.000000000 -0400
|
|
|
8ca2e9 |
+++ tiff-3.9.2/libtiff/tif_jpeg.c 2010-01-05 22:40:40.000000000 -0500
|
|
|
8ca2e9 |
@@ -988,8 +988,15 @@
|
|
|
8ca2e9 |
tsize_t nrows;
|
|
|
8ca2e9 |
(void) s;
|
|
|
8ca2e9 |
|
|
|
8ca2e9 |
- /* data is expected to be read in multiples of a scanline */
|
|
|
8ca2e9 |
- if ( (nrows = sp->cinfo.d.image_height) ) {
|
|
|
8ca2e9 |
+ nrows = cc / sp->bytesperline;
|
|
|
8ca2e9 |
+ if (cc % sp->bytesperline)
|
|
|
8ca2e9 |
+ TIFFWarningExt(tif->tif_clientdata, tif->tif_name, "fractional scanline not read");
|
|
|
8ca2e9 |
+
|
|
|
8ca2e9 |
+ if( nrows > (int) sp->cinfo.d.image_height )
|
|
|
8ca2e9 |
+ nrows = sp->cinfo.d.image_height;
|
|
|
8ca2e9 |
+
|
|
|
8ca2e9 |
+ /* data is expected to be read in multiples of a scanline */
|
|
|
8ca2e9 |
+ if (nrows) {
|
|
|
8ca2e9 |
/* Cb,Cr both have sampling factors 1, so this is correct */
|
|
|
8ca2e9 |
JDIMENSION clumps_per_line = sp->cinfo.d.comp_info[1].downsampled_width;
|
|
|
8ca2e9 |
int samples_per_clump = sp->samplesperclump;
|
|
|
8ca2e9 |
@@ -1087,8 +1094,7 @@
|
|
|
8ca2e9 |
* TODO: resolve this */
|
|
|
8ca2e9 |
buf += sp->bytesperline;
|
|
|
8ca2e9 |
cc -= sp->bytesperline;
|
|
|
8ca2e9 |
- nrows -= sp->v_sampling;
|
|
|
8ca2e9 |
- } while (nrows > 0);
|
|
|
8ca2e9 |
+ } while (--nrows > 0);
|
|
|
8ca2e9 |
|
|
|
8ca2e9 |
#ifdef JPEG_LIB_MK1
|
|
|
8ca2e9 |
_TIFFfree(tmpbuf);
|
|
|
8ca2e9 |
diff -Naur tiff-3.9.2.orig/libtiff/tif_strip.c tiff-3.9.2/libtiff/tif_strip.c
|
|
|
8ca2e9 |
--- tiff-3.9.2.orig/libtiff/tif_strip.c 2006-03-25 13:04:35.000000000 -0500
|
|
|
8ca2e9 |
+++ tiff-3.9.2/libtiff/tif_strip.c 2010-01-05 21:39:20.000000000 -0500
|
|
|
8ca2e9 |
@@ -238,23 +238,19 @@
|
|
|
8ca2e9 |
ycbcrsubsampling + 0,
|
|
|
8ca2e9 |
ycbcrsubsampling + 1);
|
|
|
8ca2e9 |
|
|
|
8ca2e9 |
- if (ycbcrsubsampling[0] == 0) {
|
|
|
8ca2e9 |
+ if (ycbcrsubsampling[0]*ycbcrsubsampling[1] == 0) {
|
|
|
8ca2e9 |
TIFFErrorExt(tif->tif_clientdata, tif->tif_name,
|
|
|
8ca2e9 |
"Invalid YCbCr subsampling");
|
|
|
8ca2e9 |
return 0;
|
|
|
8ca2e9 |
}
|
|
|
8ca2e9 |
|
|
|
8ca2e9 |
- scanline = TIFFroundup(td->td_imagewidth,
|
|
|
8ca2e9 |
+ /* number of sample clumps per line */
|
|
|
8ca2e9 |
+ scanline = TIFFhowmany(td->td_imagewidth,
|
|
|
8ca2e9 |
ycbcrsubsampling[0]);
|
|
|
8ca2e9 |
- scanline = TIFFhowmany8(multiply(tif, scanline,
|
|
|
8ca2e9 |
- td->td_bitspersample,
|
|
|
8ca2e9 |
- "TIFFScanlineSize"));
|
|
|
8ca2e9 |
- return ((tsize_t)
|
|
|
8ca2e9 |
- summarize(tif, scanline,
|
|
|
8ca2e9 |
- multiply(tif, 2,
|
|
|
8ca2e9 |
- scanline / ycbcrsubsampling[0],
|
|
|
8ca2e9 |
- "TIFFVStripSize"),
|
|
|
8ca2e9 |
- "TIFFVStripSize"));
|
|
|
8ca2e9 |
+ /* number of samples per line */
|
|
|
8ca2e9 |
+ scanline = multiply(tif, scanline,
|
|
|
8ca2e9 |
+ ycbcrsubsampling[0]*ycbcrsubsampling[1] + 2,
|
|
|
8ca2e9 |
+ "TIFFScanlineSize");
|
|
|
8ca2e9 |
} else {
|
|
|
8ca2e9 |
scanline = multiply(tif, td->td_imagewidth,
|
|
|
8ca2e9 |
td->td_samplesperpixel,
|