Blame SOURCES/gcc48-rh1469697-22.patch

4dd737
diff -Nrup a/gcc/config/i386/i386.c b/gcc/config/i386/i386.c
4dd737
--- a/gcc/config/i386/i386.c	2018-01-03 16:10:46.278171086 -0700
4dd737
+++ b/gcc/config/i386/i386.c	2018-01-03 16:12:32.022220166 -0700
4dd737
@@ -9862,14 +9862,13 @@ static void
4dd737
 ix86_adjust_stack_and_probe_stack_clash (const HOST_WIDE_INT size)
4dd737
 {
4dd737
   struct machine_function *m = cfun->machine;
4dd737
+  struct ix86_frame frame;
4dd737
+  ix86_compute_frame_layout (&frame);
4dd737
 
4dd737
   /* If this function does not statically allocate stack space, then
4dd737
      no probes are needed.  */
4dd737
   if (!size)
4dd737
     {
4dd737
-      struct ix86_frame frame;
4dd737
-      ix86_compute_frame_layout (&frame);
4dd737
-
4dd737
       /* However, the allocation of space via pushes for register
4dd737
 	 saves could be viewed as allocating space, but without the
4dd737
 	 need to probe.  */
4dd737
@@ -9888,21 +9887,40 @@ ix86_adjust_stack_and_probe_stack_clash
4dd737
      pointer could be anywhere in the guard page.  The safe thing
4dd737
      to do is emit a probe now.
4dd737
 
4dd737
+     The probe can be avoided if we have already emitted any callee
4dd737
+     register saves into the stack or have a frame pointer (which will
4dd737
+     have been saved as well).  Those saves will function as implicit
4dd737
+     probes.
4dd737
+
4dd737
      ?!? This should be revamped to work like aarch64 and s390 where
4dd737
      we track the offset from the most recent probe.  Normally that
4dd737
      offset would be zero.  For a non-return function we would reset
4dd737
      it to PROBE_INTERVAL - (STACK_BOUNDARY / BITS_PER_UNIT).   Then
4dd737
      we just probe when we cross PROBE_INTERVAL.  */
4dd737
-  if (TREE_THIS_VOLATILE (cfun->decl))
4dd737
+  if (TREE_THIS_VOLATILE (cfun->decl)
4dd737
+      && !(frame.nregs || frame.nsseregs || frame_pointer_needed))
4dd737
+
4dd737
     {
4dd737
       /* We can safely use any register here since we're just going to push
4dd737
 	 its value and immediately pop it back.  But we do try and avoid
4dd737
 	 argument passing registers so as not to introduce dependencies in
4dd737
 	 the pipeline.  For 32 bit we use %esi and for 64 bit we use %rax.  */
4dd737
       rtx dummy_reg = gen_rtx_REG (word_mode, TARGET_64BIT ? AX_REG : SI_REG);
4dd737
-      rtx insn = emit_insn (gen_push (dummy_reg));
4dd737
-      RTX_FRAME_RELATED_P (insn) = 1;
4dd737
-      ix86_emit_restore_reg_using_pop (dummy_reg);
4dd737
+      rtx insn_push = emit_insn (gen_push (dummy_reg));
4dd737
+      rtx insn_pop = emit_insn (gen_pop (dummy_reg));
4dd737
+      m->fs.sp_offset -= UNITS_PER_WORD;
4dd737
+      if (m->fs.cfa_reg == stack_pointer_rtx)
4dd737
+	{
4dd737
+	  m->fs.cfa_offset -= UNITS_PER_WORD;
4dd737
+	  rtx x = plus_constant (Pmode, stack_pointer_rtx, -UNITS_PER_WORD);
4dd737
+	  x = gen_rtx_SET (VOIDmode, stack_pointer_rtx, x);
4dd737
+	  add_reg_note (insn_push, REG_CFA_ADJUST_CFA, x);
4dd737
+	  RTX_FRAME_RELATED_P (insn_push) = 1;
4dd737
+	  x = plus_constant (Pmode, stack_pointer_rtx, UNITS_PER_WORD);
4dd737
+	  x = gen_rtx_SET (VOIDmode, stack_pointer_rtx, x);
4dd737
+	  add_reg_note (insn_pop, REG_CFA_ADJUST_CFA, x);
4dd737
+	  RTX_FRAME_RELATED_P (insn_pop) = 1;
4dd737
+	}
4dd737
       emit_insn (gen_blockage ());
4dd737
     }
4dd737
 
4dd737
 
4dd737
diff -Nrup a/gcc-4.8.5-20150702/gcc/testsuite/gcc.target/i386/stack-check-12.c b/gcc-4.8.5-20150702/gcc/testsuite/gcc.target/i386/stack-check-12.c
4dd737
--- gcc-4.8.5-20150702/gcc/testsuite/gcc.target/i386/stack-check-12.c	2018-01-03 15:42:40.849530670 -0700
4dd737
+++ gcc-4.8.5-20150702/gcc/testsuite/gcc.target/i386/stack-check-12.c	2018-01-03 15:36:12.528488596 -0700
4dd737
@@ -7,7 +7,6 @@ __attribute__ ((noreturn)) void exit (in
4dd737
 __attribute__ ((noreturn)) void
4dd737
 f (void)
4dd737
 {
4dd737
-  asm volatile ("nop" ::: "edi");
4dd737
   exit (1);
4dd737
 }
4dd737
 
4dd737
diff -Nrup a/gcc-4.8.5-20150702/gcc/testsuite/gcc.target/i386/stack-check-17.c b/gcc-4.8.5-20150702/gcc/testsuite/gcc.target/i386/stack-check-17.c
4dd737
--- gcc-4.8.5-20150702/gcc/testsuite/gcc.target/i386/stack-check-17.c	1969-12-31 17:00:00.000000000 -0700
4dd737
+++ gcc-4.8.5-20150702/gcc/testsuite/gcc.target/i386/stack-check-17.c	2018-01-03 15:36:12.528488596 -0700
4dd737
@@ -0,0 +1,37 @@
4dd737
+/* { dg-do compile } */
4dd737
+/* { dg-options "-O2 -fstack-clash-protection -mtune=generic -fomit-frame-pointer" } */
4dd737
+/* { dg-require-effective-target supports_stack_clash_protection } */
4dd737
+
4dd737
+
4dd737
+int x0, x1;
4dd737
+void f1 (void);
4dd737
+void f2 (int, int);
4dd737
+
4dd737
+__attribute__ ((noreturn))
4dd737
+void
4dd737
+f3 (void)
4dd737
+{ 
4dd737
+  int y0 = x0;
4dd737
+  int y1 = x1;
4dd737
+  f1 ();
4dd737
+  f2 (y0, y1);
4dd737
+  while (1);
4dd737
+}
4dd737
+
4dd737
+/* Verify no explicit probes.  */
4dd737
+/* { dg-final { scan-assembler-not "or\[ql\]" } } */
4dd737
+
4dd737
+/* We also want to verify we did not use a push/pop sequence
4dd737
+   to probe *sp as the callee register saves are sufficient
4dd737
+   to probe *sp.
4dd737
+
4dd737
+   y0/y1 are live across the call and thus must be allocated
4dd737
+   into either a stack slot or callee saved register.  The former
4dd737
+   would be rather dumb.  So assume it does not happen.
4dd737
+
4dd737
+   So search for two/four pushes for the callee register saves/argument
4dd737
+   pushes and no pops (since the function has no reachable epilogue).  */
4dd737
+/* { dg-final { scan-assembler-times "push\[ql\]" 2 { target { ! ia32 } } } }  */
4dd737
+/* { dg-final { scan-assembler-times "push\[ql\]" 4 { target { ia32 } } } }  */
4dd737
+/* { dg-final { scan-assembler-not "pop" } } */
4dd737
+