|
 |
5ed81e |
2017-05-30 Jakub Jelinek <jakub@redhat.com>
|
|
|
5ed81e |
|
|
|
5ed81e |
Backported from mainline
|
|
|
5ed81e |
2017-03-22 Jakub Jelinek <jakub@redhat.com>
|
|
|
5ed81e |
|
|
|
5ed81e |
PR c++/80129
|
|
|
5ed81e |
* gimplify.c (gimplify_modify_expr_rhs) <case COND_EXPR>: Clear
|
|
|
5ed81e |
TREE_READONLY on result if writing it more than once.
|
|
|
5ed81e |
|
|
|
5ed81e |
* g++.dg/torture/pr80129.C: New test.
|
|
|
5ed81e |
|
|
|
5ed81e |
--- gcc/gimplify.c
|
|
|
5ed81e |
+++ gcc/gimplify.c
|
|
|
5ed81e |
@@ -4293,6 +4293,14 @@ gimplify_modify_expr_rhs (tree *expr_p, tree *from_p, tree *to_p,
|
|
|
5ed81e |
if (ret != GS_ERROR)
|
|
|
5ed81e |
ret = GS_OK;
|
|
|
5ed81e |
|
|
|
5ed81e |
+ /* If we are going to write RESULT more than once, clear
|
|
|
5ed81e |
+ TREE_READONLY flag, otherwise we might incorrectly promote
|
|
|
5ed81e |
+ the variable to static const and initialize it at compile
|
|
|
5ed81e |
+ time in one of the branches. */
|
|
|
5ed81e |
+ if (TREE_CODE (result) == VAR_DECL
|
|
|
5ed81e |
+ && TREE_TYPE (TREE_OPERAND (cond, 1)) != void_type_node
|
|
|
5ed81e |
+ && TREE_TYPE (TREE_OPERAND (cond, 2)) != void_type_node)
|
|
|
5ed81e |
+ TREE_READONLY (result) = 0;
|
|
|
5ed81e |
if (TREE_TYPE (TREE_OPERAND (cond, 1)) != void_type_node)
|
|
|
5ed81e |
TREE_OPERAND (cond, 1)
|
|
|
5ed81e |
= build2 (code, void_type_node, result,
|
|
|
5ed81e |
--- /dev/null
|
|
|
5ed81e |
+++ gcc/testsuite/g++.dg/torture/pr80129.C
|
|
|
5ed81e |
@@ -0,0 +1,14 @@
|
|
|
5ed81e |
+// PR c++/80129
|
|
|
5ed81e |
+// { dg-do run }
|
|
|
5ed81e |
+// { dg-options "-std=c++11" }
|
|
|
5ed81e |
+
|
|
|
5ed81e |
+struct A { bool a; int b; };
|
|
|
5ed81e |
+
|
|
|
5ed81e |
+int
|
|
|
5ed81e |
+main ()
|
|
|
5ed81e |
+{
|
|
|
5ed81e |
+ bool c = false;
|
|
|
5ed81e |
+ const A x = c ? A {true, 1} : A {false, 0};
|
|
|
5ed81e |
+ if (x.a)
|
|
|
5ed81e |
+ __builtin_abort ();
|
|
|
5ed81e |
+}
|