Blame SOURCES/gcc48-pr56564.patch

001c85
2013-06-19  Igor Zamyatin  <igor.zamyatin@intel.com>
001c85
001c85
	* gcc.dg/tree-ssa/loop-19.c: Add -fno-common.
001c85
001c85
2013-06-12  Jakub Jelinek  <jakub@redhat.com>
001c85
001c85
	PR target/56564
001c85
	* varasm.c (decl_binds_to_current_def_p): Call binds_local_p
001c85
	target hook even for !TREE_PUBLIC decls.  If no resolution info
001c85
	is available, return false for common and external decls.
001c85
001c85
	* gcc.target/i386/pr56564-1.c: Skip on darwin, mingw and cygwin.
001c85
	* gcc.target/i386/pr56564-3.c: Likewise.
001c85
001c85
2013-06-11  Jakub Jelinek  <jakub@redhat.com>
001c85
001c85
	PR target/56564
001c85
	* varasm.c (get_variable_align): Move #endif to the right place.
001c85
001c85
2013-06-10  Jakub Jelinek  <jakub@redhat.com>
001c85
001c85
	PR target/56564
001c85
	* varasm.c (align_variable): Don't use DATA_ALIGNMENT or
001c85
	CONSTANT_ALIGNMENT if !decl_binds_to_current_def_p (decl).
001c85
	Use DATA_ABI_ALIGNMENT for that case instead if defined.
001c85
	(get_variable_align): New function.
001c85
	(get_variable_section, emit_bss, emit_common,
001c85
	assemble_variable_contents, place_block_symbol): Use
001c85
	get_variable_align instead of DECL_ALIGN.
001c85
	(assemble_noswitch_variable): Add align argument, use it
001c85
	instead of DECL_ALIGN.
001c85
	(assemble_variable): Adjust caller.  Use get_variable_align
001c85
	instead of DECL_ALIGN.
001c85
	* config/i386/i386.h (DATA_ALIGNMENT): Adjust x86_data_alignment
001c85
	caller.
001c85
	(DATA_ABI_ALIGNMENT): Define.
001c85
	* config/i386/i386-protos.h (x86_data_alignment): Adjust prototype.
001c85
	* config/i386/i386.c (x86_data_alignment): Add opt argument.  If
001c85
	opt is false, only return the psABI mandated alignment increase.
001c85
	* config/c6x/c6x.h (DATA_ALIGNMENT): Renamed to...
001c85
	(DATA_ABI_ALIGNMENT): ... this.
001c85
	* config/mmix/mmix.h (DATA_ALIGNMENT): Renamed to...
001c85
	(DATA_ABI_ALIGNMENT): ... this.
001c85
	* config/mmix/mmix.c (mmix_data_alignment): Adjust function comment.
001c85
	* config/s390/s390.h (DATA_ALIGNMENT): Renamed to...
001c85
	(DATA_ABI_ALIGNMENT): ... this.
001c85
	* doc/tm.texi.in (DATA_ABI_ALIGNMENT): Document.
001c85
	* doc/tm.texi: Regenerated.
001c85
001c85
	* gcc.target/i386/pr56564-1.c: New test.
001c85
	* gcc.target/i386/pr56564-2.c: New test.
001c85
	* gcc.target/i386/pr56564-3.c: New test.
001c85
	* gcc.target/i386/pr56564-4.c: New test.
001c85
	* gcc.target/i386/avx256-unaligned-load-4.c: Add -fno-common.
001c85
	* gcc.target/i386/avx256-unaligned-store-1.c: Likewise.
001c85
	* gcc.target/i386/avx256-unaligned-store-3.c: Likewise.
001c85
	* gcc.target/i386/avx256-unaligned-store-4.c: Likewise.
001c85
	* gcc.target/i386/vect-sizes-1.c: Likewise.
001c85
	* gcc.target/i386/memcpy-1.c: Likewise.
001c85
	* gcc.dg/vect/costmodel/i386/costmodel-vect-31.c (tmp): Initialize.
001c85
	* gcc.dg/vect/costmodel/x86_64/costmodel-vect-31.c (tmp): Likewise.
001c85
001c85
--- gcc/doc/tm.texi.in	(revision 199897)
001c85
+++ gcc/doc/tm.texi.in	(revision 199898)
001c85
@@ -1062,6 +1062,15 @@ arrays to be word-aligned so that @code{
001c85
 constants to character arrays can be done inline.
001c85
 @end defmac
001c85
 
001c85
+@defmac DATA_ABI_ALIGNMENT (@var{type}, @var{basic-align})
001c85
+Similar to @code{DATA_ALIGNMENT}, but for the cases where the ABI mandates
001c85
+some alignment increase, instead of optimization only purposes.  E.g.@
001c85
+AMD x86-64 psABI says that variables with array type larger than 15 bytes
001c85
+must be aligned to 16 byte boundaries.
001c85
+
001c85
+If this macro is not defined, then @var{basic-align} is used.
001c85
+@end defmac
001c85
+
001c85
 @defmac CONSTANT_ALIGNMENT (@var{constant}, @var{basic-align})
001c85
 If defined, a C expression to compute the alignment given to a constant
001c85
 that is being placed in memory.  @var{constant} is the constant and
001c85
--- gcc/doc/tm.texi	(revision 199897)
001c85
+++ gcc/doc/tm.texi	(revision 199898)
001c85
@@ -1078,6 +1078,15 @@ arrays to be word-aligned so that @code{
001c85
 constants to character arrays can be done inline.
001c85
 @end defmac
001c85
 
001c85
+@defmac DATA_ABI_ALIGNMENT (@var{type}, @var{basic-align})
001c85
+Similar to @code{DATA_ALIGNMENT}, but for the cases where the ABI mandates
001c85
+some alignment increase, instead of optimization only purposes.  E.g.@
001c85
+AMD x86-64 psABI says that variables with array type larger than 15 bytes
001c85
+must be aligned to 16 byte boundaries.
001c85
+
001c85
+If this macro is not defined, then @var{basic-align} is used.
001c85
+@end defmac
001c85
+
001c85
 @defmac CONSTANT_ALIGNMENT (@var{constant}, @var{basic-align})
001c85
 If defined, a C expression to compute the alignment given to a constant
001c85
 that is being placed in memory.  @var{constant} is the constant and
001c85
--- gcc/varasm.c	(revision 199897)
001c85
+++ gcc/varasm.c	(revision 199984)
001c85
@@ -966,13 +966,80 @@ align_variable (tree decl, bool dont_out
001c85
       align = MAX_OFILE_ALIGNMENT;
001c85
     }
001c85
 
001c85
-  /* On some machines, it is good to increase alignment sometimes.  */
001c85
   if (! DECL_USER_ALIGN (decl))
001c85
     {
001c85
+#ifdef DATA_ABI_ALIGNMENT
001c85
+      unsigned int data_abi_align
001c85
+	= DATA_ABI_ALIGNMENT (TREE_TYPE (decl), align);
001c85
+      /* For backwards compatibility, don't assume the ABI alignment for
001c85
+	 TLS variables.  */
001c85
+      if (! DECL_THREAD_LOCAL_P (decl) || data_abi_align <= BITS_PER_WORD)
001c85
+	align = data_abi_align;
001c85
+#endif
001c85
+
001c85
+      /* On some machines, it is good to increase alignment sometimes.
001c85
+	 But as DECL_ALIGN is used both for actually emitting the variable
001c85
+	 and for code accessing the variable as guaranteed alignment, we
001c85
+	 can only increase the alignment if it is a performance optimization
001c85
+	 if the references to it must bind to the current definition.  */
001c85
+      if (decl_binds_to_current_def_p (decl))
001c85
+	{
001c85
+#ifdef DATA_ALIGNMENT
001c85
+	  unsigned int data_align = DATA_ALIGNMENT (TREE_TYPE (decl), align);
001c85
+	  /* Don't increase alignment too much for TLS variables - TLS space
001c85
+	     is too precious.  */
001c85
+	  if (! DECL_THREAD_LOCAL_P (decl) || data_align <= BITS_PER_WORD)
001c85
+	    align = data_align;
001c85
+#endif
001c85
+#ifdef CONSTANT_ALIGNMENT
001c85
+	  if (DECL_INITIAL (decl) != 0
001c85
+	      && DECL_INITIAL (decl) != error_mark_node)
001c85
+	    {
001c85
+	      unsigned int const_align
001c85
+		= CONSTANT_ALIGNMENT (DECL_INITIAL (decl), align);
001c85
+	      /* Don't increase alignment too much for TLS variables - TLS
001c85
+		 space is too precious.  */
001c85
+	      if (! DECL_THREAD_LOCAL_P (decl) || const_align <= BITS_PER_WORD)
001c85
+		align = const_align;
001c85
+	    }
001c85
+#endif
001c85
+	}
001c85
+    }
001c85
+
001c85
+  /* Reset the alignment in case we have made it tighter, so we can benefit
001c85
+     from it in get_pointer_alignment.  */
001c85
+  DECL_ALIGN (decl) = align;
001c85
+}
001c85
+
001c85
+/* Return DECL_ALIGN (decl), possibly increased for optimization purposes
001c85
+   beyond what align_variable returned.  */
001c85
+
001c85
+static unsigned int
001c85
+get_variable_align (tree decl)
001c85
+{
001c85
+  unsigned int align = DECL_ALIGN (decl);
001c85
+
001c85
+  /* For user aligned vars or static vars align_variable already did
001c85
+     everything.  */
001c85
+  if (DECL_USER_ALIGN (decl) || !TREE_PUBLIC (decl))
001c85
+    return align;
001c85
+
001c85
+#ifdef DATA_ABI_ALIGNMENT
001c85
+  if (DECL_THREAD_LOCAL_P (decl))
001c85
+    align = DATA_ABI_ALIGNMENT (TREE_TYPE (decl), align);
001c85
+#endif
001c85
+
001c85
+  /* For decls that bind to the current definition, align_variable
001c85
+     did also everything, except for not assuming ABI required alignment
001c85
+     of TLS variables.  For other vars, increase the alignment here
001c85
+     as an optimization.  */
001c85
+  if (!decl_binds_to_current_def_p (decl))
001c85
+    {
001c85
+      /* On some machines, it is good to increase alignment sometimes.  */
001c85
 #ifdef DATA_ALIGNMENT
001c85
       unsigned int data_align = DATA_ALIGNMENT (TREE_TYPE (decl), align);
001c85
       /* Don't increase alignment too much for TLS variables - TLS space
001c85
-	 is too precious.  */
001c85
+         is too precious.  */
001c85
       if (! DECL_THREAD_LOCAL_P (decl) || data_align <= BITS_PER_WORD)
001c85
 	align = data_align;
001c85
 #endif
001c85
@@ -989,9 +1056,7 @@ align_variable (tree decl, bool dont_out
001c85
 #endif
001c85
     }
001c85
 
001c85
-  /* Reset the alignment in case we have made it tighter, so we can benefit
001c85
-     from it in get_pointer_alignment.  */
001c85
-  DECL_ALIGN (decl) = align;
001c85
+  return align;
001c85
 }
001c85
 
001c85
 /* Return the section into which the given VAR_DECL or CONST_DECL
001c85
@@ -1043,7 +1108,8 @@ get_variable_section (tree decl, bool pr
001c85
 	return bss_noswitch_section;
001c85
     }
001c85
 
001c85
-  return targetm.asm_out.select_section (decl, reloc, DECL_ALIGN (decl));
001c85
+  return targetm.asm_out.select_section (decl, reloc,
001c85
+					 get_variable_align (decl));
001c85
 }
001c85
 
001c85
 /* Return the block into which object_block DECL should be placed.  */
001c85
@@ -1780,7 +1846,8 @@ emit_bss (tree decl ATTRIBUTE_UNUSED,
001c85
 	  unsigned HOST_WIDE_INT rounded ATTRIBUTE_UNUSED)
001c85
 {
001c85
 #if defined ASM_OUTPUT_ALIGNED_BSS
001c85
-  ASM_OUTPUT_ALIGNED_BSS (asm_out_file, decl, name, size, DECL_ALIGN (decl));
001c85
+  ASM_OUTPUT_ALIGNED_BSS (asm_out_file, decl, name, size,
001c85
+			  get_variable_align (decl));
001c85
   return true;
001c85
 #endif
001c85
 }
001c85
@@ -1796,10 +1863,11 @@ emit_common (tree decl ATTRIBUTE_UNUSED,
001c85
 {
001c85
 #if defined ASM_OUTPUT_ALIGNED_DECL_COMMON
001c85
   ASM_OUTPUT_ALIGNED_DECL_COMMON (asm_out_file, decl, name,
001c85
-				  size, DECL_ALIGN (decl));
001c85
+				  size, get_variable_align (decl));
001c85
   return true;
001c85
 #elif defined ASM_OUTPUT_ALIGNED_COMMON
001c85
-  ASM_OUTPUT_ALIGNED_COMMON (asm_out_file, name, size, DECL_ALIGN (decl));
001c85
+  ASM_OUTPUT_ALIGNED_COMMON (asm_out_file, name, size,
001c85
+			     get_variable_align (decl));
001c85
   return true;
001c85
 #else
001c85
   ASM_OUTPUT_COMMON (asm_out_file, name, size, rounded);
001c85
@@ -1828,7 +1896,8 @@ emit_tls_common (tree decl ATTRIBUTE_UNU
001c85
    NAME is the name of DECL's SYMBOL_REF.  */
001c85
 
001c85
 static void
001c85
-assemble_noswitch_variable (tree decl, const char *name, section *sect)
001c85
+assemble_noswitch_variable (tree decl, const char *name, section *sect,
001c85
+			    unsigned int align)
001c85
 {
001c85
   unsigned HOST_WIDE_INT size, rounded;
001c85
 
001c85
@@ -1850,7 +1919,7 @@ assemble_noswitch_variable (tree decl, c
001c85
 	     * (BIGGEST_ALIGNMENT / BITS_PER_UNIT));
001c85
 
001c85
   if (!sect->noswitch.callback (decl, name, size, rounded)
001c85
-      && (unsigned HOST_WIDE_INT) DECL_ALIGN_UNIT (decl) > rounded)
001c85
+      && (unsigned HOST_WIDE_INT) (align / BITS_PER_UNIT) > rounded)
001c85
     warning (0, "requested alignment for %q+D is greater than "
001c85
 	     "implemented alignment of %wu", decl, rounded);
001c85
 }
001c85
@@ -1880,7 +1949,7 @@ assemble_variable_contents (tree decl, c
001c85
 	/* Output the actual data.  */
001c85
 	output_constant (DECL_INITIAL (decl),
001c85
 			 tree_low_cst (DECL_SIZE_UNIT (decl), 1),
001c85
-			 DECL_ALIGN (decl));
001c85
+			 get_variable_align (decl));
001c85
       else
001c85
 	/* Leave space for it.  */
001c85
 	assemble_zeros (tree_low_cst (DECL_SIZE_UNIT (decl), 1));
001c85
@@ -1904,6 +1973,7 @@ assemble_variable (tree decl, int top_le
001c85
   const char *name;
001c85
   rtx decl_rtl, symbol;
001c85
   section *sect;
001c85
+  unsigned int align;
001c85
   bool asan_protected = false;
001c85
 
001c85
   /* This function is supposed to handle VARIABLES.  Ensure we have one.  */
001c85
@@ -2003,6 +2073,8 @@ assemble_variable (tree decl, int top_le
001c85
 
001c85
   set_mem_align (decl_rtl, DECL_ALIGN (decl));
001c85
 
001c85
+  align = get_variable_align (decl);
001c85
+
001c85
   if (TREE_PUBLIC (decl))
001c85
     maybe_assemble_visibility (decl);
001c85
 
001c85
@@ -2032,12 +2104,12 @@ assemble_variable (tree decl, int top_le
001c85
       place_block_symbol (symbol);
001c85
     }
001c85
   else if (SECTION_STYLE (sect) == SECTION_NOSWITCH)
001c85
-    assemble_noswitch_variable (decl, name, sect);
001c85
+    assemble_noswitch_variable (decl, name, sect, align);
001c85
   else
001c85
     {
001c85
       switch_to_section (sect);
001c85
-      if (DECL_ALIGN (decl) > BITS_PER_UNIT)
001c85
-	ASM_OUTPUT_ALIGN (asm_out_file, floor_log2 (DECL_ALIGN_UNIT (decl)));
001c85
+      if (align > BITS_PER_UNIT)
001c85
+	ASM_OUTPUT_ALIGN (asm_out_file, floor_log2 (align / BITS_PER_UNIT));
001c85
       assemble_variable_contents (decl, name, dont_output_data);
001c85
       if (asan_protected)
001c85
 	{
001c85
@@ -6709,10 +6781,10 @@ bool
001c85
 decl_binds_to_current_def_p (tree decl)
001c85
 {
001c85
   gcc_assert (DECL_P (decl));
001c85
-  if (!TREE_PUBLIC (decl))
001c85
-    return true;
001c85
   if (!targetm.binds_local_p (decl))
001c85
     return false;
001c85
+  if (!TREE_PUBLIC (decl))
001c85
+    return true;
001c85
   /* When resolution is available, just use it.  */
001c85
   if (TREE_CODE (decl) == VAR_DECL
001c85
       && (TREE_STATIC (decl) || DECL_EXTERNAL (decl)))
001c85
@@ -6730,10 +6802,20 @@ decl_binds_to_current_def_p (tree decl)
001c85
 	return resolution_to_local_definition_p (node->symbol.resolution);
001c85
     }
001c85
   /* Otherwise we have to assume the worst for DECL_WEAK (hidden weaks
001c85
-     binds locally but still can be overwritten).
001c85
+     binds locally but still can be overwritten), DECL_COMMON (can be merged
001c85
+     with a non-common definition somewhere in the same module) or
001c85
+     DECL_EXTERNAL.
001c85
      This rely on fact that binds_local_p behave as decl_replaceable_p
001c85
      for all other declaration types.  */
001c85
-  return !DECL_WEAK (decl);
001c85
+  if (DECL_WEAK (decl))
001c85
+    return false;
001c85
+  if (DECL_COMMON (decl)
001c85
+      && (DECL_INITIAL (decl) == NULL
001c85
+	  || DECL_INITIAL (decl) == error_mark_node))
001c85
+    return false;
001c85
+  if (DECL_EXTERNAL (decl))
001c85
+    return false;
001c85
+  return true;
001c85
 }
001c85
 
001c85
 /* A replaceable function or variable is one which may be replaced
001c85
@@ -6959,7 +7041,7 @@ place_block_symbol (rtx symbol)
001c85
   else
001c85
     {
001c85
       decl = SYMBOL_REF_DECL (symbol);
001c85
-      alignment = DECL_ALIGN (decl);
001c85
+      alignment = get_variable_align (decl);
001c85
       size = tree_low_cst (DECL_SIZE_UNIT (decl), 1);
001c85
       if (flag_asan && asan_protect_global (decl))
001c85
 	{
001c85
--- gcc/config/s390/s390.h	(revision 199897)
001c85
+++ gcc/config/s390/s390.h	(revision 199898)
001c85
@@ -221,7 +221,7 @@ enum processor_flags
001c85
 
001c85
 /* Alignment on even addresses for LARL instruction.  */
001c85
 #define CONSTANT_ALIGNMENT(EXP, ALIGN) (ALIGN) < 16 ? 16 : (ALIGN)
001c85
-#define DATA_ALIGNMENT(TYPE, ALIGN) (ALIGN) < 16 ? 16 : (ALIGN)
001c85
+#define DATA_ABI_ALIGNMENT(TYPE, ALIGN) (ALIGN) < 16 ? 16 : (ALIGN)
001c85
 
001c85
 /* Alignment is not required by the hardware.  */
001c85
 #define STRICT_ALIGNMENT 0
001c85
--- gcc/config/i386/i386.h	(revision 199897)
001c85
+++ gcc/config/i386/i386.h	(revision 199898)
001c85
@@ -859,7 +859,18 @@ enum target_cpu_default
001c85
    cause character arrays to be word-aligned so that `strcpy' calls
001c85
    that copy constants to character arrays can be done inline.  */
001c85
 
001c85
-#define DATA_ALIGNMENT(TYPE, ALIGN) ix86_data_alignment ((TYPE), (ALIGN))
001c85
+#define DATA_ALIGNMENT(TYPE, ALIGN) \
001c85
+  ix86_data_alignment ((TYPE), (ALIGN), true)
001c85
+
001c85
+/* Similar to DATA_ALIGNMENT, but for the cases where the ABI mandates
001c85
+   some alignment increase, instead of optimization only purposes.  E.g.
001c85
+   AMD x86-64 psABI says that variables with array type larger than 15 bytes
001c85
+   must be aligned to 16 byte boundaries.
001c85
+
001c85
+   If this macro is not defined, then ALIGN is used.  */
001c85
+
001c85
+#define DATA_ABI_ALIGNMENT(TYPE, ALIGN) \
001c85
+  ix86_data_alignment ((TYPE), (ALIGN), false)
001c85
 
001c85
 /* If defined, a C expression to compute the alignment for a local
001c85
    variable.  TYPE is the data type, and ALIGN is the alignment that
001c85
--- gcc/config/i386/i386-protos.h	(revision 199897)
001c85
+++ gcc/config/i386/i386-protos.h	(revision 199898)
001c85
@@ -207,7 +207,7 @@ extern void init_cumulative_args (CUMULA
001c85
 #endif	/* RTX_CODE  */
001c85
 
001c85
 #ifdef TREE_CODE
001c85
-extern int ix86_data_alignment (tree, int);
001c85
+extern int ix86_data_alignment (tree, int, bool);
001c85
 extern unsigned int ix86_local_alignment (tree, enum machine_mode,
001c85
 					  unsigned int);
001c85
 extern unsigned int ix86_minimum_alignment (tree, enum machine_mode,
001c85
--- gcc/config/i386/i386.c	(revision 199897)
001c85
+++ gcc/config/i386/i386.c	(revision 199898)
001c85
@@ -25292,12 +25292,13 @@ ix86_constant_alignment (tree exp, int a
001c85
    instead of that alignment to align the object.  */
001c85
 
001c85
 int
001c85
-ix86_data_alignment (tree type, int align)
001c85
+ix86_data_alignment (tree type, int align, bool opt)
001c85
 {
001c85
   int max_align
001c85
     = optimize_size ? BITS_PER_WORD : MIN (256, MAX_OFILE_ALIGNMENT);
001c85
 
001c85
-  if (AGGREGATE_TYPE_P (type)
001c85
+  if (opt
001c85
+      && AGGREGATE_TYPE_P (type)
001c85
       && TYPE_SIZE (type)
001c85
       && TREE_CODE (TYPE_SIZE (type)) == INTEGER_CST
001c85
       && (TREE_INT_CST_LOW (TYPE_SIZE (type)) >= (unsigned) max_align
001c85
@@ -25309,14 +25310,17 @@ ix86_data_alignment (tree type, int alig
001c85
      to 16byte boundary.  */
001c85
   if (TARGET_64BIT)
001c85
     {
001c85
-      if (AGGREGATE_TYPE_P (type)
001c85
-	   && TYPE_SIZE (type)
001c85
-	   && TREE_CODE (TYPE_SIZE (type)) == INTEGER_CST
001c85
-	   && (TREE_INT_CST_LOW (TYPE_SIZE (type)) >= 128
001c85
-	       || TREE_INT_CST_HIGH (TYPE_SIZE (type))) && align < 128)
001c85
+      if ((opt ? AGGREGATE_TYPE_P (type) : TREE_CODE (type) == ARRAY_TYPE)
001c85
+	  && TYPE_SIZE (type)
001c85
+	  && TREE_CODE (TYPE_SIZE (type)) == INTEGER_CST
001c85
+	  && (TREE_INT_CST_LOW (TYPE_SIZE (type)) >= 128
001c85
+	      || TREE_INT_CST_HIGH (TYPE_SIZE (type))) && align < 128)
001c85
 	return 128;
001c85
     }
001c85
 
001c85
+  if (!opt)
001c85
+    return align;
001c85
+
001c85
   if (TREE_CODE (type) == ARRAY_TYPE)
001c85
     {
001c85
       if (TYPE_MODE (TREE_TYPE (type)) == DFmode && align < 64)
001c85
--- gcc/config/c6x/c6x.h	(revision 199897)
001c85
+++ gcc/config/c6x/c6x.h	(revision 199898)
001c85
@@ -134,7 +134,7 @@ extern c6x_cpu_t c6x_arch;
001c85
    Really only externally visible arrays must be aligned this way, as
001c85
    only those are directly visible from another compilation unit.  But
001c85
    we don't have that information available here.  */
001c85
-#define DATA_ALIGNMENT(TYPE, ALIGN)					\
001c85
+#define DATA_ABI_ALIGNMENT(TYPE, ALIGN)					\
001c85
   (((ALIGN) < BITS_PER_UNIT * 8 && TREE_CODE (TYPE) == ARRAY_TYPE)	\
001c85
    ? BITS_PER_UNIT * 8 : (ALIGN))
001c85
 
001c85
--- gcc/config/mmix/mmix.h	(revision 199897)
001c85
+++ gcc/config/mmix/mmix.h	(revision 199898)
001c85
@@ -164,7 +164,7 @@ struct GTY(()) machine_function
001c85
 /* Copied from elfos.h.  */
001c85
 #define MAX_OFILE_ALIGNMENT (32768 * 8)
001c85
 
001c85
-#define DATA_ALIGNMENT(TYPE, BASIC_ALIGN) \
001c85
+#define DATA_ABI_ALIGNMENT(TYPE, BASIC_ALIGN) \
001c85
  mmix_data_alignment (TYPE, BASIC_ALIGN)
001c85
 
001c85
 #define CONSTANT_ALIGNMENT(CONSTANT, BASIC_ALIGN) \
001c85
--- gcc/config/mmix/mmix.c	(revision 199897)
001c85
+++ gcc/config/mmix/mmix.c	(revision 199898)
001c85
@@ -313,7 +313,7 @@ mmix_init_machine_status (void)
001c85
   return ggc_alloc_cleared_machine_function ();
001c85
 }
001c85
 
001c85
-/* DATA_ALIGNMENT.
001c85
+/* DATA_ABI_ALIGNMENT.
001c85
    We have trouble getting the address of stuff that is located at other
001c85
    than 32-bit alignments (GETA requirements), so try to give everything
001c85
    at least 32-bit alignment.  */
001c85
--- gcc/testsuite/gcc.target/i386/memcpy-1.c	(revision 199897)
001c85
+++ gcc/testsuite/gcc.target/i386/memcpy-1.c	(revision 199898)
001c85
@@ -1,6 +1,6 @@
001c85
 /* { dg-do compile } */
001c85
 /* { dg-require-effective-target ia32 } */
001c85
-/* { dg-options "-O2 -march=pentiumpro -minline-all-stringops" } */
001c85
+/* { dg-options "-O2 -march=pentiumpro -minline-all-stringops -fno-common" } */
001c85
 /* { dg-final { scan-assembler "rep" } } */
001c85
 /* { dg-final { scan-assembler "movs" } } */
001c85
 /* { dg-final { scan-assembler-not "test" } } */
001c85
--- gcc/testsuite/gcc.target/i386/vect-sizes-1.c	(revision 199897)
001c85
+++ gcc/testsuite/gcc.target/i386/vect-sizes-1.c	(revision 199898)
001c85
@@ -1,5 +1,5 @@
001c85
 /* { dg-do compile } */
001c85
-/* { dg-options "-O3 -ffast-math -mavx -mtune=generic" } */
001c85
+/* { dg-options "-O3 -ffast-math -mavx -mtune=generic -fno-common" } */
001c85
 
001c85
 double a[1024];
001c85
 
001c85
--- gcc/testsuite/gcc.target/i386/avx256-unaligned-load-4.c	(revision 199897)
001c85
+++ gcc/testsuite/gcc.target/i386/avx256-unaligned-load-4.c	(revision 199898)
001c85
@@ -1,5 +1,5 @@
001c85
 /* { dg-do compile } */
001c85
-/* { dg-options "-O3 -dp -mavx -mno-avx256-split-unaligned-load -mno-avx256-split-unaligned-store" } */
001c85
+/* { dg-options "-O3 -dp -mavx -mno-avx256-split-unaligned-load -mno-avx256-split-unaligned-store -fno-common" } */
001c85
 
001c85
 #define N 1024
001c85
 
001c85
--- gcc/testsuite/gcc.target/i386/avx256-unaligned-store-1.c	(revision 199897)
001c85
+++ gcc/testsuite/gcc.target/i386/avx256-unaligned-store-1.c	(revision 199898)
001c85
@@ -1,5 +1,5 @@
001c85
 /* { dg-do compile } */
001c85
-/* { dg-options "-O3 -dp -mavx -mavx256-split-unaligned-store" } */
001c85
+/* { dg-options "-O3 -dp -mavx -mavx256-split-unaligned-store -fno-common" } */
001c85
 
001c85
 #define N 1024
001c85
 
001c85
--- gcc/testsuite/gcc.target/i386/avx256-unaligned-store-3.c	(revision 199897)
001c85
+++ gcc/testsuite/gcc.target/i386/avx256-unaligned-store-3.c	(revision 199898)
001c85
@@ -1,5 +1,5 @@
001c85
 /* { dg-do compile } */
001c85
-/* { dg-options "-O3 -dp -mavx -mavx256-split-unaligned-store -mtune=generic" } */
001c85
+/* { dg-options "-O3 -dp -mavx -mavx256-split-unaligned-store -mtune=generic -fno-common" } */
001c85
 
001c85
 #define N 1024
001c85
 
001c85
--- gcc/testsuite/gcc.target/i386/avx256-unaligned-store-4.c	(revision 199897)
001c85
+++ gcc/testsuite/gcc.target/i386/avx256-unaligned-store-4.c	(revision 199898)
001c85
@@ -1,5 +1,5 @@
001c85
 /* { dg-do compile } */
001c85
-/* { dg-options "-O3 -dp -mavx -mno-avx256-split-unaligned-load -mno-avx256-split-unaligned-store" } */
001c85
+/* { dg-options "-O3 -dp -mavx -mno-avx256-split-unaligned-load -mno-avx256-split-unaligned-store -fno-common" } */
001c85
 
001c85
 #define N 1024
001c85
 
001c85
--- gcc/testsuite/gcc.target/i386/pr56564-1.c	(revision 0)
001c85
+++ gcc/testsuite/gcc.target/i386/pr56564-1.c	(revision 199985)
001c85
@@ -0,0 +1,26 @@
001c85
+/* PR target/56564 */
001c85
+/* { dg-do compile { target { fpic && lp64 } } } */
001c85
+/* { dg-skip-if "No symbol interposition for PIC" { *-*-mingw* *-*-cygwin* *-*-darwin* } } */
001c85
+/* { dg-options "-O3 -fpic -fdump-tree-optimized" } */
001c85
+
001c85
+struct S { long a, b; } s = { 5, 6 };
001c85
+char t[16] = { 7 };
001c85
+
001c85
+int
001c85
+foo (void)
001c85
+{
001c85
+  return ((__UINTPTR_TYPE__) &s) & 15;
001c85
+}
001c85
+
001c85
+int
001c85
+bar (void)
001c85
+{
001c85
+  return ((__UINTPTR_TYPE__) &t[0]) & 15;
001c85
+}
001c85
+
001c85
+/* { dg-final { scan-tree-dump-times "&s" 1 "optimized" } } */
001c85
+/* { dg-final { scan-tree-dump-times "&t" 0 "optimized" } } */
001c85
+/* { dg-final { scan-tree-dump-times "return 0" 1 "optimized" } } */
001c85
+/* { dg-final { scan-assembler ".align\[ \t]*16\[^:]*\[\n\r]s:" { target { *-*-linux* } } } } */
001c85
+/* { dg-final { scan-assembler ".align\[ \t]*16\[^:]*\[\n\r]t:" { target { *-*-linux* } } } } */
001c85
+/* { dg-final { cleanup-tree-dump "optimized" } } */
001c85
--- gcc/testsuite/gcc.target/i386/pr56564-2.c	(revision 0)
001c85
+++ gcc/testsuite/gcc.target/i386/pr56564-2.c	(revision 199898)
001c85
@@ -0,0 +1,25 @@
001c85
+/* PR target/56564 */
001c85
+/* { dg-do compile { target { *-*-linux* && lp64 } } } */
001c85
+/* { dg-options "-O3 -fno-pic -fdump-tree-optimized" } */
001c85
+
001c85
+struct S { long a, b; } s = { 5, 6 };
001c85
+char t[16] = { 7 };
001c85
+
001c85
+int
001c85
+foo (void)
001c85
+{
001c85
+  return ((__UINTPTR_TYPE__) &s) & 15;
001c85
+}
001c85
+
001c85
+int
001c85
+bar (void)
001c85
+{
001c85
+  return ((__UINTPTR_TYPE__) &t[0]) & 15;
001c85
+}
001c85
+
001c85
+/* { dg-final { scan-tree-dump-times "&s" 0 "optimized" } } */
001c85
+/* { dg-final { scan-tree-dump-times "&t" 0 "optimized" } } */
001c85
+/* { dg-final { scan-tree-dump-times "return 0" 2 "optimized" } } */
001c85
+/* { dg-final { scan-assembler ".align\[ \t]*16\[^:]*\[\n\r]s:" { target { *-*-linux* } } } } */
001c85
+/* { dg-final { scan-assembler ".align\[ \t]*16\[^:]*\[\n\r]t:" { target { *-*-linux* } } } } */
001c85
+/* { dg-final { cleanup-tree-dump "optimized" } } */
001c85
--- gcc/testsuite/gcc.target/i386/pr56564-3.c	(revision 0)
001c85
+++ gcc/testsuite/gcc.target/i386/pr56564-3.c	(revision 199985)
001c85
@@ -0,0 +1,29 @@
001c85
+/* PR target/56564 */
001c85
+/* { dg-do compile { target { fpic && lp64 } } } */
001c85
+/* { dg-skip-if "No symbol interposition for PIC" { *-*-mingw* *-*-cygwin* *-*-darwin* } } */
001c85
+/* { dg-options "-O3 -fpic -fdump-tree-optimized" } */
001c85
+
001c85
+__thread struct S { long a, b; } s = { 5, 6 };
001c85
+__thread char t[16] = { 7 };
001c85
+
001c85
+int
001c85
+foo (void)
001c85
+{
001c85
+  return ((__UINTPTR_TYPE__) &s) & 15;
001c85
+}
001c85
+
001c85
+/* For backwards compatibility we don't assume that t must
001c85
+   be aligned to 16 bytes, but align it anyway.  */
001c85
+
001c85
+int
001c85
+bar (void)
001c85
+{
001c85
+  return ((__UINTPTR_TYPE__) &t[0]) & 15;
001c85
+}
001c85
+
001c85
+/* { dg-final { scan-tree-dump-times "&s" 1 "optimized" } } */
001c85
+/* { dg-final { scan-tree-dump-times "&t" 1 "optimized" } } */
001c85
+/* { dg-final { scan-tree-dump-times "return 0" 0 "optimized" } } */
001c85
+/* { dg-final { scan-assembler-not ".align\[ \t]*16\[^:]*\[\n\r]s:" { target { *-*-linux* } } } } */
001c85
+/* { dg-final { scan-assembler ".align\[ \t]*16\[^:]*\[\n\r]t:" { target { *-*-linux* } } } } */
001c85
+/* { dg-final { cleanup-tree-dump "optimized" } } */
001c85
--- gcc/testsuite/gcc.target/i386/pr56564-4.c	(revision 0)
001c85
+++ gcc/testsuite/gcc.target/i386/pr56564-4.c	(revision 199898)
001c85
@@ -0,0 +1,22 @@
001c85
+/* PR target/56564 */
001c85
+/* { dg-do compile { target { *-*-linux* && lp64 } } } */
001c85
+/* { dg-options "-O3 -fno-pic -fdump-tree-optimized" } */
001c85
+
001c85
+__thread struct S { long a, b; } s = { 5, 6 };
001c85
+__thread char t[16] = { 7 };
001c85
+
001c85
+int
001c85
+foo (void)
001c85
+{
001c85
+  return ((__UINTPTR_TYPE__) &s) & 15;
001c85
+}
001c85
+
001c85
+int
001c85
+bar (void)
001c85
+{
001c85
+  return ((__UINTPTR_TYPE__) &t[0]) & 15;
001c85
+}
001c85
+
001c85
+/* { dg-final { scan-assembler-not ".align\[ \t]*16\[^:]*\[\n\r]s:" { target { *-*-linux* } } } } */
001c85
+/* { dg-final { scan-assembler ".align\[ \t]*16\[^:]*\[\n\r]t:" { target { *-*-linux* } } } } */
001c85
+/* { dg-final { cleanup-tree-dump "optimized" } } */
001c85
--- gcc/testsuite/gcc.dg/vect/costmodel/i386/costmodel-vect-31.c	(revision 199897)
001c85
+++ gcc/testsuite/gcc.dg/vect/costmodel/i386/costmodel-vect-31.c	(revision 199898)
001c85
@@ -18,7 +18,7 @@ struct s{
001c85
   struct t e;   /* unaligned (offset 2N+4N+4 B) */
001c85
 };
001c85
  
001c85
-struct s tmp;
001c85
+struct s tmp = { 1 };
001c85
 
001c85
 int main1 ()
001c85
 {  
001c85
--- gcc/testsuite/gcc.dg/vect/costmodel/x86_64/costmodel-vect-31.c	(revision 199897)
001c85
+++ gcc/testsuite/gcc.dg/vect/costmodel/x86_64/costmodel-vect-31.c	(revision 199898)
001c85
@@ -18,7 +18,7 @@ struct s{
001c85
   struct t e;   /* unaligned (offset 2N+4N+4 B) */
001c85
 };
001c85
  
001c85
-struct s tmp;
001c85
+struct s tmp = { 1 };
001c85
 
001c85
 int main1 ()
001c85
 {  
001c85
--- gcc/testsuite/gcc.dg/tree-ssa/loop-19.c	(revision 200212)
001c85
+++ gcc/testsuite/gcc.dg/tree-ssa/loop-19.c	(revision 200213)
001c85
@@ -6,7 +6,7 @@
001c85
 
001c85
 /* { dg-do compile { target { i?86-*-* || { x86_64-*-* || powerpc_hard_double } } } } */
001c85
 /* { dg-require-effective-target nonpic } */
001c85
-/* { dg-options "-O3 -fno-tree-loop-distribute-patterns -fno-prefetch-loop-arrays -fdump-tree-optimized" } */
001c85
+/* { dg-options "-O3 -fno-tree-loop-distribute-patterns -fno-prefetch-loop-arrays -fdump-tree-optimized -fno-common" } */
001c85
 
001c85
 # define N      2000000
001c85
 double   a[N],c[N];