Blame SOURCES/gcc48-libgo-p224.patch

8178f7
--- libgo/Makefile.am.jj	2013-12-12 19:01:49.000000000 +0100
8178f7
+++ libgo/Makefile.am	2014-02-18 17:31:54.798484657 +0100
8178f7
@@ -1109,8 +1109,7 @@ go_crypto_dsa_files = \
8178f7
 go_crypto_ecdsa_files = \
8178f7
 	go/crypto/ecdsa/ecdsa.go
8178f7
 go_crypto_elliptic_files = \
8178f7
-	go/crypto/elliptic/elliptic.go \
8178f7
-	go/crypto/elliptic/p224.go
8178f7
+	go/crypto/elliptic/elliptic.go
8178f7
 go_crypto_hmac_files = \
8178f7
 	go/crypto/hmac/hmac.go
8178f7
 go_crypto_md5_files = \
8178f7
--- libgo/Makefile.in.jj	2013-12-12 19:01:49.000000000 +0100
8178f7
+++ libgo/Makefile.in	2014-02-18 17:32:11.350389191 +0100
8178f7
@@ -1274,8 +1274,7 @@ go_crypto_ecdsa_files = \
8178f7
 	go/crypto/ecdsa/ecdsa.go
8178f7
 
8178f7
 go_crypto_elliptic_files = \
8178f7
-	go/crypto/elliptic/elliptic.go \
8178f7
-	go/crypto/elliptic/p224.go
8178f7
+	go/crypto/elliptic/elliptic.go
8178f7
 
8178f7
 go_crypto_hmac_files = \
8178f7
 	go/crypto/hmac/hmac.go
8178f7
--- libgo/go/crypto/elliptic/elliptic.go.jj	2012-12-13 11:32:02.640039537 +0100
8178f7
+++ libgo/go/crypto/elliptic/elliptic.go	2014-02-18 17:28:22.909692022 +0100
8178f7
@@ -327,7 +327,6 @@ var p384 *CurveParams
8178f7
 var p521 *CurveParams
8178f7
 
8178f7
 func initAll() {
8178f7
-	initP224()
8178f7
 	initP256()
8178f7
 	initP384()
8178f7
 	initP521()
8178f7
--- libgo/go/crypto/elliptic/elliptic_test.go.jj	2012-12-13 11:32:02.640039537 +0100
8178f7
+++ libgo/go/crypto/elliptic/elliptic_test.go	2014-02-18 17:31:04.052774265 +0100
8178f7
@@ -5,329 +5,14 @@
8178f7
 package elliptic
8178f7
 
8178f7
 import (
8178f7
-	"crypto/rand"
8178f7
-	"encoding/hex"
8178f7
-	"fmt"
8178f7
-	"math/big"
8178f7
 	"testing"
8178f7
 )
8178f7
 
8178f7
-func TestOnCurve(t *testing.T) {
8178f7
-	p224 := P224()
8178f7
-	if !p224.IsOnCurve(p224.Params().Gx, p224.Params().Gy) {
8178f7
-		t.Errorf("FAIL")
8178f7
-	}
8178f7
-}
8178f7
-
8178f7
-type baseMultTest struct {
8178f7
-	k    string
8178f7
-	x, y string
8178f7
-}
8178f7
-
8178f7
-var p224BaseMultTests = []baseMultTest{
8178f7
-	{
8178f7
-		"1",
8178f7
-		"b70e0cbd6bb4bf7f321390b94a03c1d356c21122343280d6115c1d21",
8178f7
-		"bd376388b5f723fb4c22dfe6cd4375a05a07476444d5819985007e34",
8178f7
-	},
8178f7
-	{
8178f7
-		"2",
8178f7
-		"706a46dc76dcb76798e60e6d89474788d16dc18032d268fd1a704fa6",
8178f7
-		"1c2b76a7bc25e7702a704fa986892849fca629487acf3709d2e4e8bb",
8178f7
-	},
8178f7
-	{
8178f7
-		"3",
8178f7
-		"df1b1d66a551d0d31eff822558b9d2cc75c2180279fe0d08fd896d04",
8178f7
-		"a3f7f03cadd0be444c0aa56830130ddf77d317344e1af3591981a925",
8178f7
-	},
8178f7
-	{
8178f7
-		"4",
8178f7
-		"ae99feebb5d26945b54892092a8aee02912930fa41cd114e40447301",
8178f7
-		"482580a0ec5bc47e88bc8c378632cd196cb3fa058a7114eb03054c9",
8178f7
-	},
8178f7
-	{
8178f7
-		"5",
8178f7
-		"31c49ae75bce7807cdff22055d94ee9021fedbb5ab51c57526f011aa",
8178f7
-		"27e8bff1745635ec5ba0c9f1c2ede15414c6507d29ffe37e790a079b",
8178f7
-	},
8178f7
-	{
8178f7
-		"6",
8178f7
-		"1f2483f82572251fca975fea40db821df8ad82a3c002ee6c57112408",
8178f7
-		"89faf0ccb750d99b553c574fad7ecfb0438586eb3952af5b4b153c7e",
8178f7
-	},
8178f7
-	{
8178f7
-		"7",
8178f7
-		"db2f6be630e246a5cf7d99b85194b123d487e2d466b94b24a03c3e28",
8178f7
-		"f3a30085497f2f611ee2517b163ef8c53b715d18bb4e4808d02b963",
8178f7
-	},
8178f7
-	{
8178f7
-		"8",
8178f7
-		"858e6f9cc6c12c31f5df124aa77767b05c8bc021bd683d2b55571550",
8178f7
-		"46dcd3ea5c43898c5c5fc4fdac7db39c2f02ebee4e3541d1e78047a",
8178f7
-	},
8178f7
-	{
8178f7
-		"9",
8178f7
-		"2fdcccfee720a77ef6cb3bfbb447f9383117e3daa4a07e36ed15f78d",
8178f7
-		"371732e4f41bf4f7883035e6a79fcedc0e196eb07b48171697517463",
8178f7
-	},
8178f7
-	{
8178f7
-		"10",
8178f7
-		"aea9e17a306517eb89152aa7096d2c381ec813c51aa880e7bee2c0fd",
8178f7
-		"39bb30eab337e0a521b6cba1abe4b2b3a3e524c14a3fe3eb116b655f",
8178f7
-	},
8178f7
-	{
8178f7
-		"11",
8178f7
-		"ef53b6294aca431f0f3c22dc82eb9050324f1d88d377e716448e507c",
8178f7
-		"20b510004092e96636cfb7e32efded8265c266dfb754fa6d6491a6da",
8178f7
-	},
8178f7
-	{
8178f7
-		"12",
8178f7
-		"6e31ee1dc137f81b056752e4deab1443a481033e9b4c93a3044f4f7a",
8178f7
-		"207dddf0385bfdeab6e9acda8da06b3bbef224a93ab1e9e036109d13",
8178f7
-	},
8178f7
-	{
8178f7
-		"13",
8178f7
-		"34e8e17a430e43289793c383fac9774247b40e9ebd3366981fcfaeca",
8178f7
-		"252819f71c7fb7fbcb159be337d37d3336d7feb963724fdfb0ecb767",
8178f7
-	},
8178f7
-	{
8178f7
-		"14",
8178f7
-		"a53640c83dc208603ded83e4ecf758f24c357d7cf48088b2ce01e9fa",
8178f7
-		"d5814cd724199c4a5b974a43685fbf5b8bac69459c9469bc8f23ccaf",
8178f7
-	},
8178f7
-	{
8178f7
-		"15",
8178f7
-		"baa4d8635511a7d288aebeedd12ce529ff102c91f97f867e21916bf9",
8178f7
-		"979a5f4759f80f4fb4ec2e34f5566d595680a11735e7b61046127989",
8178f7
-	},
8178f7
-	{
8178f7
-		"16",
8178f7
-		"b6ec4fe1777382404ef679997ba8d1cc5cd8e85349259f590c4c66d",
8178f7
-		"3399d464345906b11b00e363ef429221f2ec720d2f665d7dead5b482",
8178f7
-	},
8178f7
-	{
8178f7
-		"17",
8178f7
-		"b8357c3a6ceef288310e17b8bfeff9200846ca8c1942497c484403bc",
8178f7
-		"ff149efa6606a6bd20ef7d1b06bd92f6904639dce5174db6cc554a26",
8178f7
-	},
8178f7
-	{
8178f7
-		"18",
8178f7
-		"c9ff61b040874c0568479216824a15eab1a838a797d189746226e4cc",
8178f7
-		"ea98d60e5ffc9b8fcf999fab1df7e7ef7084f20ddb61bb045a6ce002",
8178f7
-	},
8178f7
-	{
8178f7
-		"19",
8178f7
-		"a1e81c04f30ce201c7c9ace785ed44cc33b455a022f2acdbc6cae83c",
8178f7
-		"dcf1f6c3db09c70acc25391d492fe25b4a180babd6cea356c04719cd",
8178f7
-	},
8178f7
-	{
8178f7
-		"20",
8178f7
-		"fcc7f2b45df1cd5a3c0c0731ca47a8af75cfb0347e8354eefe782455",
8178f7
-		"d5d7110274cba7cdee90e1a8b0d394c376a5573db6be0bf2747f530",
8178f7
-	},
8178f7
-	{
8178f7
-		"112233445566778899",
8178f7
-		"61f077c6f62ed802dad7c2f38f5c67f2cc453601e61bd076bb46179e",
8178f7
-		"2272f9e9f5933e70388ee652513443b5e289dd135dcc0d0299b225e4",
8178f7
-	},
8178f7
-	{
8178f7
-		"112233445566778899112233445566778899",
8178f7
-		"29895f0af496bfc62b6ef8d8a65c88c613949b03668aab4f0429e35",
8178f7
-		"3ea6e53f9a841f2019ec24bde1a75677aa9b5902e61081c01064de93",
8178f7
-	},
8178f7
-	{
8178f7
-		"6950511619965839450988900688150712778015737983940691968051900319680",
8178f7
-		"ab689930bcae4a4aa5f5cb085e823e8ae30fd365eb1da4aba9cf0379",
8178f7
-		"3345a121bbd233548af0d210654eb40bab788a03666419be6fbd34e7",
8178f7
-	},
8178f7
-	{
8178f7
-		"13479972933410060327035789020509431695094902435494295338570602119423",
8178f7
-		"bdb6a8817c1f89da1c2f3dd8e97feb4494f2ed302a4ce2bc7f5f4025",
8178f7
-		"4c7020d57c00411889462d77a5438bb4e97d177700bf7243a07f1680",
8178f7
-	},
8178f7
-	{
8178f7
-		"13479971751745682581351455311314208093898607229429740618390390702079",
8178f7
-		"d58b61aa41c32dd5eba462647dba75c5d67c83606c0af2bd928446a9",
8178f7
-		"d24ba6a837be0460dd107ae77725696d211446c5609b4595976b16bd",
8178f7
-	},
8178f7
-	{
8178f7
-		"13479972931865328106486971546324465392952975980343228160962702868479",
8178f7
-		"dc9fa77978a005510980e929a1485f63716df695d7a0c18bb518df03",
8178f7
-		"ede2b016f2ddffc2a8c015b134928275ce09e5661b7ab14ce0d1d403",
8178f7
-	},
8178f7
-	{
8178f7
-		"11795773708834916026404142434151065506931607341523388140225443265536",
8178f7
-		"499d8b2829cfb879c901f7d85d357045edab55028824d0f05ba279ba",
8178f7
-		"bf929537b06e4015919639d94f57838fa33fc3d952598dcdbb44d638",
8178f7
-	},
8178f7
-	{
8178f7
-		"784254593043826236572847595991346435467177662189391577090",
8178f7
-		"8246c999137186632c5f9eddf3b1b0e1764c5e8bd0e0d8a554b9cb77",
8178f7
-		"e80ed8660bc1cb17ac7d845be40a7a022d3306f116ae9f81fea65947",
8178f7
-	},
8178f7
-	{
8178f7
-		"13479767645505654746623887797783387853576174193480695826442858012671",
8178f7
-		"6670c20afcceaea672c97f75e2e9dd5c8460e54bb38538ebb4bd30eb",
8178f7
-		"f280d8008d07a4caf54271f993527d46ff3ff46fd1190a3f1faa4f74",
8178f7
-	},
8178f7
-	{
8178f7
-		"205688069665150753842126177372015544874550518966168735589597183",
8178f7
-		"eca934247425cfd949b795cb5ce1eff401550386e28d1a4c5a8eb",
8178f7
-		"d4c01040dba19628931bc8855370317c722cbd9ca6156985f1c2e9ce",
8178f7
-	},
8178f7
-	{
8178f7
-		"13479966930919337728895168462090683249159702977113823384618282123295",
8178f7
-		"ef353bf5c73cd551b96d596fbc9a67f16d61dd9fe56af19de1fba9cd",
8178f7
-		"21771b9cdce3e8430c09b3838be70b48c21e15bc09ee1f2d7945b91f",
8178f7
-	},
8178f7
-	{
8178f7
-		"50210731791415612487756441341851895584393717453129007497216",
8178f7
-		"4036052a3091eb481046ad3289c95d3ac905ca0023de2c03ecd451cf",
8178f7
-		"d768165a38a2b96f812586a9d59d4136035d9c853a5bf2e1c86a4993",
8178f7
-	},
8178f7
-	{
8178f7
-		"26959946667150639794667015087019625940457807714424391721682722368041",
8178f7
-		"fcc7f2b45df1cd5a3c0c0731ca47a8af75cfb0347e8354eefe782455",
8178f7
-		"f2a28eefd8b345832116f1e574f2c6b2c895aa8c24941f40d8b80ad1",
8178f7
-	},
8178f7
-	{
8178f7
-		"26959946667150639794667015087019625940457807714424391721682722368042",
8178f7
-		"a1e81c04f30ce201c7c9ace785ed44cc33b455a022f2acdbc6cae83c",
8178f7
-		"230e093c24f638f533dac6e2b6d01da3b5e7f45429315ca93fb8e634",
8178f7
-	},
8178f7
-	{
8178f7
-		"26959946667150639794667015087019625940457807714424391721682722368043",
8178f7
-		"c9ff61b040874c0568479216824a15eab1a838a797d189746226e4cc",
8178f7
-		"156729f1a003647030666054e208180f8f7b0df2249e44fba5931fff",
8178f7
-	},
8178f7
-	{
8178f7
-		"26959946667150639794667015087019625940457807714424391721682722368044",
8178f7
-		"b8357c3a6ceef288310e17b8bfeff9200846ca8c1942497c484403bc",
8178f7
-		"eb610599f95942df1082e4f9426d086fb9c6231ae8b24933aab5db",
8178f7
-	},
8178f7
-	{
8178f7
-		"26959946667150639794667015087019625940457807714424391721682722368045",
8178f7
-		"b6ec4fe1777382404ef679997ba8d1cc5cd8e85349259f590c4c66d",
8178f7
-		"cc662b9bcba6f94ee4ff1c9c10bd6ddd0d138df2d099a282152a4b7f",
8178f7
-	},
8178f7
-	{
8178f7
-		"26959946667150639794667015087019625940457807714424391721682722368046",
8178f7
-		"baa4d8635511a7d288aebeedd12ce529ff102c91f97f867e21916bf9",
8178f7
-		"6865a0b8a607f0b04b13d1cb0aa992a5a97f5ee8ca1849efb9ed8678",
8178f7
-	},
8178f7
-	{
8178f7
-		"26959946667150639794667015087019625940457807714424391721682722368047",
8178f7
-		"a53640c83dc208603ded83e4ecf758f24c357d7cf48088b2ce01e9fa",
8178f7
-		"2a7eb328dbe663b5a468b5bc97a040a3745396ba636b964370dc3352",
8178f7
-	},
8178f7
-	{
8178f7
-		"26959946667150639794667015087019625940457807714424391721682722368048",
8178f7
-		"34e8e17a430e43289793c383fac9774247b40e9ebd3366981fcfaeca",
8178f7
-		"dad7e608e380480434ea641cc82c82cbc92801469c8db0204f13489a",
8178f7
-	},
8178f7
-	{
8178f7
-		"26959946667150639794667015087019625940457807714424391721682722368049",
8178f7
-		"6e31ee1dc137f81b056752e4deab1443a481033e9b4c93a3044f4f7a",
8178f7
-		"df82220fc7a4021549165325725f94c3410ddb56c54e161fc9ef62ee",
8178f7
-	},
8178f7
-	{
8178f7
-		"26959946667150639794667015087019625940457807714424391721682722368050",
8178f7
-		"ef53b6294aca431f0f3c22dc82eb9050324f1d88d377e716448e507c",
8178f7
-		"df4aefffbf6d1699c930481cd102127c9a3d992048ab05929b6e5927",
8178f7
-	},
8178f7
-	{
8178f7
-		"26959946667150639794667015087019625940457807714424391721682722368051",
8178f7
-		"aea9e17a306517eb89152aa7096d2c381ec813c51aa880e7bee2c0fd",
8178f7
-		"c644cf154cc81f5ade49345e541b4d4b5c1adb3eb5c01c14ee949aa2",
8178f7
-	},
8178f7
-	{
8178f7
-		"26959946667150639794667015087019625940457807714424391721682722368052",
8178f7
-		"2fdcccfee720a77ef6cb3bfbb447f9383117e3daa4a07e36ed15f78d",
8178f7
-		"c8e8cd1b0be40b0877cfca1958603122f1e6914f84b7e8e968ae8b9e",
8178f7
-	},
8178f7
-	{
8178f7
-		"26959946667150639794667015087019625940457807714424391721682722368053",
8178f7
-		"858e6f9cc6c12c31f5df124aa77767b05c8bc021bd683d2b55571550",
8178f7
-		"fb9232c15a3bc7673a3a03b0253824c53d0fd1411b1cabe2e187fb87",
8178f7
-	},
8178f7
-	{
8178f7
-		"26959946667150639794667015087019625940457807714424391721682722368054",
8178f7
-		"db2f6be630e246a5cf7d99b85194b123d487e2d466b94b24a03c3e28",
8178f7
-		"f0c5cff7ab680d09ee11dae84e9c1072ac48ea2e744b1b7f72fd469e",
8178f7
-	},
8178f7
-	{
8178f7
-		"26959946667150639794667015087019625940457807714424391721682722368055",
8178f7
-		"1f2483f82572251fca975fea40db821df8ad82a3c002ee6c57112408",
8178f7
-		"76050f3348af2664aac3a8b05281304ebc7a7914c6ad50a4b4eac383",
8178f7
-	},
8178f7
-	{
8178f7
-		"26959946667150639794667015087019625940457807714424391721682722368056",
8178f7
-		"31c49ae75bce7807cdff22055d94ee9021fedbb5ab51c57526f011aa",
8178f7
-		"d817400e8ba9ca13a45f360e3d121eaaeb39af82d6001c8186f5f866",
8178f7
-	},
8178f7
-	{
8178f7
-		"26959946667150639794667015087019625940457807714424391721682722368057",
8178f7
-		"ae99feebb5d26945b54892092a8aee02912930fa41cd114e40447301",
8178f7
-		"fb7da7f5f13a43b81774373c879cd32d6934c05fa758eeb14fcfab38",
8178f7
-	},
8178f7
-	{
8178f7
-		"26959946667150639794667015087019625940457807714424391721682722368058",
8178f7
-		"df1b1d66a551d0d31eff822558b9d2cc75c2180279fe0d08fd896d04",
8178f7
-		"5c080fc3522f41bbb3f55a97cfecf21f882ce8cbb1e50ca6e67e56dc",
8178f7
-	},
8178f7
-	{
8178f7
-		"26959946667150639794667015087019625940457807714424391721682722368059",
8178f7
-		"706a46dc76dcb76798e60e6d89474788d16dc18032d268fd1a704fa6",
8178f7
-		"e3d4895843da188fd58fb0567976d7b50359d6b78530c8f62d1b1746",
8178f7
-	},
8178f7
-	{
8178f7
-		"26959946667150639794667015087019625940457807714424391721682722368060",
8178f7
-		"b70e0cbd6bb4bf7f321390b94a03c1d356c21122343280d6115c1d21",
8178f7
-		"42c89c774a08dc04b3dd201932bc8a5ea5f8b89bbb2a7e667aff81cd",
8178f7
-	},
8178f7
-}
8178f7
-
8178f7
-func TestBaseMult(t *testing.T) {
8178f7
-	p224 := P224()
8178f7
-	for i, e := range p224BaseMultTests {
8178f7
-		k, ok := new(big.Int).SetString(e.k, 10)
8178f7
-		if !ok {
8178f7
-			t.Errorf("%d: bad value for k: %s", i, e.k)
8178f7
-		}
8178f7
-		x, y := p224.ScalarBaseMult(k.Bytes())
8178f7
-		if fmt.Sprintf("%x", x) != e.x || fmt.Sprintf("%x", y) != e.y {
8178f7
-			t.Errorf("%d: bad output for k=%s: got (%x, %x), want (%s, %s)", i, e.k, x, y, e.x, e.y)
8178f7
-		}
8178f7
-		if testing.Short() && i > 5 {
8178f7
-			break
8178f7
-		}
8178f7
-	}
8178f7
-}
8178f7
-
8178f7
-func TestGenericBaseMult(t *testing.T) {
8178f7
-	// We use the P224 CurveParams directly in order to test the generic implementation.
8178f7
-	p224 := P224().Params()
8178f7
-	for i, e := range p224BaseMultTests {
8178f7
-		k, ok := new(big.Int).SetString(e.k, 10)
8178f7
-		if !ok {
8178f7
-			t.Errorf("%d: bad value for k: %s", i, e.k)
8178f7
-		}
8178f7
-		x, y := p224.ScalarBaseMult(k.Bytes())
8178f7
-		if fmt.Sprintf("%x", x) != e.x || fmt.Sprintf("%x", y) != e.y {
8178f7
-			t.Errorf("%d: bad output for k=%s: got (%x, %x), want (%s, %s)", i, e.k, x, y, e.x, e.y)
8178f7
-		}
8178f7
-		if testing.Short() && i > 5 {
8178f7
-			break
8178f7
-		}
8178f7
-	}
8178f7
-}
8178f7
-
8178f7
 func TestInfinity(t *testing.T) {
8178f7
 	tests := []struct {
8178f7
 		name  string
8178f7
 		curve Curve
8178f7
 	}{
8178f7
-		{"p224", P224()},
8178f7
 		{"p256", P256()},
8178f7
 	}
8178f7
 
8178f7
@@ -359,43 +44,3 @@ func TestInfinity(t *testing.T) {
8178f7
 		}
8178f7
 	}
8178f7
 }
8178f7
-
8178f7
-func BenchmarkBaseMult(b *testing.B) {
8178f7
-	b.ResetTimer()
8178f7
-	p224 := P224()
8178f7
-	e := p224BaseMultTests[25]
8178f7
-	k, _ := new(big.Int).SetString(e.k, 10)
8178f7
-	b.StartTimer()
8178f7
-	for i := 0; i < b.N; i++ {
8178f7
-		p224.ScalarBaseMult(k.Bytes())
8178f7
-	}
8178f7
-}
8178f7
-
8178f7
-func TestMarshal(t *testing.T) {
8178f7
-	p224 := P224()
8178f7
-	_, x, y, err := GenerateKey(p224, rand.Reader)
8178f7
-	if err != nil {
8178f7
-		t.Error(err)
8178f7
-		return
8178f7
-	}
8178f7
-	serialized := Marshal(p224, x, y)
8178f7
-	xx, yy := Unmarshal(p224, serialized)
8178f7
-	if xx == nil {
8178f7
-		t.Error("failed to unmarshal")
8178f7
-		return
8178f7
-	}
8178f7
-	if xx.Cmp(x) != 0 || yy.Cmp(y) != 0 {
8178f7
-		t.Error("unmarshal returned different values")
8178f7
-		return
8178f7
-	}
8178f7
-}
8178f7
-
8178f7
-func TestP224Overflow(t *testing.T) {
8178f7
-	// This tests for a specific bug in the P224 implementation.
8178f7
-	p224 := P224()
8178f7
-	pointData, _ := hex.DecodeString("049B535B45FB0A2072398A6831834624C7E32CCFD5A4B933BCEAF77F1DD945E08BBE5178F5EDF5E733388F196D2A631D2E075BB16CBFEEA15B")
8178f7
-	x, y := Unmarshal(p224, pointData)
8178f7
-	if !p224.IsOnCurve(x, y) {
8178f7
-		t.Error("P224 failed to validate a correct point")
8178f7
-	}
8178f7
-}
8178f7
--- libgo/go/crypto/ecdsa/ecdsa_test.go.jj	2012-12-13 11:32:02.589039782 +0100
8178f7
+++ libgo/go/crypto/ecdsa/ecdsa_test.go	2014-02-18 17:28:22.909692022 +0100
8178f7
@@ -33,7 +33,6 @@ func testKeyGeneration(t *testing.T, c e
8178f7
 }
8178f7
 
8178f7
 func TestKeyGeneration(t *testing.T) {
8178f7
-	testKeyGeneration(t, elliptic.P224(), "p224")
8178f7
 	if testing.Short() {
8178f7
 		return
8178f7
 	}
8178f7
@@ -63,7 +62,6 @@ func testSignAndVerify(t *testing.T, c e
8178f7
 }
8178f7
 
8178f7
 func TestSignAndVerify(t *testing.T) {
8178f7
-	testSignAndVerify(t, elliptic.P224(), "p224")
8178f7
 	if testing.Short() {
8178f7
 		return
8178f7
 	}
8178f7
@@ -129,8 +127,6 @@ func TestVectors(t *testing.T) {
8178f7
 			parts := strings.SplitN(line, ",", 2)
8178f7
 
8178f7
 			switch parts[0] {
8178f7
-			case "P-224":
8178f7
-				pub.Curve = elliptic.P224()
8178f7
 			case "P-256":
8178f7
 				pub.Curve = elliptic.P256()
8178f7
 			case "P-384":
8178f7
--- libgo/go/crypto/x509/x509.go.jj	2013-08-14 13:55:08.939843607 +0200
8178f7
+++ libgo/go/crypto/x509/x509.go	2014-02-18 17:28:22.943691764 +0100
8178f7
@@ -283,9 +283,6 @@ func getPublicKeyAlgorithmFromOID(oid as
8178f7
 
8178f7
 // RFC 5480, 2.1.1.1. Named Curve
8178f7
 //
8178f7
-// secp224r1 OBJECT IDENTIFIER ::= {
8178f7
-//   iso(1) identified-organization(3) certicom(132) curve(0) 33 }
8178f7
-//
8178f7
 // secp256r1 OBJECT IDENTIFIER ::= {
8178f7
 //   iso(1) member-body(2) us(840) ansi-X9-62(10045) curves(3)
8178f7
 //   prime(1) 7 }
8178f7
@@ -298,7 +295,6 @@ func getPublicKeyAlgorithmFromOID(oid as
8178f7
 //
8178f7
 // NB: secp256r1 is equivalent to prime256v1
8178f7
 var (
8178f7
-	oidNamedCurveP224 = asn1.ObjectIdentifier{1, 3, 132, 0, 33}
8178f7
 	oidNamedCurveP256 = asn1.ObjectIdentifier{1, 2, 840, 10045, 3, 1, 7}
8178f7
 	oidNamedCurveP384 = asn1.ObjectIdentifier{1, 3, 132, 0, 34}
8178f7
 	oidNamedCurveP521 = asn1.ObjectIdentifier{1, 3, 132, 0, 35}
8178f7
@@ -306,8 +302,6 @@ var (
8178f7
 
8178f7
 func namedCurveFromOID(oid asn1.ObjectIdentifier) elliptic.Curve {
8178f7
 	switch {
8178f7
-	case oid.Equal(oidNamedCurveP224):
8178f7
-		return elliptic.P224()
8178f7
 	case oid.Equal(oidNamedCurveP256):
8178f7
 		return elliptic.P256()
8178f7
 	case oid.Equal(oidNamedCurveP384):
8178f7
@@ -320,8 +314,6 @@ func namedCurveFromOID(oid asn1.ObjectId
8178f7
 
8178f7
 func oidFromNamedCurve(curve elliptic.Curve) (asn1.ObjectIdentifier, bool) {
8178f7
 	switch curve {
8178f7
-	case elliptic.P224():
8178f7
-		return oidNamedCurveP224, true
8178f7
 	case elliptic.P256():
8178f7
 		return oidNamedCurveP256, true
8178f7
 	case elliptic.P384():
8178f7
@@ -1212,7 +1204,7 @@ func CreateCertificate(rand io.Reader, t
8178f7
 		hashFunc = crypto.SHA1
8178f7
 	case *ecdsa.PrivateKey:
8178f7
 		switch priv.Curve {
8178f7
-		case elliptic.P224(), elliptic.P256():
8178f7
+		case elliptic.P256():
8178f7
 			hashFunc = crypto.SHA256
8178f7
 			signatureAlgorithm.Algorithm = oidSignatureECDSAWithSHA256
8178f7
 		case elliptic.P384():
8178f7
--- libgo/go/crypto/elliptic/p224.go.jj	2012-12-13 11:32:02.641039533 +0100
8178f7
+++ libgo/go/crypto/elliptic/p224.go	2014-02-15 11:40:56.191557928 +0100
8178f7
@@ -1,765 +0,0 @@
8178f7
-// Copyright 2012 The Go Authors.  All rights reserved.
8178f7
-// Use of this source code is governed by a BSD-style
8178f7
-// license that can be found in the LICENSE file.
8178f7
-
8178f7
-package elliptic
8178f7
-
8178f7
-// This is a constant-time, 32-bit implementation of P224. See FIPS 186-3,
8178f7
-// section D.2.2.
8178f7
-//
8178f7
-// See http://www.imperialviolet.org/2010/12/04/ecc.html ([1]) for background.
8178f7
-
8178f7
-import (
8178f7
-	"math/big"
8178f7
-)
8178f7
-
8178f7
-var p224 p224Curve
8178f7
-
8178f7
-type p224Curve struct {
8178f7
-	*CurveParams
8178f7
-	gx, gy, b p224FieldElement
8178f7
-}
8178f7
-
8178f7
-func initP224() {
8178f7
-	// See FIPS 186-3, section D.2.2
8178f7
-	p224.CurveParams = new(CurveParams)
8178f7
-	p224.P, _ = new(big.Int).SetString("26959946667150639794667015087019630673557916260026308143510066298881", 10)
8178f7
-	p224.N, _ = new(big.Int).SetString("26959946667150639794667015087019625940457807714424391721682722368061", 10)
8178f7
-	p224.B, _ = new(big.Int).SetString("b4050a850c04b3abf54132565044b0b7d7bfd8ba270b39432355ffb4", 16)
8178f7
-	p224.Gx, _ = new(big.Int).SetString("b70e0cbd6bb4bf7f321390b94a03c1d356c21122343280d6115c1d21", 16)
8178f7
-	p224.Gy, _ = new(big.Int).SetString("bd376388b5f723fb4c22dfe6cd4375a05a07476444d5819985007e34", 16)
8178f7
-	p224.BitSize = 224
8178f7
-
8178f7
-	p224FromBig(&p224.gx, p224.Gx)
8178f7
-	p224FromBig(&p224.gy, p224.Gy)
8178f7
-	p224FromBig(&p224.b, p224.B)
8178f7
-}
8178f7
-
8178f7
-// P224 returns a Curve which implements P-224 (see FIPS 186-3, section D.2.2)
8178f7
-func P224() Curve {
8178f7
-	initonce.Do(initAll)
8178f7
-	return p224
8178f7
-}
8178f7
-
8178f7
-func (curve p224Curve) Params() *CurveParams {
8178f7
-	return curve.CurveParams
8178f7
-}
8178f7
-
8178f7
-func (curve p224Curve) IsOnCurve(bigX, bigY *big.Int) bool {
8178f7
-	var x, y p224FieldElement
8178f7
-	p224FromBig(&x, bigX)
8178f7
-	p224FromBig(&y, bigY)
8178f7
-
8178f7
-	// y² = x³ - 3x + b
8178f7
-	var tmp p224LargeFieldElement
8178f7
-	var x3 p224FieldElement
8178f7
-	p224Square(&x3, &x, &tmp)
8178f7
-	p224Mul(&x3, &x3, &x, &tmp)
8178f7
-
8178f7
-	for i := 0; i < 8; i++ {
8178f7
-		x[i] *= 3
8178f7
-	}
8178f7
-	p224Sub(&x3, &x3, &x)
8178f7
-	p224Reduce(&x3)
8178f7
-	p224Add(&x3, &x3, &curve.b)
8178f7
-	p224Contract(&x3, &x3)
8178f7
-
8178f7
-	p224Square(&y, &y, &tmp)
8178f7
-	p224Contract(&y, &y)
8178f7
-
8178f7
-	for i := 0; i < 8; i++ {
8178f7
-		if y[i] != x3[i] {
8178f7
-			return false
8178f7
-		}
8178f7
-	}
8178f7
-	return true
8178f7
-}
8178f7
-
8178f7
-func (p224Curve) Add(bigX1, bigY1, bigX2, bigY2 *big.Int) (x, y *big.Int) {
8178f7
-	var x1, y1, z1, x2, y2, z2, x3, y3, z3 p224FieldElement
8178f7
-
8178f7
-	p224FromBig(&x1, bigX1)
8178f7
-	p224FromBig(&y1, bigY1)
8178f7
-	if bigX1.Sign() != 0 || bigY1.Sign() != 0 {
8178f7
-		z1[0] = 1
8178f7
-	}
8178f7
-	p224FromBig(&x2, bigX2)
8178f7
-	p224FromBig(&y2, bigY2)
8178f7
-	if bigX2.Sign() != 0 || bigY2.Sign() != 0 {
8178f7
-		z2[0] = 1
8178f7
-	}
8178f7
-
8178f7
-	p224AddJacobian(&x3, &y3, &z3, &x1, &y1, &z1, &x2, &y2, &z2)
8178f7
-	return p224ToAffine(&x3, &y3, &z3)
8178f7
-}
8178f7
-
8178f7
-func (p224Curve) Double(bigX1, bigY1 *big.Int) (x, y *big.Int) {
8178f7
-	var x1, y1, z1, x2, y2, z2 p224FieldElement
8178f7
-
8178f7
-	p224FromBig(&x1, bigX1)
8178f7
-	p224FromBig(&y1, bigY1)
8178f7
-	z1[0] = 1
8178f7
-
8178f7
-	p224DoubleJacobian(&x2, &y2, &z2, &x1, &y1, &z1)
8178f7
-	return p224ToAffine(&x2, &y2, &z2)
8178f7
-}
8178f7
-
8178f7
-func (p224Curve) ScalarMult(bigX1, bigY1 *big.Int, scalar []byte) (x, y *big.Int) {
8178f7
-	var x1, y1, z1, x2, y2, z2 p224FieldElement
8178f7
-
8178f7
-	p224FromBig(&x1, bigX1)
8178f7
-	p224FromBig(&y1, bigY1)
8178f7
-	z1[0] = 1
8178f7
-
8178f7
-	p224ScalarMult(&x2, &y2, &z2, &x1, &y1, &z1, scalar)
8178f7
-	return p224ToAffine(&x2, &y2, &z2)
8178f7
-}
8178f7
-
8178f7
-func (curve p224Curve) ScalarBaseMult(scalar []byte) (x, y *big.Int) {
8178f7
-	var z1, x2, y2, z2 p224FieldElement
8178f7
-
8178f7
-	z1[0] = 1
8178f7
-	p224ScalarMult(&x2, &y2, &z2, &curve.gx, &curve.gy, &z1, scalar)
8178f7
-	return p224ToAffine(&x2, &y2, &z2)
8178f7
-}
8178f7
-
8178f7
-// Field element functions.
8178f7
-//
8178f7
-// The field that we're dealing with is ℤ/pℤ where p = 2**224 - 2**96 + 1.
8178f7
-//
8178f7
-// Field elements are represented by a FieldElement, which is a typedef to an
8178f7
-// array of 8 uint32's. The value of a FieldElement, a, is:
8178f7
-//   a[0] + 2**28·a[1] + 2**56·a[1] + ... + 2**196·a[7]
8178f7
-//
8178f7
-// Using 28-bit limbs means that there's only 4 bits of headroom, which is less
8178f7
-// than we would really like. But it has the useful feature that we hit 2**224
8178f7
-// exactly, making the reflections during a reduce much nicer.
8178f7
-type p224FieldElement [8]uint32
8178f7
-
8178f7
-// p224P is the order of the field, represented as a p224FieldElement.
8178f7
-var p224P = [8]uint32{1, 0, 0, 0xffff000, 0xfffffff, 0xfffffff, 0xfffffff, 0xfffffff}
8178f7
-
8178f7
-// p224IsZero returns 1 if a == 0 mod p and 0 otherwise.
8178f7
-//
8178f7
-// a[i] < 2**29
8178f7
-func p224IsZero(a *p224FieldElement) uint32 {
8178f7
-	// Since a p224FieldElement contains 224 bits there are two possible
8178f7
-	// representations of 0: 0 and p.
8178f7
-	var minimal p224FieldElement
8178f7
-	p224Contract(&minimal, a)
8178f7
-
8178f7
-	var isZero, isP uint32
8178f7
-	for i, v := range minimal {
8178f7
-		isZero |= v
8178f7
-		isP |= v - p224P[i]
8178f7
-	}
8178f7
-
8178f7
-	// If either isZero or isP is 0, then we should return 1.
8178f7
-	isZero |= isZero >> 16
8178f7
-	isZero |= isZero >> 8
8178f7
-	isZero |= isZero >> 4
8178f7
-	isZero |= isZero >> 2
8178f7
-	isZero |= isZero >> 1
8178f7
-
8178f7
-	isP |= isP >> 16
8178f7
-	isP |= isP >> 8
8178f7
-	isP |= isP >> 4
8178f7
-	isP |= isP >> 2
8178f7
-	isP |= isP >> 1
8178f7
-
8178f7
-	// For isZero and isP, the LSB is 0 iff all the bits are zero.
8178f7
-	result := isZero & isP
8178f7
-	result = (^result) & 1
8178f7
-
8178f7
-	return result
8178f7
-}
8178f7
-
8178f7
-// p224Add computes *out = a+b
8178f7
-//
8178f7
-// a[i] + b[i] < 2**32
8178f7
-func p224Add(out, a, b *p224FieldElement) {
8178f7
-	for i := 0; i < 8; i++ {
8178f7
-		out[i] = a[i] + b[i]
8178f7
-	}
8178f7
-}
8178f7
-
8178f7
-const two31p3 = 1<<31 + 1<<3
8178f7
-const two31m3 = 1<<31 - 1<<3
8178f7
-const two31m15m3 = 1<<31 - 1<<15 - 1<<3
8178f7
-
8178f7
-// p224ZeroModP31 is 0 mod p where bit 31 is set in all limbs so that we can
8178f7
-// subtract smaller amounts without underflow. See the section "Subtraction" in
8178f7
-// [1] for reasoning.
8178f7
-var p224ZeroModP31 = []uint32{two31p3, two31m3, two31m3, two31m15m3, two31m3, two31m3, two31m3, two31m3}
8178f7
-
8178f7
-// p224Sub computes *out = a-b
8178f7
-//
8178f7
-// a[i], b[i] < 2**30
8178f7
-// out[i] < 2**32
8178f7
-func p224Sub(out, a, b *p224FieldElement) {
8178f7
-	for i := 0; i < 8; i++ {
8178f7
-		out[i] = a[i] + p224ZeroModP31[i] - b[i]
8178f7
-	}
8178f7
-}
8178f7
-
8178f7
-// LargeFieldElement also represents an element of the field. The limbs are
8178f7
-// still spaced 28-bits apart and in little-endian order. So the limbs are at
8178f7
-// 0, 28, 56, ..., 392 bits, each 64-bits wide.
8178f7
-type p224LargeFieldElement [15]uint64
8178f7
-
8178f7
-const two63p35 = 1<<63 + 1<<35
8178f7
-const two63m35 = 1<<63 - 1<<35
8178f7
-const two63m35m19 = 1<<63 - 1<<35 - 1<<19
8178f7
-
8178f7
-// p224ZeroModP63 is 0 mod p where bit 63 is set in all limbs. See the section
8178f7
-// "Subtraction" in [1] for why.
8178f7
-var p224ZeroModP63 = [8]uint64{two63p35, two63m35, two63m35, two63m35, two63m35m19, two63m35, two63m35, two63m35}
8178f7
-
8178f7
-const bottom12Bits = 0xfff
8178f7
-const bottom28Bits = 0xfffffff
8178f7
-
8178f7
-// p224Mul computes *out = a*b
8178f7
-//
8178f7
-// a[i] < 2**29, b[i] < 2**30 (or vice versa)
8178f7
-// out[i] < 2**29
8178f7
-func p224Mul(out, a, b *p224FieldElement, tmp *p224LargeFieldElement) {
8178f7
-	for i := 0; i < 15; i++ {
8178f7
-		tmp[i] = 0
8178f7
-	}
8178f7
-
8178f7
-	for i := 0; i < 8; i++ {
8178f7
-		for j := 0; j < 8; j++ {
8178f7
-			tmp[i+j] += uint64(a[i]) * uint64(b[j])
8178f7
-		}
8178f7
-	}
8178f7
-
8178f7
-	p224ReduceLarge(out, tmp)
8178f7
-}
8178f7
-
8178f7
-// Square computes *out = a*a
8178f7
-//
8178f7
-// a[i] < 2**29
8178f7
-// out[i] < 2**29
8178f7
-func p224Square(out, a *p224FieldElement, tmp *p224LargeFieldElement) {
8178f7
-	for i := 0; i < 15; i++ {
8178f7
-		tmp[i] = 0
8178f7
-	}
8178f7
-
8178f7
-	for i := 0; i < 8; i++ {
8178f7
-		for j := 0; j <= i; j++ {
8178f7
-			r := uint64(a[i]) * uint64(a[j])
8178f7
-			if i == j {
8178f7
-				tmp[i+j] += r
8178f7
-			} else {
8178f7
-				tmp[i+j] += r << 1
8178f7
-			}
8178f7
-		}
8178f7
-	}
8178f7
-
8178f7
-	p224ReduceLarge(out, tmp)
8178f7
-}
8178f7
-
8178f7
-// ReduceLarge converts a p224LargeFieldElement to a p224FieldElement.
8178f7
-//
8178f7
-// in[i] < 2**62
8178f7
-func p224ReduceLarge(out *p224FieldElement, in *p224LargeFieldElement) {
8178f7
-	for i := 0; i < 8; i++ {
8178f7
-		in[i] += p224ZeroModP63[i]
8178f7
-	}
8178f7
-
8178f7
-	// Eliminate the coefficients at 2**224 and greater.
8178f7
-	for i := 14; i >= 8; i-- {
8178f7
-		in[i-8] -= in[i]
8178f7
-		in[i-5] += (in[i] & 0xffff) << 12
8178f7
-		in[i-4] += in[i] >> 16
8178f7
-	}
8178f7
-	in[8] = 0
8178f7
-	// in[0..8] < 2**64
8178f7
-
8178f7
-	// As the values become small enough, we start to store them in |out|
8178f7
-	// and use 32-bit operations.
8178f7
-	for i := 1; i < 8; i++ {
8178f7
-		in[i+1] += in[i] >> 28
8178f7
-		out[i] = uint32(in[i] & bottom28Bits)
8178f7
-	}
8178f7
-	in[0] -= in[8]
8178f7
-	out[3] += uint32(in[8]&0xffff) << 12
8178f7
-	out[4] += uint32(in[8] >> 16)
8178f7
-	// in[0] < 2**64
8178f7
-	// out[3] < 2**29
8178f7
-	// out[4] < 2**29
8178f7
-	// out[1,2,5..7] < 2**28
8178f7
-
8178f7
-	out[0] = uint32(in[0] & bottom28Bits)
8178f7
-	out[1] += uint32((in[0] >> 28) & bottom28Bits)
8178f7
-	out[2] += uint32(in[0] >> 56)
8178f7
-	// out[0] < 2**28
8178f7
-	// out[1..4] < 2**29
8178f7
-	// out[5..7] < 2**28
8178f7
-}
8178f7
-
8178f7
-// Reduce reduces the coefficients of a to smaller bounds.
8178f7
-//
8178f7
-// On entry: a[i] < 2**31 + 2**30
8178f7
-// On exit: a[i] < 2**29
8178f7
-func p224Reduce(a *p224FieldElement) {
8178f7
-	for i := 0; i < 7; i++ {
8178f7
-		a[i+1] += a[i] >> 28
8178f7
-		a[i] &= bottom28Bits
8178f7
-	}
8178f7
-	top := a[7] >> 28
8178f7
-	a[7] &= bottom28Bits
8178f7
-
8178f7
-	// top < 2**4
8178f7
-	mask := top
8178f7
-	mask |= mask >> 2
8178f7
-	mask |= mask >> 1
8178f7
-	mask <<= 31
8178f7
-	mask = uint32(int32(mask) >> 31)
8178f7
-	// Mask is all ones if top != 0, all zero otherwise
8178f7
-
8178f7
-	a[0] -= top
8178f7
-	a[3] += top << 12
8178f7
-
8178f7
-	// We may have just made a[0] negative but, if we did, then we must
8178f7
-	// have added something to a[3], this it's > 2**12. Therefore we can
8178f7
-	// carry down to a[0].
8178f7
-	a[3] -= 1 & mask
8178f7
-	a[2] += mask & (1<<28 - 1)
8178f7
-	a[1] += mask & (1<<28 - 1)
8178f7
-	a[0] += mask & (1 << 28)
8178f7
-}
8178f7
-
8178f7
-// p224Invert calculates *out = in**-1 by computing in**(2**224 - 2**96 - 1),
8178f7
-// i.e. Fermat's little theorem.
8178f7
-func p224Invert(out, in *p224FieldElement) {
8178f7
-	var f1, f2, f3, f4 p224FieldElement
8178f7
-	var c p224LargeFieldElement
8178f7
-
8178f7
-	p224Square(&f1, in, &c)    // 2
8178f7
-	p224Mul(&f1, &f1, in, &c)  // 2**2 - 1
8178f7
-	p224Square(&f1, &f1, &c)   // 2**3 - 2
8178f7
-	p224Mul(&f1, &f1, in, &c)  // 2**3 - 1
8178f7
-	p224Square(&f2, &f1, &c)   // 2**4 - 2
8178f7
-	p224Square(&f2, &f2, &c)   // 2**5 - 4
8178f7
-	p224Square(&f2, &f2, &c)   // 2**6 - 8
8178f7
-	p224Mul(&f1, &f1, &f2, &c) // 2**6 - 1
8178f7
-	p224Square(&f2, &f1, &c)   // 2**7 - 2
8178f7
-	for i := 0; i < 5; i++ {   // 2**12 - 2**6
8178f7
-		p224Square(&f2, &f2, &c)
8178f7
-	}
8178f7
-	p224Mul(&f2, &f2, &f1, &c) // 2**12 - 1
8178f7
-	p224Square(&f3, &f2, &c)   // 2**13 - 2
8178f7
-	for i := 0; i < 11; i++ {  // 2**24 - 2**12
8178f7
-		p224Square(&f3, &f3, &c)
8178f7
-	}
8178f7
-	p224Mul(&f2, &f3, &f2, &c) // 2**24 - 1
8178f7
-	p224Square(&f3, &f2, &c)   // 2**25 - 2
8178f7
-	for i := 0; i < 23; i++ {  // 2**48 - 2**24
8178f7
-		p224Square(&f3, &f3, &c)
8178f7
-	}
8178f7
-	p224Mul(&f3, &f3, &f2, &c) // 2**48 - 1
8178f7
-	p224Square(&f4, &f3, &c)   // 2**49 - 2
8178f7
-	for i := 0; i < 47; i++ {  // 2**96 - 2**48
8178f7
-		p224Square(&f4, &f4, &c)
8178f7
-	}
8178f7
-	p224Mul(&f3, &f3, &f4, &c) // 2**96 - 1
8178f7
-	p224Square(&f4, &f3, &c)   // 2**97 - 2
8178f7
-	for i := 0; i < 23; i++ {  // 2**120 - 2**24
8178f7
-		p224Square(&f4, &f4, &c)
8178f7
-	}
8178f7
-	p224Mul(&f2, &f4, &f2, &c) // 2**120 - 1
8178f7
-	for i := 0; i < 6; i++ {   // 2**126 - 2**6
8178f7
-		p224Square(&f2, &f2, &c)
8178f7
-	}
8178f7
-	p224Mul(&f1, &f1, &f2, &c) // 2**126 - 1
8178f7
-	p224Square(&f1, &f1, &c)   // 2**127 - 2
8178f7
-	p224Mul(&f1, &f1, in, &c)  // 2**127 - 1
8178f7
-	for i := 0; i < 97; i++ {  // 2**224 - 2**97
8178f7
-		p224Square(&f1, &f1, &c)
8178f7
-	}
8178f7
-	p224Mul(out, &f1, &f3, &c) // 2**224 - 2**96 - 1
8178f7
-}
8178f7
-
8178f7
-// p224Contract converts a FieldElement to its unique, minimal form.
8178f7
-//
8178f7
-// On entry, in[i] < 2**29
8178f7
-// On exit, in[i] < 2**28
8178f7
-func p224Contract(out, in *p224FieldElement) {
8178f7
-	copy(out[:], in[:])
8178f7
-
8178f7
-	for i := 0; i < 7; i++ {
8178f7
-		out[i+1] += out[i] >> 28
8178f7
-		out[i] &= bottom28Bits
8178f7
-	}
8178f7
-	top := out[7] >> 28
8178f7
-	out[7] &= bottom28Bits
8178f7
-
8178f7
-	out[0] -= top
8178f7
-	out[3] += top << 12
8178f7
-
8178f7
-	// We may just have made out[i] negative. So we carry down. If we made
8178f7
-	// out[0] negative then we know that out[3] is sufficiently positive
8178f7
-	// because we just added to it.
8178f7
-	for i := 0; i < 3; i++ {
8178f7
-		mask := uint32(int32(out[i]) >> 31)
8178f7
-		out[i] += (1 << 28) & mask
8178f7
-		out[i+1] -= 1 & mask
8178f7
-	}
8178f7
-
8178f7
-	// We might have pushed out[3] over 2**28 so we perform another, partial,
8178f7
-	// carry chain.
8178f7
-	for i := 3; i < 7; i++ {
8178f7
-		out[i+1] += out[i] >> 28
8178f7
-		out[i] &= bottom28Bits
8178f7
-	}
8178f7
-	top = out[7] >> 28
8178f7
-	out[7] &= bottom28Bits
8178f7
-
8178f7
-	// Eliminate top while maintaining the same value mod p.
8178f7
-	out[0] -= top
8178f7
-	out[3] += top << 12
8178f7
-
8178f7
-	// There are two cases to consider for out[3]:
8178f7
-	//   1) The first time that we eliminated top, we didn't push out[3] over
8178f7
-	//      2**28. In this case, the partial carry chain didn't change any values
8178f7
-	//      and top is zero.
8178f7
-	//   2) We did push out[3] over 2**28 the first time that we eliminated top.
8178f7
-	//      The first value of top was in [0..16), therefore, prior to eliminating
8178f7
-	//      the first top, 0xfff1000 <= out[3] <= 0xfffffff. Therefore, after
8178f7
-	//      overflowing and being reduced by the second carry chain, out[3] <=
8178f7
-	//      0xf000. Thus it cannot have overflowed when we eliminated top for the
8178f7
-	//      second time.
8178f7
-
8178f7
-	// Again, we may just have made out[0] negative, so do the same carry down.
8178f7
-	// As before, if we made out[0] negative then we know that out[3] is
8178f7
-	// sufficiently positive.
8178f7
-	for i := 0; i < 3; i++ {
8178f7
-		mask := uint32(int32(out[i]) >> 31)
8178f7
-		out[i] += (1 << 28) & mask
8178f7
-		out[i+1] -= 1 & mask
8178f7
-	}
8178f7
-
8178f7
-	// Now we see if the value is >= p and, if so, subtract p.
8178f7
-
8178f7
-	// First we build a mask from the top four limbs, which must all be
8178f7
-	// equal to bottom28Bits if the whole value is >= p. If top4AllOnes
8178f7
-	// ends up with any zero bits in the bottom 28 bits, then this wasn't
8178f7
-	// true.
8178f7
-	top4AllOnes := uint32(0xffffffff)
8178f7
-	for i := 4; i < 8; i++ {
8178f7
-		top4AllOnes &= out[i]
8178f7
-	}
8178f7
-	top4AllOnes |= 0xf0000000
8178f7
-	// Now we replicate any zero bits to all the bits in top4AllOnes.
8178f7
-	top4AllOnes &= top4AllOnes >> 16
8178f7
-	top4AllOnes &= top4AllOnes >> 8
8178f7
-	top4AllOnes &= top4AllOnes >> 4
8178f7
-	top4AllOnes &= top4AllOnes >> 2
8178f7
-	top4AllOnes &= top4AllOnes >> 1
8178f7
-	top4AllOnes = uint32(int32(top4AllOnes<<31) >> 31)
8178f7
-
8178f7
-	// Now we test whether the bottom three limbs are non-zero.
8178f7
-	bottom3NonZero := out[0] | out[1] | out[2]
8178f7
-	bottom3NonZero |= bottom3NonZero >> 16
8178f7
-	bottom3NonZero |= bottom3NonZero >> 8
8178f7
-	bottom3NonZero |= bottom3NonZero >> 4
8178f7
-	bottom3NonZero |= bottom3NonZero >> 2
8178f7
-	bottom3NonZero |= bottom3NonZero >> 1
8178f7
-	bottom3NonZero = uint32(int32(bottom3NonZero<<31) >> 31)
8178f7
-
8178f7
-	// Everything depends on the value of out[3].
8178f7
-	//    If it's > 0xffff000 and top4AllOnes != 0 then the whole value is >= p
8178f7
-	//    If it's = 0xffff000 and top4AllOnes != 0 and bottom3NonZero != 0,
8178f7
-	//      then the whole value is >= p
8178f7
-	//    If it's < 0xffff000, then the whole value is < p
8178f7
-	n := out[3] - 0xffff000
8178f7
-	out3Equal := n
8178f7
-	out3Equal |= out3Equal >> 16
8178f7
-	out3Equal |= out3Equal >> 8
8178f7
-	out3Equal |= out3Equal >> 4
8178f7
-	out3Equal |= out3Equal >> 2
8178f7
-	out3Equal |= out3Equal >> 1
8178f7
-	out3Equal = ^uint32(int32(out3Equal<<31) >> 31)
8178f7
-
8178f7
-	// If out[3] > 0xffff000 then n's MSB will be zero.
8178f7
-	out3GT := ^uint32(int32(n) >> 31)
8178f7
-
8178f7
-	mask := top4AllOnes & ((out3Equal & bottom3NonZero) | out3GT)
8178f7
-	out[0] -= 1 & mask
8178f7
-	out[3] -= 0xffff000 & mask
8178f7
-	out[4] -= 0xfffffff & mask
8178f7
-	out[5] -= 0xfffffff & mask
8178f7
-	out[6] -= 0xfffffff & mask
8178f7
-	out[7] -= 0xfffffff & mask
8178f7
-}
8178f7
-
8178f7
-// Group element functions.
8178f7
-//
8178f7
-// These functions deal with group elements. The group is an elliptic curve
8178f7
-// group with a = -3 defined in FIPS 186-3, section D.2.2.
8178f7
-
8178f7
-// p224AddJacobian computes *out = a+b where a != b.
8178f7
-func p224AddJacobian(x3, y3, z3, x1, y1, z1, x2, y2, z2 *p224FieldElement) {
8178f7
-	// See http://hyperelliptic.org/EFD/g1p/auto-shortw-jacobian-3.html#addition-p224Add-2007-bl
8178f7
-	var z1z1, z2z2, u1, u2, s1, s2, h, i, j, r, v p224FieldElement
8178f7
-	var c p224LargeFieldElement
8178f7
-
8178f7
-	z1IsZero := p224IsZero(z1)
8178f7
-	z2IsZero := p224IsZero(z2)
8178f7
-
8178f7
-	// Z1Z1 = Z1²
8178f7
-	p224Square(&z1z1, z1, &c)
8178f7
-	// Z2Z2 = Z2²
8178f7
-	p224Square(&z2z2, z2, &c)
8178f7
-	// U1 = X1*Z2Z2
8178f7
-	p224Mul(&u1, x1, &z2z2, &c)
8178f7
-	// U2 = X2*Z1Z1
8178f7
-	p224Mul(&u2, x2, &z1z1, &c)
8178f7
-	// S1 = Y1*Z2*Z2Z2
8178f7
-	p224Mul(&s1, z2, &z2z2, &c)
8178f7
-	p224Mul(&s1, y1, &s1, &c)
8178f7
-	// S2 = Y2*Z1*Z1Z1
8178f7
-	p224Mul(&s2, z1, &z1z1, &c)
8178f7
-	p224Mul(&s2, y2, &s2, &c)
8178f7
-	// H = U2-U1
8178f7
-	p224Sub(&h, &u2, &u1)
8178f7
-	p224Reduce(&h)
8178f7
-	xEqual := p224IsZero(&h)
8178f7
-	// I = (2*H)²
8178f7
-	for j := 0; j < 8; j++ {
8178f7
-		i[j] = h[j] << 1
8178f7
-	}
8178f7
-	p224Reduce(&i)
8178f7
-	p224Square(&i, &i, &c)
8178f7
-	// J = H*I
8178f7
-	p224Mul(&j, &h, &i, &c)
8178f7
-	// r = 2*(S2-S1)
8178f7
-	p224Sub(&r, &s2, &s1)
8178f7
-	p224Reduce(&r)
8178f7
-	yEqual := p224IsZero(&r)
8178f7
-	if xEqual == 1 && yEqual == 1 && z1IsZero == 0 && z2IsZero == 0 {
8178f7
-		p224DoubleJacobian(x3, y3, z3, x1, y1, z1)
8178f7
-		return
8178f7
-	}
8178f7
-	for i := 0; i < 8; i++ {
8178f7
-		r[i] <<= 1
8178f7
-	}
8178f7
-	p224Reduce(&r)
8178f7
-	// V = U1*I
8178f7
-	p224Mul(&v, &u1, &i, &c)
8178f7
-	// Z3 = ((Z1+Z2)²-Z1Z1-Z2Z2)*H
8178f7
-	p224Add(&z1z1, &z1z1, &z2z2)
8178f7
-	p224Add(&z2z2, z1, z2)
8178f7
-	p224Reduce(&z2z2)
8178f7
-	p224Square(&z2z2, &z2z2, &c)
8178f7
-	p224Sub(z3, &z2z2, &z1z1)
8178f7
-	p224Reduce(z3)
8178f7
-	p224Mul(z3, z3, &h, &c)
8178f7
-	// X3 = r²-J-2*V
8178f7
-	for i := 0; i < 8; i++ {
8178f7
-		z1z1[i] = v[i] << 1
8178f7
-	}
8178f7
-	p224Add(&z1z1, &j, &z1z1)
8178f7
-	p224Reduce(&z1z1)
8178f7
-	p224Square(x3, &r, &c)
8178f7
-	p224Sub(x3, x3, &z1z1)
8178f7
-	p224Reduce(x3)
8178f7
-	// Y3 = r*(V-X3)-2*S1*J
8178f7
-	for i := 0; i < 8; i++ {
8178f7
-		s1[i] <<= 1
8178f7
-	}
8178f7
-	p224Mul(&s1, &s1, &j, &c)
8178f7
-	p224Sub(&z1z1, &v, x3)
8178f7
-	p224Reduce(&z1z1)
8178f7
-	p224Mul(&z1z1, &z1z1, &r, &c)
8178f7
-	p224Sub(y3, &z1z1, &s1)
8178f7
-	p224Reduce(y3)
8178f7
-
8178f7
-	p224CopyConditional(x3, x2, z1IsZero)
8178f7
-	p224CopyConditional(x3, x1, z2IsZero)
8178f7
-	p224CopyConditional(y3, y2, z1IsZero)
8178f7
-	p224CopyConditional(y3, y1, z2IsZero)
8178f7
-	p224CopyConditional(z3, z2, z1IsZero)
8178f7
-	p224CopyConditional(z3, z1, z2IsZero)
8178f7
-}
8178f7
-
8178f7
-// p224DoubleJacobian computes *out = a+a.
8178f7
-func p224DoubleJacobian(x3, y3, z3, x1, y1, z1 *p224FieldElement) {
8178f7
-	var delta, gamma, beta, alpha, t p224FieldElement
8178f7
-	var c p224LargeFieldElement
8178f7
-
8178f7
-	p224Square(&delta, z1, &c)
8178f7
-	p224Square(&gamma, y1, &c)
8178f7
-	p224Mul(&beta, x1, &gamma, &c)
8178f7
-
8178f7
-	// alpha = 3*(X1-delta)*(X1+delta)
8178f7
-	p224Add(&t, x1, &delta)
8178f7
-	for i := 0; i < 8; i++ {
8178f7
-		t[i] += t[i] << 1
8178f7
-	}
8178f7
-	p224Reduce(&t)
8178f7
-	p224Sub(&alpha, x1, &delta)
8178f7
-	p224Reduce(&alpha)
8178f7
-	p224Mul(&alpha, &alpha, &t, &c)
8178f7
-
8178f7
-	// Z3 = (Y1+Z1)²-gamma-delta
8178f7
-	p224Add(z3, y1, z1)
8178f7
-	p224Reduce(z3)
8178f7
-	p224Square(z3, z3, &c)
8178f7
-	p224Sub(z3, z3, &gamma)
8178f7
-	p224Reduce(z3)
8178f7
-	p224Sub(z3, z3, &delta)
8178f7
-	p224Reduce(z3)
8178f7
-
8178f7
-	// X3 = alpha²-8*beta
8178f7
-	for i := 0; i < 8; i++ {
8178f7
-		delta[i] = beta[i] << 3
8178f7
-	}
8178f7
-	p224Reduce(&delta)
8178f7
-	p224Square(x3, &alpha, &c)
8178f7
-	p224Sub(x3, x3, &delta)
8178f7
-	p224Reduce(x3)
8178f7
-
8178f7
-	// Y3 = alpha*(4*beta-X3)-8*gamma²
8178f7
-	for i := 0; i < 8; i++ {
8178f7
-		beta[i] <<= 2
8178f7
-	}
8178f7
-	p224Sub(&beta, &beta, x3)
8178f7
-	p224Reduce(&beta)
8178f7
-	p224Square(&gamma, &gamma, &c)
8178f7
-	for i := 0; i < 8; i++ {
8178f7
-		gamma[i] <<= 3
8178f7
-	}
8178f7
-	p224Reduce(&gamma)
8178f7
-	p224Mul(y3, &alpha, &beta, &c)
8178f7
-	p224Sub(y3, y3, &gamma)
8178f7
-	p224Reduce(y3)
8178f7
-}
8178f7
-
8178f7
-// p224CopyConditional sets *out = *in iff the least-significant-bit of control
8178f7
-// is true, and it runs in constant time.
8178f7
-func p224CopyConditional(out, in *p224FieldElement, control uint32) {
8178f7
-	control <<= 31
8178f7
-	control = uint32(int32(control) >> 31)
8178f7
-
8178f7
-	for i := 0; i < 8; i++ {
8178f7
-		out[i] ^= (out[i] ^ in[i]) & control
8178f7
-	}
8178f7
-}
8178f7
-
8178f7
-func p224ScalarMult(outX, outY, outZ, inX, inY, inZ *p224FieldElement, scalar []byte) {
8178f7
-	var xx, yy, zz p224FieldElement
8178f7
-	for i := 0; i < 8; i++ {
8178f7
-		outX[i] = 0
8178f7
-		outY[i] = 0
8178f7
-		outZ[i] = 0
8178f7
-	}
8178f7
-
8178f7
-	for _, byte := range scalar {
8178f7
-		for bitNum := uint(0); bitNum < 8; bitNum++ {
8178f7
-			p224DoubleJacobian(outX, outY, outZ, outX, outY, outZ)
8178f7
-			bit := uint32((byte >> (7 - bitNum)) & 1)
8178f7
-			p224AddJacobian(&xx, &yy, &zz, inX, inY, inZ, outX, outY, outZ)
8178f7
-			p224CopyConditional(outX, &xx, bit)
8178f7
-			p224CopyConditional(outY, &yy, bit)
8178f7
-			p224CopyConditional(outZ, &zz, bit)
8178f7
-		}
8178f7
-	}
8178f7
-}
8178f7
-
8178f7
-// p224ToAffine converts from Jacobian to affine form.
8178f7
-func p224ToAffine(x, y, z *p224FieldElement) (*big.Int, *big.Int) {
8178f7
-	var zinv, zinvsq, outx, outy p224FieldElement
8178f7
-	var tmp p224LargeFieldElement
8178f7
-
8178f7
-	if isPointAtInfinity := p224IsZero(z); isPointAtInfinity == 1 {
8178f7
-		return new(big.Int), new(big.Int)
8178f7
-	}
8178f7
-
8178f7
-	p224Invert(&zinv, z)
8178f7
-	p224Square(&zinvsq, &zinv, &tmp)
8178f7
-	p224Mul(x, x, &zinvsq, &tmp)
8178f7
-	p224Mul(&zinvsq, &zinvsq, &zinv, &tmp)
8178f7
-	p224Mul(y, y, &zinvsq, &tmp)
8178f7
-
8178f7
-	p224Contract(&outx, x)
8178f7
-	p224Contract(&outy, y)
8178f7
-	return p224ToBig(&outx), p224ToBig(&outy)
8178f7
-}
8178f7
-
8178f7
-// get28BitsFromEnd returns the least-significant 28 bits from buf>>shift,
8178f7
-// where buf is interpreted as a big-endian number.
8178f7
-func get28BitsFromEnd(buf []byte, shift uint) (uint32, []byte) {
8178f7
-	var ret uint32
8178f7
-
8178f7
-	for i := uint(0); i < 4; i++ {
8178f7
-		var b byte
8178f7
-		if l := len(buf); l > 0 {
8178f7
-			b = buf[l-1]
8178f7
-			// We don't remove the byte if we're about to return and we're not
8178f7
-			// reading all of it.
8178f7
-			if i != 3 || shift == 4 {
8178f7
-				buf = buf[:l-1]
8178f7
-			}
8178f7
-		}
8178f7
-		ret |= uint32(b) << (8 * i) >> shift
8178f7
-	}
8178f7
-	ret &= bottom28Bits
8178f7
-	return ret, buf
8178f7
-}
8178f7
-
8178f7
-// p224FromBig sets *out = *in.
8178f7
-func p224FromBig(out *p224FieldElement, in *big.Int) {
8178f7
-	bytes := in.Bytes()
8178f7
-	out[0], bytes = get28BitsFromEnd(bytes, 0)
8178f7
-	out[1], bytes = get28BitsFromEnd(bytes, 4)
8178f7
-	out[2], bytes = get28BitsFromEnd(bytes, 0)
8178f7
-	out[3], bytes = get28BitsFromEnd(bytes, 4)
8178f7
-	out[4], bytes = get28BitsFromEnd(bytes, 0)
8178f7
-	out[5], bytes = get28BitsFromEnd(bytes, 4)
8178f7
-	out[6], bytes = get28BitsFromEnd(bytes, 0)
8178f7
-	out[7], bytes = get28BitsFromEnd(bytes, 4)
8178f7
-}
8178f7
-
8178f7
-// p224ToBig returns in as a big.Int.
8178f7
-func p224ToBig(in *p224FieldElement) *big.Int {
8178f7
-	var buf [28]byte
8178f7
-	buf[27] = byte(in[0])
8178f7
-	buf[26] = byte(in[0] >> 8)
8178f7
-	buf[25] = byte(in[0] >> 16)
8178f7
-	buf[24] = byte(((in[0] >> 24) & 0x0f) | (in[1]<<4)&0xf0)
8178f7
-
8178f7
-	buf[23] = byte(in[1] >> 4)
8178f7
-	buf[22] = byte(in[1] >> 12)
8178f7
-	buf[21] = byte(in[1] >> 20)
8178f7
-
8178f7
-	buf[20] = byte(in[2])
8178f7
-	buf[19] = byte(in[2] >> 8)
8178f7
-	buf[18] = byte(in[2] >> 16)
8178f7
-	buf[17] = byte(((in[2] >> 24) & 0x0f) | (in[3]<<4)&0xf0)
8178f7
-
8178f7
-	buf[16] = byte(in[3] >> 4)
8178f7
-	buf[15] = byte(in[3] >> 12)
8178f7
-	buf[14] = byte(in[3] >> 20)
8178f7
-
8178f7
-	buf[13] = byte(in[4])
8178f7
-	buf[12] = byte(in[4] >> 8)
8178f7
-	buf[11] = byte(in[4] >> 16)
8178f7
-	buf[10] = byte(((in[4] >> 24) & 0x0f) | (in[5]<<4)&0xf0)
8178f7
-
8178f7
-	buf[9] = byte(in[5] >> 4)
8178f7
-	buf[8] = byte(in[5] >> 12)
8178f7
-	buf[7] = byte(in[5] >> 20)
8178f7
-
8178f7
-	buf[6] = byte(in[6])
8178f7
-	buf[5] = byte(in[6] >> 8)
8178f7
-	buf[4] = byte(in[6] >> 16)
8178f7
-	buf[3] = byte(((in[6] >> 24) & 0x0f) | (in[7]<<4)&0xf0)
8178f7
-
8178f7
-	buf[2] = byte(in[7] >> 4)
8178f7
-	buf[1] = byte(in[7] >> 12)
8178f7
-	buf[0] = byte(in[7] >> 20)
8178f7
-
8178f7
-	return new(big.Int).SetBytes(buf[:])
8178f7
-}
8178f7
--- libgo/go/crypto/elliptic/p224_test.go.jj	2014-02-18 18:03:31.615598561 +0100
8178f7
+++ libgo/go/crypto/elliptic/p224_test.go	2014-02-15 11:40:56.191557928 +0100
8178f7
@@ -1,47 +0,0 @@
8178f7
-// Copyright 2012 The Go Authors.  All rights reserved.
8178f7
-// Use of this source code is governed by a BSD-style
8178f7
-// license that can be found in the LICENSE file.
8178f7
-
8178f7
-package elliptic
8178f7
-
8178f7
-import (
8178f7
-	"math/big"
8178f7
-	"testing"
8178f7
-)
8178f7
-
8178f7
-var toFromBigTests = []string{
8178f7
-	"0",
8178f7
-	"1",
8178f7
-	"23",
8178f7
-	"b70e0cb46bb4bf7f321390b94a03c1d356c01122343280d6105c1d21",
8178f7
-	"706a46d476dcb76798e6046d89474788d164c18032d268fd10704fa6",
8178f7
-}
8178f7
-
8178f7
-func p224AlternativeToBig(in *p224FieldElement) *big.Int {
8178f7
-	ret := new(big.Int)
8178f7
-	tmp := new(big.Int)
8178f7
-
8178f7
-	for i := uint(0); i < 8; i++ {
8178f7
-		tmp.SetInt64(int64(in[i]))
8178f7
-		tmp.Lsh(tmp, 28*i)
8178f7
-		ret.Add(ret, tmp)
8178f7
-	}
8178f7
-	ret.Mod(ret, p224.P)
8178f7
-	return ret
8178f7
-}
8178f7
-
8178f7
-func TestToFromBig(t *testing.T) {
8178f7
-	for i, test := range toFromBigTests {
8178f7
-		n, _ := new(big.Int).SetString(test, 16)
8178f7
-		var x p224FieldElement
8178f7
-		p224FromBig(&x, n)
8178f7
-		m := p224ToBig(&x)
8178f7
-		if n.Cmp(m) != 0 {
8178f7
-			t.Errorf("#%d: %x != %x", i, n, m)
8178f7
-		}
8178f7
-		q := p224AlternativeToBig(&x)
8178f7
-		if n.Cmp(q) != 0 {
8178f7
-			t.Errorf("#%d: %x != %x (alternative)", i, n, m)
8178f7
-		}
8178f7
-	}
8178f7
-}