|
 |
1330ca |
--- a/koan/virtinstall.py 2018-11-12 05:32:23.803251480 -0500
|
|
|
1330ca |
+++ b/koan/virtinstall.py 2018-11-12 06:40:17.454546012 -0500
|
|
|
1330ca |
@@ -70,12 +70,13 @@ except:
|
|
|
1330ca |
supported_variants.add(variant.split()[0])
|
|
|
1330ca |
except:
|
|
|
1330ca |
try:
|
|
|
1330ca |
- # maybe on newer os using osinfo-query?
|
|
|
1330ca |
- rc, response = utils.subprocess_get_response(
|
|
|
1330ca |
- shlex.split('osinfo-query os'))
|
|
|
1330ca |
+ rc, response = subprocess_get_response(
|
|
|
1330ca |
+ shlex.split('osinfo-query -f short-id os'))
|
|
|
1330ca |
variants = response.decode('utf-8').split('\n')
|
|
|
1330ca |
for variant in variants:
|
|
|
1330ca |
- supported_variants.add(variant.split()[0])
|
|
|
1330ca |
+ supported_variants.add(variant.strip())
|
|
|
1330ca |
+ # osinfo-query does not list virtio26, add it here for fallback
|
|
|
1330ca |
+ supported_variants.add('virtio26')
|
|
|
1330ca |
except:
|
|
|
1330ca |
# okay, probably on old os and we'll just use generic26
|
|
|
1330ca |
pass
|
|
|
1330ca |
@@ -367,19 +368,24 @@ def build_commandline(uri,
|
|
|
1330ca |
if suse_version_re.match(os_version):
|
|
|
1330ca |
os_version = suse_version_re.match(os_version).groups()[0]
|
|
|
1330ca |
# make sure virt-install knows about our os_version,
|
|
|
1330ca |
- # otherwise default it to generic26
|
|
|
1330ca |
- found = False
|
|
|
1330ca |
+ # otherwise default it to virtio26 or generic26
|
|
|
1330ca |
+ # found = False
|
|
|
1330ca |
if os_version in supported_variants:
|
|
|
1330ca |
- cmd += "--os-variant %s " % os_version
|
|
|
1330ca |
+ pass # os_version is correct
|
|
|
1330ca |
elif os_version + ".0" in supported_variants:
|
|
|
1330ca |
# osinfo based virt-install only knows about major.minor
|
|
|
1330ca |
# variants, not just major variants like it used to. Default
|
|
|
1330ca |
# to major.0 variant in that case. Lack of backwards
|
|
|
1330ca |
# compatibility in virt-install grumble grumble.
|
|
|
1330ca |
- cmd += "--os-variant %s" % os_version + ".0 "
|
|
|
1330ca |
+ os_version = os_version + ".0"
|
|
|
1330ca |
else:
|
|
|
1330ca |
- print(("- warning: virt-install doesn't know this os_version, defaulting to generic26"))
|
|
|
1330ca |
- cmd += "--os-variant generic26 "
|
|
|
1330ca |
+ if "virtio26" in supported_variants:
|
|
|
1330ca |
+ os_version = "virtio26"
|
|
|
1330ca |
+ else:
|
|
|
1330ca |
+ os_version = "generic26"
|
|
|
1330ca |
+ print("- warning: virt-install doesn't know this os_version, "
|
|
|
1330ca |
+ "defaulting to %s" % os_version)
|
|
|
1330ca |
+ cmd += "--os-variant %s " % os_version
|
|
|
1330ca |
else:
|
|
|
1330ca |
distro = "unix"
|
|
|
1330ca |
if breed in [ "debian", "suse", "redhat" ]:
|