6f2509
From 9694c02529a8c1c41fd3ea003b750fd519f24420 Mon Sep 17 00:00:00 2001
f6265e
From: Eduardo Otubo <otubo@redhat.com>
f6265e
Date: Wed, 20 Mar 2019 11:45:59 +0100
f6265e
Subject: include 'NOZEROCONF=yes' in /etc/sysconfig/network
f6265e
f6265e
RH-Author: Eduardo Otubo <otubo@redhat.com>
f6265e
Message-id: <20190320114559.23708-1-otubo@redhat.com>
f6265e
Patchwork-id: 84937
f6265e
O-Subject: [RHEL-7.7 cloud-init PATCH] include 'NOZEROCONF=yes' in /etc/sysconfig/network
f6265e
Bugzilla: 1653131
f6265e
RH-Acked-by: Cathy Avery <cavery@redhat.com>
f6265e
RH-Acked-by: Mohammed Gamal <mgamal@redhat.com>
f6265e
RH-Acked-by: Vitaly Kuznetsov <vkuznets@redhat.com>
f6265e
f6265e
The option NOZEROCONF=yes is not included by default in
f6265e
/etc/sysconfig/network, which is required by Overcloud instances. The
f6265e
patch also includes tests for the modifications.
f6265e
f6265e
X-downstream-only: yes
f6265e
Resolves: rhbz#1653131
f6265e
f6265e
Signed-off-by: Eduardo Otubo <otubo@redhat.com>
f6265e
Signed-off-by: Miroslav Rezanina <mrezanin@redhat.com>
f6265e
---
f6265e
 cloudinit/net/sysconfig.py  | 11 ++++++++++-
f6265e
 tests/unittests/test_net.py |  1 -
f6265e
 2 files changed, 10 insertions(+), 2 deletions(-)
f6265e
f6265e
diff --git a/cloudinit/net/sysconfig.py b/cloudinit/net/sysconfig.py
6f2509
index 8bd7e88..810b283 100644
f6265e
--- a/cloudinit/net/sysconfig.py
f6265e
+++ b/cloudinit/net/sysconfig.py
6f2509
@@ -754,7 +754,16 @@ class Renderer(renderer.Renderer):
f6265e
         # Distros configuring /etc/sysconfig/network as a file e.g. Centos
f6265e
         if sysconfig_path.endswith('network'):
f6265e
             util.ensure_dir(os.path.dirname(sysconfig_path))
f6265e
-            netcfg = [_make_header(), 'NETWORKING=yes']
f6265e
+            netcfg = []
f6265e
+            for line in util.load_file(sysconfig_path, quiet=True).split('\n'):
f6265e
+                if 'cloud-init' in line:
f6265e
+                    break
f6265e
+                if not line.startswith(('NETWORKING=',
f6265e
+                                        'IPV6_AUTOCONF=',
f6265e
+                                        'NETWORKING_IPV6=')):
f6265e
+                    netcfg.append(line)
f6265e
+            # Now generate the cloud-init portion of sysconfig/network
f6265e
+            netcfg.extend([_make_header(), 'NETWORKING=yes'])
f6265e
             if network_state.use_ipv6:
f6265e
                 netcfg.append('NETWORKING_IPV6=yes')
f6265e
                 netcfg.append('IPV6_AUTOCONF=no')
f6265e
diff --git a/tests/unittests/test_net.py b/tests/unittests/test_net.py
6f2509
index 1306a0f..a931a3e 100644
f6265e
--- a/tests/unittests/test_net.py
f6265e
+++ b/tests/unittests/test_net.py
6f2509
@@ -1483,7 +1483,6 @@ pre-down route del -net 10.0.0.0/8 gw 11.0.0.1 metric 3 || true
f6265e
                 BOOTPROTO=none
f6265e
                 DEVICE=bond0
f6265e
                 DHCPV6C=yes
f6265e
-                IPV6_AUTOCONF=no
f6265e
                 IPV6INIT=yes
f6265e
                 MACADDR=aa:bb:cc:dd:ee:ff
f6265e
                 ONBOOT=yes
f6265e
-- 
f6265e
1.8.3.1
f6265e