|
 |
0a07cd |
From 0bff7d73c49043b0820d0231c9a47539287f35e3 Mon Sep 17 00:00:00 2001
|
|
|
222d62 |
From: Miroslav Rezanina <mrezanin@redhat.com>
|
|
|
222d62 |
Date: Thu, 31 May 2018 19:37:55 +0200
|
|
|
222d62 |
Subject: Do not write NM_CONTROLLED=no in generated interface config files
|
|
|
222d62 |
|
|
|
222d62 |
X-downstream-only: true
|
|
|
222d62 |
Signed-off-by: Ryan McCabe <rmccabe@redhat.com>
|
|
|
0a07cd |
Signed-off-by: Danilo C. L. de Paula <ddepaula@redhat.com>
|
|
|
222d62 |
---
|
|
|
0a07cd |
cloudinit/net/sysconfig.py | 1 -
|
|
|
0a07cd |
tests/unittests/test_net.py | 30 ------------------------------
|
|
|
0a07cd |
2 files changed, 31 deletions(-)
|
|
|
222d62 |
|
|
|
222d62 |
diff --git a/cloudinit/net/sysconfig.py b/cloudinit/net/sysconfig.py
|
|
|
0a07cd |
index 17293e1d..ae0554ef 100644
|
|
|
222d62 |
--- a/cloudinit/net/sysconfig.py
|
|
|
222d62 |
+++ b/cloudinit/net/sysconfig.py
|
|
|
0a07cd |
@@ -250,7 +250,6 @@ class Renderer(renderer.Renderer):
|
|
|
222d62 |
iface_defaults = tuple([
|
|
|
222d62 |
('ONBOOT', True),
|
|
|
222d62 |
('USERCTL', False),
|
|
|
222d62 |
- ('NM_CONTROLLED', False),
|
|
|
222d62 |
('BOOTPROTO', 'none'),
|
|
|
222d62 |
])
|
|
|
222d62 |
|
|
|
222d62 |
diff --git a/tests/unittests/test_net.py b/tests/unittests/test_net.py
|
|
|
0a07cd |
index 195f261c..5f1aa3e7 100644
|
|
|
222d62 |
--- a/tests/unittests/test_net.py
|
|
|
222d62 |
+++ b/tests/unittests/test_net.py
|
|
|
0a07cd |
@@ -175,7 +175,6 @@ GATEWAY=172.19.3.254
|
|
|
222d62 |
HWADDR=fa:16:3e:ed:9a:59
|
|
|
222d62 |
IPADDR=172.19.1.34
|
|
|
222d62 |
NETMASK=255.255.252.0
|
|
|
222d62 |
-NM_CONTROLLED=no
|
|
|
222d62 |
ONBOOT=yes
|
|
|
222d62 |
TYPE=Ethernet
|
|
|
222d62 |
USERCTL=no
|
|
|
0a07cd |
@@ -279,7 +278,6 @@ IPADDR=172.19.1.34
|
|
|
222d62 |
IPADDR1=10.0.0.10
|
|
|
222d62 |
NETMASK=255.255.252.0
|
|
|
222d62 |
NETMASK1=255.255.255.0
|
|
|
222d62 |
-NM_CONTROLLED=no
|
|
|
222d62 |
ONBOOT=yes
|
|
|
222d62 |
TYPE=Ethernet
|
|
|
222d62 |
USERCTL=no
|
|
|
0a07cd |
@@ -407,7 +405,6 @@ IPV6ADDR_SECONDARIES="2001:DB9::10/64 2001:DB10::10/64"
|
|
|
222d62 |
IPV6INIT=yes
|
|
|
222d62 |
IPV6_DEFAULTGW=2001:DB8::1
|
|
|
222d62 |
NETMASK=255.255.252.0
|
|
|
222d62 |
-NM_CONTROLLED=no
|
|
|
222d62 |
ONBOOT=yes
|
|
|
222d62 |
TYPE=Ethernet
|
|
|
222d62 |
USERCTL=no
|
|
|
0a07cd |
@@ -523,7 +520,6 @@ NETWORK_CONFIGS = {
|
|
|
222d62 |
BOOTPROTO=none
|
|
|
222d62 |
DEVICE=eth1
|
|
|
222d62 |
HWADDR=cf:d6:af:48:e8:80
|
|
|
222d62 |
- NM_CONTROLLED=no
|
|
|
222d62 |
ONBOOT=yes
|
|
|
222d62 |
TYPE=Ethernet
|
|
|
222d62 |
USERCTL=no"""),
|
|
|
0a07cd |
@@ -539,7 +535,6 @@ NETWORK_CONFIGS = {
|
|
|
222d62 |
IPADDR=192.168.21.3
|
|
|
222d62 |
NETMASK=255.255.255.0
|
|
|
0a07cd |
METRIC=10000
|
|
|
222d62 |
- NM_CONTROLLED=no
|
|
|
222d62 |
ONBOOT=yes
|
|
|
222d62 |
TYPE=Ethernet
|
|
|
222d62 |
USERCTL=no"""),
|
|
|
0a07cd |
@@ -652,7 +647,6 @@ NETWORK_CONFIGS = {
|
|
|
222d62 |
IPV6ADDR=2001:1::1/64
|
|
|
222d62 |
IPV6INIT=yes
|
|
|
222d62 |
NETMASK=255.255.255.0
|
|
|
222d62 |
- NM_CONTROLLED=no
|
|
|
222d62 |
ONBOOT=yes
|
|
|
222d62 |
TYPE=Ethernet
|
|
|
222d62 |
USERCTL=no
|
|
|
0a07cd |
@@ -894,14 +888,12 @@ pre-down route del -net 10.0.0.0 netmask 255.0.0.0 gw 11.0.0.1 metric 3 || true
|
|
|
222d62 |
DHCPV6C=yes
|
|
|
222d62 |
IPV6INIT=yes
|
|
|
222d62 |
MACADDR=aa:bb:cc:dd:ee:ff
|
|
|
222d62 |
- NM_CONTROLLED=no
|
|
|
222d62 |
ONBOOT=yes
|
|
|
222d62 |
TYPE=Bond
|
|
|
222d62 |
USERCTL=no"""),
|
|
|
222d62 |
'ifcfg-bond0.200': textwrap.dedent("""\
|
|
|
222d62 |
BOOTPROTO=dhcp
|
|
|
222d62 |
DEVICE=bond0.200
|
|
|
222d62 |
- NM_CONTROLLED=no
|
|
|
222d62 |
ONBOOT=yes
|
|
|
222d62 |
PHYSDEV=bond0
|
|
|
222d62 |
TYPE=Ethernet
|
|
|
0a07cd |
@@ -918,7 +910,6 @@ pre-down route del -net 10.0.0.0 netmask 255.0.0.0 gw 11.0.0.1 metric 3 || true
|
|
|
222d62 |
IPV6_DEFAULTGW=2001:4800:78ff:1b::1
|
|
|
0a07cd |
MACADDR=bb:bb:bb:bb:bb:aa
|
|
|
222d62 |
NETMASK=255.255.255.0
|
|
|
222d62 |
- NM_CONTROLLED=no
|
|
|
222d62 |
ONBOOT=yes
|
|
|
222d62 |
PRIO=22
|
|
|
222d62 |
STP=no
|
|
|
0a07cd |
@@ -928,7 +919,6 @@ pre-down route del -net 10.0.0.0 netmask 255.0.0.0 gw 11.0.0.1 metric 3 || true
|
|
|
222d62 |
BOOTPROTO=none
|
|
|
222d62 |
DEVICE=eth0
|
|
|
222d62 |
HWADDR=c0:d6:9f:2c:e8:80
|
|
|
222d62 |
- NM_CONTROLLED=no
|
|
|
222d62 |
ONBOOT=yes
|
|
|
222d62 |
TYPE=Ethernet
|
|
|
222d62 |
USERCTL=no"""),
|
|
|
0a07cd |
@@ -945,7 +935,6 @@ pre-down route del -net 10.0.0.0 netmask 255.0.0.0 gw 11.0.0.1 metric 3 || true
|
|
|
222d62 |
MTU=1500
|
|
|
222d62 |
NETMASK=255.255.255.0
|
|
|
222d62 |
NETMASK1=255.255.255.0
|
|
|
222d62 |
- NM_CONTROLLED=no
|
|
|
222d62 |
ONBOOT=yes
|
|
|
222d62 |
PHYSDEV=eth0
|
|
|
222d62 |
TYPE=Ethernet
|
|
|
0a07cd |
@@ -956,7 +945,6 @@ pre-down route del -net 10.0.0.0 netmask 255.0.0.0 gw 11.0.0.1 metric 3 || true
|
|
|
222d62 |
DEVICE=eth1
|
|
|
222d62 |
HWADDR=aa:d6:9f:2c:e8:80
|
|
|
222d62 |
MASTER=bond0
|
|
|
222d62 |
- NM_CONTROLLED=no
|
|
|
222d62 |
ONBOOT=yes
|
|
|
222d62 |
SLAVE=yes
|
|
|
222d62 |
TYPE=Ethernet
|
|
|
0a07cd |
@@ -966,7 +954,6 @@ pre-down route del -net 10.0.0.0 netmask 255.0.0.0 gw 11.0.0.1 metric 3 || true
|
|
|
222d62 |
DEVICE=eth2
|
|
|
222d62 |
HWADDR=c0:bb:9f:2c:e8:80
|
|
|
222d62 |
MASTER=bond0
|
|
|
222d62 |
- NM_CONTROLLED=no
|
|
|
222d62 |
ONBOOT=yes
|
|
|
222d62 |
SLAVE=yes
|
|
|
222d62 |
TYPE=Ethernet
|
|
|
0a07cd |
@@ -976,7 +963,6 @@ pre-down route del -net 10.0.0.0 netmask 255.0.0.0 gw 11.0.0.1 metric 3 || true
|
|
|
222d62 |
BRIDGE=br0
|
|
|
222d62 |
DEVICE=eth3
|
|
|
222d62 |
HWADDR=66:bb:9f:2c:e8:80
|
|
|
222d62 |
- NM_CONTROLLED=no
|
|
|
222d62 |
ONBOOT=yes
|
|
|
222d62 |
TYPE=Ethernet
|
|
|
222d62 |
USERCTL=no"""),
|
|
|
0a07cd |
@@ -985,7 +971,6 @@ pre-down route del -net 10.0.0.0 netmask 255.0.0.0 gw 11.0.0.1 metric 3 || true
|
|
|
222d62 |
BRIDGE=br0
|
|
|
222d62 |
DEVICE=eth4
|
|
|
222d62 |
HWADDR=98:bb:9f:2c:e8:80
|
|
|
222d62 |
- NM_CONTROLLED=no
|
|
|
222d62 |
ONBOOT=yes
|
|
|
222d62 |
TYPE=Ethernet
|
|
|
222d62 |
USERCTL=no"""),
|
|
|
0a07cd |
@@ -993,7 +978,6 @@ pre-down route del -net 10.0.0.0 netmask 255.0.0.0 gw 11.0.0.1 metric 3 || true
|
|
|
222d62 |
BOOTPROTO=dhcp
|
|
|
222d62 |
DEVICE=eth5
|
|
|
222d62 |
HWADDR=98:bb:9f:2c:e8:8a
|
|
|
222d62 |
- NM_CONTROLLED=no
|
|
|
222d62 |
ONBOOT=no
|
|
|
222d62 |
TYPE=Ethernet
|
|
|
222d62 |
USERCTL=no""")
|
|
|
0a07cd |
@@ -1356,7 +1340,6 @@ pre-down route del -net 10.0.0.0 netmask 255.0.0.0 gw 11.0.0.1 metric 3 || true
|
|
|
0a07cd |
MTU=9000
|
|
|
222d62 |
NETMASK=255.255.255.0
|
|
|
222d62 |
NETMASK1=255.255.255.0
|
|
|
222d62 |
- NM_CONTROLLED=no
|
|
|
222d62 |
ONBOOT=yes
|
|
|
222d62 |
TYPE=Bond
|
|
|
222d62 |
USERCTL=no
|
|
|
0a07cd |
@@ -1366,7 +1349,6 @@ pre-down route del -net 10.0.0.0 netmask 255.0.0.0 gw 11.0.0.1 metric 3 || true
|
|
|
222d62 |
DEVICE=bond0s0
|
|
|
222d62 |
HWADDR=aa:bb:cc:dd:e8:00
|
|
|
222d62 |
MASTER=bond0
|
|
|
222d62 |
- NM_CONTROLLED=no
|
|
|
222d62 |
ONBOOT=yes
|
|
|
222d62 |
SLAVE=yes
|
|
|
222d62 |
TYPE=Ethernet
|
|
|
0a07cd |
@@ -1388,7 +1370,6 @@ pre-down route del -net 10.0.0.0 netmask 255.0.0.0 gw 11.0.0.1 metric 3 || true
|
|
|
222d62 |
DEVICE=bond0s1
|
|
|
222d62 |
HWADDR=aa:bb:cc:dd:e8:01
|
|
|
222d62 |
MASTER=bond0
|
|
|
222d62 |
- NM_CONTROLLED=no
|
|
|
222d62 |
ONBOOT=yes
|
|
|
222d62 |
SLAVE=yes
|
|
|
222d62 |
TYPE=Ethernet
|
|
|
0a07cd |
@@ -1426,7 +1407,6 @@ pre-down route del -net 10.0.0.0 netmask 255.0.0.0 gw 11.0.0.1 metric 3 || true
|
|
|
222d62 |
BOOTPROTO=none
|
|
|
222d62 |
DEVICE=en0
|
|
|
222d62 |
HWADDR=aa:bb:cc:dd:e8:00
|
|
|
222d62 |
- NM_CONTROLLED=no
|
|
|
222d62 |
ONBOOT=yes
|
|
|
222d62 |
TYPE=Ethernet
|
|
|
222d62 |
USERCTL=no"""),
|
|
|
0a07cd |
@@ -1443,7 +1423,6 @@ pre-down route del -net 10.0.0.0 netmask 255.0.0.0 gw 11.0.0.1 metric 3 || true
|
|
|
0a07cd |
MTU=2222
|
|
|
222d62 |
NETMASK=255.255.255.0
|
|
|
222d62 |
NETMASK1=255.255.255.0
|
|
|
222d62 |
- NM_CONTROLLED=no
|
|
|
222d62 |
ONBOOT=yes
|
|
|
222d62 |
PHYSDEV=en0
|
|
|
222d62 |
TYPE=Ethernet
|
|
|
0a07cd |
@@ -1484,7 +1463,6 @@ pre-down route del -net 10.0.0.0 netmask 255.0.0.0 gw 11.0.0.1 metric 3 || true
|
|
|
222d62 |
DEVICE=br0
|
|
|
222d62 |
IPADDR=192.168.2.2
|
|
|
222d62 |
NETMASK=255.255.255.0
|
|
|
222d62 |
- NM_CONTROLLED=no
|
|
|
222d62 |
ONBOOT=yes
|
|
|
222d62 |
PRIO=22
|
|
|
222d62 |
STP=no
|
|
|
0a07cd |
@@ -1498,7 +1476,6 @@ pre-down route del -net 10.0.0.0 netmask 255.0.0.0 gw 11.0.0.1 metric 3 || true
|
|
|
222d62 |
HWADDR=52:54:00:12:34:00
|
|
|
222d62 |
IPV6ADDR=2001:1::100/96
|
|
|
222d62 |
IPV6INIT=yes
|
|
|
222d62 |
- NM_CONTROLLED=no
|
|
|
222d62 |
ONBOOT=yes
|
|
|
222d62 |
TYPE=Ethernet
|
|
|
222d62 |
USERCTL=no
|
|
|
0a07cd |
@@ -1510,7 +1487,6 @@ pre-down route del -net 10.0.0.0 netmask 255.0.0.0 gw 11.0.0.1 metric 3 || true
|
|
|
222d62 |
HWADDR=52:54:00:12:34:01
|
|
|
222d62 |
IPV6ADDR=2001:1::101/96
|
|
|
222d62 |
IPV6INIT=yes
|
|
|
222d62 |
- NM_CONTROLLED=no
|
|
|
222d62 |
ONBOOT=yes
|
|
|
222d62 |
TYPE=Ethernet
|
|
|
222d62 |
USERCTL=no
|
|
|
0a07cd |
@@ -1584,7 +1560,6 @@ pre-down route del -net 10.0.0.0 netmask 255.0.0.0 gw 11.0.0.1 metric 3 || true
|
|
|
222d62 |
HWADDR=52:54:00:12:34:00
|
|
|
222d62 |
IPADDR=192.168.1.2
|
|
|
222d62 |
NETMASK=255.255.255.0
|
|
|
222d62 |
- NM_CONTROLLED=no
|
|
|
222d62 |
ONBOOT=no
|
|
|
222d62 |
TYPE=Ethernet
|
|
|
222d62 |
USERCTL=no
|
|
|
0a07cd |
@@ -1594,7 +1569,6 @@ pre-down route del -net 10.0.0.0 netmask 255.0.0.0 gw 11.0.0.1 metric 3 || true
|
|
|
222d62 |
DEVICE=eth1
|
|
|
222d62 |
HWADDR=52:54:00:12:34:aa
|
|
|
222d62 |
MTU=1480
|
|
|
222d62 |
- NM_CONTROLLED=no
|
|
|
222d62 |
ONBOOT=yes
|
|
|
222d62 |
TYPE=Ethernet
|
|
|
222d62 |
USERCTL=no
|
|
|
0a07cd |
@@ -1603,7 +1577,6 @@ pre-down route del -net 10.0.0.0 netmask 255.0.0.0 gw 11.0.0.1 metric 3 || true
|
|
|
222d62 |
BOOTPROTO=none
|
|
|
222d62 |
DEVICE=eth2
|
|
|
222d62 |
HWADDR=52:54:00:12:34:ff
|
|
|
222d62 |
- NM_CONTROLLED=no
|
|
|
222d62 |
ONBOOT=no
|
|
|
222d62 |
TYPE=Ethernet
|
|
|
222d62 |
USERCTL=no
|
|
|
0a07cd |
@@ -1969,7 +1942,6 @@ class TestRhelSysConfigRendering(CiTestCase):
|
|
|
222d62 |
BOOTPROTO=dhcp
|
|
|
222d62 |
DEVICE=eth1000
|
|
|
222d62 |
HWADDR=07-1C-C6-75-A4-BE
|
|
|
222d62 |
-NM_CONTROLLED=no
|
|
|
222d62 |
ONBOOT=yes
|
|
|
222d62 |
TYPE=Ethernet
|
|
|
222d62 |
USERCTL=no
|
|
|
0a07cd |
@@ -2090,7 +2062,6 @@ GATEWAY=10.0.2.2
|
|
|
222d62 |
HWADDR=52:54:00:12:34:00
|
|
|
222d62 |
IPADDR=10.0.2.15
|
|
|
222d62 |
NETMASK=255.255.255.0
|
|
|
222d62 |
-NM_CONTROLLED=no
|
|
|
222d62 |
ONBOOT=yes
|
|
|
222d62 |
TYPE=Ethernet
|
|
|
222d62 |
USERCTL=no
|
|
|
0a07cd |
@@ -2111,7 +2082,6 @@ USERCTL=no
|
|
|
222d62 |
#
|
|
|
222d62 |
BOOTPROTO=dhcp
|
|
|
222d62 |
DEVICE=eth0
|
|
|
222d62 |
-NM_CONTROLLED=no
|
|
|
222d62 |
ONBOOT=yes
|
|
|
222d62 |
TYPE=Ethernet
|
|
|
222d62 |
USERCTL=no
|
|
|
222d62 |
--
|
|
|
0a07cd |
2.20.1
|
|
|
222d62 |
|