|
 |
0af72f |
From 205775f73f7eef7b207acccac6b853562adf604b Mon Sep 17 00:00:00 2001
|
|
|
0af72f |
From: Rob Crittenden <rcritten@redhat.com>
|
|
|
0af72f |
Date: Fri, 25 Oct 2019 20:25:36 +0000
|
|
|
0af72f |
Subject: [PATCH] Don't close STDERR when submitting request
|
|
|
0af72f |
|
|
|
0af72f |
cm_subproc_mark_most_cloexec() now closes all open file
|
|
|
0af72f |
descriptors except for up to three requested for stdin, stdout
|
|
|
0af72f |
and stderr. Before the optimization those three were always
|
|
|
0af72f |
left open.
|
|
|
0af72f |
|
|
|
0af72f |
This was causing errors in the IPA helper ipa-server-guard
|
|
|
0af72f |
because it tries to display the contents of stderr which was
|
|
|
0af72f |
always being closed, causing ipa-server-guard to blow up.
|
|
|
0af72f |
---
|
|
|
0af72f |
src/submit-e.c | 4 ++--
|
|
|
0af72f |
1 file changed, 2 insertions(+), 2 deletions(-)
|
|
|
0af72f |
|
|
|
0af72f |
diff --git a/src/submit-e.c b/src/submit-e.c
|
|
|
0af72f |
index d6158d7a..69b4f8e2 100644
|
|
|
0af72f |
--- a/src/submit-e.c
|
|
|
0af72f |
+++ b/src/submit-e.c
|
|
|
0af72f |
@@ -941,8 +941,8 @@ cm_submit_e_helper_main(int fd, struct cm_store_ca *ca,
|
|
|
0af72f |
}
|
|
|
0af72f |
return -1;
|
|
|
0af72f |
}
|
|
|
0af72f |
- cm_log(2, "Redirecting stdin and stderr to /dev/null, leaving stdout open for child \"%s\".\n", argv[0]);
|
|
|
0af72f |
- cm_subproc_mark_most_cloexec(STDOUT_FILENO, -1, -1);
|
|
|
0af72f |
+ cm_log(2, "Redirecting stdin to /dev/null, leaving stdout and stderr open for child \"%s\".\n", argv[0]);
|
|
|
0af72f |
+ cm_subproc_mark_most_cloexec(STDOUT_FILENO, STDERR_FILENO, -1);
|
|
|
0af72f |
cm_log(1, "Running enrollment helper \"%s\".\n", argv[0]);
|
|
|
0af72f |
execvp(argv[0], argv);
|
|
|
0af72f |
u = errno;
|
|
|
0af72f |
--
|
|
|
0af72f |
2.21.0
|
|
|
0af72f |
|