|
 |
2f3073 |
From daf4ef50c88c2b9a6bf2c40b537eebc202caad6e Mon Sep 17 00:00:00 2001
|
|
|
2f3073 |
From: =?UTF-8?q?S=C3=A9bastien=20Gonzalve?=
|
|
|
2f3073 |
<sebastien.gonzalve@aliceadsl.fr>
|
|
|
2f3073 |
Date: Sat, 14 Nov 2020 10:39:47 +0100
|
|
|
2f3073 |
Subject: [PATCH] Do not try to access element when vector is empty
|
|
|
2f3073 |
|
|
|
2f3073 |
Trying to access tmp[0] causes a crash on Fedora when assertion on STL
|
|
|
2f3073 |
are enabled.
|
|
|
2f3073 |
|
|
|
2f3073 |
/usr/include/c++/10/bits/stl_vector.h:1045: std::vector<_Tp, _Alloc>::reference std::vector<_Tp, _Alloc>::operator[](std::vector<_Tp, _Alloc>::size_type) [with _Tp = unsigned char; _Alloc = std::allocator<unsigned char>; std::vector<_Tp, _Alloc>::reference = unsigned char&; std::vector<_Tp, _Alloc>::size_type = long unsigned int]: Assertion '__builtin_expect(__n < this->size(), true)' failed.
|
|
|
2f3073 |
|
|
|
2f3073 |
This patch just passes nullptr as pointer to getSortKey() when tmp size
|
|
|
2f3073 |
is 0, preventing dereferencing elements in empty vector.
|
|
|
2f3073 |
|
|
|
2f3073 |
I guess that &tmp[0] should be optimized as 'no real access' when
|
|
|
2f3073 |
disabling assertion, but actually leads to crash when assert are
|
|
|
2f3073 |
enabled.
|
|
|
2f3073 |
---
|
|
|
2f3073 |
src/icu/collator.cpp | 2 +-
|
|
|
2f3073 |
1 file changed, 1 insertion(+), 1 deletion(-)
|
|
|
2f3073 |
|
|
|
2f3073 |
diff --git a/libs/locale/src/icu/collator.cpp b/libs/locale/src/icu/collator.cpp
|
|
|
2f3073 |
index 7f1ea6a..dc59e8c 100644
|
|
|
2f3073 |
--- a/libs/locale/src/icu/collator.cpp
|
|
|
2f3073 |
+++ b/libs/locale/src/icu/collator.cpp
|
|
|
2f3073 |
@@ -93,7 +93,7 @@ namespace boost {
|
|
|
2f3073 |
std::vector<uint8_t> tmp;
|
|
|
2f3073 |
tmp.resize(str.length());
|
|
|
2f3073 |
icu::Collator *collate = get_collator(level);
|
|
|
2f3073 |
- int len = collate->getSortKey(str,&tmp[0],tmp.size());
|
|
|
2f3073 |
+ int len = collate->getSortKey(str,tmp.empty()?nullptr:&tmp[0],tmp.size());
|
|
|
2f3073 |
if(len > int(tmp.size())) {
|
|
|
2f3073 |
tmp.resize(len);
|
|
|
2f3073 |
collate->getSortKey(str,&tmp[0],tmp.size());
|
|
|
2f3073 |
--
|
|
|
2f3073 |
2.26.2
|
|
|
2f3073 |
|