4aabfd
From 8ff11a8eccc41914478e92231500fc47fefa6779 Mon Sep 17 00:00:00 2001
4aabfd
From: Jonathan Wakely <boost@kayari.org>
4aabfd
Date: Wed, 10 Oct 2018 17:17:10 +0100
4aabfd
Subject: [PATCH] Fix memory leak
4aabfd
4aabfd
If vsnprintf returns -1 then the buffer should be freed before returning.
4aabfd
---
4aabfd
 src/engine/debugger.c | 5 +++--
4aabfd
 1 file changed, 3 insertions(+), 2 deletions(-)
4aabfd
4aabfd
diff --git a/src/engine/debugger.c b/src/engine/debugger.c
4aabfd
index 3c811b4557..d849d064a9 100644
4aabfd
--- a/tools/build/src/engine/debugger.c
4aabfd
+++ b/tools/build/src/engine/debugger.c
4aabfd
@@ -860,10 +860,11 @@ static const char * debug_format_message( const char * format, va_list vargs )
4aabfd
         result = vsnprintf( buf, sz, format, args );
4aabfd
         #endif
4aabfd
         va_end( args );
4aabfd
+        if ( 0 <= result && result < sz )
4aabfd
+	    return buf;
4aabfd
+        free( buf );
4aabfd
         if ( result < 0 )
4aabfd
             return 0;
4aabfd
-        if ( result < sz ) return buf;
4aabfd
-        free( buf );
4aabfd
         sz = result + 1;
4aabfd
     }
4aabfd
 }