|
 |
150e62 |
From 4ae130455b173650f564d92f7908a7ca4f7b1ee6 Mon Sep 17 00:00:00 2001
|
|
|
150e62 |
From: Gopal Tiwari <gtiwari@redhat.com>
|
|
|
150e62 |
Date: Tue, 31 May 2022 13:11:10 +0530
|
|
|
150e62 |
Subject: [PATCH BlueZ 06/12] create-image: Fix leaked_handle
|
|
|
150e62 |
|
|
|
150e62 |
While performing static tool analysis using coverity found following
|
|
|
150e62 |
reports for resouse leak
|
|
|
150e62 |
|
|
|
150e62 |
bluez-5.64/tools/create-image.c:124: leaked_storage: Variable "map"
|
|
|
150e62 |
going out of scope leaks the storage it points to.
|
|
|
150e62 |
---
|
|
|
150e62 |
tools/create-image.c | 7 +++----
|
|
|
150e62 |
1 file changed, 3 insertions(+), 4 deletions(-)
|
|
|
150e62 |
|
|
|
150e62 |
diff --git a/tools/create-image.c b/tools/create-image.c
|
|
|
150e62 |
index aba940da7..90cd87315 100644
|
|
|
150e62 |
--- a/tools/create-image.c
|
|
|
150e62 |
+++ b/tools/create-image.c
|
|
|
150e62 |
@@ -97,12 +97,13 @@ static void write_block(FILE *fp, const char *pathname, unsigned int ino,
|
|
|
150e62 |
|
|
|
150e62 |
map = mmap(NULL, st.st_size, PROT_READ, MAP_SHARED, fd, 0);
|
|
|
150e62 |
if (!map || map == MAP_FAILED) {
|
|
|
150e62 |
- close(fd);
|
|
|
150e62 |
- fd = -1;
|
|
|
150e62 |
map = NULL;
|
|
|
150e62 |
st.st_size = 0;
|
|
|
150e62 |
}
|
|
|
150e62 |
|
|
|
150e62 |
+ close(fd);
|
|
|
150e62 |
+ fd = -1;
|
|
|
150e62 |
+
|
|
|
150e62 |
done:
|
|
|
150e62 |
fprintf(fp, HDR_FMT, HDR_MAGIC, ino, mode, 0, 0, 1, 0,
|
|
|
150e62 |
(uintmax_t) st.st_size, 0, 0, 0, 0, namelen + 1, 0, name);
|
|
|
150e62 |
@@ -117,9 +118,7 @@ done:
|
|
|
150e62 |
pad = 3 - ((st.st_size + 3) % 4);
|
|
|
150e62 |
for (i = 0; i < pad; i++)
|
|
|
150e62 |
fputc(0, fp);
|
|
|
150e62 |
-
|
|
|
150e62 |
munmap(map, st.st_size);
|
|
|
150e62 |
- close(fd);
|
|
|
150e62 |
}
|
|
|
150e62 |
}
|
|
|
150e62 |
|
|
|
150e62 |
--
|
|
|
150e62 |
2.26.2
|
|
|
150e62 |
|