|
 |
150e62 |
From 5eb96b3ec8545047a74d7204664267c7aa749070 Mon Sep 17 00:00:00 2001
|
|
|
150e62 |
From: Gopal Tiwari <gtiwari@redhat.com>
|
|
|
150e62 |
Date: Tue, 31 May 2022 13:11:06 +0530
|
|
|
150e62 |
Subject: [PATCH BlueZ 02/12] mesh/appkey: Fix memory leaks
|
|
|
150e62 |
|
|
|
150e62 |
While performing the static analysis using the coverity tool found
|
|
|
150e62 |
following memory leak reports
|
|
|
150e62 |
|
|
|
150e62 |
bluez-5.64/mesh/appkey.c:143: leaked_storage: Variable "key" going
|
|
|
150e62 |
out of scope leaks the storage it points to.
|
|
|
150e62 |
|
|
|
150e62 |
Error: RESOURCE_LEAK (CWE-772):
|
|
|
150e62 |
bluez-5.64/mesh/appkey.c:146: leaked_storage: Variable "key" going
|
|
|
150e62 |
out of scope leaks the storage it points to.
|
|
|
150e62 |
---
|
|
|
150e62 |
mesh/appkey.c | 8 ++++++--
|
|
|
150e62 |
1 file changed, 6 insertions(+), 2 deletions(-)
|
|
|
150e62 |
|
|
|
150e62 |
diff --git a/mesh/appkey.c b/mesh/appkey.c
|
|
|
150e62 |
index 5088a1812..52fed8c31 100644
|
|
|
150e62 |
--- a/mesh/appkey.c
|
|
|
150e62 |
+++ b/mesh/appkey.c
|
|
|
150e62 |
@@ -139,11 +139,15 @@ bool appkey_key_init(struct mesh_net *net, uint16_t net_idx, uint16_t app_idx,
|
|
|
150e62 |
key->net_idx = net_idx;
|
|
|
150e62 |
key->app_idx = app_idx;
|
|
|
150e62 |
|
|
|
150e62 |
- if (key_value && !set_key(key, app_idx, key_value, false))
|
|
|
150e62 |
+ if (key_value && !set_key(key, app_idx, key_value, false)) {
|
|
|
150e62 |
+ appkey_key_free(key);
|
|
|
150e62 |
return false;
|
|
|
150e62 |
+ }
|
|
|
150e62 |
|
|
|
150e62 |
- if (new_key_value && !set_key(key, app_idx, new_key_value, true))
|
|
|
150e62 |
+ if (new_key_value && !set_key(key, app_idx, new_key_value, true)) {
|
|
|
150e62 |
+ appkey_key_free(key);
|
|
|
150e62 |
return false;
|
|
|
150e62 |
+ }
|
|
|
150e62 |
|
|
|
150e62 |
l_queue_push_tail(app_keys, key);
|
|
|
150e62 |
|
|
|
150e62 |
--
|
|
|
150e62 |
2.26.2
|
|
|
150e62 |
|