Blame SOURCES/binutils-gold-i386-gnu-property-notes.patch

61bcc6
diff --git a/gold/i386.cc b/gold/i386.cc
61bcc6
index bf209fe9a86..31161ff091c 100644
61bcc6
--- a/gold/i386.cc
61bcc6
+++ b/gold/i386.cc
61bcc6
@@ -360,7 +360,11 @@ class Target_i386 : public Sized_target<32, false>
61bcc6
       got_(NULL), plt_(NULL), got_plt_(NULL), got_irelative_(NULL),
61bcc6
       got_tlsdesc_(NULL), global_offset_table_(NULL), rel_dyn_(NULL),
61bcc6
       rel_irelative_(NULL), copy_relocs_(elfcpp::R_386_COPY),
61bcc6
-      got_mod_index_offset_(-1U), tls_base_symbol_defined_(false)
61bcc6
+      got_mod_index_offset_(-1U), tls_base_symbol_defined_(false),
61bcc6
+      isa_1_used_(0), isa_1_needed_(0),
61bcc6
+      feature_1_(0), feature_2_used_(0), feature_2_needed_(0),
61bcc6
+      object_isa_1_used_(0), object_feature_1_(0),
61bcc6
+      object_feature_2_used_(0), seen_first_object_(false)
61bcc6
   { }
61bcc6
 
61bcc6
   // Process the relocations to determine unreferenced sections for
61bcc6
@@ -859,6 +863,21 @@ class Target_i386 : public Sized_target<32, false>
61bcc6
 				  this->rel_dyn_section(layout));
61bcc6
   }
61bcc6
 
61bcc6
+  // Record a target-specific program property in the .note.gnu.property
61bcc6
+  // section.
61bcc6
+  void
61bcc6
+  record_gnu_property(unsigned int, unsigned int, size_t,
61bcc6
+		      const unsigned char*, const Object*);
61bcc6
+
61bcc6
+  // Merge the target-specific program properties from the current object.
61bcc6
+  void
61bcc6
+  merge_gnu_properties(const Object*);
61bcc6
+
61bcc6
+  // Finalize the target-specific program properties and add them back to
61bcc6
+  // the layout.
61bcc6
+  void
61bcc6
+  do_finalize_gnu_properties(Layout*) const;
61bcc6
+
61bcc6
   // Information about this specific target which we pass to the
61bcc6
   // general Target structure.
61bcc6
   static const Target::Target_info i386_info;
61bcc6
@@ -898,6 +917,26 @@ class Target_i386 : public Sized_target<32, false>
61bcc6
   unsigned int got_mod_index_offset_;
61bcc6
   // True if the _TLS_MODULE_BASE_ symbol has been defined.
61bcc6
   bool tls_base_symbol_defined_;
61bcc6
+
61bcc6
+  // Target-specific program properties, from .note.gnu.property section.
61bcc6
+  // Each bit represents a specific feature.
61bcc6
+  uint32_t isa_1_used_;
61bcc6
+  uint32_t isa_1_needed_;
61bcc6
+  uint32_t feature_1_;
61bcc6
+  uint32_t feature_2_used_;
61bcc6
+  uint32_t feature_2_needed_;
61bcc6
+  // Target-specific properties from the current object.
61bcc6
+  // These bits get ORed into ISA_1_USED_ after all properties for the object
61bcc6
+  // have been processed. But if either is all zeroes (as when the property
61bcc6
+  // is absent from an object), the result should be all zeroes.
61bcc6
+  // (See PR ld/23486.)
61bcc6
+  uint32_t object_isa_1_used_;
61bcc6
+  // These bits get ANDed into FEATURE_1_ after all properties for the object
61bcc6
+  // have been processed.
61bcc6
+  uint32_t object_feature_1_;
61bcc6
+  uint32_t object_feature_2_used_;
61bcc6
+  // Whether we have seen our first object, for use in initializing FEATURE_1_.
61bcc6
+  bool seen_first_object_;
61bcc6
 };
61bcc6
 
61bcc6
 const Target::Target_info Target_i386::i386_info =
61bcc6
@@ -1042,6 +1081,126 @@ Target_i386::rel_irelative_section(Layout* layout)
61bcc6
   return this->rel_irelative_;
61bcc6
 }
61bcc6
 
61bcc6
+// Record a target-specific program property from the .note.gnu.property
61bcc6
+// section.
61bcc6
+void
61bcc6
+Target_i386::record_gnu_property(
61bcc6
+    unsigned int, unsigned int pr_type,
61bcc6
+    size_t pr_datasz, const unsigned char* pr_data,
61bcc6
+    const Object* object)
61bcc6
+{
61bcc6
+  uint32_t val = 0;
61bcc6
+
61bcc6
+  switch (pr_type)
61bcc6
+    {
61bcc6
+    case elfcpp::GNU_PROPERTY_X86_COMPAT_ISA_1_USED:
61bcc6
+    case elfcpp::GNU_PROPERTY_X86_COMPAT_ISA_1_NEEDED:
61bcc6
+    case elfcpp::GNU_PROPERTY_X86_COMPAT_2_ISA_1_USED:
61bcc6
+    case elfcpp::GNU_PROPERTY_X86_COMPAT_2_ISA_1_NEEDED:
61bcc6
+    case elfcpp::GNU_PROPERTY_X86_ISA_1_USED:
61bcc6
+    case elfcpp::GNU_PROPERTY_X86_ISA_1_NEEDED:
61bcc6
+    case elfcpp::GNU_PROPERTY_X86_FEATURE_1_AND:
61bcc6
+    case elfcpp::GNU_PROPERTY_X86_FEATURE_2_USED:
61bcc6
+    case elfcpp::GNU_PROPERTY_X86_FEATURE_2_NEEDED:
61bcc6
+      if (pr_datasz != 4)
61bcc6
+	{
61bcc6
+	  gold_warning(_("%s: corrupt .note.gnu.property section "
61bcc6
+			 "(pr_datasz for property %d is not 4)"),
61bcc6
+		       object->name().c_str(), pr_type);
61bcc6
+	  return;
61bcc6
+	}
61bcc6
+      val = elfcpp::Swap<32, false>::readval(pr_data);
61bcc6
+      break;
61bcc6
+    default:
61bcc6
+      gold_warning(_("%s: unknown program property type 0x%x "
61bcc6
+		     "in .note.gnu.property section"),
61bcc6
+		   object->name().c_str(), pr_type);
61bcc6
+      break;
61bcc6
+    }
61bcc6
+
61bcc6
+  switch (pr_type)
61bcc6
+    {
61bcc6
+    case elfcpp::GNU_PROPERTY_X86_ISA_1_USED:
61bcc6
+      this->object_isa_1_used_ |= val;
61bcc6
+      break;
61bcc6
+    case elfcpp::GNU_PROPERTY_X86_ISA_1_NEEDED:
61bcc6
+      this->isa_1_needed_ |= val;
61bcc6
+      break;
61bcc6
+    case elfcpp::GNU_PROPERTY_X86_FEATURE_1_AND:
61bcc6
+      // If we see multiple feature props in one object, OR them together.
61bcc6
+      this->object_feature_1_ |= val;
61bcc6
+      break;
61bcc6
+    case elfcpp::GNU_PROPERTY_X86_FEATURE_2_USED:
61bcc6
+      this->object_feature_2_used_ |= val;
61bcc6
+      break;
61bcc6
+    case elfcpp::GNU_PROPERTY_X86_FEATURE_2_NEEDED:
61bcc6
+      this->feature_2_needed_ |= val;
61bcc6
+      break;
61bcc6
+    }
61bcc6
+}
61bcc6
+
61bcc6
+// Merge the target-specific program properties from the current object.
61bcc6
+void
61bcc6
+Target_i386::merge_gnu_properties(const Object*)
61bcc6
+{
61bcc6
+  if (this->seen_first_object_)
61bcc6
+    {
61bcc6
+      // If any object is missing the ISA_1_USED property, we must omit
61bcc6
+      // it from the output file.
61bcc6
+      if (this->object_isa_1_used_ == 0)
61bcc6
+	this->isa_1_used_ = 0;
61bcc6
+      else if (this->isa_1_used_ != 0)
61bcc6
+	this->isa_1_used_ |= this->object_isa_1_used_;
61bcc6
+      this->feature_1_ &= this->object_feature_1_;
61bcc6
+      // If any object is missing the FEATURE_2_USED property, we must
61bcc6
+      // omit it from the output file.
61bcc6
+      if (this->object_feature_2_used_ == 0)
61bcc6
+	this->feature_2_used_ = 0;
61bcc6
+      else if (this->feature_2_used_ != 0)
61bcc6
+	this->feature_2_used_ |= this->object_feature_2_used_;
61bcc6
+    }
61bcc6
+  else
61bcc6
+    {
61bcc6
+      this->isa_1_used_ = this->object_isa_1_used_;
61bcc6
+      this->feature_1_ = this->object_feature_1_;
61bcc6
+      this->feature_2_used_ = this->object_feature_2_used_;
61bcc6
+      this->seen_first_object_ = true;
61bcc6
+    }
61bcc6
+  this->object_isa_1_used_ = 0;
61bcc6
+  this->object_feature_1_ = 0;
61bcc6
+  this->object_feature_2_used_ = 0;
61bcc6
+}
61bcc6
+
61bcc6
+static inline void
61bcc6
+add_property(Layout* layout, unsigned int pr_type, uint32_t val)
61bcc6
+{
61bcc6
+  unsigned char buf[4];
61bcc6
+  elfcpp::Swap<32, false>::writeval(buf, val);
61bcc6
+  layout->add_gnu_property(elfcpp::NT_GNU_PROPERTY_TYPE_0, pr_type, 4, buf);
61bcc6
+}
61bcc6
+
61bcc6
+// Finalize the target-specific program properties and add them back to
61bcc6
+// the layout.
61bcc6
+void
61bcc6
+Target_i386::do_finalize_gnu_properties(Layout* layout) const
61bcc6
+{
61bcc6
+  if (this->isa_1_used_ != 0)
61bcc6
+    add_property(layout, elfcpp::GNU_PROPERTY_X86_ISA_1_USED,
61bcc6
+		 this->isa_1_used_);
61bcc6
+  if (this->isa_1_needed_ != 0)
61bcc6
+    add_property(layout, elfcpp::GNU_PROPERTY_X86_ISA_1_NEEDED,
61bcc6
+		 this->isa_1_needed_);
61bcc6
+  if (this->feature_1_ != 0)
61bcc6
+    add_property(layout, elfcpp::GNU_PROPERTY_X86_FEATURE_1_AND,
61bcc6
+		 this->feature_1_);
61bcc6
+  if (this->feature_2_used_ != 0)
61bcc6
+    add_property(layout, elfcpp::GNU_PROPERTY_X86_FEATURE_2_USED,
61bcc6
+		 this->feature_2_used_);
61bcc6
+  if (this->feature_2_needed_ != 0)
61bcc6
+    add_property(layout, elfcpp::GNU_PROPERTY_X86_FEATURE_2_NEEDED,
61bcc6
+		 this->feature_2_needed_);
61bcc6
+}
61bcc6
+
61bcc6
 // Write the first three reserved words of the .got.plt section.
61bcc6
 // The remainder of the section is written while writing the PLT
61bcc6
 // in Output_data_plt_i386::do_write.
61bcc6
--- binutils.orig/elfcpp/elfcpp.h	2021-06-23 12:31:04.550738064 +0100
61bcc6
+++ binutils-2.30/elfcpp/elfcpp.h	2021-06-23 12:33:18.068875079 +0100
61bcc6
@@ -1008,9 +1008,21 @@ enum
61bcc6
   GNU_PROPERTY_STACK_SIZE = 1,
61bcc6
   GNU_PROPERTY_NO_COPY_ON_PROTECTED = 2,
61bcc6
   GNU_PROPERTY_LOPROC = 0xc0000000,
61bcc6
-  GNU_PROPERTY_X86_ISA_1_USED = 0xc0000000,
61bcc6
-  GNU_PROPERTY_X86_ISA_1_NEEDED = 0xc0000001,
61bcc6
-  GNU_PROPERTY_X86_FEATURE_1_AND = 0xc0000002,
61bcc6
+  GNU_PROPERTY_X86_COMPAT_ISA_1_USED = 0xc0000000,
61bcc6
+  GNU_PROPERTY_X86_COMPAT_ISA_1_NEEDED = 0xc0000001,
61bcc6
+  GNU_PROPERTY_X86_UINT32_AND_LO = 0xc0000002,
61bcc6
+  GNU_PROPERTY_X86_UINT32_AND_HI = 0xc0007fff,
61bcc6
+  GNU_PROPERTY_X86_UINT32_OR_LO = 0xc0008000,
61bcc6
+  GNU_PROPERTY_X86_UINT32_OR_HI = 0xc000ffff,
61bcc6
+  GNU_PROPERTY_X86_UINT32_OR_AND_LO = 0xc0010000,
61bcc6
+  GNU_PROPERTY_X86_UINT32_OR_AND_HI = 0xc0017fff,
61bcc6
+  GNU_PROPERTY_X86_COMPAT_2_ISA_1_NEEDED = GNU_PROPERTY_X86_UINT32_OR_LO + 0,
61bcc6
+  GNU_PROPERTY_X86_COMPAT_2_ISA_1_USED = GNU_PROPERTY_X86_UINT32_OR_AND_LO + 0,
61bcc6
+  GNU_PROPERTY_X86_FEATURE_1_AND = GNU_PROPERTY_X86_UINT32_AND_LO + 0,
61bcc6
+  GNU_PROPERTY_X86_ISA_1_NEEDED = GNU_PROPERTY_X86_UINT32_OR_LO + 2,
61bcc6
+  GNU_PROPERTY_X86_FEATURE_2_NEEDED = GNU_PROPERTY_X86_UINT32_OR_LO + 1,
61bcc6
+  GNU_PROPERTY_X86_ISA_1_USED = GNU_PROPERTY_X86_UINT32_OR_AND_LO + 2,
61bcc6
+  GNU_PROPERTY_X86_FEATURE_2_USED = GNU_PROPERTY_X86_UINT32_OR_AND_LO + 1,
61bcc6
   GNU_PROPERTY_HIPROC = 0xdfffffff,
61bcc6
   GNU_PROPERTY_LOUSER = 0xe0000000,
61bcc6
   GNU_PROPERTY_HIUSER = 0xffffffff
61bcc6
--- binutils.orig/gold/i386.cc	2021-07-07 14:15:34.369441519 +0100
61bcc6
+++ binutils-2.30/gold/i386.cc	2021-07-07 14:36:11.932838272 +0100
61bcc6
@@ -362,9 +362,8 @@ class Target_i386 : public Sized_target<
61bcc6
       rel_irelative_(NULL), copy_relocs_(elfcpp::R_386_COPY),
61bcc6
       got_mod_index_offset_(-1U), tls_base_symbol_defined_(false),
61bcc6
       isa_1_used_(0), isa_1_needed_(0),
61bcc6
-      feature_1_(0), feature_2_used_(0), feature_2_needed_(0),
61bcc6
-      object_isa_1_used_(0), object_feature_1_(0),
61bcc6
-      object_feature_2_used_(0), seen_first_object_(false)
61bcc6
+      feature_1_(0), object_feature_1_(0),
61bcc6
+      seen_first_object_(false)
61bcc6
   { }
61bcc6
 
61bcc6
   // Process the relocations to determine unreferenced sections for
61bcc6
@@ -866,7 +865,7 @@ class Target_i386 : public Sized_target<
61bcc6
   // Record a target-specific program property in the .note.gnu.property
61bcc6
   // section.
61bcc6
   void
61bcc6
-  record_gnu_property(unsigned int, unsigned int, size_t,
61bcc6
+  record_gnu_property(int, int, size_t,
61bcc6
 		      const unsigned char*, const Object*);
61bcc6
 
61bcc6
   // Merge the target-specific program properties from the current object.
61bcc6
@@ -923,18 +922,10 @@ class Target_i386 : public Sized_target<
61bcc6
   uint32_t isa_1_used_;
61bcc6
   uint32_t isa_1_needed_;
61bcc6
   uint32_t feature_1_;
61bcc6
-  uint32_t feature_2_used_;
61bcc6
-  uint32_t feature_2_needed_;
61bcc6
   // Target-specific properties from the current object.
61bcc6
-  // These bits get ORed into ISA_1_USED_ after all properties for the object
61bcc6
-  // have been processed. But if either is all zeroes (as when the property
61bcc6
-  // is absent from an object), the result should be all zeroes.
61bcc6
-  // (See PR ld/23486.)
61bcc6
-  uint32_t object_isa_1_used_;
61bcc6
   // These bits get ANDed into FEATURE_1_ after all properties for the object
61bcc6
   // have been processed.
61bcc6
   uint32_t object_feature_1_;
61bcc6
-  uint32_t object_feature_2_used_;
61bcc6
   // Whether we have seen our first object, for use in initializing FEATURE_1_.
61bcc6
   bool seen_first_object_;
61bcc6
 };
61bcc6
@@ -1084,7 +1075,7 @@ Target_i386::rel_irelative_section(Layou
61bcc6
 // section.
61bcc6
 void
61bcc6
 Target_i386::record_gnu_property(
61bcc6
-    unsigned int, unsigned int pr_type,
61bcc6
+    int, int pr_type,
61bcc6
     size_t pr_datasz, const unsigned char* pr_data,
61bcc6
     const Object* object)
61bcc6
 {
61bcc6
@@ -1092,15 +1083,9 @@ Target_i386::record_gnu_property(
61bcc6
 
61bcc6
   switch (pr_type)
61bcc6
     {
61bcc6
-    case elfcpp::GNU_PROPERTY_X86_COMPAT_ISA_1_USED:
61bcc6
-    case elfcpp::GNU_PROPERTY_X86_COMPAT_ISA_1_NEEDED:
61bcc6
-    case elfcpp::GNU_PROPERTY_X86_COMPAT_2_ISA_1_USED:
61bcc6
-    case elfcpp::GNU_PROPERTY_X86_COMPAT_2_ISA_1_NEEDED:
61bcc6
     case elfcpp::GNU_PROPERTY_X86_ISA_1_USED:
61bcc6
     case elfcpp::GNU_PROPERTY_X86_ISA_1_NEEDED:
61bcc6
     case elfcpp::GNU_PROPERTY_X86_FEATURE_1_AND:
61bcc6
-    case elfcpp::GNU_PROPERTY_X86_FEATURE_2_USED:
61bcc6
-    case elfcpp::GNU_PROPERTY_X86_FEATURE_2_NEEDED:
61bcc6
       if (pr_datasz != 4)
61bcc6
 	{
61bcc6
 	  gold_warning(_("%s: corrupt .note.gnu.property section "
61bcc6
@@ -1120,7 +1105,7 @@ Target_i386::record_gnu_property(
61bcc6
   switch (pr_type)
61bcc6
     {
61bcc6
     case elfcpp::GNU_PROPERTY_X86_ISA_1_USED:
61bcc6
-      this->object_isa_1_used_ |= val;
61bcc6
+      this->isa_1_used_ |= val;
61bcc6
       break;
61bcc6
     case elfcpp::GNU_PROPERTY_X86_ISA_1_NEEDED:
61bcc6
       this->isa_1_needed_ |= val;
61bcc6
@@ -1129,12 +1114,6 @@ Target_i386::record_gnu_property(
61bcc6
       // If we see multiple feature props in one object, OR them together.
61bcc6
       this->object_feature_1_ |= val;
61bcc6
       break;
61bcc6
-    case elfcpp::GNU_PROPERTY_X86_FEATURE_2_USED:
61bcc6
-      this->object_feature_2_used_ |= val;
61bcc6
-      break;
61bcc6
-    case elfcpp::GNU_PROPERTY_X86_FEATURE_2_NEEDED:
61bcc6
-      this->feature_2_needed_ |= val;
61bcc6
-      break;
61bcc6
     }
61bcc6
 }
61bcc6
 
61bcc6
@@ -1143,31 +1122,13 @@ void
61bcc6
 Target_i386::merge_gnu_properties(const Object*)
61bcc6
 {
61bcc6
   if (this->seen_first_object_)
61bcc6
-    {
61bcc6
-      // If any object is missing the ISA_1_USED property, we must omit
61bcc6
-      // it from the output file.
61bcc6
-      if (this->object_isa_1_used_ == 0)
61bcc6
-	this->isa_1_used_ = 0;
61bcc6
-      else if (this->isa_1_used_ != 0)
61bcc6
-	this->isa_1_used_ |= this->object_isa_1_used_;
61bcc6
-      this->feature_1_ &= this->object_feature_1_;
61bcc6
-      // If any object is missing the FEATURE_2_USED property, we must
61bcc6
-      // omit it from the output file.
61bcc6
-      if (this->object_feature_2_used_ == 0)
61bcc6
-	this->feature_2_used_ = 0;
61bcc6
-      else if (this->feature_2_used_ != 0)
61bcc6
-	this->feature_2_used_ |= this->object_feature_2_used_;
61bcc6
-    }
61bcc6
+    this->feature_1_ &= this->object_feature_1_;
61bcc6
   else
61bcc6
     {
61bcc6
-      this->isa_1_used_ = this->object_isa_1_used_;
61bcc6
       this->feature_1_ = this->object_feature_1_;
61bcc6
-      this->feature_2_used_ = this->object_feature_2_used_;
61bcc6
       this->seen_first_object_ = true;
61bcc6
     }
61bcc6
-  this->object_isa_1_used_ = 0;
61bcc6
   this->object_feature_1_ = 0;
61bcc6
-  this->object_feature_2_used_ = 0;
61bcc6
 }
61bcc6
 
61bcc6
 static inline void
61bcc6
@@ -1192,12 +1153,6 @@ Target_i386::do_finalize_gnu_properties(
61bcc6
   if (this->feature_1_ != 0)
61bcc6
     add_property(layout, elfcpp::GNU_PROPERTY_X86_FEATURE_1_AND,
61bcc6
 		 this->feature_1_);
61bcc6
-  if (this->feature_2_used_ != 0)
61bcc6
-    add_property(layout, elfcpp::GNU_PROPERTY_X86_FEATURE_2_USED,
61bcc6
-		 this->feature_2_used_);
61bcc6
-  if (this->feature_2_needed_ != 0)
61bcc6
-    add_property(layout, elfcpp::GNU_PROPERTY_X86_FEATURE_2_NEEDED,
61bcc6
-		 this->feature_2_needed_);
61bcc6
 }
61bcc6
 
61bcc6
 // Write the first three reserved words of the .got.plt section.