Blame SOURCES/binutils-gold-i386-gnu-property-notes.patch

d7faec
diff --git a/gold/i386.cc b/gold/i386.cc
d7faec
index bf209fe9a86..31161ff091c 100644
d7faec
--- a/gold/i386.cc
d7faec
+++ b/gold/i386.cc
d7faec
@@ -360,7 +360,11 @@ class Target_i386 : public Sized_target<32, false>
d7faec
       got_(NULL), plt_(NULL), got_plt_(NULL), got_irelative_(NULL),
d7faec
       got_tlsdesc_(NULL), global_offset_table_(NULL), rel_dyn_(NULL),
d7faec
       rel_irelative_(NULL), copy_relocs_(elfcpp::R_386_COPY),
d7faec
-      got_mod_index_offset_(-1U), tls_base_symbol_defined_(false)
d7faec
+      got_mod_index_offset_(-1U), tls_base_symbol_defined_(false),
d7faec
+      isa_1_used_(0), isa_1_needed_(0),
d7faec
+      feature_1_(0), feature_2_used_(0), feature_2_needed_(0),
d7faec
+      object_isa_1_used_(0), object_feature_1_(0),
d7faec
+      object_feature_2_used_(0), seen_first_object_(false)
d7faec
   { }
d7faec
 
d7faec
   // Process the relocations to determine unreferenced sections for
d7faec
@@ -859,6 +863,21 @@ class Target_i386 : public Sized_target<32, false>
d7faec
 				  this->rel_dyn_section(layout));
d7faec
   }
d7faec
 
d7faec
+  // Record a target-specific program property in the .note.gnu.property
d7faec
+  // section.
d7faec
+  void
d7faec
+  record_gnu_property(unsigned int, unsigned int, size_t,
d7faec
+		      const unsigned char*, const Object*);
d7faec
+
d7faec
+  // Merge the target-specific program properties from the current object.
d7faec
+  void
d7faec
+  merge_gnu_properties(const Object*);
d7faec
+
d7faec
+  // Finalize the target-specific program properties and add them back to
d7faec
+  // the layout.
d7faec
+  void
d7faec
+  do_finalize_gnu_properties(Layout*) const;
d7faec
+
d7faec
   // Information about this specific target which we pass to the
d7faec
   // general Target structure.
d7faec
   static const Target::Target_info i386_info;
d7faec
@@ -898,6 +917,26 @@ class Target_i386 : public Sized_target<32, false>
d7faec
   unsigned int got_mod_index_offset_;
d7faec
   // True if the _TLS_MODULE_BASE_ symbol has been defined.
d7faec
   bool tls_base_symbol_defined_;
d7faec
+
d7faec
+  // Target-specific program properties, from .note.gnu.property section.
d7faec
+  // Each bit represents a specific feature.
d7faec
+  uint32_t isa_1_used_;
d7faec
+  uint32_t isa_1_needed_;
d7faec
+  uint32_t feature_1_;
d7faec
+  uint32_t feature_2_used_;
d7faec
+  uint32_t feature_2_needed_;
d7faec
+  // Target-specific properties from the current object.
d7faec
+  // These bits get ORed into ISA_1_USED_ after all properties for the object
d7faec
+  // have been processed. But if either is all zeroes (as when the property
d7faec
+  // is absent from an object), the result should be all zeroes.
d7faec
+  // (See PR ld/23486.)
d7faec
+  uint32_t object_isa_1_used_;
d7faec
+  // These bits get ANDed into FEATURE_1_ after all properties for the object
d7faec
+  // have been processed.
d7faec
+  uint32_t object_feature_1_;
d7faec
+  uint32_t object_feature_2_used_;
d7faec
+  // Whether we have seen our first object, for use in initializing FEATURE_1_.
d7faec
+  bool seen_first_object_;
d7faec
 };
d7faec
 
d7faec
 const Target::Target_info Target_i386::i386_info =
d7faec
@@ -1042,6 +1081,126 @@ Target_i386::rel_irelative_section(Layout* layout)
d7faec
   return this->rel_irelative_;
d7faec
 }
d7faec
 
d7faec
+// Record a target-specific program property from the .note.gnu.property
d7faec
+// section.
d7faec
+void
d7faec
+Target_i386::record_gnu_property(
d7faec
+    unsigned int, unsigned int pr_type,
d7faec
+    size_t pr_datasz, const unsigned char* pr_data,
d7faec
+    const Object* object)
d7faec
+{
d7faec
+  uint32_t val = 0;
d7faec
+
d7faec
+  switch (pr_type)
d7faec
+    {
d7faec
+    case elfcpp::GNU_PROPERTY_X86_COMPAT_ISA_1_USED:
d7faec
+    case elfcpp::GNU_PROPERTY_X86_COMPAT_ISA_1_NEEDED:
d7faec
+    case elfcpp::GNU_PROPERTY_X86_COMPAT_2_ISA_1_USED:
d7faec
+    case elfcpp::GNU_PROPERTY_X86_COMPAT_2_ISA_1_NEEDED:
d7faec
+    case elfcpp::GNU_PROPERTY_X86_ISA_1_USED:
d7faec
+    case elfcpp::GNU_PROPERTY_X86_ISA_1_NEEDED:
d7faec
+    case elfcpp::GNU_PROPERTY_X86_FEATURE_1_AND:
d7faec
+    case elfcpp::GNU_PROPERTY_X86_FEATURE_2_USED:
d7faec
+    case elfcpp::GNU_PROPERTY_X86_FEATURE_2_NEEDED:
d7faec
+      if (pr_datasz != 4)
d7faec
+	{
d7faec
+	  gold_warning(_("%s: corrupt .note.gnu.property section "
d7faec
+			 "(pr_datasz for property %d is not 4)"),
d7faec
+		       object->name().c_str(), pr_type);
d7faec
+	  return;
d7faec
+	}
d7faec
+      val = elfcpp::Swap<32, false>::readval(pr_data);
d7faec
+      break;
d7faec
+    default:
d7faec
+      gold_warning(_("%s: unknown program property type 0x%x "
d7faec
+		     "in .note.gnu.property section"),
d7faec
+		   object->name().c_str(), pr_type);
d7faec
+      break;
d7faec
+    }
d7faec
+
d7faec
+  switch (pr_type)
d7faec
+    {
d7faec
+    case elfcpp::GNU_PROPERTY_X86_ISA_1_USED:
d7faec
+      this->object_isa_1_used_ |= val;
d7faec
+      break;
d7faec
+    case elfcpp::GNU_PROPERTY_X86_ISA_1_NEEDED:
d7faec
+      this->isa_1_needed_ |= val;
d7faec
+      break;
d7faec
+    case elfcpp::GNU_PROPERTY_X86_FEATURE_1_AND:
d7faec
+      // If we see multiple feature props in one object, OR them together.
d7faec
+      this->object_feature_1_ |= val;
d7faec
+      break;
d7faec
+    case elfcpp::GNU_PROPERTY_X86_FEATURE_2_USED:
d7faec
+      this->object_feature_2_used_ |= val;
d7faec
+      break;
d7faec
+    case elfcpp::GNU_PROPERTY_X86_FEATURE_2_NEEDED:
d7faec
+      this->feature_2_needed_ |= val;
d7faec
+      break;
d7faec
+    }
d7faec
+}
d7faec
+
d7faec
+// Merge the target-specific program properties from the current object.
d7faec
+void
d7faec
+Target_i386::merge_gnu_properties(const Object*)
d7faec
+{
d7faec
+  if (this->seen_first_object_)
d7faec
+    {
d7faec
+      // If any object is missing the ISA_1_USED property, we must omit
d7faec
+      // it from the output file.
d7faec
+      if (this->object_isa_1_used_ == 0)
d7faec
+	this->isa_1_used_ = 0;
d7faec
+      else if (this->isa_1_used_ != 0)
d7faec
+	this->isa_1_used_ |= this->object_isa_1_used_;
d7faec
+      this->feature_1_ &= this->object_feature_1_;
d7faec
+      // If any object is missing the FEATURE_2_USED property, we must
d7faec
+      // omit it from the output file.
d7faec
+      if (this->object_feature_2_used_ == 0)
d7faec
+	this->feature_2_used_ = 0;
d7faec
+      else if (this->feature_2_used_ != 0)
d7faec
+	this->feature_2_used_ |= this->object_feature_2_used_;
d7faec
+    }
d7faec
+  else
d7faec
+    {
d7faec
+      this->isa_1_used_ = this->object_isa_1_used_;
d7faec
+      this->feature_1_ = this->object_feature_1_;
d7faec
+      this->feature_2_used_ = this->object_feature_2_used_;
d7faec
+      this->seen_first_object_ = true;
d7faec
+    }
d7faec
+  this->object_isa_1_used_ = 0;
d7faec
+  this->object_feature_1_ = 0;
d7faec
+  this->object_feature_2_used_ = 0;
d7faec
+}
d7faec
+
d7faec
+static inline void
d7faec
+add_property(Layout* layout, unsigned int pr_type, uint32_t val)
d7faec
+{
d7faec
+  unsigned char buf[4];
d7faec
+  elfcpp::Swap<32, false>::writeval(buf, val);
d7faec
+  layout->add_gnu_property(elfcpp::NT_GNU_PROPERTY_TYPE_0, pr_type, 4, buf);
d7faec
+}
d7faec
+
d7faec
+// Finalize the target-specific program properties and add them back to
d7faec
+// the layout.
d7faec
+void
d7faec
+Target_i386::do_finalize_gnu_properties(Layout* layout) const
d7faec
+{
d7faec
+  if (this->isa_1_used_ != 0)
d7faec
+    add_property(layout, elfcpp::GNU_PROPERTY_X86_ISA_1_USED,
d7faec
+		 this->isa_1_used_);
d7faec
+  if (this->isa_1_needed_ != 0)
d7faec
+    add_property(layout, elfcpp::GNU_PROPERTY_X86_ISA_1_NEEDED,
d7faec
+		 this->isa_1_needed_);
d7faec
+  if (this->feature_1_ != 0)
d7faec
+    add_property(layout, elfcpp::GNU_PROPERTY_X86_FEATURE_1_AND,
d7faec
+		 this->feature_1_);
d7faec
+  if (this->feature_2_used_ != 0)
d7faec
+    add_property(layout, elfcpp::GNU_PROPERTY_X86_FEATURE_2_USED,
d7faec
+		 this->feature_2_used_);
d7faec
+  if (this->feature_2_needed_ != 0)
d7faec
+    add_property(layout, elfcpp::GNU_PROPERTY_X86_FEATURE_2_NEEDED,
d7faec
+		 this->feature_2_needed_);
d7faec
+}
d7faec
+
d7faec
 // Write the first three reserved words of the .got.plt section.
d7faec
 // The remainder of the section is written while writing the PLT
d7faec
 // in Output_data_plt_i386::do_write.
d7faec
--- binutils.orig/elfcpp/elfcpp.h	2021-06-23 12:31:04.550738064 +0100
d7faec
+++ binutils-2.30/elfcpp/elfcpp.h	2021-06-23 12:33:18.068875079 +0100
d7faec
@@ -1008,9 +1008,21 @@ enum
d7faec
   GNU_PROPERTY_STACK_SIZE = 1,
d7faec
   GNU_PROPERTY_NO_COPY_ON_PROTECTED = 2,
d7faec
   GNU_PROPERTY_LOPROC = 0xc0000000,
d7faec
-  GNU_PROPERTY_X86_ISA_1_USED = 0xc0000000,
d7faec
-  GNU_PROPERTY_X86_ISA_1_NEEDED = 0xc0000001,
d7faec
-  GNU_PROPERTY_X86_FEATURE_1_AND = 0xc0000002,
d7faec
+  GNU_PROPERTY_X86_COMPAT_ISA_1_USED = 0xc0000000,
d7faec
+  GNU_PROPERTY_X86_COMPAT_ISA_1_NEEDED = 0xc0000001,
d7faec
+  GNU_PROPERTY_X86_UINT32_AND_LO = 0xc0000002,
d7faec
+  GNU_PROPERTY_X86_UINT32_AND_HI = 0xc0007fff,
d7faec
+  GNU_PROPERTY_X86_UINT32_OR_LO = 0xc0008000,
d7faec
+  GNU_PROPERTY_X86_UINT32_OR_HI = 0xc000ffff,
d7faec
+  GNU_PROPERTY_X86_UINT32_OR_AND_LO = 0xc0010000,
d7faec
+  GNU_PROPERTY_X86_UINT32_OR_AND_HI = 0xc0017fff,
d7faec
+  GNU_PROPERTY_X86_COMPAT_2_ISA_1_NEEDED = GNU_PROPERTY_X86_UINT32_OR_LO + 0,
d7faec
+  GNU_PROPERTY_X86_COMPAT_2_ISA_1_USED = GNU_PROPERTY_X86_UINT32_OR_AND_LO + 0,
d7faec
+  GNU_PROPERTY_X86_FEATURE_1_AND = GNU_PROPERTY_X86_UINT32_AND_LO + 0,
d7faec
+  GNU_PROPERTY_X86_ISA_1_NEEDED = GNU_PROPERTY_X86_UINT32_OR_LO + 2,
d7faec
+  GNU_PROPERTY_X86_FEATURE_2_NEEDED = GNU_PROPERTY_X86_UINT32_OR_LO + 1,
d7faec
+  GNU_PROPERTY_X86_ISA_1_USED = GNU_PROPERTY_X86_UINT32_OR_AND_LO + 2,
d7faec
+  GNU_PROPERTY_X86_FEATURE_2_USED = GNU_PROPERTY_X86_UINT32_OR_AND_LO + 1,
d7faec
   GNU_PROPERTY_HIPROC = 0xdfffffff,
d7faec
   GNU_PROPERTY_LOUSER = 0xe0000000,
d7faec
   GNU_PROPERTY_HIUSER = 0xffffffff
d7faec
--- binutils.orig/gold/i386.cc	2021-07-07 14:15:34.369441519 +0100
d7faec
+++ binutils-2.30/gold/i386.cc	2021-07-07 14:36:11.932838272 +0100
d7faec
@@ -362,9 +362,8 @@ class Target_i386 : public Sized_target<
d7faec
       rel_irelative_(NULL), copy_relocs_(elfcpp::R_386_COPY),
d7faec
       got_mod_index_offset_(-1U), tls_base_symbol_defined_(false),
d7faec
       isa_1_used_(0), isa_1_needed_(0),
d7faec
-      feature_1_(0), feature_2_used_(0), feature_2_needed_(0),
d7faec
-      object_isa_1_used_(0), object_feature_1_(0),
d7faec
-      object_feature_2_used_(0), seen_first_object_(false)
d7faec
+      feature_1_(0), object_feature_1_(0),
d7faec
+      seen_first_object_(false)
d7faec
   { }
d7faec
 
d7faec
   // Process the relocations to determine unreferenced sections for
d7faec
@@ -866,7 +865,7 @@ class Target_i386 : public Sized_target<
d7faec
   // Record a target-specific program property in the .note.gnu.property
d7faec
   // section.
d7faec
   void
d7faec
-  record_gnu_property(unsigned int, unsigned int, size_t,
d7faec
+  record_gnu_property(int, int, size_t,
d7faec
 		      const unsigned char*, const Object*);
d7faec
 
d7faec
   // Merge the target-specific program properties from the current object.
d7faec
@@ -923,18 +922,10 @@ class Target_i386 : public Sized_target<
d7faec
   uint32_t isa_1_used_;
d7faec
   uint32_t isa_1_needed_;
d7faec
   uint32_t feature_1_;
d7faec
-  uint32_t feature_2_used_;
d7faec
-  uint32_t feature_2_needed_;
d7faec
   // Target-specific properties from the current object.
d7faec
-  // These bits get ORed into ISA_1_USED_ after all properties for the object
d7faec
-  // have been processed. But if either is all zeroes (as when the property
d7faec
-  // is absent from an object), the result should be all zeroes.
d7faec
-  // (See PR ld/23486.)
d7faec
-  uint32_t object_isa_1_used_;
d7faec
   // These bits get ANDed into FEATURE_1_ after all properties for the object
d7faec
   // have been processed.
d7faec
   uint32_t object_feature_1_;
d7faec
-  uint32_t object_feature_2_used_;
d7faec
   // Whether we have seen our first object, for use in initializing FEATURE_1_.
d7faec
   bool seen_first_object_;
d7faec
 };
d7faec
@@ -1084,7 +1075,7 @@ Target_i386::rel_irelative_section(Layou
d7faec
 // section.
d7faec
 void
d7faec
 Target_i386::record_gnu_property(
d7faec
-    unsigned int, unsigned int pr_type,
d7faec
+    int, int pr_type,
d7faec
     size_t pr_datasz, const unsigned char* pr_data,
d7faec
     const Object* object)
d7faec
 {
d7faec
@@ -1092,15 +1083,9 @@ Target_i386::record_gnu_property(
d7faec
 
d7faec
   switch (pr_type)
d7faec
     {
d7faec
-    case elfcpp::GNU_PROPERTY_X86_COMPAT_ISA_1_USED:
d7faec
-    case elfcpp::GNU_PROPERTY_X86_COMPAT_ISA_1_NEEDED:
d7faec
-    case elfcpp::GNU_PROPERTY_X86_COMPAT_2_ISA_1_USED:
d7faec
-    case elfcpp::GNU_PROPERTY_X86_COMPAT_2_ISA_1_NEEDED:
d7faec
     case elfcpp::GNU_PROPERTY_X86_ISA_1_USED:
d7faec
     case elfcpp::GNU_PROPERTY_X86_ISA_1_NEEDED:
d7faec
     case elfcpp::GNU_PROPERTY_X86_FEATURE_1_AND:
d7faec
-    case elfcpp::GNU_PROPERTY_X86_FEATURE_2_USED:
d7faec
-    case elfcpp::GNU_PROPERTY_X86_FEATURE_2_NEEDED:
d7faec
       if (pr_datasz != 4)
d7faec
 	{
d7faec
 	  gold_warning(_("%s: corrupt .note.gnu.property section "
d7faec
@@ -1120,7 +1105,7 @@ Target_i386::record_gnu_property(
d7faec
   switch (pr_type)
d7faec
     {
d7faec
     case elfcpp::GNU_PROPERTY_X86_ISA_1_USED:
d7faec
-      this->object_isa_1_used_ |= val;
d7faec
+      this->isa_1_used_ |= val;
d7faec
       break;
d7faec
     case elfcpp::GNU_PROPERTY_X86_ISA_1_NEEDED:
d7faec
       this->isa_1_needed_ |= val;
d7faec
@@ -1129,12 +1114,6 @@ Target_i386::record_gnu_property(
d7faec
       // If we see multiple feature props in one object, OR them together.
d7faec
       this->object_feature_1_ |= val;
d7faec
       break;
d7faec
-    case elfcpp::GNU_PROPERTY_X86_FEATURE_2_USED:
d7faec
-      this->object_feature_2_used_ |= val;
d7faec
-      break;
d7faec
-    case elfcpp::GNU_PROPERTY_X86_FEATURE_2_NEEDED:
d7faec
-      this->feature_2_needed_ |= val;
d7faec
-      break;
d7faec
     }
d7faec
 }
d7faec
 
d7faec
@@ -1143,31 +1122,13 @@ void
d7faec
 Target_i386::merge_gnu_properties(const Object*)
d7faec
 {
d7faec
   if (this->seen_first_object_)
d7faec
-    {
d7faec
-      // If any object is missing the ISA_1_USED property, we must omit
d7faec
-      // it from the output file.
d7faec
-      if (this->object_isa_1_used_ == 0)
d7faec
-	this->isa_1_used_ = 0;
d7faec
-      else if (this->isa_1_used_ != 0)
d7faec
-	this->isa_1_used_ |= this->object_isa_1_used_;
d7faec
-      this->feature_1_ &= this->object_feature_1_;
d7faec
-      // If any object is missing the FEATURE_2_USED property, we must
d7faec
-      // omit it from the output file.
d7faec
-      if (this->object_feature_2_used_ == 0)
d7faec
-	this->feature_2_used_ = 0;
d7faec
-      else if (this->feature_2_used_ != 0)
d7faec
-	this->feature_2_used_ |= this->object_feature_2_used_;
d7faec
-    }
d7faec
+    this->feature_1_ &= this->object_feature_1_;
d7faec
   else
d7faec
     {
d7faec
-      this->isa_1_used_ = this->object_isa_1_used_;
d7faec
       this->feature_1_ = this->object_feature_1_;
d7faec
-      this->feature_2_used_ = this->object_feature_2_used_;
d7faec
       this->seen_first_object_ = true;
d7faec
     }
d7faec
-  this->object_isa_1_used_ = 0;
d7faec
   this->object_feature_1_ = 0;
d7faec
-  this->object_feature_2_used_ = 0;
d7faec
 }
d7faec
 
d7faec
 static inline void
d7faec
@@ -1192,12 +1153,6 @@ Target_i386::do_finalize_gnu_properties(
d7faec
   if (this->feature_1_ != 0)
d7faec
     add_property(layout, elfcpp::GNU_PROPERTY_X86_FEATURE_1_AND,
d7faec
 		 this->feature_1_);
d7faec
-  if (this->feature_2_used_ != 0)
d7faec
-    add_property(layout, elfcpp::GNU_PROPERTY_X86_FEATURE_2_USED,
d7faec
-		 this->feature_2_used_);
d7faec
-  if (this->feature_2_needed_ != 0)
d7faec
-    add_property(layout, elfcpp::GNU_PROPERTY_X86_FEATURE_2_NEEDED,
d7faec
-		 this->feature_2_needed_);
d7faec
 }
d7faec
 
d7faec
 // Write the first three reserved words of the .got.plt section.