|
 |
425d11 |
From 728005aac7c23590a406ac67235d915e416bff5d Mon Sep 17 00:00:00 2001
|
|
|
425d11 |
From: Yonghong Song <yhs@fb.com>
|
|
|
425d11 |
Date: Sat, 13 Aug 2022 17:50:07 -0700
|
|
|
425d11 |
Subject: [PATCH 1/2] Fix bpf_pseudo_fd() type conversion error
|
|
|
425d11 |
|
|
|
425d11 |
With llvm15 and llvm16, the following command line
|
|
|
425d11 |
sudo ./trace.py 'smp_call_function_single "%K", arg1'
|
|
|
425d11 |
will cause error:
|
|
|
425d11 |
/virtual/main.c:60:36: error: incompatible integer to pointer conversion passing 'u64'
|
|
|
425d11 |
(aka 'unsigned long long') to parameter of type 'void *' [-Wint-conversion]
|
|
|
425d11 |
bpf_perf_event_output(ctx, bpf_pseudo_fd(1, -1), CUR_CPU_IDENTIFIER, &__data, sizeof(__data));
|
|
|
425d11 |
^~~~~~~~~~~~~~~~~~~~
|
|
|
425d11 |
1 error generated.
|
|
|
425d11 |
Failed to compile BPF module <text>
|
|
|
425d11 |
|
|
|
425d11 |
In helpers.h, we have
|
|
|
425d11 |
u64 bpf_pseudo_fd(u64, u64) asm("llvm.bpf.pseudo");
|
|
|
425d11 |
Apparently, <= llvm14 can tolerate u64 -> 'void *' conversion, but
|
|
|
425d11 |
llvm15 by default will cause an error.
|
|
|
425d11 |
|
|
|
425d11 |
Let us explicitly convert bpf_pseudo_fd to 'void *' to avoid
|
|
|
425d11 |
such errors.
|
|
|
425d11 |
|
|
|
425d11 |
Signed-off-by: Yonghong Song <yhs@fb.com>
|
|
|
425d11 |
---
|
|
|
425d11 |
src/cc/frontends/clang/b_frontend_action.cc | 10 +++++-----
|
|
|
425d11 |
1 file changed, 5 insertions(+), 5 deletions(-)
|
|
|
425d11 |
|
|
|
425d11 |
diff --git a/src/cc/frontends/clang/b_frontend_action.cc b/src/cc/frontends/clang/b_frontend_action.cc
|
|
|
425d11 |
index a4e05b16..dbeba3e4 100644
|
|
|
425d11 |
--- a/src/cc/frontends/clang/b_frontend_action.cc
|
|
|
425d11 |
+++ b/src/cc/frontends/clang/b_frontend_action.cc
|
|
|
425d11 |
@@ -957,7 +957,7 @@ bool BTypeVisitor::VisitCallExpr(CallExpr *Call) {
|
|
|
425d11 |
string arg0 = rewriter_.getRewrittenText(expansionRange(Call->getArg(0)->getSourceRange()));
|
|
|
425d11 |
string args_other = rewriter_.getRewrittenText(expansionRange(SourceRange(GET_BEGINLOC(Call->getArg(1)),
|
|
|
425d11 |
GET_ENDLOC(Call->getArg(2)))));
|
|
|
425d11 |
- txt = "bpf_perf_event_output(" + arg0 + ", bpf_pseudo_fd(1, " + fd + ")";
|
|
|
425d11 |
+ txt = "bpf_perf_event_output(" + arg0 + ", (void *)bpf_pseudo_fd(1, " + fd + ")";
|
|
|
425d11 |
txt += ", CUR_CPU_IDENTIFIER, " + args_other + ")";
|
|
|
425d11 |
|
|
|
425d11 |
// e.g.
|
|
|
425d11 |
@@ -986,7 +986,7 @@ bool BTypeVisitor::VisitCallExpr(CallExpr *Call) {
|
|
|
425d11 |
string meta_len = rewriter_.getRewrittenText(expansionRange(Call->getArg(3)->getSourceRange()));
|
|
|
425d11 |
txt = "bpf_perf_event_output(" +
|
|
|
425d11 |
skb + ", " +
|
|
|
425d11 |
- "bpf_pseudo_fd(1, " + fd + "), " +
|
|
|
425d11 |
+ "(void *)bpf_pseudo_fd(1, " + fd + "), " +
|
|
|
425d11 |
"((__u64)" + skb_len + " << 32) | BPF_F_CURRENT_CPU, " +
|
|
|
425d11 |
meta + ", " +
|
|
|
425d11 |
meta_len + ");";
|
|
|
425d11 |
@@ -1006,12 +1006,12 @@ bool BTypeVisitor::VisitCallExpr(CallExpr *Call) {
|
|
|
425d11 |
string keyp = rewriter_.getRewrittenText(expansionRange(Call->getArg(1)->getSourceRange()));
|
|
|
425d11 |
string flag = rewriter_.getRewrittenText(expansionRange(Call->getArg(2)->getSourceRange()));
|
|
|
425d11 |
txt = "bpf_" + string(memb_name) + "(" + ctx + ", " +
|
|
|
425d11 |
- "bpf_pseudo_fd(1, " + fd + "), " + keyp + ", " + flag + ");";
|
|
|
425d11 |
+ "(void *)bpf_pseudo_fd(1, " + fd + "), " + keyp + ", " + flag + ");";
|
|
|
425d11 |
} else if (memb_name == "ringbuf_output") {
|
|
|
425d11 |
string name = string(Ref->getDecl()->getName());
|
|
|
425d11 |
string args = rewriter_.getRewrittenText(expansionRange(SourceRange(GET_BEGINLOC(Call->getArg(0)),
|
|
|
425d11 |
GET_ENDLOC(Call->getArg(2)))));
|
|
|
425d11 |
- txt = "bpf_ringbuf_output(bpf_pseudo_fd(1, " + fd + ")";
|
|
|
425d11 |
+ txt = "bpf_ringbuf_output((void *)bpf_pseudo_fd(1, " + fd + ")";
|
|
|
425d11 |
txt += ", " + args + ")";
|
|
|
425d11 |
|
|
|
425d11 |
// e.g.
|
|
|
425d11 |
@@ -1033,7 +1033,7 @@ bool BTypeVisitor::VisitCallExpr(CallExpr *Call) {
|
|
|
425d11 |
} else if (memb_name == "ringbuf_reserve") {
|
|
|
425d11 |
string name = string(Ref->getDecl()->getName());
|
|
|
425d11 |
string arg0 = rewriter_.getRewrittenText(expansionRange(Call->getArg(0)->getSourceRange()));
|
|
|
425d11 |
- txt = "bpf_ringbuf_reserve(bpf_pseudo_fd(1, " + fd + ")";
|
|
|
425d11 |
+ txt = "bpf_ringbuf_reserve((void *)bpf_pseudo_fd(1, " + fd + ")";
|
|
|
425d11 |
txt += ", " + arg0 + ", 0)"; // Flags in reserve are meaningless
|
|
|
425d11 |
} else if (memb_name == "ringbuf_discard") {
|
|
|
425d11 |
string name = string(Ref->getDecl()->getName());
|
|
|
425d11 |
--
|
|
|
425d11 |
2.38.1
|
|
|
425d11 |
|