|
 |
288172 |
autofs-5.1.8 - fix parse module instance mutex naming
|
|
|
288172 |
|
|
|
288172 |
From: Ian Kent <raven@themaw.net>
|
|
|
288172 |
|
|
|
288172 |
The naming used for parse module instance locks is the same as that
|
|
|
288172 |
used for map lookup instances. Rename these to make it clear they
|
|
|
288172 |
are being used in the parse modules.
|
|
|
288172 |
|
|
|
288172 |
Signed-off-by: Ian Kent <raven@themaw.net>
|
|
|
288172 |
---
|
|
|
288172 |
CHANGELOG | 1 +
|
|
|
288172 |
modules/parse_amd.c | 28 ++++++++++++++--------------
|
|
|
288172 |
modules/parse_sun.c | 20 ++++++++++----------
|
|
|
288172 |
3 files changed, 25 insertions(+), 24 deletions(-)
|
|
|
288172 |
|
|
|
288172 |
--- autofs-5.1.4.orig/CHANGELOG
|
|
|
288172 |
+++ autofs-5.1.4/CHANGELOG
|
|
|
288172 |
@@ -96,6 +96,7 @@
|
|
|
288172 |
- fix handling of incorrect return from umount_ent().
|
|
|
288172 |
- dont use initgroups() at spawn.
|
|
|
288172 |
- fix invalid tsv access.
|
|
|
288172 |
+- fix parse module instance mutex naming.
|
|
|
288172 |
|
|
|
288172 |
xx/xx/2018 autofs-5.1.5
|
|
|
288172 |
- fix flag file permission.
|
|
|
288172 |
--- autofs-5.1.4.orig/modules/parse_amd.c
|
|
|
288172 |
+++ autofs-5.1.4/modules/parse_amd.c
|
|
|
288172 |
@@ -39,18 +39,18 @@ int parse_version = AUTOFS_PARSE_VERSION
|
|
|
288172 |
|
|
|
288172 |
static struct mount_mod *mount_nfs = NULL;
|
|
|
288172 |
static int init_ctr = 0;
|
|
|
288172 |
-static pthread_mutex_t instance_mutex = PTHREAD_MUTEX_INITIALIZER;
|
|
|
288172 |
+static pthread_mutex_t parse_instance_mutex = PTHREAD_MUTEX_INITIALIZER;
|
|
|
288172 |
|
|
|
288172 |
-static void instance_mutex_lock(void)
|
|
|
288172 |
+static void parse_instance_mutex_lock(void)
|
|
|
288172 |
{
|
|
|
288172 |
- int status = pthread_mutex_lock(&instance_mutex);
|
|
|
288172 |
+ int status = pthread_mutex_lock(&parse_instance_mutex);
|
|
|
288172 |
if (status)
|
|
|
288172 |
fatal(status);
|
|
|
288172 |
}
|
|
|
288172 |
|
|
|
288172 |
-static void instance_mutex_unlock(void)
|
|
|
288172 |
+static void parse_instance_mutex_unlock(void)
|
|
|
288172 |
{
|
|
|
288172 |
- int status = pthread_mutex_unlock(&instance_mutex);
|
|
|
288172 |
+ int status = pthread_mutex_unlock(&parse_instance_mutex);
|
|
|
288172 |
if (status)
|
|
|
288172 |
fatal(status);
|
|
|
288172 |
}
|
|
|
288172 |
@@ -112,7 +112,7 @@ int parse_init(int argc, const char *con
|
|
|
288172 |
|
|
|
288172 |
/* We only need this once. NFS mounts are so common that we cache
|
|
|
288172 |
this module. */
|
|
|
288172 |
- instance_mutex_lock();
|
|
|
288172 |
+ parse_instance_mutex_lock();
|
|
|
288172 |
if (mount_nfs)
|
|
|
288172 |
init_ctr++;
|
|
|
288172 |
else {
|
|
|
288172 |
@@ -121,11 +121,11 @@ int parse_init(int argc, const char *con
|
|
|
288172 |
} else {
|
|
|
288172 |
kill_context(ctxt);
|
|
|
288172 |
*context = NULL;
|
|
|
288172 |
- instance_mutex_unlock();
|
|
|
288172 |
+ parse_instance_mutex_unlock();
|
|
|
288172 |
return 1;
|
|
|
288172 |
}
|
|
|
288172 |
}
|
|
|
288172 |
- instance_mutex_unlock();
|
|
|
288172 |
+ parse_instance_mutex_unlock();
|
|
|
288172 |
|
|
|
288172 |
return 0;
|
|
|
288172 |
}
|
|
|
288172 |
@@ -1358,11 +1358,11 @@ static int do_host_mount(struct autofs_p
|
|
|
288172 |
argc = 1;
|
|
|
288172 |
}
|
|
|
288172 |
|
|
|
288172 |
- instance_mutex_lock();
|
|
|
288172 |
+ parse_instance_mutex_lock();
|
|
|
288172 |
status = open_lookup("hosts", MODPREFIX, NULL, argc, pargv, &lookup);
|
|
|
288172 |
if (status != NSS_STATUS_SUCCESS) {
|
|
|
288172 |
debug(ap->logopt, "open lookup module hosts failed");
|
|
|
288172 |
- instance_mutex_unlock();
|
|
|
288172 |
+ parse_instance_mutex_unlock();
|
|
|
288172 |
goto out;
|
|
|
288172 |
}
|
|
|
288172 |
|
|
|
288172 |
@@ -1374,13 +1374,13 @@ static int do_host_mount(struct autofs_p
|
|
|
288172 |
if (!instance) {
|
|
|
288172 |
error(ap->logopt, MODPREFIX
|
|
|
288172 |
"failed to create source instance for hosts map");
|
|
|
288172 |
- instance_mutex_unlock();
|
|
|
288172 |
+ parse_instance_mutex_unlock();
|
|
|
288172 |
close_lookup(lookup);
|
|
|
288172 |
goto out;
|
|
|
288172 |
}
|
|
|
288172 |
}
|
|
|
288172 |
instance->lookup = lookup;
|
|
|
288172 |
- instance_mutex_unlock();
|
|
|
288172 |
+ parse_instance_mutex_unlock();
|
|
|
288172 |
|
|
|
288172 |
cache_writelock(source->mc);
|
|
|
288172 |
me = cache_lookup_distinct(source->mc, name);
|
|
|
288172 |
@@ -2373,12 +2373,12 @@ int parse_done(void *context)
|
|
|
288172 |
int rv = 0;
|
|
|
288172 |
struct parse_context *ctxt = (struct parse_context *) context;
|
|
|
288172 |
|
|
|
288172 |
- instance_mutex_lock();
|
|
|
288172 |
+ parse_instance_mutex_lock();
|
|
|
288172 |
if (--init_ctr == 0) {
|
|
|
288172 |
rv = close_mount(mount_nfs);
|
|
|
288172 |
mount_nfs = NULL;
|
|
|
288172 |
}
|
|
|
288172 |
- instance_mutex_unlock();
|
|
|
288172 |
+ parse_instance_mutex_unlock();
|
|
|
288172 |
if (ctxt)
|
|
|
288172 |
kill_context(ctxt);
|
|
|
288172 |
|
|
|
288172 |
--- autofs-5.1.4.orig/modules/parse_sun.c
|
|
|
288172 |
+++ autofs-5.1.4/modules/parse_sun.c
|
|
|
288172 |
@@ -41,18 +41,18 @@ int parse_version = AUTOFS_PARSE_VERSION
|
|
|
288172 |
|
|
|
288172 |
static struct mount_mod *mount_nfs = NULL;
|
|
|
288172 |
static int init_ctr = 0;
|
|
|
288172 |
-static pthread_mutex_t instance_mutex = PTHREAD_MUTEX_INITIALIZER;
|
|
|
288172 |
+static pthread_mutex_t parse_instance_mutex = PTHREAD_MUTEX_INITIALIZER;
|
|
|
288172 |
|
|
|
288172 |
-static void instance_mutex_lock(void)
|
|
|
288172 |
+static void parse_instance_mutex_lock(void)
|
|
|
288172 |
{
|
|
|
288172 |
- int status = pthread_mutex_lock(&instance_mutex);
|
|
|
288172 |
+ int status = pthread_mutex_lock(&parse_instance_mutex);
|
|
|
288172 |
if (status)
|
|
|
288172 |
fatal(status);
|
|
|
288172 |
}
|
|
|
288172 |
|
|
|
288172 |
-static void instance_mutex_unlock(void)
|
|
|
288172 |
+static void parse_instance_mutex_unlock(void)
|
|
|
288172 |
{
|
|
|
288172 |
- int status = pthread_mutex_unlock(&instance_mutex);
|
|
|
288172 |
+ int status = pthread_mutex_unlock(&parse_instance_mutex);
|
|
|
288172 |
if (status)
|
|
|
288172 |
fatal(status);
|
|
|
288172 |
}
|
|
|
288172 |
@@ -423,7 +423,7 @@ int parse_init(int argc, const char *con
|
|
|
288172 |
|
|
|
288172 |
/* We only need this once. NFS mounts are so common that we cache
|
|
|
288172 |
this module. */
|
|
|
288172 |
- instance_mutex_lock();
|
|
|
288172 |
+ parse_instance_mutex_lock();
|
|
|
288172 |
if (mount_nfs)
|
|
|
288172 |
init_ctr++;
|
|
|
288172 |
else {
|
|
|
288172 |
@@ -431,11 +431,11 @@ int parse_init(int argc, const char *con
|
|
|
288172 |
init_ctr++;
|
|
|
288172 |
} else {
|
|
|
288172 |
kill_context(ctxt);
|
|
|
288172 |
- instance_mutex_unlock();
|
|
|
288172 |
+ parse_instance_mutex_unlock();
|
|
|
288172 |
return 1;
|
|
|
288172 |
}
|
|
|
288172 |
}
|
|
|
288172 |
- instance_mutex_unlock();
|
|
|
288172 |
+ parse_instance_mutex_unlock();
|
|
|
288172 |
|
|
|
288172 |
*context = (void *) ctxt;
|
|
|
288172 |
|
|
|
288172 |
@@ -1719,12 +1719,12 @@ int parse_done(void *context)
|
|
|
288172 |
int rv = 0;
|
|
|
288172 |
struct parse_context *ctxt = (struct parse_context *) context;
|
|
|
288172 |
|
|
|
288172 |
- instance_mutex_lock();
|
|
|
288172 |
+ parse_instance_mutex_lock();
|
|
|
288172 |
if (--init_ctr == 0) {
|
|
|
288172 |
rv = close_mount(mount_nfs);
|
|
|
288172 |
mount_nfs = NULL;
|
|
|
288172 |
}
|
|
|
288172 |
- instance_mutex_unlock();
|
|
|
288172 |
+ parse_instance_mutex_unlock();
|
|
|
288172 |
if (ctxt)
|
|
|
288172 |
kill_context(ctxt);
|
|
|
288172 |
|