Blame SOURCES/autofs-5.1.8-fix-memory-leak-in-xdr_exports.patch

4218b4
autofs-5.1.8 - fix memory leak in xdr_exports()
4218b4
4218b4
From: Ian Kent <raven@themaw.net>
4218b4
4218b4
Converting xdr_exports() to not be recursive introduced a memory leak
4218b4
if an error is encountered, fix it.
4218b4
4218b4
Signed-off-by: Ian Kent <raven@themaw.net>
4218b4
---
4218b4
 CHANGELOG      |    1 +
4218b4
 lib/rpc_subs.c |    7 ++++++-
4218b4
 2 files changed, 7 insertions(+), 1 deletion(-)
4218b4
4218b4
--- autofs-5.1.7.orig/CHANGELOG
4218b4
+++ autofs-5.1.7/CHANGELOG
4218b4
@@ -91,6 +91,7 @@
4218b4
 - fix loop under run in cache_get_offset_parent().
4218b4
 - simplify cache_add() a little.
4218b4
 - fix use after free in tree_mapent_delete_offset_tree().
4218b4
+- fix memory leak in xdr_exports().
4218b4
 
4218b4
 25/01/2021 autofs-5.1.7
4218b4
 - make bind mounts propagation slave by default.
4218b4
--- autofs-5.1.7.orig/lib/rpc_subs.c
4218b4
+++ autofs-5.1.7/lib/rpc_subs.c
4218b4
@@ -1151,8 +1151,13 @@ bool_t xdr_exports(XDR *xdrs, struct exp
4218b4
 
4218b4
 	export = (char **) exports;
4218b4
 	while (1) {
4218b4
-		if (!xdr_pointer(xdrs, export, size, (xdrproc_t) xdr_export))
4218b4
+		if (!xdr_pointer(xdrs, export, size, (xdrproc_t) xdr_export)) {
4218b4
+			if (*exports) {
4218b4
+				rpc_exports_free(*exports);
4218b4
+				*exports = NULL;
4218b4
+			}
4218b4
 			return FALSE;
4218b4
+		}
4218b4
 		if (!*export)
4218b4
 			break;
4218b4
 		export = (char **) &((struct exportinfo *) *export)->next;