Blame SOURCES/autofs-5.1.7-simplify-mount_subtree-mount-check.patch

29d2b9
autofs-5.1.7 - simplify mount_subtree() mount check
29d2b9
29d2b9
From: Ian Kent <raven@themaw.net>
29d2b9
29d2b9
The check of the return from sun_mount() following the possible mount
29d2b9
of the root offset in mount_subtree() can be simpler.
29d2b9
29d2b9
Signed-off-by: Ian Kent <raven@themaw.net>
29d2b9
---
29d2b9
 CHANGELOG           |    1 +
29d2b9
 modules/parse_sun.c |   10 +---------
29d2b9
 2 files changed, 2 insertions(+), 9 deletions(-)
29d2b9
29d2b9
diff --git a/CHANGELOG b/CHANGELOG
29d2b9
index b1ce7b69..f5c5641a 100644
29d2b9
--- a/CHANGELOG
29d2b9
+++ b/CHANGELOG
29d2b9
@@ -13,6 +13,7 @@
29d2b9
 - remove unused parameter form do_mount_autofs_offset().
29d2b9
 - refactor umount_multi_triggers().
29d2b9
 - eliminate clean_stale_multi_triggers().
29d2b9
+- simplify mount_subtree() mount check.
29d2b9
 
29d2b9
 25/01/2021 autofs-5.1.7
29d2b9
 - make bind mounts propagation slave by default.
29d2b9
diff --git a/modules/parse_sun.c b/modules/parse_sun.c
29d2b9
index f4d5125c..1142e8a3 100644
29d2b9
--- a/modules/parse_sun.c
29d2b9
+++ b/modules/parse_sun.c
29d2b9
@@ -1203,15 +1203,7 @@ static int mount_subtree(struct autofs_point *ap, struct mapent *me,
29d2b9
 				free(ro_loc);
29d2b9
 		}
29d2b9
 
29d2b9
-		if (ro && rv == 0) {
29d2b9
-			ret = mount_multi_triggers(ap, me, mm_root, start, mm_base);
29d2b9
-			if (ret == -1) {
29d2b9
-				error(ap->logopt, MODPREFIX
29d2b9
-					 "failed to mount offset triggers");
29d2b9
-				cleanup_multi_triggers(ap, me, mm_root, start, mm_base);
29d2b9
-				return 1;
29d2b9
-			}
29d2b9
-		} else if (rv <= 0) {
29d2b9
+		if ((ro && rv == 0) || rv <= 0) {
29d2b9
 			ret = mount_multi_triggers(ap, me, mm_root, start, mm_base);
29d2b9
 			if (ret == -1) {
29d2b9
 				error(ap->logopt, MODPREFIX