Blame SOURCES/autofs-5.1.7-remove-redundant-assignment-in-master_add_amd_mount_section_mounts.patch

29d2b9
autofs-5.1.7 - remove redundant assignment in master_add_amd_mount_section_mounts()
29d2b9
29d2b9
From: Ian Kent <raven@themaw.net>
29d2b9
29d2b9
Coverity: missing_lock: Accessing "entry->current" without holding lock
29d2b9
	  "master_mapent.current_mutex".
29d2b9
29d2b9
This is initialization not clearing current source. But the field has
29d2b9
already been initialized in the master_new_mapent() call.
29d2b9
29d2b9
Signed-off-by: Ian Kent <raven@themaw.net>
29d2b9
---
29d2b9
 CHANGELOG       |    1 +
29d2b9
 daemon/master.c |    1 -
29d2b9
 2 files changed, 1 insertion(+), 1 deletion(-)
29d2b9
29d2b9
diff --git a/CHANGELOG b/CHANGELOG
29d2b9
index c7bc0c39..f95b1aa6 100644
29d2b9
--- a/CHANGELOG
29d2b9
+++ b/CHANGELOG
29d2b9
@@ -58,6 +58,7 @@
29d2b9
 - add length check in umount_subtree_mounts().
29d2b9
 - fix flags check in umount_multi().
29d2b9
 - dont try umount after stat() ENOENT fail.
29d2b9
+- remove redundant assignment in master_add_amd_mount_section_mounts().
29d2b9
 
29d2b9
 25/01/2021 autofs-5.1.7
29d2b9
 - make bind mounts propagation slave by default.
29d2b9
diff --git a/daemon/master.c b/daemon/master.c
29d2b9
index 30d7cf98..84743f80 100644
29d2b9
--- a/daemon/master.c
29d2b9
+++ b/daemon/master.c
29d2b9
@@ -996,7 +996,6 @@ static void master_add_amd_mount_section_mounts(struct master *master, time_t ag
29d2b9
 		source->master_line = 0;
29d2b9
 
29d2b9
 		entry->age = age;
29d2b9
-		entry->current = NULL;
29d2b9
 
29d2b9
 		master_add_mapent(master, entry);
29d2b9
 next: