Blame SOURCES/autofs-5.1.7-fix-flag-check-in-umount_multi.patch

29d2b9
autofs-5.1.7 - fix flags check in umount_multi()
29d2b9
29d2b9
From: Ian Kent <raven@themaw.net>
29d2b9
29d2b9
Coverity: operator_confusion: "ap->flags | 1" is always 1/true
29d2b9
	  regardless of the values of its operand.
29d2b9
29d2b9
Signed-off-by: Ian Kent <raven@themaw.net>
29d2b9
---
29d2b9
 CHANGELOG          |    1 +
29d2b9
 daemon/automount.c |    2 +-
29d2b9
 2 files changed, 2 insertions(+), 1 deletion(-)
29d2b9
29d2b9
diff --git a/CHANGELOG b/CHANGELOG
29d2b9
index 9e385ba9..7add6c55 100644
29d2b9
--- a/CHANGELOG
29d2b9
+++ b/CHANGELOG
29d2b9
@@ -56,6 +56,7 @@
29d2b9
 - fix possible memory leak in mnts_add_amdmount().
29d2b9
 - fix double unlock in parse_mount().
29d2b9
 - add length check in umount_subtree_mounts().
29d2b9
+- fix flags check in umount_multi().
29d2b9
 
29d2b9
 25/01/2021 autofs-5.1.7
29d2b9
 - make bind mounts propagation slave by default.
29d2b9
diff --git a/daemon/automount.c b/daemon/automount.c
29d2b9
index 70506d83..23235a7d 100644
29d2b9
--- a/daemon/automount.c
29d2b9
+++ b/daemon/automount.c
29d2b9
@@ -662,7 +662,7 @@ int umount_multi(struct autofs_point *ap, const char *path, int incl)
29d2b9
 		/* Check if the autofs mount has browse mode enabled.
29d2b9
 		 * If so re-create the directory entry.
29d2b9
 		 */
29d2b9
-		if (ap->flags | MOUNT_FLAG_GHOST) {
29d2b9
+		if (ap->flags & MOUNT_FLAG_GHOST) {
29d2b9
 			int ret;
29d2b9
 
29d2b9
 			/* If the browse directory create fails log an